| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a3bb668a-ab9e-fd09-a9f3-85a515d5d6bf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8278:10252F:CD27A3:11852AF:696A8C89 |
| html-safe-nonce | feb2b8d5d9b9c22e1fb23ebabca1e0ed695889b850d7d0af879443fd15d03984 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Mjc4OjEwMjUyRjpDRDI3QTM6MTE4NTJBRjo2OTZBOEM4OSIsInZpc2l0b3JfaWQiOiI1MTY1ODUwODAyNjk2OTE2MTA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d8a16185133031bba1e8a004a55437ff317641760b453557990a591556a30c2c |
| hovercard-subject-tag | pull_request:564555868 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/37153/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ff35b5cbd52089eadd8fe00590f20a72eb5471ed4f01b1c09fb1216695784916/nodejs/node/pull/37153 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ff35b5cbd52089eadd8fe00590f20a72eb5471ed4f01b1c09fb1216695784916/nodejs/node/pull/37153 |
| og:image:alt | Added setInterval async generator to timers\promises. Utilises async generators to provide an iterator compatible with
for await. This is a continuation of initial work by Fabian Cook #35841 (who i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Linkgoron |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/37153#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37153 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37153 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/37153 |
| Reload | https://github.com/nodejs/node/pull/37153 |
| Reload | https://github.com/nodejs/node/pull/37153 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/37153#issue-comment-box |
| Linkgoron | https://github.com/Linkgoron |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Linkgoron:timers-set-interval-async | https://github.com/Linkgoron/node/tree/timers-set-interval-async |
|
timers: introduce setInterval async iterator
| https://github.com/nodejs/node/pull/37153#top |
| Linkgoron | https://github.com/Linkgoron |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Linkgoron:timers-set-interval-async | https://github.com/Linkgoron/node/tree/timers-set-interval-async |
|
Conversation
63
| https://github.com/nodejs/node/pull/37153 |
|
Commits
1
| https://github.com/nodejs/node/pull/37153/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/37153/checks |
|
Files changed
| https://github.com/nodejs/node/pull/37153/files |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#issue-797582900 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| #35841 | https://github.com/nodejs/node/pull/35841 |
| PR | https://github.com/nodejs/node/pull/35841 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#event-4269779363 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| force-pushed | https://github.com/nodejs/node/compare/45584a1ffbaf7c1932dcdb7186fd08f1526aaa7f..42a7f5276adaf72fbaac15d016b9b465d35b2efe |
| 45584a1 | https://github.com/nodejs/node/commit/45584a1ffbaf7c1932dcdb7186fd08f1526aaa7f |
| 42a7f52 | https://github.com/nodejs/node/commit/42a7f5276adaf72fbaac15d016b9b465d35b2efe |
|
Compare
| https://github.com/nodejs/node/compare/45584a1ffbaf7c1932dcdb7186fd08f1526aaa7f..42a7f5276adaf72fbaac15d016b9b465d35b2efe |
| January 31, 2021 00:32 | https://github.com/nodejs/node/pull/37153#event-4269795378 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-770305854 |
| @benjamingr | https://github.com/benjamingr |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 31, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-579845379 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| lib/timers.js | https://github.com/nodejs/node/pull/37153/files#diff-5a0457600721c223f1ed7184ef7d1d2617f4552a5341b53a49b284f808981724 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| test/parallel/test-timers-promisified.js | https://github.com/nodejs/node/pull/37153/files#diff-c48c5d2dbad4874175965763cabe20d29958bc1e62f4a80966610e2eaf23405b |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| test/parallel/test-timers-promisified.js | https://github.com/nodejs/node/pull/37153/files#diff-c48c5d2dbad4874175965763cabe20d29958bc1e62f4a80966610e2eaf23405b |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| aduh95 | https://github.com/aduh95 |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567349579 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Linkgoron | https://github.com/Linkgoron |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567352488 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| aduh95 | https://github.com/aduh95 |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567449041 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Linkgoron | https://github.com/Linkgoron |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567455728 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| aduh95 | https://github.com/aduh95 |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567349678 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Linkgoron | https://github.com/Linkgoron |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567352468 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| aduh95 | https://github.com/aduh95 |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567349857 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Linkgoron | https://github.com/Linkgoron |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567352274 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| aduh95 | https://github.com/aduh95 |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567350151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Linkgoron | https://github.com/Linkgoron |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567354271 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| force-pushed | https://github.com/nodejs/node/compare/2cb80b21d3d5269198a351e437a3e52a58b1c095..1f8b21c76768b41ec24f66516a5243b087929282 |
| 2cb80b2 | https://github.com/nodejs/node/commit/2cb80b21d3d5269198a351e437a3e52a58b1c095 |
| 1f8b21c | https://github.com/nodejs/node/commit/1f8b21c76768b41ec24f66516a5243b087929282 |
|
Compare
| https://github.com/nodejs/node/compare/2cb80b21d3d5269198a351e437a3e52a58b1c095..1f8b21c76768b41ec24f66516a5243b087929282 |
| January 31, 2021 03:06 | https://github.com/nodejs/node/pull/37153#event-4269874751 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jan 31, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-579868889 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| doc/api/timers.md | https://github.com/nodejs/node/pull/37153/files#diff-5df4100773a1545e98d8c01219d23b913ac663812e286963b011cf61357a84d6 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jan 31, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-579869054 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jan 31, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-579870160 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jan 31, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-579870478 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jan 31, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-579870502 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/37153#pullrequestreview-579870502 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-770354933 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-770356656 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-770404137 |
| @Linkgoron | https://github.com/Linkgoron |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 31, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-579910060 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| aduh95 | https://github.com/aduh95 |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567448651 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| lib/timers/promises.js | https://github.com/nodejs/node/pull/37153/files#diff-47e08480e3fb55faaefa09d77a9423cd193d72296ff4d293b7aed6adac438746 |
| aduh95 | https://github.com/aduh95 |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r567449041 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| Jan 31, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-770459208 |
| @Linkgoron | https://github.com/Linkgoron |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| force-pushed | https://github.com/nodejs/node/compare/4db2941401729573aed4d31d9efc79c8cfd3288b..bc95c21edea5b7592300a89035299cec025cda3e |
| 4db2941 | https://github.com/nodejs/node/commit/4db2941401729573aed4d31d9efc79c8cfd3288b |
| bc95c21 | https://github.com/nodejs/node/commit/bc95c21edea5b7592300a89035299cec025cda3e |
|
Compare
| https://github.com/nodejs/node/compare/4db2941401729573aed4d31d9efc79c8cfd3288b..bc95c21edea5b7592300a89035299cec025cda3e |
| January 31, 2021 23:25 | https://github.com/nodejs/node/pull/37153#event-4270897509 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Feb 1, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-580188216 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/37153#pullrequestreview-580188216 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Feb 1, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-580209690 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| test/parallel/test-timers-promisified.js | https://github.com/nodejs/node/pull/37153/files#diff-c48c5d2dbad4874175965763cabe20d29958bc1e62f4a80966610e2eaf23405b |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Feb 1, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-580210801 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files |
| doc/api/timers.md | https://github.com/nodejs/node/pull/37153/files#diff-5df4100773a1545e98d8c01219d23b913ac663812e286963b011cf61357a84d6 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Feb 1, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-770752298 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Feb 1, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-770757306 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| force-pushed | https://github.com/nodejs/node/compare/bc95c21edea5b7592300a89035299cec025cda3e..6c7ec0e9d0e77bc7bb5b403419f96a465954d73d |
| bc95c21 | https://github.com/nodejs/node/commit/bc95c21edea5b7592300a89035299cec025cda3e |
| 6c7ec0e | https://github.com/nodejs/node/commit/6c7ec0e9d0e77bc7bb5b403419f96a465954d73d |
|
Compare
| https://github.com/nodejs/node/compare/bc95c21edea5b7592300a89035299cec025cda3e..6c7ec0e9d0e77bc7bb5b403419f96a465954d73d |
| February 1, 2021 13:56 | https://github.com/nodejs/node/pull/37153#event-4273817961 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Feb 1, 2021 | https://github.com/nodejs/node/pull/37153#event-4273837587 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 1, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-770877326 |
| https://ci.nodejs.org/job/node-test-pull-request/35856/ | https://ci.nodejs.org/job/node-test-pull-request/35856/ |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| force-pushed | https://github.com/nodejs/node/compare/35084138f973df12d0de17f6758e8d5c248645df..a651ce4c7dd89bfed841be38214d4cb25817d5b5 |
| 3508413 | https://github.com/nodejs/node/commit/35084138f973df12d0de17f6758e8d5c248645df |
| a651ce4 | https://github.com/nodejs/node/commit/a651ce4c7dd89bfed841be38214d4cb25817d5b5 |
|
Compare
| https://github.com/nodejs/node/compare/35084138f973df12d0de17f6758e8d5c248645df..a651ce4c7dd89bfed841be38214d4cb25817d5b5 |
| February 1, 2021 15:51 | https://github.com/nodejs/node/pull/37153#event-4274460982 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 2, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-771835510 |
| https://ci.nodejs.org/job/node-test-pull-request/35892/ | https://ci.nodejs.org/job/node-test-pull-request/35892/ |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 2, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-771883726 |
| https://ci.nodejs.org/job/node-test-pull-request/35898/ | https://ci.nodejs.org/job/node-test-pull-request/35898/ |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 2, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-772028057 |
| https://ci.nodejs.org/job/node-test-pull-request/35903/ | https://ci.nodejs.org/job/node-test-pull-request/35903/ |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 3, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-772335075 |
| https://ci.nodejs.org/job/node-test-pull-request/35915/ | https://ci.nodejs.org/job/node-test-pull-request/35915/ |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Feb 3, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-772443202 |
| @devsnek | https://github.com/devsnek |
| @ronag | https://github.com/ronag |
| @jasnell | https://github.com/jasnell |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 3, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-582357816 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files/55eedb65ec469e74862944100f9bedf81ffda927 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Feb 3, 2021
| https://github.com/nodejs/node/pull/37153#ref-pullrequest-731011193 |
|
timers: introduce setInterval async iterator
#35841
| https://github.com/nodejs/node/pull/35841 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Feb 3, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-772683950 |
| fefc639 | https://github.com/nodejs/node/commit/fefc639016af9a30b9b24edcc43d616abcec1d2d |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Feb 3, 2021 | https://github.com/nodejs/node/pull/37153#event-4286574390 |
| benjamingr | https://github.com/benjamingr |
|
Feb 3, 2021
| https://github.com/nodejs/node/pull/37153#ref-commit-fefc639 |
|
| https://github.com/Linkgoron |
|
| https://github.com/benjamingr |
| timers: introduce setInterval async iterator | https://github.com/nodejs/node/commit/fefc639016af9a30b9b24edcc43d616abcec1d2d |
| fefc639 | https://github.com/nodejs/node/commit/fefc639016af9a30b9b24edcc43d616abcec1d2d |
| #37153 | https://github.com/nodejs/node/pull/37153 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Feb 3, 2021
| https://github.com/nodejs/node/pull/37153#ref-issue-800654429 |
|
AbortController (in Node), integration with CAF?
getify/CAF#21
| https://github.com/getify/CAF/issues/21 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Feb 4, 2021
| https://github.com/nodejs/node/pull/37153#pullrequestreview-583378270 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/37153/files/55eedb65ec469e74862944100f9bedf81ffda927 |
| test/parallel/test-timers-promisified.js | https://github.com/nodejs/node/pull/37153/files/55eedb65ec469e74862944100f9bedf81ffda927#diff-c48c5d2dbad4874175965763cabe20d29958bc1e62f4a80966610e2eaf23405b |
| Trott | https://github.com/Trott |
| Feb 4, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r570213458 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Linkgoron | https://github.com/Linkgoron |
| Feb 4, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r570217601 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Linkgoron | https://github.com/Linkgoron |
| Feb 4, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r570223267 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Linkgoron | https://github.com/Linkgoron |
| Feb 4, 2021 | https://github.com/nodejs/node/pull/37153#discussion_r570229965 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #37227 | https://github.com/nodejs/node/pull/37227 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Feb 4, 2021
| https://github.com/nodejs/node/pull/37153#ref-issue-801273983 |
|
investigate flaky test-timers-promisified
#37226
| https://github.com/nodejs/node/issues/37226 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
|
Feb 4, 2021
| https://github.com/nodejs/node/pull/37153#ref-pullrequest-801291894 |
|
timers: remove flaky setInterval test
#37227
| https://github.com/nodejs/node/pull/37227 |
| danielleadams | https://github.com/danielleadams |
|
Feb 16, 2021
| https://github.com/nodejs/node/pull/37153#ref-commit-4ebe38b |
|
| https://github.com/Linkgoron |
|
| https://github.com/danielleadams |
| timers: introduce setInterval async iterator | https://github.com/nodejs/node/commit/4ebe38b212bfd648cb6229b59e5dbf92326f5cf6 |
| 4ebe38b | https://github.com/nodejs/node/commit/4ebe38b212bfd648cb6229b59e5dbf92326f5cf6 |
| #37153 | https://github.com/nodejs/node/pull/37153 |
| danielleadams | https://github.com/danielleadams |
|
Feb 16, 2021
| https://github.com/nodejs/node/pull/37153#ref-commit-5133659 |
|
| https://github.com/danielleadams |
| 2021-02-16, Version 15.9.0 (Current) | https://github.com/nodejs/node/commit/51336594337ed19d0826e480d0e7e024c55bbeb2 |
| 5133659 | https://github.com/nodejs/node/commit/51336594337ed19d0826e480d0e7e024c55bbeb2 |
| #37081 | https://github.com/nodejs/node/pull/37081 |
| #37360 | https://github.com/nodejs/node/pull/37360 |
| #37377 | https://github.com/nodejs/node/pull/37377 |
| #37170 | https://github.com/nodejs/node/pull/37170 |
| #37179 | https://github.com/nodejs/node/pull/37179 |
| #37174 | https://github.com/nodejs/node/pull/37174 |
| #37190 | https://github.com/nodejs/node/pull/37190 |
| #37155 | https://github.com/nodejs/node/pull/37155 |
| #37158 | https://github.com/nodejs/node/pull/37158 |
| #37153 | https://github.com/nodejs/node/pull/37153 |
| #37070 | https://github.com/nodejs/node/pull/37070 |
|
v15.9.0 proposal
#37405
| https://github.com/nodejs/node/pull/37405 |
|
v15.9.0 proposal
#37406
| https://github.com/nodejs/node/pull/37406 |
| danielleadams | https://github.com/danielleadams |
|
Feb 17, 2021
| https://github.com/nodejs/node/pull/37153#ref-commit-889ffde |
|
| https://github.com/danielleadams |
| 2021-02-17, Version 15.9.0 (Current) | https://github.com/nodejs/node/commit/889ffdeee6dc396edf232f3c7d73417f9d82d805 |
|
| https://github.com/nodejs/node/commit/889ffdeee6dc396edf232f3c7d73417f9d82d805#comments |
| 889ffde | https://github.com/nodejs/node/commit/889ffdeee6dc396edf232f3c7d73417f9d82d805 |
| #37081 | https://github.com/nodejs/node/pull/37081 |
| #37360 | https://github.com/nodejs/node/pull/37360 |
| #37377 | https://github.com/nodejs/node/pull/37377 |
| #37170 | https://github.com/nodejs/node/pull/37170 |
| #37179 | https://github.com/nodejs/node/pull/37179 |
| #37174 | https://github.com/nodejs/node/pull/37174 |
| #37190 | https://github.com/nodejs/node/pull/37190 |
| #37155 | https://github.com/nodejs/node/pull/37155 |
| #37158 | https://github.com/nodejs/node/pull/37158 |
| #37153 | https://github.com/nodejs/node/pull/37153 |
| #37070 | https://github.com/nodejs/node/pull/37070 |
| danielleadams | https://github.com/danielleadams |
|
Feb 17, 2021
| https://github.com/nodejs/node/pull/37153#ref-commit-b471267 |
|
| https://github.com/danielleadams |
| 2021-02-17, Version 15.9.0 (Current) | https://github.com/nodejs/node/commit/b47126743932509bb4dee7e3c0e420268bbc2dfd |
| b471267 | https://github.com/nodejs/node/commit/b47126743932509bb4dee7e3c0e420268bbc2dfd |
| #37081 | https://github.com/nodejs/node/pull/37081 |
| #37360 | https://github.com/nodejs/node/pull/37360 |
| #37377 | https://github.com/nodejs/node/pull/37377 |
| #37170 | https://github.com/nodejs/node/pull/37170 |
| #37179 | https://github.com/nodejs/node/pull/37179 |
| #37174 | https://github.com/nodejs/node/pull/37174 |
| #37190 | https://github.com/nodejs/node/pull/37190 |
| #37155 | https://github.com/nodejs/node/pull/37155 |
| #37158 | https://github.com/nodejs/node/pull/37158 |
| #37153 | https://github.com/nodejs/node/pull/37153 |
| #37070 | https://github.com/nodejs/node/pull/37070 |
| danielleadams | https://github.com/danielleadams |
|
Feb 17, 2021
| https://github.com/nodejs/node/pull/37153#ref-commit-877f66e |
|
| https://github.com/danielleadams |
| 2021-02-17, Version 15.9.0 (Current) | https://github.com/nodejs/node/commit/877f66eb2d00f1bf7326a70d9bc12f49d46e1aca |
| 877f66e | https://github.com/nodejs/node/commit/877f66eb2d00f1bf7326a70d9bc12f49d46e1aca |
| #37406 | https://github.com/nodejs/node/pull/37406 |
| #37081 | https://github.com/nodejs/node/pull/37081 |
| #37360 | https://github.com/nodejs/node/pull/37360 |
| #37377 | https://github.com/nodejs/node/pull/37377 |
| #37170 | https://github.com/nodejs/node/pull/37170 |
| #37179 | https://github.com/nodejs/node/pull/37179 |
| #37174 | https://github.com/nodejs/node/pull/37174 |
| #37190 | https://github.com/nodejs/node/pull/37190 |
| #37155 | https://github.com/nodejs/node/pull/37155 |
| #37158 | https://github.com/nodejs/node/pull/37158 |
| #37153 | https://github.com/nodejs/node/pull/37153 |
| #37070 | https://github.com/nodejs/node/pull/37070 |
| danielleadams | https://github.com/danielleadams |
|
Feb 18, 2021
| https://github.com/nodejs/node/pull/37153#ref-commit-3bf50a7 |
|
| https://github.com/danielleadams |
| 2021-02-17, Version 15.9.0 (Current) | https://github.com/nodejs/node/commit/3bf50a70b4cd801cb1fa53ffd98ae89677412b0a |
| 3bf50a7 | https://github.com/nodejs/node/commit/3bf50a70b4cd801cb1fa53ffd98ae89677412b0a |
| #37406 | https://github.com/nodejs/node/pull/37406 |
| #37081 | https://github.com/nodejs/node/pull/37081 |
| #37360 | https://github.com/nodejs/node/pull/37360 |
| #37377 | https://github.com/nodejs/node/pull/37377 |
| #37170 | https://github.com/nodejs/node/pull/37170 |
| #37179 | https://github.com/nodejs/node/pull/37179 |
| #37174 | https://github.com/nodejs/node/pull/37174 |
| #37190 | https://github.com/nodejs/node/pull/37190 |
| #37155 | https://github.com/nodejs/node/pull/37155 |
| #37158 | https://github.com/nodejs/node/pull/37158 |
| #37153 | https://github.com/nodejs/node/pull/37153 |
| #37070 | https://github.com/nodejs/node/pull/37070 |
| https://github.com/azu |
| azu | https://github.com/azu |
|
Feb 18, 2021
| https://github.com/nodejs/node/pull/37153#ref-issue-590720476 |
|
for await...ofについての記述を追加
azu/promises-book#347
| https://github.com/azu/promises-book/issues/347 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| February 26, 2021 14:27 | https://github.com/nodejs/node/pull/37153#event-4382127703 |
|
debugger: revise async iterator usage to comply with lint rules
#38847
| https://github.com/nodejs/node/pull/38847 |
|
debugger: refactor internal/inspector/_inspect to use more primordials
#38406
| https://github.com/nodejs/node/pull/38406 |
|
debugger: remove unnecessary boilerplate copyright comment
#38952
| https://github.com/nodejs/node/pull/38952 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v12.x |
| Jul 19, 2021 | https://github.com/nodejs/node/pull/37153#event-5038549610 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Jul 19, 2021 | https://github.com/nodejs/node/pull/37153#issuecomment-882559051 |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37153 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/37153/files/1f8b21c76768b41ec24f66516a5243b087929282 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/37153/files/55eedb65ec469e74862944100f9bedf81ffda927 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/37153/files/9186124767f9c0fc33d294cb850e2f34d15883f4 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/37153/files/bc95c21edea5b7592300a89035299cec025cda3e |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/37153/files/1f8b21c76768b41ec24f66516a5243b087929282 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/37153/files/55eedb65ec469e74862944100f9bedf81ffda927 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Please reload this page | https://github.com/nodejs/node/pull/37153 |
|
| https://github.com/Linkgoron |
|
| https://github.com/targos |
|
| https://github.com/benjamingr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/aduh95 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |