René's URL Explorer Experiment


Title: crypto: add support for SM2 by tniessen · Pull Request #37066 · nodejs/node · GitHub

Open Graph Title: crypto: add support for SM2 by tniessen · Pull Request #37066 · nodejs/node

X Title: crypto: add support for SM2 by tniessen · Pull Request #37066 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: These commits add support for SM2 from the SM9 standard. It requires a fair amount of hacks within our codebase, so if anyone has any other integration ideas, I'd be happy to hear them. Asymmet...

X Description: These commits add support for SM2 from the SM9 standard. It requires a fair amount of hacks within our codebase, so if anyone has any other integration ideas, I'd be happy to hear them. Asy...

Opengraph URL: https://github.com/nodejs/node/pull/37066

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:5b09f6c9-b1e1-88c5-2f4a-50475451eb73
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C7C:1ED861:13A20E6:19EE2EF:6A534377
html-safe-noncebf5e5e3c6361f61e1a12d925c2c308ed60d47ce4859ed171d1235af60ca3650e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzdDOjFFRDg2MToxM0EyMEU2OjE5RUUyRUY6NkE1MzQzNzciLCJ2aXNpdG9yX2lkIjoiMzI3NzI5NjkxNjA3ODIxNjA1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6f2ebf25c56f4f89e6dcba9ee6d01a7d0f914a55575c90770560aa5c4c22f5d6
hovercard-subject-tagpull_request:561302210
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/37066
twitter:imagehttps://opengraph.githubassets.com/14e013ca5de16198797db6b22b7094a01000e70bb977a742c2655f86b8192d65/nodejs/node/pull/37066
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/14e013ca5de16198797db6b22b7094a01000e70bb977a742c2655f86b8192d65/nodejs/node/pull/37066
og:image:altThese commits add support for SM2 from the SM9 standard. It requires a fair amount of hacks within our codebase, so if anyone has any other integration ideas, I'd be happy to hear them. Asymmet...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/37066#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37066
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37066
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/37066
Reloadhttps://github.com/nodejs/node/pull/37066
Reloadhttps://github.com/nodejs/node/pull/37066
Please reload this pagehttps://github.com/nodejs/node/pull/37066
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/37066
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 997 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
tniessenhttps://github.com/tniessen
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-add-support-for-sm2https://github.com/tniessen/node/tree/crypto-add-support-for-sm2
Conversationhttps://github.com/nodejs/node/pull/37066
Commits4 (4)https://github.com/nodejs/node/pull/37066/commits
Checkshttps://github.com/nodejs/node/pull/37066/checks
Files changedhttps://github.com/nodejs/node/pull/37066/files
crypto: add support for SM2https://github.com/nodejs/node/pull/37066#top
tniessenhttps://github.com/tniessen
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-add-support-for-sm2https://github.com/tniessen/node/tree/crypto-add-support-for-sm2
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jan 25, 2021https://github.com/nodejs/node/pull/37066#issue-793649862
SM9 standardhttps://en.wikipedia.org/wiki/SM9_%28cryptography_standard%29
doi:10.1007/978-3-642-25513-7_12https://doi.org/10.1007/978-3-642-25513-7_12
Please reload this pagehttps://github.com/nodejs/node/pull/37066
tniessenhttps://github.com/tniessen
January 25, 2021 18:35https://github.com/nodejs/node/pull/37066#commits-pushed-70988ea
https://github.com/tniessen
crypto: add 'sm2' key type and key pair generationhttps://github.com/nodejs/node/pull/37066/commits/70988ea2f60c37d71adaa5e9400d77c377b032b5
70988eahttps://github.com/nodejs/node/pull/37066/commits/70988ea2f60c37d71adaa5e9400d77c377b032b5
https://github.com/tniessen
crypto: add support for SM2 one-shot signatureshttps://github.com/nodejs/node/pull/37066/commits/4282617daf5ab9c3aa71b88ca40f6a7e64b05db9
4282617https://github.com/nodejs/node/pull/37066/commits/4282617daf5ab9c3aa71b88ca40f6a7e64b05db9
https://github.com/tniessen
crypto: allow adjusting key type on importhttps://github.com/nodejs/node/pull/37066/commits/a52008c0e9b5d57bc16759feaa78e73333b95478
a52008chttps://github.com/nodejs/node/pull/37066/commits/a52008c0e9b5d57bc16759feaa78e73333b95478
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jan 25, 2021https://github.com/nodejs/node/pull/37066#event-4247261777
https://github.com/tniessen
tniessenhttps://github.com/tniessen
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Jan 25, 2021https://github.com/nodejs/node/pull/37066#event-4247262574
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jan 25, 2021https://github.com/nodejs/node/pull/37066#issuecomment-767047117
#37055https://github.com/nodejs/node/issues/37055
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/tniessen
test: ensure EC keys on the SM2 curve workhttps://github.com/nodejs/node/pull/37066/commits/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e
a76c7e4https://github.com/nodejs/node/pull/37066/commits/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 25, 2021 https://github.com/nodejs/node/pull/37066#pullrequestreview-575731102
View reviewed changes https://github.com/nodejs/node/pull/37066/files/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e
doc/api/crypto.mdhttps://github.com/nodejs/node/pull/37066/files/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454
jasnellhttps://github.com/jasnell
Jan 25, 2021https://github.com/nodejs/node/pull/37066#discussion_r563981925
Please reload this pagehttps://github.com/nodejs/node/pull/37066
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 25, 2021 https://github.com/nodejs/node/pull/37066#pullrequestreview-575733308
View reviewed changes https://github.com/nodejs/node/pull/37066/files/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e
doc/api/crypto.mdhttps://github.com/nodejs/node/pull/37066/files/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454
jasnellhttps://github.com/jasnell
Jan 25, 2021https://github.com/nodejs/node/pull/37066#discussion_r563983556
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 25, 2021 https://github.com/nodejs/node/pull/37066#pullrequestreview-575734438
View reviewed changes https://github.com/nodejs/node/pull/37066/files/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e
lib/internal/crypto/keys.jshttps://github.com/nodejs/node/pull/37066/files/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e#diff-dc0c77ec6254d6ea006052823a4d90dda37543cc4c4bf451a6fd8d079b9fa9f3
jasnellhttps://github.com/jasnell
Jan 25, 2021https://github.com/nodejs/node/pull/37066#discussion_r563984439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/37066
Mifrillhttps://github.com/Mifrill
Nov 17, 2023https://github.com/nodejs/node/pull/37066#discussion_r1397893716
Please reload this pagehttps://github.com/nodejs/node/pull/37066
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jan 25, 2021https://github.com/nodejs/node/pull/37066#issuecomment-767070047
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jan 26, 2021 https://github.com/nodejs/node/pull/37066#ref-issue-427145334
Supported asymmetric key types #26996 https://github.com/nodejs/node/issues/26996
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jan 26, 2021https://github.com/nodejs/node/pull/37066#issuecomment-767502133
#26996https://github.com/nodejs/node/issues/26996
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 26, 2021https://github.com/nodejs/node/pull/37066#issuecomment-767639890
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jan 26, 2021https://github.com/nodejs/node/pull/37066#issuecomment-767825572
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 5, 2021 https://github.com/nodejs/node/pull/37066#ref-pullrequest-800746627
crypto: introduce crypto/promises #37218 https://github.com/nodejs/node/pull/37218
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
dc5a5dahttps://github.com/nodejs/node/commit/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04
8e46568https://github.com/nodejs/node/commit/8e46568b1e12fe00581b1292bd6c2b01373f17bd
Compare https://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
March 29, 2021 21:33https://github.com/nodejs/node/pull/37066#event-4523995672
Replace OpenSSL 1.1.1 with OpenSSL 3.0.0 #40106 https://github.com/nodejs/node/issues/40106
deps: update openssl to quictls/openssl 3.0.0+quic #38512 https://github.com/nodejs/node/pull/38512
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 26, 2021https://github.com/nodejs/node/pull/37066#issuecomment-952025254
@jasnellhttps://github.com/jasnell
@mscdexhttps://github.com/mscdex
#40106 (comment)https://github.com/nodejs/node/issues/40106#issuecomment-936412898
#38512 (comment)https://github.com/nodejs/node/pull/38512#issuecomment-938040117
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 2, 2021https://github.com/nodejs/node/pull/37066#issuecomment-957882352
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Nov 2, 2021https://github.com/nodejs/node/pull/37066#issuecomment-958020796
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
2d76238https://github.com/nodejs/node/commit/2d76238f9184c9009bfa395848a120ac3e5b98e5
ca3ed36https://github.com/nodejs/node/commit/ca3ed363ffefa4819c1414aff7ffca34b53a7b95
Compare https://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
November 12, 2022 01:49https://github.com/nodejs/node/pull/37066#event-7795751633
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 8, 2024 https://github.com/nodejs/node/pull/37066#ref-issue-2396197938
The signature and verification of SM2 return incorrect results in crypto.createSign and crypto.createVerify #53761 https://github.com/nodejs/node/issues/53761
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37066
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/37066/files/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e
https://github.com/Mifrill
Mifrill https://github.com/Mifrill
https://github.com/nodejs/node/pull/37066/files/a76c7e4e77a6634e829137e68e34a5c5d9c78a0e
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/37066
https://github.com/tniessen
https://github.com/mscdex
https://github.com/jasnell
https://github.com/Mifrill
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.