René's URL Explorer Experiment


Title: crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X* by panva · Pull Request #37063 · nodejs/node · GitHub

Open Graph Title: crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X* by panva · Pull Request #37063 · nodejs/node

X Title: crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X* by panva · Pull Request #37063 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The following "curves" were added to the 'ec' key type in #36879. NODE-ED25519 NODE-ED448 NODE-X25519 NODE-X448 However, none of these are pure EC curves, for example, Curve2551...

X Description: The following "curves" were added to the 'ec' key type in #36879. NODE-ED25519 NODE-ED448 NODE-X25519 NODE-X448 However, none of these are pure EC curves, for ex...

Opengraph URL: https://github.com/nodejs/node/pull/37063

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4dd16bdc-d54a-8963-ff61-3de9ee4dbcaf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA138:30769A:7618CA:9D55B7:6A52A5D4
html-safe-noncefb832e7a5b9db4302c72daabfd369fcb3c6176516a96958839f9a7661a940fa6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTM4OjMwNzY5QTo3NjE4Q0E6OUQ1NUI3OjZBNTJBNUQ0IiwidmlzaXRvcl9pZCI6Ijg1NjI5MTM3OTQ4ODM0OTUzODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac89b95465c79c882b3295562bc519dc25d12a37dca4d5a5c4bfb6ad5f3c80fe10
hovercard-subject-tagpull_request:561079584
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/37063/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cf8fdbea1642f1b774702e1ef069167ac6623c90ea449897beb380a3adf94eae/nodejs/node/pull/37063
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf8fdbea1642f1b774702e1ef069167ac6623c90ea449897beb380a3adf94eae/nodejs/node/pull/37063
og:image:altThe following "curves" were added to the 'ec' key type in #36879. NODE-ED25519 NODE-ED448 NODE-X25519 NODE-X448 However, none of these are pure EC curves, for example, Curve2551...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepanva
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/37063#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37063
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37063
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/37063
Reloadhttps://github.com/nodejs/node/pull/37063
Reloadhttps://github.com/nodejs/node/pull/37063
Please reload this pagehttps://github.com/nodejs/node/pull/37063
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/37063
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 988 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
panvahttps://github.com/panva
nodejs:masterhttps://github.com/nodejs/node/tree/master
panva:fix-37055https://github.com/panva/node/tree/fix-37055
Conversationhttps://github.com/nodejs/node/pull/37063
Commits4 (4)https://github.com/nodejs/node/pull/37063/commits
Checkshttps://github.com/nodejs/node/pull/37063/checks
Files changedhttps://github.com/nodejs/node/pull/37063/files
crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X*https://github.com/nodejs/node/pull/37063#top
panvahttps://github.com/panva
nodejs:masterhttps://github.com/nodejs/node/tree/master
panva:fix-37055https://github.com/panva/node/tree/fix-37055
https://github.com/panva
panvahttps://github.com/panva
Jan 25, 2021https://github.com/nodejs/node/pull/37063#issue-793382083
Please reload this pagehttps://github.com/nodejs/node/pull/37063
#36879https://github.com/nodejs/node/pull/36879
#37055https://github.com/nodejs/node/issues/37055
@jasnellhttps://github.com/jasnell
@tniessenhttps://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/37063
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Jan 25, 2021https://github.com/nodejs/node/pull/37063#event-4245587901
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2021https://github.com/nodejs/node/pull/37063#issuecomment-766820169
https://ci.nodejs.org/job/node-test-pull-request/35727/https://ci.nodejs.org/job/node-test-pull-request/35727/
Please reload this pagehttps://github.com/nodejs/node/pull/37063
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jan 25, 2021 https://github.com/nodejs/node/pull/37063#pullrequestreview-575404238
View reviewed changes https://github.com/nodejs/node/pull/37063/files
lib/internal/crypto/ec.jshttps://github.com/nodejs/node/pull/37063/files#diff-15c1a60d165e73c0aa21f0aff84493a257a577a97e9c8d2f33779b003193e338
Please reload this pagehttps://github.com/nodejs/node/pull/37063
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jan 25, 2021 https://github.com/nodejs/node/pull/37063#pullrequestreview-575422261
View reviewed changes https://github.com/nodejs/node/pull/37063/files
tniessenhttps://github.com/tniessen
https://github.com/nodejs/node/pull/37063#pullrequestreview-575422261
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/37063
lib/internal/crypto/ec.jshttps://github.com/nodejs/node/pull/37063/files#diff-15c1a60d165e73c0aa21f0aff84493a257a577a97e9c8d2f33779b003193e338
Please reload this pagehttps://github.com/nodejs/node/pull/37063
https://github.com/panva
panvahttps://github.com/panva
Jan 25, 2021https://github.com/nodejs/node/pull/37063#issuecomment-766838935
Please reload this pagehttps://github.com/nodejs/node/pull/37063
https://github.com/panva
panvahttps://github.com/panva
Jan 25, 2021 https://github.com/nodejs/node/pull/37063#pullrequestreview-575468159
View reviewed changes https://github.com/nodejs/node/pull/37063/files
src/crypto/crypto_ecdh.cchttps://github.com/nodejs/node/pull/37063/files#diff-a46bf10f12f6a722718ddbe78b234fa0e92659fa6fcd933c1d7b5f13f143e909
panvahttps://github.com/panva
Jan 25, 2021https://github.com/nodejs/node/pull/37063#discussion_r563778928
Please reload this pagehttps://github.com/nodejs/node/pull/37063
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/37063
https://github.com/tniessen
tniessenhttps://github.com/tniessen
jasnellhttps://github.com/jasnell
January 25, 2021 15:43https://github.com/nodejs/node/pull/37063#event-4246277737
panvahttps://github.com/panva
January 25, 2021 18:08https://github.com/nodejs/node/pull/37063#commits-pushed-76f8180
https://github.com/panva
crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X*https://github.com/nodejs/node/pull/37063/commits/76f81802b3186c71e171c19fe0e41ffcd89c8d60
76f8180https://github.com/nodejs/node/pull/37063/commits/76f81802b3186c71e171c19fe0e41ffcd89c8d60
nodejs#37055https://github.com/nodejs/node/issues/37055
https://github.com/panva
https://github.com/tniessen
Update lib/internal/crypto/ec.jshttps://github.com/nodejs/node/pull/37063/commits/eb07638f6a3b122e7cd083584e848597346606e1
eb07638https://github.com/nodejs/node/pull/37063/commits/eb07638f6a3b122e7cd083584e848597346606e1
https://github.com/panva
fix linthttps://github.com/nodejs/node/pull/37063/commits/42805dd9064f43b38f8f6b847a2ccc96cbb0a620
42805ddhttps://github.com/nodejs/node/pull/37063/commits/42805dd9064f43b38f8f6b847a2ccc96cbb0a620
https://github.com/panva
fixup!https://github.com/nodejs/node/pull/37063/commits/566ceb417b1c0321f78b01bafa927099e1df73aa
566ceb4https://github.com/nodejs/node/pull/37063/commits/566ceb417b1c0321f78b01bafa927099e1df73aa
https://github.com/panva
panvahttps://github.com/panva
force-pushedhttps://github.com/nodejs/node/compare/f9922c0dd89630f97d0a85142e425357eec50e69..566ceb417b1c0321f78b01bafa927099e1df73aa
f9922c0https://github.com/nodejs/node/commit/f9922c0dd89630f97d0a85142e425357eec50e69
566ceb4https://github.com/nodejs/node/commit/566ceb417b1c0321f78b01bafa927099e1df73aa
Compare https://github.com/nodejs/node/compare/f9922c0dd89630f97d0a85142e425357eec50e69..566ceb417b1c0321f78b01bafa927099e1df73aa
January 25, 2021 17:10https://github.com/nodejs/node/pull/37063#event-4246724614
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 25, 2021https://github.com/nodejs/node/pull/37063#issuecomment-766967817
https://ci.nodejs.org/job/node-test-pull-request/35728/https://ci.nodejs.org/job/node-test-pull-request/35728/
Please reload this pagehttps://github.com/nodejs/node/pull/37063
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 25, 2021 https://github.com/nodejs/node/pull/37063#pullrequestreview-575669017
View reviewed changes https://github.com/nodejs/node/pull/37063/files/566ceb417b1c0321f78b01bafa927099e1df73aa
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 25, 2021https://github.com/nodejs/node/pull/37063#event-4247065444
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jan 25, 2021 https://github.com/nodejs/node/pull/37063#pullrequestreview-575699858
View reviewed changes https://github.com/nodejs/node/pull/37063/files/566ceb417b1c0321f78b01bafa927099e1df73aa
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Jan 26, 2021 https://github.com/nodejs/node/pull/37063#pullrequestreview-575927078
View reviewed changes https://github.com/nodejs/node/pull/37063/files/566ceb417b1c0321f78b01bafa927099e1df73aa
panvahttps://github.com/panva
Jan 27, 2021 https://github.com/nodejs/node/pull/37063#ref-commit-8b65004
https://github.com/panva
crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X*https://github.com/nodejs/node/commit/8b65004193ae2010b7c663b3f66473244613bcca
8b65004https://github.com/nodejs/node/commit/8b65004193ae2010b7c663b3f66473244613bcca
#37055https://github.com/nodejs/node/issues/37055
#37063https://github.com/nodejs/node/pull/37063
https://github.com/panva
panvahttps://github.com/panva
Jan 27, 2021https://github.com/nodejs/node/pull/37063#issuecomment-768301692
8b65004https://github.com/nodejs/node/commit/8b65004193ae2010b7c663b3f66473244613bcca
Please reload this pagehttps://github.com/nodejs/node/pull/37063
https://github.com/panva
panvahttps://github.com/panva
Jan 27, 2021https://github.com/nodejs/node/pull/37063#event-4255986731
targoshttps://github.com/targos
Feb 2, 2021 https://github.com/nodejs/node/pull/37063#ref-commit-cb3b0ec
https://github.com/panva
https://github.com/targos
crypto: generateKeyPair('ec') should not support NODE-ED* and NODE-X*https://github.com/nodejs/node/commit/cb3b0ec4fcbef9d77bcb66338ca048b69ca2a31b
cb3b0echttps://github.com/nodejs/node/commit/cb3b0ec4fcbef9d77bcb66338ca048b69ca2a31b
#37055https://github.com/nodejs/node/issues/37055
#37063https://github.com/nodejs/node/pull/37063
https://github.com/targos
targoshttps://github.com/targos
Feb 2, 2021 https://github.com/nodejs/node/pull/37063#ref-pullrequest-799142097
v15.8.0 release proposal #37183 https://github.com/nodejs/node/pull/37183
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
May 25, 2021https://github.com/nodejs/node/pull/37063#event-4793475406
https://github.com/panva
panvahttps://github.com/panva
October 13, 2022 09:13https://github.com/nodejs/node/pull/37063#event-7579170546
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F37063
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/37063/files/566ceb417b1c0321f78b01bafa927099e1df73aa
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/37063/files/566ceb417b1c0321f78b01bafa927099e1df73aa
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/37063/files/566ceb417b1c0321f78b01bafa927099e1df73aa
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
generateKeyPair('ec') should not support NODE-ED* and NODE-X* https://github.com/nodejs/node/issues/37055
Please reload this pagehttps://github.com/nodejs/node/pull/37063
https://github.com/panva
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/tniessen
https://github.com/juanarbol
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.