| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:78897350-88cc-4917-1163-8a50b92e4afe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B8B8:1DC0B7:19961CB:22C7EEA:6A53EDF0 |
| html-safe-nonce | 3d21afa627648187e7037d0f3533d8a773e5f90c3286685f0df6bf1c81f210b7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEI4OjFEQzBCNzoxOTk2MUNCOjIyQzdFRUE6NkE1M0VERjAiLCJ2aXNpdG9yX2lkIjoiNzk1NTAzOTcxMTkwNjc1NDAzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 56369c7360a0ef19f6c9c8e7d5ebc0344ca6b0a1158c2af6597a0c8f08b06071 |
| hovercard-subject-tag | pull_request:555384925 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36937/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7c4b6432a89b720c3f12977d593120ec15a86a5c3728924bdab12fd1b957be7e/nodejs/node/pull/36937 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7c4b6432a89b720c3f12977d593120ec15a86a5c3728924bdab12fd1b957be7e/nodejs/node/pull/36937 |
| og:image:alt | Fixes: #36936 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Lxxyx |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36937#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36937 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36937 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36937 |
| Reload | https://github.com/nodejs/node/pull/36937 |
| Reload | https://github.com/nodejs/node/pull/36937 |
| Please reload this page | https://github.com/nodejs/node/pull/36937 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36937 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
996
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Lxxyx | https://github.com/Lxxyx |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Lxxyx:fix-perf_hooks-histogram-error | https://github.com/Lxxyx/node/tree/fix-perf_hooks-histogram-error |
| Conversation | https://github.com/nodejs/node/pull/36937 |
| Commits1 (1) | https://github.com/nodejs/node/pull/36937/commits |
| Checks | https://github.com/nodejs/node/pull/36937/checks |
| Files changed | https://github.com/nodejs/node/pull/36937/files |
| perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN | https://github.com/nodejs/node/pull/36937#top |
| Lxxyx | https://github.com/Lxxyx |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Lxxyx:fix-perf_hooks-histogram-error | https://github.com/Lxxyx/node/tree/fix-perf_hooks-histogram-error |
|
| https://github.com/Lxxyx |
| Lxxyx | https://github.com/Lxxyx |
| Jan 15, 2021 | https://github.com/nodejs/node/pull/36937#issue-786532957 |
| #36936 | https://github.com/nodejs/node/issues/36936 |
| Please reload this page | https://github.com/nodejs/node/pull/36937 |
|
| https://github.com/Lxxyx |
| perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param… | https://github.com/nodejs/node/pull/36937/commits/5f9ad65f07346eec2818d0733712bd4d494291db |
| 5f9ad65 | https://github.com/nodejs/node/pull/36937/commits/5f9ad65f07346eec2818d0733712bd4d494291db |
| nodejs#36936 | https://github.com/nodejs/node/issues/36936 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 15, 2021
| https://github.com/nodejs/node/pull/36937#pullrequestreview-569084067 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db |
| https://github.com/RaisinTen |
| RaisinTen | https://github.com/RaisinTen |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jan 15, 2021 | https://github.com/nodejs/node/pull/36937#event-4210176450 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 15, 2021
| https://github.com/nodejs/node/pull/36937#pullrequestreview-569305285 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 15, 2021 | https://github.com/nodejs/node/pull/36937#issuecomment-760981253 |
| https://ci.nodejs.org/job/node-test-pull-request/35561/ | https://ci.nodejs.org/job/node-test-pull-request/35561/ |
| Please reload this page | https://github.com/nodejs/node/pull/36937 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 15, 2021
| https://github.com/nodejs/node/pull/36937#pullrequestreview-569322450 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36937#issuecomment-762173688 |
| https://ci.nodejs.org/job/node-test-pull-request/35599/ | https://ci.nodejs.org/job/node-test-pull-request/35599/ |
| Please reload this page | https://github.com/nodejs/node/pull/36937 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36937#issuecomment-762479839 |
| 59af4e6 | https://github.com/nodejs/node/commit/59af4e6acdd140b672dd809bfd754b7d87bda137 |
| Please reload this page | https://github.com/nodejs/node/pull/36937 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36937#event-4219894675 |
| jasnell | https://github.com/jasnell |
|
Jan 18, 2021
| https://github.com/nodejs/node/pull/36937#ref-commit-59af4e6 |
|
| https://github.com/Lxxyx |
|
| https://github.com/jasnell |
| perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param… | https://github.com/nodejs/node/commit/59af4e6acdd140b672dd809bfd754b7d87bda137 |
| 59af4e6 | https://github.com/nodejs/node/commit/59af4e6acdd140b672dd809bfd754b7d87bda137 |
| #36936 | https://github.com/nodejs/node/issues/36936 |
| #36937 | https://github.com/nodejs/node/pull/36937 |
| https://github.com/Lxxyx |
| Lxxyx | https://github.com/Lxxyx |
| January 18, 2021 21:43 | https://github.com/nodejs/node/pull/36937#event-4219918548 |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36937#ref-commit-327a2b7 |
|
| https://github.com/Lxxyx |
|
| https://github.com/ruyadorno |
| perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param… | https://github.com/nodejs/node/commit/327a2b7801c3dc19e332763208c77a530091d6a1 |
| 327a2b7 | https://github.com/nodejs/node/commit/327a2b7801c3dc19e332763208c77a530091d6a1 |
| #36936 | https://github.com/nodejs/node/issues/36936 |
| #36937 | https://github.com/nodejs/node/pull/36937 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36937#ref-pullrequest-791653749 |
|
v15.7.0 proposal
#37020
| https://github.com/nodejs/node/pull/37020 |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 25, 2021
| https://github.com/nodejs/node/pull/36937#ref-commit-3f75a60 |
|
| https://github.com/Lxxyx |
|
| https://github.com/ruyadorno |
| perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param… | https://github.com/nodejs/node/commit/3f75a60b518f72ed77a43dd92675ce16ab0e1c4a |
| 3f75a60 | https://github.com/nodejs/node/commit/3f75a60b518f72ed77a43dd92675ce16ab0e1c4a |
| #36936 | https://github.com/nodejs/node/issues/36936 |
| #36937 | https://github.com/nodejs/node/pull/36937 |
| targos | https://github.com/targos |
|
May 25, 2021
| https://github.com/nodejs/node/pull/36937#ref-commit-579d199 |
|
| https://github.com/Lxxyx |
|
| https://github.com/targos |
| perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param… | https://github.com/nodejs/node/commit/579d19944366d81aade80e3a24cb301bfe1b6266 |
| 579d199 | https://github.com/nodejs/node/commit/579d19944366d81aade80e3a24cb301bfe1b6266 |
| #36936 | https://github.com/nodejs/node/issues/36936 |
| #36937 | https://github.com/nodejs/node/pull/36937 |
| targos | https://github.com/targos |
|
May 30, 2021
| https://github.com/nodejs/node/pull/36937#ref-commit-bd298f7 |
|
| https://github.com/Lxxyx |
|
| https://github.com/targos |
| perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param… | https://github.com/nodejs/node/commit/bd298f7555c922826aed842b476ff2eba469a6f8 |
| bd298f7 | https://github.com/nodejs/node/commit/bd298f7555c922826aed842b476ff2eba469a6f8 |
| #36936 | https://github.com/nodejs/node/issues/36936 |
| #36937 | https://github.com/nodejs/node/pull/36937 |
| targos | https://github.com/targos |
|
Jun 5, 2021
| https://github.com/nodejs/node/pull/36937#ref-commit-38178b8 |
|
| https://github.com/Lxxyx |
|
| https://github.com/targos |
| perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param… | https://github.com/nodejs/node/commit/38178b87efe8e27dcf0405ae58709e9905a1fb48 |
| 38178b8 | https://github.com/nodejs/node/commit/38178b87efe8e27dcf0405ae58709e9905a1fb48 |
| #36936 | https://github.com/nodejs/node/issues/36936 |
| #36937 | https://github.com/nodejs/node/pull/36937 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jun 6, 2021
| https://github.com/nodejs/node/pull/36937#ref-pullrequest-912748369 |
|
v14.17.1 release proposal
#38948
| https://github.com/nodejs/node/pull/38948 |
| targos | https://github.com/targos |
|
Jun 11, 2021
| https://github.com/nodejs/node/pull/36937#ref-commit-726ef40 |
|
| https://github.com/Lxxyx |
|
| https://github.com/targos |
| perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param… | https://github.com/nodejs/node/commit/726ef40fcb829578027ceafb6155c949d2b55360 |
| 726ef40 | https://github.com/nodejs/node/commit/726ef40fcb829578027ceafb6155c949d2b55360 |
| #36936 | https://github.com/nodejs/node/issues/36936 |
| #36937 | https://github.com/nodejs/node/pull/36937 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36937 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
perf_hooks: histogram.percentile throw Assertion `(percentile) > (0)' failed when param is NaN
| https://github.com/nodejs/node/issues/36936 |
| Please reload this page | https://github.com/nodejs/node/pull/36937 |
|
| https://github.com/Lxxyx |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/aduh95 |
|
| https://github.com/RaisinTen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |