René's URL Explorer Experiment


Title: perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN by Lxxyx · Pull Request #36937 · nodejs/node · GitHub

Open Graph Title: perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN by Lxxyx · Pull Request #36937 · nodejs/node

X Title: perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN by Lxxyx · Pull Request #36937 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #36936

X Description: Fixes: #36936

Opengraph URL: https://github.com/nodejs/node/pull/36937

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:78897350-88cc-4917-1163-8a50b92e4afe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8B8:1DC0B7:19961CB:22C7EEA:6A53EDF0
html-safe-nonce3d21afa627648187e7037d0f3533d8a773e5f90c3286685f0df6bf1c81f210b7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEI4OjFEQzBCNzoxOTk2MUNCOjIyQzdFRUE6NkE1M0VERjAiLCJ2aXNpdG9yX2lkIjoiNzk1NTAzOTcxMTkwNjc1NDAzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac56369c7360a0ef19f6c9c8e7d5ebc0344ca6b0a1158c2af6597a0c8f08b06071
hovercard-subject-tagpull_request:555384925
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36937/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7c4b6432a89b720c3f12977d593120ec15a86a5c3728924bdab12fd1b957be7e/nodejs/node/pull/36937
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7c4b6432a89b720c3f12977d593120ec15a86a5c3728924bdab12fd1b957be7e/nodejs/node/pull/36937
og:image:altFixes: #36936
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLxxyx
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36937#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36937
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36937
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36937
Reloadhttps://github.com/nodejs/node/pull/36937
Reloadhttps://github.com/nodejs/node/pull/36937
Please reload this pagehttps://github.com/nodejs/node/pull/36937
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36937
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 996 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Lxxyxhttps://github.com/Lxxyx
nodejs:masterhttps://github.com/nodejs/node/tree/master
Lxxyx:fix-perf_hooks-histogram-errorhttps://github.com/Lxxyx/node/tree/fix-perf_hooks-histogram-error
Conversationhttps://github.com/nodejs/node/pull/36937
Commits1 (1)https://github.com/nodejs/node/pull/36937/commits
Checkshttps://github.com/nodejs/node/pull/36937/checks
Files changedhttps://github.com/nodejs/node/pull/36937/files
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaNhttps://github.com/nodejs/node/pull/36937#top
Lxxyxhttps://github.com/Lxxyx
nodejs:masterhttps://github.com/nodejs/node/tree/master
Lxxyx:fix-perf_hooks-histogram-errorhttps://github.com/Lxxyx/node/tree/fix-perf_hooks-histogram-error
https://github.com/Lxxyx
Lxxyxhttps://github.com/Lxxyx
Jan 15, 2021https://github.com/nodejs/node/pull/36937#issue-786532957
#36936https://github.com/nodejs/node/issues/36936
Please reload this pagehttps://github.com/nodejs/node/pull/36937
https://github.com/Lxxyx
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…https://github.com/nodejs/node/pull/36937/commits/5f9ad65f07346eec2818d0733712bd4d494291db
5f9ad65https://github.com/nodejs/node/pull/36937/commits/5f9ad65f07346eec2818d0733712bd4d494291db
nodejs#36936https://github.com/nodejs/node/issues/36936
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 15, 2021 https://github.com/nodejs/node/pull/36937#pullrequestreview-569084067
View reviewed changes https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 15, 2021https://github.com/nodejs/node/pull/36937#event-4210176450
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 15, 2021 https://github.com/nodejs/node/pull/36937#pullrequestreview-569305285
View reviewed changes https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 15, 2021https://github.com/nodejs/node/pull/36937#issuecomment-760981253
https://ci.nodejs.org/job/node-test-pull-request/35561/https://ci.nodejs.org/job/node-test-pull-request/35561/
Please reload this pagehttps://github.com/nodejs/node/pull/36937
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 15, 2021 https://github.com/nodejs/node/pull/36937#pullrequestreview-569322450
View reviewed changes https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 18, 2021https://github.com/nodejs/node/pull/36937#issuecomment-762173688
https://ci.nodejs.org/job/node-test-pull-request/35599/https://ci.nodejs.org/job/node-test-pull-request/35599/
Please reload this pagehttps://github.com/nodejs/node/pull/36937
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 18, 2021https://github.com/nodejs/node/pull/36937#issuecomment-762479839
59af4e6https://github.com/nodejs/node/commit/59af4e6acdd140b672dd809bfd754b7d87bda137
Please reload this pagehttps://github.com/nodejs/node/pull/36937
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 18, 2021https://github.com/nodejs/node/pull/36937#event-4219894675
jasnellhttps://github.com/jasnell
Jan 18, 2021 https://github.com/nodejs/node/pull/36937#ref-commit-59af4e6
https://github.com/Lxxyx
https://github.com/jasnell
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…https://github.com/nodejs/node/commit/59af4e6acdd140b672dd809bfd754b7d87bda137
59af4e6https://github.com/nodejs/node/commit/59af4e6acdd140b672dd809bfd754b7d87bda137
#36936https://github.com/nodejs/node/issues/36936
#36937https://github.com/nodejs/node/pull/36937
https://github.com/Lxxyx
Lxxyxhttps://github.com/Lxxyx
January 18, 2021 21:43https://github.com/nodejs/node/pull/36937#event-4219918548
ruyadornohttps://github.com/ruyadorno
Jan 22, 2021 https://github.com/nodejs/node/pull/36937#ref-commit-327a2b7
https://github.com/Lxxyx
https://github.com/ruyadorno
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…https://github.com/nodejs/node/commit/327a2b7801c3dc19e332763208c77a530091d6a1
327a2b7https://github.com/nodejs/node/commit/327a2b7801c3dc19e332763208c77a530091d6a1
#36936https://github.com/nodejs/node/issues/36936
#36937https://github.com/nodejs/node/pull/36937
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Jan 22, 2021 https://github.com/nodejs/node/pull/36937#ref-pullrequest-791653749
v15.7.0 proposal #37020 https://github.com/nodejs/node/pull/37020
ruyadornohttps://github.com/ruyadorno
Jan 25, 2021 https://github.com/nodejs/node/pull/36937#ref-commit-3f75a60
https://github.com/Lxxyx
https://github.com/ruyadorno
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…https://github.com/nodejs/node/commit/3f75a60b518f72ed77a43dd92675ce16ab0e1c4a
3f75a60https://github.com/nodejs/node/commit/3f75a60b518f72ed77a43dd92675ce16ab0e1c4a
#36936https://github.com/nodejs/node/issues/36936
#36937https://github.com/nodejs/node/pull/36937
targoshttps://github.com/targos
May 25, 2021 https://github.com/nodejs/node/pull/36937#ref-commit-579d199
https://github.com/Lxxyx
https://github.com/targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…https://github.com/nodejs/node/commit/579d19944366d81aade80e3a24cb301bfe1b6266
579d199https://github.com/nodejs/node/commit/579d19944366d81aade80e3a24cb301bfe1b6266
#36936https://github.com/nodejs/node/issues/36936
#36937https://github.com/nodejs/node/pull/36937
targoshttps://github.com/targos
May 30, 2021 https://github.com/nodejs/node/pull/36937#ref-commit-bd298f7
https://github.com/Lxxyx
https://github.com/targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…https://github.com/nodejs/node/commit/bd298f7555c922826aed842b476ff2eba469a6f8
bd298f7https://github.com/nodejs/node/commit/bd298f7555c922826aed842b476ff2eba469a6f8
#36936https://github.com/nodejs/node/issues/36936
#36937https://github.com/nodejs/node/pull/36937
targoshttps://github.com/targos
Jun 5, 2021 https://github.com/nodejs/node/pull/36937#ref-commit-38178b8
https://github.com/Lxxyx
https://github.com/targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…https://github.com/nodejs/node/commit/38178b87efe8e27dcf0405ae58709e9905a1fb48
38178b8https://github.com/nodejs/node/commit/38178b87efe8e27dcf0405ae58709e9905a1fb48
#36936https://github.com/nodejs/node/issues/36936
#36937https://github.com/nodejs/node/pull/36937
https://github.com/targos
targoshttps://github.com/targos
Jun 6, 2021 https://github.com/nodejs/node/pull/36937#ref-pullrequest-912748369
v14.17.1 release proposal #38948 https://github.com/nodejs/node/pull/38948
targoshttps://github.com/targos
Jun 11, 2021 https://github.com/nodejs/node/pull/36937#ref-commit-726ef40
https://github.com/Lxxyx
https://github.com/targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…https://github.com/nodejs/node/commit/726ef40fcb829578027ceafb6155c949d2b55360
726ef40https://github.com/nodejs/node/commit/726ef40fcb829578027ceafb6155c949d2b55360
#36936https://github.com/nodejs/node/issues/36936
#36937https://github.com/nodejs/node/pull/36937
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36937
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/36937/files/5f9ad65f07346eec2818d0733712bd4d494291db
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
perf_hooks: histogram.percentile throw Assertion `(percentile) > (0)' failed when param is NaN https://github.com/nodejs/node/issues/36936
Please reload this pagehttps://github.com/nodejs/node/pull/36937
https://github.com/Lxxyx
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/aduh95
https://github.com/RaisinTen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.