| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f0ff1c28-74c3-df74-3723-6ae19d5ea9ac |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 89E2:FDB96:2F0628:3EBCD1:6A517E3B |
| html-safe-nonce | aaf80cc66da4d2cc38bf35782563b915f98409697daf9eec85606f32879b43a9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUUyOkZEQjk2OjJGMDYyODozRUJDRDE6NkE1MTdFM0IiLCJ2aXNpdG9yX2lkIjoiNTAzOTEzNTUyMzU4NDcwNDA1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 20a2ee5615da21884aac2a117b55474f4d9b8a316bef11105e703171023cd2e7 |
| hovercard-subject-tag | pull_request:554280825 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36914/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d06e32e13a046d731e7ad5f2e3f0bf8aaf464d7f99fd04a3d0fa3b00ed00a8f7/nodejs/node/pull/36914 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d06e32e13a046d731e7ad5f2e3f0bf8aaf464d7f99fd04a3d0fa3b00ed00a8f7/nodejs/node/pull/36914 |
| og:image:alt | The async tests, which are modified in this PR, appear to be the async equivalents of these synchronous tests:
node/test/parallel/test-fs-read-type.js
Lines 222 to ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d01c62704ef24df49056c63892a149b775e1353d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36914#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36914 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36914 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36914 |
| Reload | https://github.com/nodejs/node/pull/36914 |
| Reload | https://github.com/nodejs/node/pull/36914 |
| Please reload this page | https://github.com/nodejs/node/pull/36914 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36914 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
981
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:test-make-checks-stricter-in-fs-read-type | https://github.com/tniessen/node/tree/test-make-checks-stricter-in-fs-read-type |
| Conversation | https://github.com/nodejs/node/pull/36914 |
| Commits1 (1) | https://github.com/nodejs/node/pull/36914/commits |
| Checks | https://github.com/nodejs/node/pull/36914/checks |
| Files changed | https://github.com/nodejs/node/pull/36914/files |
| test: check mustCall errors in test-fs-read-type | https://github.com/nodejs/node/pull/36914#top |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:test-make-checks-stricter-in-fs-read-type | https://github.com/tniessen/node/tree/test-make-checks-stricter-in-fs-read-type |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36914#issue-785217724 |
| node/test/parallel/test-fs-read-type.js | https://github.com/nodejs/node/blob/251a0ffd80b6698d1c53c37f7870fab7dd402584/test/parallel/test-fs-read-type.js#L222-L239 |
| 251a0ff | https://github.com/nodejs/node/commit/251a0ffd80b6698d1c53c37f7870fab7dd402584 |
| #36190 | https://github.com/nodejs/node/pull/36190 |
| Please reload this page | https://github.com/nodejs/node/pull/36914 |
|
| https://github.com/tniessen |
| test: check mustCall errors in test-fs-read-type | https://github.com/nodejs/node/pull/36914/commits/55db8509a4df803856186259dbd1e67f1670fc1b |
| 55db850 | https://github.com/nodejs/node/pull/36914/commits/55db8509a4df803856186259dbd1e67f1670fc1b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36914#event-4201895120 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36914#pullrequestreview-567360264 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36914/files/55db8509a4df803856186259dbd1e67f1670fc1b |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36914#pullrequestreview-567372020 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36914/files/55db8509a4df803856186259dbd1e67f1670fc1b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36914#issuecomment-759548444 |
| https://ci.nodejs.org/job/node-test-pull-request/35525/ | https://ci.nodejs.org/job/node-test-pull-request/35525/ |
| Please reload this page | https://github.com/nodejs/node/pull/36914 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36914#event-4201988245 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36914#pullrequestreview-567398284 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36914/files/55db8509a4df803856186259dbd1e67f1670fc1b |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36914#issuecomment-759817148 |
| https://ci.nodejs.org/job/node-test-pull-request/35532/ | https://ci.nodejs.org/job/node-test-pull-request/35532/ |
| Please reload this page | https://github.com/nodejs/node/pull/36914 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36914#event-4203632762 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 14, 2021
| https://github.com/nodejs/node/pull/36914#pullrequestreview-567856798 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36914/files/55db8509a4df803856186259dbd1e67f1670fc1b |
| tniessen | https://github.com/tniessen |
|
Jan 15, 2021
| https://github.com/nodejs/node/pull/36914#ref-commit-d7b1866 |
|
| https://github.com/tniessen |
| test: check mustCall errors in test-fs-read-type | https://github.com/nodejs/node/commit/d7b18662c6a4e88f4d942662903a63a9c6bed46b |
| d7b1866 | https://github.com/nodejs/node/commit/d7b18662c6a4e88f4d942662903a63a9c6bed46b |
| #36914 | https://github.com/nodejs/node/pull/36914 |
| #36190 | https://github.com/nodejs/node/pull/36190 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 15, 2021 | https://github.com/nodejs/node/pull/36914#issuecomment-761068249 |
| d7b1866 | https://github.com/nodejs/node/commit/d7b18662c6a4e88f4d942662903a63a9c6bed46b |
| Please reload this page | https://github.com/nodejs/node/pull/36914 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 15, 2021 | https://github.com/nodejs/node/pull/36914#event-4212132612 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| January 15, 2021 17:13 | https://github.com/nodejs/node/pull/36914#event-4212133180 |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36914#ref-commit-c2ec15a |
|
| https://github.com/tniessen |
|
| https://github.com/ruyadorno |
| test: check mustCall errors in test-fs-read-type | https://github.com/nodejs/node/commit/c2ec15aff6591e8f82a969f5a30716b63a672ac8 |
| c2ec15a | https://github.com/nodejs/node/commit/c2ec15aff6591e8f82a969f5a30716b63a672ac8 |
| #36914 | https://github.com/nodejs/node/pull/36914 |
| #36190 | https://github.com/nodejs/node/pull/36190 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36914#ref-pullrequest-791653749 |
|
v15.7.0 proposal
#37020
| https://github.com/nodejs/node/pull/37020 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jan 23, 2021 | https://github.com/nodejs/node/pull/36914#event-4241641032 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-blocked-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x |
| May 25, 2021 | https://github.com/nodejs/node/pull/36914#event-4793287259 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-blocked-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x |
| Aug 8, 2021 | https://github.com/nodejs/node/pull/36914#event-5126348079 |
| targos | https://github.com/targos |
|
Aug 8, 2021
| https://github.com/nodejs/node/pull/36914#ref-commit-3b25cbe |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| test: check mustCall errors in test-fs-read-type | https://github.com/nodejs/node/commit/3b25cbe1100397d8d650a9f671a30fcae3d764e8 |
| 3b25cbe | https://github.com/nodejs/node/commit/3b25cbe1100397d8d650a9f671a30fcae3d764e8 |
| #36914 | https://github.com/nodejs/node/pull/36914 |
| #36190 | https://github.com/nodejs/node/pull/36190 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 12, 2021
| https://github.com/nodejs/node/pull/36914#ref-commit-e4c9b45 |
|
| https://github.com/tniessen |
|
| https://github.com/BethGriggs |
| test: check mustCall errors in test-fs-read-type | https://github.com/nodejs/node/commit/e4c9b45182afdf68130b9d1c8a885557fca13355 |
| e4c9b45 | https://github.com/nodejs/node/commit/e4c9b45182afdf68130b9d1c8a885557fca13355 |
| #36914 | https://github.com/nodejs/node/pull/36914 |
| #36190 | https://github.com/nodejs/node/pull/36190 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 31, 2021
| https://github.com/nodejs/node/pull/36914#ref-commit-f3be3ec |
|
| https://github.com/tniessen |
|
| https://github.com/MylesBorins |
| test: check mustCall errors in test-fs-read-type | https://github.com/nodejs/node/commit/f3be3ec4179b06ae700e1268c15982427976c869 |
| f3be3ec | https://github.com/nodejs/node/commit/f3be3ec4179b06ae700e1268c15982427976c869 |
| #36914 | https://github.com/nodejs/node/pull/36914 |
| #36190 | https://github.com/nodejs/node/pull/36190 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Sep 4, 2021
| https://github.com/nodejs/node/pull/36914#ref-pullrequest-988299806 |
|
v14.18.0 release proposal
#39990
| https://github.com/nodejs/node/pull/39990 |
| foxxyz | https://github.com/foxxyz |
|
Oct 18, 2021
| https://github.com/nodejs/node/pull/36914#ref-commit-982fd37 |
|
| https://github.com/tniessen |
|
| https://github.com/foxxyz |
| test: check mustCall errors in test-fs-read-type | https://github.com/foxxyz/node/commit/982fd37cdd8a8088f7085980bb20995f1a957922 |
| 982fd37 | https://github.com/foxxyz/node/commit/982fd37cdd8a8088f7085980bb20995f1a957922 |
| nodejs#36914 | https://github.com/nodejs/node/pull/36914 |
| nodejs#36190 | https://github.com/nodejs/node/pull/36190 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36914 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/36914/files/55db8509a4df803856186259dbd1e67f1670fc1b |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/36914/files/55db8509a4df803856186259dbd1e67f1670fc1b |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/36914/files/55db8509a4df803856186259dbd1e67f1670fc1b |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/36914/files/55db8509a4df803856186259dbd1e67f1670fc1b |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/36914 |
|
| https://github.com/tniessen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/aduh95 |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |