| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4234e0ac-8001-39d3-f96c-15f9e00b3808 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8CB8:297F82:1BF063B:2662471:696AB9D9 |
| html-safe-nonce | 509dfe0cfa3589c3d5d2476912be73b275aaf3a5e8a8c369c5a18464fb13c5d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0I4OjI5N0Y4MjoxQkYwNjNCOjI2NjI0NzE6Njk2QUI5RDkiLCJ2aXNpdG9yX2lkIjoiODMwMDY2NTk5NTE3MjQyODI1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a62a685d935b2d33c848c89b2e602116ab2e479f597c1d4820b057de55358524 |
| hovercard-subject-tag | pull_request:553505036 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36890/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e7fc47ccd74f16fd1f994f649c362a1e39edd41b82652182dc9de5b355679c57/nodejs/node/pull/36890 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e7fc47ccd74f16fd1f994f649c362a1e39edd41b82652182dc9de5b355679c57/nodejs/node/pull/36890 |
| og:image:alt | To fix linter error in https://github.com/nodejs/node/pull/36889/checks?check_run_id=1688515238
/cc @danielleadams
PR-URL: #36630
Refs: #32329
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
R... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36890#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36890 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36890 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36890 |
| Reload | https://github.com/nodejs/node/pull/36890 |
| Reload | https://github.com/nodejs/node/pull/36890 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/36890#issue-comment-box |
| aduh95 | https://github.com/aduh95 |
| nodejs:v15.x-staging | https://github.com/nodejs/node/tree/v15.x-staging |
| aduh95:backport-v15-36630 | https://github.com/aduh95/node/tree/backport-v15-36630 |
|
[Backport v15.x] http: remove dead code from internal/http.js
| https://github.com/nodejs/node/pull/36890#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:v15.x-staging | https://github.com/nodejs/node/tree/v15.x-staging |
| aduh95:backport-v15-36630 | https://github.com/aduh95/node/tree/backport-v15-36630 |
|
Conversation
10
| https://github.com/nodejs/node/pull/36890 |
|
Commits
2
| https://github.com/nodejs/node/pull/36890/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/36890/checks |
|
Files changed
| https://github.com/nodejs/node/pull/36890/files |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36890#issue-784289956 |
| https://github.com/nodejs/node/pull/36889/checks?check_run_id=1688515238 | https://github.com/nodejs/node/pull/36889/checks?check_run_id=1688515238 |
| @danielleadams | https://github.com/danielleadams |
| #36630 | https://github.com/nodejs/node/pull/36630 |
| #32329 | https://github.com/nodejs/node/pull/32329 |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
v15.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av15.x |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36890#event-4196188513 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36890#ref-pullrequest-784259248 |
|
v15.6.0 proposal
#36889
| https://github.com/nodejs/node/pull/36889 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36890#pullrequestreview-566361322 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36890/files |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36890 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36890#issuecomment-758797735 |
| https://ci.nodejs.org/job/node-test-pull-request/35474/ | https://ci.nodejs.org/job/node-test-pull-request/35474/ |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36890#issuecomment-758874305 |
| #36779 (comment) | https://github.com/nodejs/node/pull/36779#issuecomment-758565326 |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36890#issuecomment-759085705 |
| #36900 | https://github.com/nodejs/node/pull/36900 |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36890#issuecomment-759095087 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36890#issuecomment-759175155 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| Lxxyx | https://github.com/Lxxyx |
| January 13, 2021 10:03 | https://github.com/nodejs/node/pull/36890#commits-pushed-cb91995 |
|
| https://github.com/Lxxyx |
|
| https://github.com/aduh95 |
| Revert "http: remove dead code from internal/http.js" | https://github.com/nodejs/node/pull/36890/commits/cb91995a204b2775252325d9c5f5ed0c28e5c6fd |
| cb91995 | https://github.com/nodejs/node/pull/36890/commits/cb91995a204b2775252325d9c5f5ed0c28e5c6fd |
| 9156f43 | https://github.com/aduh95/node/commit/9156f430b5889623b5a8ebef9059ec7212a31b8a |
|
| https://github.com/Lxxyx |
|
| https://github.com/aduh95 |
| http: remove dead code from internal/http.js | https://github.com/nodejs/node/pull/36890/commits/bae71f095530d6d2dd81a3906d7985c47c1e36ea |
| bae71f0 | https://github.com/nodejs/node/pull/36890/commits/bae71f095530d6d2dd81a3906d7985c47c1e36ea |
| nodejs#36630 | https://github.com/nodejs/node/pull/36630 |
| nodejs#32329 | https://github.com/nodejs/node/pull/32329 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/57782b0dc70f3571915de96e34d04cfd68a0b775..bae71f095530d6d2dd81a3906d7985c47c1e36ea |
| 57782b0 | https://github.com/nodejs/node/commit/57782b0dc70f3571915de96e34d04cfd68a0b775 |
| bae71f0 | https://github.com/nodejs/node/commit/bae71f095530d6d2dd81a3906d7985c47c1e36ea |
|
Compare
| https://github.com/nodejs/node/compare/57782b0dc70f3571915de96e34d04cfd68a0b775..bae71f095530d6d2dd81a3906d7985c47c1e36ea |
| January 13, 2021 09:04 | https://github.com/nodejs/node/pull/36890#event-4200124729 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36890#issuecomment-759309940 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36890#issuecomment-759310662 |
| https://ci.nodejs.org/job/node-test-pull-request/35491/ | https://ci.nodejs.org/job/node-test-pull-request/35491/ |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36890#issuecomment-759495393 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36890#pullrequestreview-567293213 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36890/files/bae71f095530d6d2dd81a3906d7985c47c1e36ea |
| danielleadams | https://github.com/danielleadams |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36890#ref-commit-7e3ad1b |
|
| https://github.com/Lxxyx |
|
| https://github.com/danielleadams |
| Revert "http: remove dead code from internal/http.js" | https://github.com/nodejs/node/commit/7e3ad1be32bf1d6c41fb2723eb0522b6addcecf4 |
| 7e3ad1b | https://github.com/nodejs/node/commit/7e3ad1be32bf1d6c41fb2723eb0522b6addcecf4 |
| 9156f43 | https://github.com/nodejs/node/commit/9156f430b5889623b5a8ebef9059ec7212a31b8a |
| #36890 | https://github.com/nodejs/node/pull/36890 |
| #32329 | https://github.com/nodejs/node/pull/32329 |
| danielleadams | https://github.com/danielleadams |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36890#ref-commit-d858c95 |
|
| https://github.com/Lxxyx |
|
| https://github.com/danielleadams |
| http: remove dead code from internal/http.js | https://github.com/nodejs/node/commit/d858c9576af50b4573b7faa6577a9f2c63fd6b86 |
| d858c95 | https://github.com/nodejs/node/commit/d858c9576af50b4573b7faa6577a9f2c63fd6b86 |
| #36630 | https://github.com/nodejs/node/pull/36630 |
| #36890 | https://github.com/nodejs/node/pull/36890 |
| #32329 | https://github.com/nodejs/node/pull/32329 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36890#issuecomment-759515150 |
| d858c95 | https://github.com/nodejs/node/commit/d858c9576af50b4573b7faa6577a9f2c63fd6b86 |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36890#event-4201779315 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| January 13, 2021 15:23 | https://github.com/nodejs/node/pull/36890#event-4201779614 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36890 |
|
| https://github.com/danielleadams |
|
danielleadams
| https://github.com/danielleadams |
|
| https://github.com/nodejs/node/pull/36890/files/bae71f095530d6d2dd81a3906d7985c47c1e36ea |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Please reload this page | https://github.com/nodejs/node/pull/36890 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
|
| https://github.com/Lxxyx |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |