| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:43bb1522-54bf-f125-7d82-9e15b4622ff7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDCA:1A8C4D:69813A:8E0DF8:6A51F090 |
| html-safe-nonce | 9d1ab54e95a07c153a6cd4a39120f0829c72d2b7c90f6e1124d91f28291aedd2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRENBOjFBOEM0RDo2OTgxM0E6OEUwREY4OjZBNTFGMDkwIiwidmlzaXRvcl9pZCI6IjE2NjQ1Mjk2MjU3ODc4ODQ5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0bcf974145f8ad332a04e5d0659e6c226dd1617ef35189a1dcaa7fbab6aa436f |
| hovercard-subject-tag | pull_request:553149030 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36884/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fbcf6cac88629adc7f5c33430587d4e3e9b50a9685eb37688bf17f2854b0ca17/nodejs/node/pull/36884 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fbcf6cac88629adc7f5c33430587d4e3e9b50a9685eb37688bf17f2854b0ca17/nodejs/node/pull/36884 |
| og:image:alt | This reverts commit a45a404.
Solved by marking ports <1024 as privileged on Docker containers.
Ref: #36850
Ref: #36847
Ref: nodejs/build#2521
/cc @nodejs/build |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rvagg |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36884#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36884 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36884 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36884 |
| Reload | https://github.com/nodejs/node/pull/36884 |
| Reload | https://github.com/nodejs/node/pull/36884 |
| Please reload this page | https://github.com/nodejs/node/pull/36884 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36884 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
985
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| rvagg | https://github.com/rvagg |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rvagg:rvagg/revert-flaky-arm | https://github.com/rvagg/io.js/tree/rvagg/revert-flaky-arm |
| Conversation | https://github.com/nodejs/node/pull/36884 |
| Commits1 (1) | https://github.com/nodejs/node/pull/36884/commits |
| Checks | https://github.com/nodejs/node/pull/36884/checks |
| Files changed | https://github.com/nodejs/node/pull/36884/files |
| Revert "test: mark test-cluster-bind-privileged-port flaky on arm" | https://github.com/nodejs/node/pull/36884#top |
| rvagg | https://github.com/rvagg |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rvagg:rvagg/revert-flaky-arm | https://github.com/rvagg/io.js/tree/rvagg/revert-flaky-arm |
|
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36884#issue-783861569 |
| a45a404 | https://github.com/nodejs/node/commit/a45a40419719ff443b80ea32175486c4f78fd628 |
| #36850 | https://github.com/nodejs/node/pull/36850 |
| #36847 | https://github.com/nodejs/node/issues/36847 |
| nodejs/build#2521 | https://github.com/nodejs/build/pull/2521 |
| Please reload this page | https://github.com/nodejs/node/pull/36884 |
|
| https://github.com/rvagg |
| Revert "test: mark test-cluster-bind-privileged-port flaky on arm" | https://github.com/nodejs/node/pull/36884/commits/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| 2fdca7b | https://github.com/nodejs/node/pull/36884/commits/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| a45a404 | https://github.com/rvagg/io.js/commit/a45a40419719ff443b80ea32175486c4f78fd628 |
| nodejs#36850 | https://github.com/nodejs/node/pull/36850 |
| nodejs#36847 | https://github.com/nodejs/node/issues/36847 |
| nodejs/build#2521 | https://github.com/nodejs/build/pull/2521 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| jasnell | https://github.com/jasnell |
| January 12, 2021 02:47 | https://github.com/nodejs/node/pull/36884#event-4193728457 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36884#event-4193728622 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36884#ref-pullrequest-782472435 |
|
ansible,docker: ensure <1024 are privileged ports
nodejs/build#2521
| https://github.com/nodejs/build/pull/2521 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36884#pullrequestreview-565900194 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36884#pullrequestreview-565910184 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36884#pullrequestreview-565923430 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36884#event-4194649446 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36884#event-4194735523 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 12, 2021 | https://github.com/nodejs/node/pull/36884#issuecomment-758510091 |
| https://ci.nodejs.org/job/node-test-pull-request/35465/ | https://ci.nodejs.org/job/node-test-pull-request/35465/ |
| Please reload this page | https://github.com/nodejs/node/pull/36884 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36884#pullrequestreview-566150511 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| https://github.com/AshCripps |
| AshCripps | https://github.com/AshCripps |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36884#pullrequestreview-566166106 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36884#pullrequestreview-566674501 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36884#pullrequestreview-566691691 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36884#pullrequestreview-567212513 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/36884#pullrequestreview-567212513 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36884 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36884#pullrequestreview-567523639 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/36884#pullrequestreview-567523639 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36884 |
| aduh95 | https://github.com/aduh95 |
|
Jan 18, 2021
| https://github.com/nodejs/node/pull/36884#ref-commit-5716130 |
|
| https://github.com/rvagg |
|
| https://github.com/aduh95 |
| Revert "test: mark test-cluster-bind-privileged-port flaky on arm" | https://github.com/nodejs/node/commit/5716130d1edcecb7ff1faf2669f33b29a89c4a6b |
| 5716130 | https://github.com/nodejs/node/commit/5716130d1edcecb7ff1faf2669f33b29a89c4a6b |
| a45a404 | https://github.com/nodejs/node/commit/a45a40419719ff443b80ea32175486c4f78fd628 |
| #36850 | https://github.com/nodejs/node/pull/36850 |
| #36847 | https://github.com/nodejs/node/issues/36847 |
| nodejs/build#2521 | https://github.com/nodejs/build/pull/2521 |
| #36884 | https://github.com/nodejs/node/pull/36884 |
| #36850 | https://github.com/nodejs/node/pull/36850 |
| #36847 | https://github.com/nodejs/node/issues/36847 |
| nodejs/build#2521 | https://github.com/nodejs/build/pull/2521 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36884#issuecomment-762162553 |
| 5716130 | https://github.com/nodejs/node/commit/5716130d1edcecb7ff1faf2669f33b29a89c4a6b |
| Please reload this page | https://github.com/nodejs/node/pull/36884 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36884#event-4217493864 |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36884#ref-commit-8a82415 |
|
| https://github.com/rvagg |
|
| https://github.com/ruyadorno |
| Revert "test: mark test-cluster-bind-privileged-port flaky on arm" | https://github.com/nodejs/node/commit/8a8241529e48c7d333721c428bfb2a1d27c3aed6 |
| 8a82415 | https://github.com/nodejs/node/commit/8a8241529e48c7d333721c428bfb2a1d27c3aed6 |
| a45a404 | https://github.com/nodejs/node/commit/a45a40419719ff443b80ea32175486c4f78fd628 |
| #36850 | https://github.com/nodejs/node/pull/36850 |
| #36847 | https://github.com/nodejs/node/issues/36847 |
| nodejs/build#2521 | https://github.com/nodejs/build/pull/2521 |
| #36884 | https://github.com/nodejs/node/pull/36884 |
| #36850 | https://github.com/nodejs/node/pull/36850 |
| #36847 | https://github.com/nodejs/node/issues/36847 |
| nodejs/build#2521 | https://github.com/nodejs/build/pull/2521 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36884#ref-pullrequest-791653749 |
|
v15.7.0 proposal
#37020
| https://github.com/nodejs/node/pull/37020 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x |
| May 25, 2021 | https://github.com/nodejs/node/pull/36884#event-4793315960 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36884 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
|
| https://github.com/watilde |
|
watilde
| https://github.com/watilde |
|
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
|
| https://github.com/AshCripps |
|
AshCripps
| https://github.com/AshCripps |
|
| https://github.com/nodejs/node/pull/36884/files/2fdca7b4ad5739d535a8ad669ab2a95560365e3e |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/36884 |
|
| https://github.com/rvagg |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/aduh95 |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/watilde |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/mhdawson |
|
| https://github.com/AshCripps |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |