| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:41d03265-c159-bb0c-276c-f61ad94b8cdc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF32:3E37F3:1458949:1AD596C:6A51B4EC |
| html-safe-nonce | 24446c307be59e109b62e4f3d9a8f181dc5adba54b4a0109f60bb65fb6222e05 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjMyOjNFMzdGMzoxNDU4OTQ5OjFBRDU5NkM6NkE1MUI0RUMiLCJ2aXNpdG9yX2lkIjoiNDQ1MTc2MjQ1MzM4MzA2Njg2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d4ff8ec02c2516ceecabea4693b06b9da24ec1e70dd81b4c443e3f6f5ba1b7fb |
| hovercard-subject-tag | pull_request:552991882 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36880/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/38f2fbf8705122a6097280e70523e62d73cc297476378bea8cd18f4205ab2121/nodejs/node/pull/36880 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/38f2fbf8705122a6097280e70523e62d73cc297476378bea8cd18f4205ab2121/nodejs/node/pull/36880 |
| og:image:alt | Issue #25741 discusses a number of
performance considerations for fs.readFile, which was changed in Node.js
10.x to split discreet chunk reads over multiple event loop turns. While
the fs.readFile(... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36880#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36880 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36880 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36880 |
| Reload | https://github.com/nodejs/node/pull/36880 |
| Reload | https://github.com/nodejs/node/pull/36880 |
| Please reload this page | https://github.com/nodejs/node/pull/36880 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36880 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
983
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:doc-fs-readfile-perf | https://github.com/jasnell/node/tree/doc-fs-readfile-perf |
| Conversation | https://github.com/nodejs/node/pull/36880 |
| Commits1 (1) | https://github.com/nodejs/node/pull/36880/commits |
| Checks | https://github.com/nodejs/node/pull/36880/checks |
| Files changed | https://github.com/nodejs/node/pull/36880/files |
| doc: add performance notes for fs.readFile | https://github.com/nodejs/node/pull/36880#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:doc-fs-readfile-perf | https://github.com/jasnell/node/tree/doc-fs-readfile-perf |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36880#issue-783670939 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| Please reload this page | https://github.com/nodejs/node/pull/36880 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36880#event-4192605627 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36880#pullrequestreview-565914560 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36880/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/36880/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/36880 |
|
| https://github.com/jasnell |
| doc: add performance notes for fs.readFile | https://github.com/nodejs/node/pull/36880/commits/92d731dec9b5298978f96b9806fcf8414fa72a59 |
| 92d731d | https://github.com/nodejs/node/pull/36880/commits/92d731dec9b5298978f96b9806fcf8414fa72a59 |
| nodejs#25741 | https://github.com/nodejs/node/issues/25741 |
| nodejs#25741 | https://github.com/nodejs/node/issues/25741 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/9bb9abb83fd8eaac71199579200feb31c36d77ce..92d731dec9b5298978f96b9806fcf8414fa72a59 |
| 9bb9abb | https://github.com/nodejs/node/commit/9bb9abb83fd8eaac71199579200feb31c36d77ce |
| 92d731d | https://github.com/nodejs/node/commit/92d731dec9b5298978f96b9806fcf8414fa72a59 |
|
Compare
| https://github.com/nodejs/node/compare/9bb9abb83fd8eaac71199579200feb31c36d77ce..92d731dec9b5298978f96b9806fcf8414fa72a59 |
| January 15, 2021 16:31 | https://github.com/nodejs/node/pull/36880#event-4211957022 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
| Jan 15, 2021 | https://github.com/nodejs/node/pull/36880#event-4212682071 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 18, 2021
| https://github.com/nodejs/node/pull/36880#pullrequestreview-570710257 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36880/files/92d731dec9b5298978f96b9806fcf8414fa72a59 |
| aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/36880#pullrequestreview-570710257 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36880 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36880#issuecomment-762468744 |
| 408e9d3 | https://github.com/nodejs/node/commit/408e9d3a3a26834a83cc3e77269ccbd3047a8903 |
| Please reload this page | https://github.com/nodejs/node/pull/36880 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36880#event-4219818057 |
| jasnell | https://github.com/jasnell |
|
Jan 18, 2021
| https://github.com/nodejs/node/pull/36880#ref-commit-408e9d3 |
|
| https://github.com/jasnell |
| doc: add performance notes for fs.readFile | https://github.com/nodejs/node/commit/408e9d3a3a26834a83cc3e77269ccbd3047a8903 |
| 408e9d3 | https://github.com/nodejs/node/commit/408e9d3a3a26834a83cc3e77269ccbd3047a8903 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| #36880 | https://github.com/nodejs/node/pull/36880 |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36880#ref-commit-7083d99 |
|
| https://github.com/jasnell |
|
| https://github.com/ruyadorno |
| doc: add performance notes for fs.readFile | https://github.com/nodejs/node/commit/7083d99803c928beffdd6d0e8097d1e390051ed7 |
| 7083d99 | https://github.com/nodejs/node/commit/7083d99803c928beffdd6d0e8097d1e390051ed7 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| #36880 | https://github.com/nodejs/node/pull/36880 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36880#ref-pullrequest-791653749 |
|
v15.7.0 proposal
#37020
| https://github.com/nodejs/node/pull/37020 |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 25, 2021
| https://github.com/nodejs/node/pull/36880#ref-commit-93fc295 |
|
| https://github.com/jasnell |
|
| https://github.com/ruyadorno |
| doc: add performance notes for fs.readFile | https://github.com/nodejs/node/commit/93fc295b759c21a60f39b74a075f7a03445a3ea2 |
| 93fc295 | https://github.com/nodejs/node/commit/93fc295b759c21a60f39b74a075f7a03445a3ea2 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| #36880 | https://github.com/nodejs/node/pull/36880 |
| targos | https://github.com/targos |
|
May 1, 2021
| https://github.com/nodejs/node/pull/36880#ref-commit-b25b694 |
|
| https://github.com/jasnell |
|
| https://github.com/targos |
| doc: add performance notes for fs.readFile | https://github.com/nodejs/node/commit/b25b69418a21656d4605df67d91ae1c7521a08c0 |
| b25b694 | https://github.com/nodejs/node/commit/b25b69418a21656d4605df67d91ae1c7521a08c0 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| #25741 | https://github.com/nodejs/node/issues/25741 |
| #36880 | https://github.com/nodejs/node/pull/36880 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
May 3, 2021
| https://github.com/nodejs/node/pull/36880#ref-pullrequest-874193529 |
|
v14.17.0 proposal
#38507
| https://github.com/nodejs/node/pull/38507 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36880 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/36880/files/9bb9abb83fd8eaac71199579200feb31c36d77ce |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/36880/files/92d731dec9b5298978f96b9806fcf8414fa72a59 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
|
fs.readFile is slower in v10
| https://github.com/nodejs/node/issues/25741 |
| Please reload this page | https://github.com/nodejs/node/pull/36880 |
|
| https://github.com/jasnell |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |