| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6be4ba33-8732-cf99-2299-16ee1e748f33 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C564:3CE760:468EC:5BC9D:6A525399 |
| html-safe-nonce | 04bd5a2a5007f03c8965c96c9a6da7458ae1fa3383bcbd80b3eac423c8c33960 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTY0OjNDRTc2MDo0NjhFQzo1QkM5RDo2QTUyNTM5OSIsInZpc2l0b3JfaWQiOiI4MTA1OTk1NTY3NDA5Mjg4MDg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2ab7ad4ae6d68f8e1cbe7fd42c0a7b790e0d086d6fc758023261f6d7f312a7bc |
| hovercard-subject-tag | pull_request:552773813 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36877/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/04bbad492ca3d0d73f4b4d88c5a82e769cf0c28621e34bf70f36a5fe36468d5b/nodejs/node/pull/36877 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/04bbad492ca3d0d73f4b4d88c5a82e769cf0c28621e34bf70f36a5fe36468d5b/nodejs/node/pull/36877 |
| og:image:alt | This patch changes GetRsaKeyDetail to work in older supported versions of OpenSSL. The added test case fails CI without this patch.
I assume the WebCrypto implementation also does not handle import... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36877#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36877 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36877 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36877 |
| Reload | https://github.com/nodejs/node/pull/36877 |
| Reload | https://github.com/nodejs/node/pull/36877 |
| Please reload this page | https://github.com/nodejs/node/pull/36877 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36877 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
984
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:webcrypto-pss-fips | https://github.com/tniessen/node/tree/webcrypto-pss-fips |
| Conversation | https://github.com/nodejs/node/pull/36877 |
| Commits1 (1) | https://github.com/nodejs/node/pull/36877/commits |
| Checks | https://github.com/nodejs/node/pull/36877/checks |
| Files changed | https://github.com/nodejs/node/pull/36877/files |
| crypto: fix WebCrypto import of RSA-PSS keys | https://github.com/nodejs/node/pull/36877#top |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:webcrypto-pss-fips | https://github.com/tniessen/node/tree/webcrypto-pss-fips |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36877#issue-783409765 |
| openssl/openssl#10217 | https://github.com/openssl/openssl/pull/10217 |
| #36188 | https://github.com/nodejs/node/pull/36188 |
| Please reload this page | https://github.com/nodejs/node/pull/36877 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36877#event-4191016327 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| jasnell | https://github.com/jasnell |
| January 11, 2021 14:20 | https://github.com/nodejs/node/pull/36877#event-4191016341 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36877#event-4191016631 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Jan 11, 2021
| https://github.com/nodejs/node/pull/36877#ref-pullrequest-747440055 |
|
crypto: add keyObject.asymmetricKeyDetails for asymmetric keys
#36188
| https://github.com/nodejs/node/pull/36188 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36877#event-4191021527 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 11, 2021
| https://github.com/nodejs/node/pull/36877#pullrequestreview-565397147 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36877/files |
| https://github.com/panva |
| panva | https://github.com/panva |
|
Jan 11, 2021
| https://github.com/nodejs/node/pull/36877#pullrequestreview-565397362 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36877/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Jan 11, 2021
| https://github.com/nodejs/node/pull/36877#pullrequestreview-565397873 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36877/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Jan 11, 2021
| https://github.com/nodejs/node/pull/36877#pullrequestreview-565398549 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36877/files |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/36877#pullrequestreview-565398549 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36877 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36877#event-4191041557 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| force-pushed | https://github.com/nodejs/node/compare/a5e3daf6201f5c148c5f8d3b2b0117d265eaf5b0..d39102e48b68a6217f4fae7d20557de15c73d3b6 |
| a5e3daf | https://github.com/nodejs/node/commit/a5e3daf6201f5c148c5f8d3b2b0117d265eaf5b0 |
| d39102e | https://github.com/nodejs/node/commit/d39102e48b68a6217f4fae7d20557de15c73d3b6 |
|
Compare
| https://github.com/nodejs/node/compare/a5e3daf6201f5c148c5f8d3b2b0117d265eaf5b0..d39102e48b68a6217f4fae7d20557de15c73d3b6 |
| January 11, 2021 14:25 | https://github.com/nodejs/node/pull/36877#event-4191045143 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36877#event-4191047802 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36877#event-4191168751 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36877 |
|
| https://github.com/tniessen |
| crypto: fix WebCrypto import of RSA-PSS keys | https://github.com/nodejs/node/pull/36877/commits/1a74096bea39f2ed39d3d921db1032add526b03a |
| 1a74096 | https://github.com/nodejs/node/pull/36877/commits/1a74096bea39f2ed39d3d921db1032add526b03a |
| openssl/openssl#10217 | https://github.com/openssl/openssl/pull/10217 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| force-pushed | https://github.com/nodejs/node/compare/d39102e48b68a6217f4fae7d20557de15c73d3b6..1a74096bea39f2ed39d3d921db1032add526b03a |
| d39102e | https://github.com/nodejs/node/commit/d39102e48b68a6217f4fae7d20557de15c73d3b6 |
| 1a74096 | https://github.com/nodejs/node/commit/1a74096bea39f2ed39d3d921db1032add526b03a |
|
Compare
| https://github.com/nodejs/node/compare/d39102e48b68a6217f4fae7d20557de15c73d3b6..1a74096bea39f2ed39d3d921db1032add526b03a |
| January 11, 2021 18:08 | https://github.com/nodejs/node/pull/36877#event-4192121631 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36877 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36877#issuecomment-758188688 |
| https://ci.nodejs.org/job/node-test-pull-request/35451/ | https://ci.nodejs.org/job/node-test-pull-request/35451/ |
| Please reload this page | https://github.com/nodejs/node/pull/36877 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36877#event-4193242160 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36877#pullrequestreview-567278371 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36877/files/1a74096bea39f2ed39d3d921db1032add526b03a |
| panva | https://github.com/panva |
|
Jan 13, 2021
| https://github.com/nodejs/node/pull/36877#ref-commit-6a7eb32 |
|
| https://github.com/tniessen |
|
| https://github.com/panva |
| crypto: fix WebCrypto import of RSA-PSS keys | https://github.com/nodejs/node/commit/6a7eb32c5bcd92f490a57f2cd12d52e1db881d17 |
| 6a7eb32 | https://github.com/nodejs/node/commit/6a7eb32c5bcd92f490a57f2cd12d52e1db881d17 |
| openssl/openssl#10217 | https://github.com/openssl/openssl/pull/10217 |
| #36877 | https://github.com/nodejs/node/pull/36877 |
| #36188 | https://github.com/nodejs/node/pull/36188 |
| https://github.com/panva |
| panva | https://github.com/panva |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36877#issuecomment-759488227 |
| 6a7eb32 | https://github.com/nodejs/node/commit/6a7eb32c5bcd92f490a57f2cd12d52e1db881d17 |
| Please reload this page | https://github.com/nodejs/node/pull/36877 |
| https://github.com/panva |
| panva | https://github.com/panva |
| Jan 13, 2021 | https://github.com/nodejs/node/pull/36877#event-4201528752 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jan 14, 2021 | https://github.com/nodejs/node/pull/36877#event-4205673971 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| January 15, 2021 17:14 | https://github.com/nodejs/node/pull/36877#event-4212136609 |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36877#ref-commit-0398167 |
|
| https://github.com/tniessen |
|
| https://github.com/ruyadorno |
| crypto: fix WebCrypto import of RSA-PSS keys | https://github.com/nodejs/node/commit/0398167b35d603e36e1511cd214a548e976f1ff7 |
| 0398167 | https://github.com/nodejs/node/commit/0398167b35d603e36e1511cd214a548e976f1ff7 |
| openssl/openssl#10217 | https://github.com/openssl/openssl/pull/10217 |
| #36877 | https://github.com/nodejs/node/pull/36877 |
| #36188 | https://github.com/nodejs/node/pull/36188 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36877#ref-pullrequest-791653749 |
|
v15.7.0 proposal
#37020
| https://github.com/nodejs/node/pull/37020 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
dont-land-on-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x |
| May 25, 2021 | https://github.com/nodejs/node/pull/36877#event-4793272594 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36877 |
|
| https://github.com/panva |
|
panva
| https://github.com/panva |
|
| https://github.com/nodejs/node/pull/36877/files/1a74096bea39f2ed39d3d921db1032add526b03a |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/36877/files/a5e3daf6201f5c148c5f8d3b2b0117d265eaf5b0 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/36877/files/a5e3daf6201f5c148c5f8d3b2b0117d265eaf5b0 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/36877/files/a5e3daf6201f5c148c5f8d3b2b0117d265eaf5b0 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Please reload this page | https://github.com/nodejs/node/pull/36877 |
|
| https://github.com/tniessen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/panva |
|
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |