René's URL Explorer Experiment


Title: Revert "http2: refactor to use primordials instead of .indexOf" by Trott · Pull Request #36873 · nodejs/node · GitHub

Open Graph Title: Revert "http2: refactor to use primordials instead of .indexOf" by Trott · Pull Request #36873 · nodejs/node

X Title: Revert "http2: refactor to use primordials instead of .indexOf" by Trott · Pull Request #36873 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commit 3af175f. Opening this as a draft PR so I can easily run benchmarks.

X Description: This reverts commit 3af175f. Opening this as a draft PR so I can easily run benchmarks.

Opengraph URL: https://github.com/nodejs/node/pull/36873

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dbb53439-6b19-326f-9b1c-15769440c646
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9B6:176010:2A4C656:3998DA3:6A53BDBF
html-safe-nonce367d273b0b0c42f4ae36e123c9d18a6d82672e583ed48a23da047055067a4bc4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUI2OjE3NjAxMDoyQTRDNjU2OjM5OThEQTM6NkE1M0JEQkYiLCJ2aXNpdG9yX2lkIjoiNjExNzk4ODk0NTk1MjU5ODM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac84c7062c6a56251302821998b119397d1942556064a6e49916848b99f46204ee
hovercard-subject-tagpull_request:552474419
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36873/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3b9aaef296e9913babab73d8281a1f1c19ff2c07b5bf74ac98cddf76ab0f0e21/nodejs/node/pull/36873
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3b9aaef296e9913babab73d8281a1f1c19ff2c07b5bf74ac98cddf76ab0f0e21/nodejs/node/pull/36873
og:image:altThis reverts commit 3af175f. Opening this as a draft PR so I can easily run benchmarks.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36873#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36873
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36873
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36873
Reloadhttps://github.com/nodejs/node/pull/36873
Reloadhttps://github.com/nodejs/node/pull/36873
Please reload this pagehttps://github.com/nodejs/node/pull/36873
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36873
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 996 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:revert-ithttps://github.com/Trott/io.js/tree/revert-it
Conversationhttps://github.com/nodejs/node/pull/36873
Commits1 (1)https://github.com/nodejs/node/pull/36873/commits
Checkshttps://github.com/nodejs/node/pull/36873/checks
Files changedhttps://github.com/nodejs/node/pull/36873/files
Revert "http2: refactor to use primordials instead of .indexOf"https://github.com/nodejs/node/pull/36873#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:revert-ithttps://github.com/Trott/io.js/tree/revert-it
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 11, 2021https://github.com/nodejs/node/pull/36873#issue-783055061
3af175fhttps://github.com/nodejs/node/commit/3af175fb5e6cfdb1de57dc19fc3827c804333545
Please reload this pagehttps://github.com/nodejs/node/pull/36873
https://github.com/Trott
Revert "http2: refactor to use primordials instead of .indexOf"https://github.com/nodejs/node/pull/36873/commits/c10942b65f023cb19b8d2238fd6b9574482d42c3
c10942bhttps://github.com/nodejs/node/pull/36873/commits/c10942b65f023cb19b8d2238fd6b9574482d42c3
3af175fhttps://github.com/Trott/io.js/commit/3af175fb5e6cfdb1de57dc19fc3827c804333545
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Jan 11, 2021https://github.com/nodejs/node/pull/36873#event-4188896610
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 11, 2021https://github.com/nodejs/node/pull/36873#issuecomment-757618099
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/886/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/886/
Please reload this pagehttps://github.com/nodejs/node/pull/36873
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 11, 2021https://github.com/nodejs/node/pull/36873#issuecomment-757760792
Please reload this pagehttps://github.com/nodejs/node/pull/36873
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 11, 2021https://github.com/nodejs/node/pull/36873#event-4189916673
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 11, 2021 https://github.com/nodejs/node/pull/36873#ref-pullrequest-776041214
lib: string indexOf to use primordials for http2/compat.js #36679 https://github.com/nodejs/node/pull/36679
https://github.com/Trott
Trotthttps://github.com/Trott
September 25, 2022 17:07https://github.com/nodejs/node/pull/36873#event-7453738110
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36873
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/36873
https://github.com/Trott
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.