René's URL Explorer Experiment


Title: http: abortIncoming only on socket close by ronag · Pull Request #36821 · nodejs/node · GitHub

Open Graph Title: http: abortIncoming only on socket close by ronag · Pull Request #36821 · nodejs/node

X Title: http: abortIncoming only on socket close by ronag · Pull Request #36821 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Don't call abortIncoming twice for same socket, i.e. both during 'end' and 'close'. Also does some minor cleanup.

X Description: Don't call abortIncoming twice for same socket, i.e. both during 'end' and 'close'. Also does some minor cleanup.

Opengraph URL: https://github.com/nodejs/node/pull/36821

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0f8a4892-a526-2d09-02a0-e1dc56f8bf20
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82A4:C09C4:3CE118:51394B:6A517E47
html-safe-nonce4ff7dc92419c18ccc6ec7ae11cd123ae83f3cae56958efeeec83ea24e6088599
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkE0OkMwOUM0OjNDRTExODo1MTM5NEI6NkE1MTdFNDciLCJ2aXNpdG9yX2lkIjoiMTIxOTI4MzI0Nzk0NDUzMTUyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace4eec9da391f8bc02a3a2934a30a7475cc9eb717ff5ec37159f4df962070b3d8
hovercard-subject-tagpull_request:550665982
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36821/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/59ccb419eae000d92d632e54bcc6edf302bec976e54f98ed6a07e6a6a97401a6/nodejs/node/pull/36821
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/59ccb419eae000d92d632e54bcc6edf302bec976e54f98ed6a07e6a6a97401a6/nodejs/node/pull/36821
og:image:altDon't call abortIncoming twice for same socket, i.e. both during 'end' and 'close'. Also does some minor cleanup.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released01c62704ef24df49056c63892a149b775e1353d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36821#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36821
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36821
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36821
Reloadhttps://github.com/nodejs/node/pull/36821
Reloadhttps://github.com/nodejs/node/pull/36821
Please reload this pagehttps://github.com/nodejs/node/pull/36821
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36821
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 981 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-aborthttps://github.com/nxtedition/node/tree/http-abort
Conversationhttps://github.com/nodejs/node/pull/36821
Commits1 (1)https://github.com/nodejs/node/pull/36821/commits
Checkshttps://github.com/nodejs/node/pull/36821/checks
Files changedhttps://github.com/nodejs/node/pull/36821/files
http: abortIncoming only on socket closehttps://github.com/nodejs/node/pull/36821#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:http-aborthttps://github.com/nxtedition/node/tree/http-abort
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 6, 2021https://github.com/nodejs/node/pull/36821#issue-780838685
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/ronag
ronaghttps://github.com/ronag
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Jan 6, 2021https://github.com/nodejs/node/pull/36821#event-4176975156
https://github.com/ronag
ronaghttps://github.com/ronag
BridgeARhttps://github.com/BridgeAR
January 6, 2021 20:50https://github.com/nodejs/node/pull/36821#event-4176975161
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/5f9df3bbd99bf524765ca77a14fcfcb01f4cb6bb..55c02b6a6c4beed1bbcf3e793cd6896e06c1382b
5f9df3bhttps://github.com/nodejs/node/commit/5f9df3bbd99bf524765ca77a14fcfcb01f4cb6bb
55c02b6https://github.com/nodejs/node/commit/55c02b6a6c4beed1bbcf3e793cd6896e06c1382b
Compare https://github.com/nodejs/node/compare/5f9df3bbd99bf524765ca77a14fcfcb01f4cb6bb..55c02b6a6c4beed1bbcf3e793cd6896e06c1382b
January 6, 2021 20:51https://github.com/nodejs/node/pull/36821#event-4176977821
https://github.com/ronag
http: abortIncoming only on socket closehttps://github.com/nodejs/node/pull/36821/commits/43fc062f278c22f4284b55dbf842525bf464d5de
43fc062https://github.com/nodejs/node/pull/36821/commits/43fc062f278c22f4284b55dbf842525bf464d5de
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/55c02b6a6c4beed1bbcf3e793cd6896e06c1382b..43fc062f278c22f4284b55dbf842525bf464d5de
55c02b6https://github.com/nodejs/node/commit/55c02b6a6c4beed1bbcf3e793cd6896e06c1382b
43fc062https://github.com/nodejs/node/commit/43fc062f278c22f4284b55dbf842525bf464d5de
Compare https://github.com/nodejs/node/compare/55c02b6a6c4beed1bbcf3e793cd6896e06c1382b..43fc062f278c22f4284b55dbf842525bf464d5de
January 6, 2021 20:53https://github.com/nodejs/node/pull/36821#event-4176982813
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 9, 2021https://github.com/nodejs/node/pull/36821#issuecomment-757335976
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/dnlup
dnluphttps://github.com/dnlup
Jan 10, 2021 https://github.com/nodejs/node/pull/36821#pullrequestreview-564837928
View reviewed changes https://github.com/nodejs/node/pull/36821/files/43fc062f278c22f4284b55dbf842525bf464d5de
lib/_http_server.jshttps://github.com/nodejs/node/pull/36821/files/43fc062f278c22f4284b55dbf842525bf464d5de#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/dnlup
dnluphttps://github.com/dnlup
Jan 10, 2021 https://github.com/nodejs/node/pull/36821#pullrequestreview-564837993
View reviewed changes https://github.com/nodejs/node/pull/36821/files/43fc062f278c22f4284b55dbf842525bf464d5de
dnluphttps://github.com/dnlup
https://github.com/nodejs/node/pull/36821#pullrequestreview-564837993
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 10, 2021https://github.com/nodejs/node/pull/36821#event-4187835722
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 10, 2021https://github.com/nodejs/node/pull/36821#event-4187841861
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 10, 2021https://github.com/nodejs/node/pull/36821#issuecomment-757443696
https://ci.nodejs.org/job/node-test-pull-request/35413/https://ci.nodejs.org/job/node-test-pull-request/35413/
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 10, 2021https://github.com/nodejs/node/pull/36821#issuecomment-757455812
https://ci.nodejs.org/job/node-test-pull-request/35417/https://ci.nodejs.org/job/node-test-pull-request/35417/
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 11, 2021https://github.com/nodejs/node/pull/36821#issuecomment-757683740
https://ci.nodejs.org/job/node-test-pull-request/35435/https://ci.nodejs.org/job/node-test-pull-request/35435/
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/dnlup
dnluphttps://github.com/dnlup
Jan 11, 2021https://github.com/nodejs/node/pull/36821#issuecomment-757686401
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 12, 2021https://github.com/nodejs/node/pull/36821#issuecomment-758481596
https://ci.nodejs.org/job/node-test-pull-request/35463/https://ci.nodejs.org/job/node-test-pull-request/35463/
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/dnlup
dnluphttps://github.com/dnlup
Jan 13, 2021 https://github.com/nodejs/node/pull/36821#pullrequestreview-567265487
View reviewed changes https://github.com/nodejs/node/pull/36821/files/43fc062f278c22f4284b55dbf842525bf464d5de
dnluphttps://github.com/dnlup
https://github.com/nodejs/node/pull/36821#pullrequestreview-567265487
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/dnlup
dnluphttps://github.com/dnlup
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 13, 2021https://github.com/nodejs/node/pull/36821#event-4201461669
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 13, 2021https://github.com/nodejs/node/pull/36821#issuecomment-759489664
https://ci.nodejs.org/job/node-test-pull-request/35520/https://ci.nodejs.org/job/node-test-pull-request/35520/
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/dnlup
dnluphttps://github.com/dnlup
Jan 13, 2021https://github.com/nodejs/node/pull/36821#issuecomment-759571680
#36868https://github.com/nodejs/node/issues/36868
herehttps://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#code-reviews
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 13, 2021https://github.com/nodejs/node/pull/36821#issuecomment-759603730
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/dnlup
dnluphttps://github.com/dnlup
Jan 14, 2021https://github.com/nodejs/node/pull/36821#issuecomment-759978794
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 14, 2021https://github.com/nodejs/node/pull/36821#issuecomment-759987533
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 18, 2021https://github.com/nodejs/node/pull/36821#issuecomment-762324506
https://ci.nodejs.org/job/node-test-pull-request/35604/https://ci.nodejs.org/job/node-test-pull-request/35604/
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 18, 2021https://github.com/nodejs/node/pull/36821#issuecomment-762480105
https://ci.nodejs.org/job/node-test-pull-request/35620/https://ci.nodejs.org/job/node-test-pull-request/35620/
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 18, 2021 https://github.com/nodejs/node/pull/36821#pullrequestreview-570787184
View reviewed changes https://github.com/nodejs/node/pull/36821/files/43fc062f278c22f4284b55dbf842525bf464d5de
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 18, 2021https://github.com/nodejs/node/pull/36821#issuecomment-762488871
708728dhttps://github.com/nodejs/node/commit/708728ddccfabacace6ae40b7b7b9cd2726a8a14
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 18, 2021https://github.com/nodejs/node/pull/36821#event-4219957853
jasnellhttps://github.com/jasnell
Jan 18, 2021 https://github.com/nodejs/node/pull/36821#ref-commit-708728d
https://github.com/ronag
https://github.com/jasnell
http: abortIncoming only on socket closehttps://github.com/nodejs/node/commit/708728ddccfabacace6ae40b7b7b9cd2726a8a14
708728dhttps://github.com/nodejs/node/commit/708728ddccfabacace6ae40b7b7b9cd2726a8a14
#36821https://github.com/nodejs/node/pull/36821
ruyadornohttps://github.com/ruyadorno
Jan 22, 2021 https://github.com/nodejs/node/pull/36821#ref-commit-82c05f5
https://github.com/ronag
https://github.com/ruyadorno
http: abortIncoming only on socket closehttps://github.com/nodejs/node/commit/82c05f5defd04e4a2ed697abb1696c63918b086f
82c05f5https://github.com/nodejs/node/commit/82c05f5defd04e4a2ed697abb1696c63918b086f
#36821https://github.com/nodejs/node/pull/36821
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Jan 22, 2021 https://github.com/nodejs/node/pull/36821#ref-pullrequest-791653749
v15.7.0 proposal #37020 https://github.com/nodejs/node/pull/37020
ruyadornohttps://github.com/ruyadorno
Jan 25, 2021 https://github.com/nodejs/node/pull/36821#ref-commit-f07e1c9
https://github.com/ronag
https://github.com/ruyadorno
http: abortIncoming only on socket closehttps://github.com/nodejs/node/commit/f07e1c9d03b2b1dac3ba7699c1456861f88a576f
f07e1c9https://github.com/nodejs/node/commit/f07e1c9d03b2b1dac3ba7699c1456861f88a576f
#36821https://github.com/nodejs/node/pull/36821
https://github.com/devinivy
devinivyhttps://github.com/devinivy
Feb 2, 2021 https://github.com/nodejs/node/pull/36821#ref-pullrequest-233259064
lookup: add hapi nodejs/citgm#436 https://github.com/nodejs/citgm/pull/436
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x
May 25, 2021https://github.com/nodejs/node/pull/36821#event-4793401911
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36821
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/36821/files/43fc062f278c22f4284b55dbf842525bf464d5de
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/dnlup
dnlup https://github.com/dnlup
https://github.com/nodejs/node/pull/36821/files/43fc062f278c22f4284b55dbf842525bf464d5de
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/36821
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/dnlup
https://github.com/jasnell
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.