| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:21a93b07-9716-9112-5f91-53a5fe57f8d6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B68:1CFEED:FD2F52:14F8EAC:6A51C135 |
| html-safe-nonce | 99e087209397c0dabb0a45adbf3b7f79435bfc3a01d3b8b3c88d422ee0a4ca9a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjY4OjFDRkVFRDpGRDJGNTI6MTRGOEVBQzo2QTUxQzEzNSIsInZpc2l0b3JfaWQiOiIzNjEwNzIwOTY5NjM3ODcxOTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a550b005c131833a3a6cc65dd49b7083ba1f29c77aac818c59ca2e4e7ab94a8b |
| hovercard-subject-tag | pull_request:547820592 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36748/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bc3ce3bb026a60ade7ec21f37237867879e8d2994349c2b331abc486a2f3d70c/nodejs/node/pull/36748 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bc3ce3bb026a60ade7ec21f37237867879e8d2994349c2b331abc486a2f3d70c/nodejs/node/pull/36748 |
| og:image:alt | We were using the result vector with an object which is not a primitive
data type, and going with the constructor allocation pattern it creates
a size of that vector and also initializes the spaces... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | yashLadha |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36748#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36748 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36748 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36748 |
| Reload | https://github.com/nodejs/node/pull/36748 |
| Reload | https://github.com/nodejs/node/pull/36748 |
| Please reload this page | https://github.com/nodejs/node/pull/36748 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36748 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
983
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| yashLadha | https://github.com/yashLadha |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| yashLadha:improve_vector_allocation | https://github.com/yashLadha/node/tree/improve_vector_allocation |
| Conversation | https://github.com/nodejs/node/pull/36748 |
| Commits1 (1) | https://github.com/nodejs/node/pull/36748/commits |
| Checks | https://github.com/nodejs/node/pull/36748/checks |
| Files changed | https://github.com/nodejs/node/pull/36748/files |
| os: performance improvement in vector allocation | https://github.com/nodejs/node/pull/36748#top |
| yashLadha | https://github.com/yashLadha |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| yashLadha:improve_vector_allocation | https://github.com/yashLadha/node/tree/improve_vector_allocation |
|
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| Jan 3, 2021 | https://github.com/nodejs/node/pull/36748#issue-777557212 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/36748 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
os
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aos |
| Jan 3, 2021 | https://github.com/nodejs/node/pull/36748#event-4162112895 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| force-pushed | https://github.com/nodejs/node/compare/d3d391fb5233fd2a67ee14a3b6c2030b7ac2ebc9..6dc0a6ee4be5fda3366c82d48e8c6d09cb8a7ba1 |
| d3d391f | https://github.com/nodejs/node/commit/d3d391fb5233fd2a67ee14a3b6c2030b7ac2ebc9 |
| 6dc0a6e | https://github.com/nodejs/node/commit/6dc0a6ee4be5fda3366c82d48e8c6d09cb8a7ba1 |
|
Compare
| https://github.com/nodejs/node/compare/d3d391fb5233fd2a67ee14a3b6c2030b7ac2ebc9..6dc0a6ee4be5fda3366c82d48e8c6d09cb8a7ba1 |
| January 3, 2021 07:18 | https://github.com/nodejs/node/pull/36748#event-4162238232 |
|
| https://github.com/yashLadha |
| os: performance improvement in vector allocation | https://github.com/nodejs/node/pull/36748/commits/aa249295d2df6a0023612f4239dd6795d0b48f98 |
| aa24929 | https://github.com/nodejs/node/pull/36748/commits/aa249295d2df6a0023612f4239dd6795d0b48f98 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| force-pushed | https://github.com/nodejs/node/compare/6dc0a6ee4be5fda3366c82d48e8c6d09cb8a7ba1..aa249295d2df6a0023612f4239dd6795d0b48f98 |
| 6dc0a6e | https://github.com/nodejs/node/commit/6dc0a6ee4be5fda3366c82d48e8c6d09cb8a7ba1 |
| aa24929 | https://github.com/nodejs/node/commit/aa249295d2df6a0023612f4239dd6795d0b48f98 |
|
Compare
| https://github.com/nodejs/node/compare/6dc0a6ee4be5fda3366c82d48e8c6d09cb8a7ba1..aa249295d2df6a0023612f4239dd6795d0b48f98 |
| January 3, 2021 07:23 | https://github.com/nodejs/node/pull/36748#event-4162240830 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| Jan 3, 2021 | https://github.com/nodejs/node/pull/36748#issuecomment-753594067 |
| https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/866/console | https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/866/console |
| Please reload this page | https://github.com/nodejs/node/pull/36748 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jan 3, 2021
| https://github.com/nodejs/node/pull/36748#pullrequestreview-560689374 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36748/files/aa249295d2df6a0023612f4239dd6795d0b48f98 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 5, 2021 | https://github.com/nodejs/node/pull/36748#event-4167396264 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 5, 2021 | https://github.com/nodejs/node/pull/36748#event-4167501488 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 5, 2021 | https://github.com/nodejs/node/pull/36748#issuecomment-754331591 |
| https://ci.nodejs.org/job/node-test-pull-request/35262/ | https://ci.nodejs.org/job/node-test-pull-request/35262/ |
| Please reload this page | https://github.com/nodejs/node/pull/36748 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36748#issuecomment-757847920 |
| https://ci.nodejs.org/job/node-test-pull-request/35437/ | https://ci.nodejs.org/job/node-test-pull-request/35437/ |
| Please reload this page | https://github.com/nodejs/node/pull/36748 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36748#issuecomment-762415075 |
| https://ci.nodejs.org/job/node-test-pull-request/35611/ | https://ci.nodejs.org/job/node-test-pull-request/35611/ |
| Please reload this page | https://github.com/nodejs/node/pull/36748 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36748#event-4219447898 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 18, 2021
| https://github.com/nodejs/node/pull/36748#pullrequestreview-570789368 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36748/files/aa249295d2df6a0023612f4239dd6795d0b48f98 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36748#issuecomment-762482575 |
| cb2535e | https://github.com/nodejs/node/commit/cb2535ef7ff9e61d827dc0f026f102a132740041 |
| Please reload this page | https://github.com/nodejs/node/pull/36748 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 18, 2021 | https://github.com/nodejs/node/pull/36748#event-4219914538 |
| jasnell | https://github.com/jasnell |
|
Jan 18, 2021
| https://github.com/nodejs/node/pull/36748#ref-commit-cb2535e |
|
| https://github.com/yashLadha |
|
| https://github.com/jasnell |
| os: performance improvement in vector allocation | https://github.com/nodejs/node/commit/cb2535ef7ff9e61d827dc0f026f102a132740041 |
| cb2535e | https://github.com/nodejs/node/commit/cb2535ef7ff9e61d827dc0f026f102a132740041 |
| #36748 | https://github.com/nodejs/node/pull/36748 |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36748#ref-commit-d3f7280 |
|
| https://github.com/yashLadha |
|
| https://github.com/ruyadorno |
| os: performance improvement in vector allocation | https://github.com/nodejs/node/commit/d3f7280e75ce51979a3c965b65662242478a77b0 |
| d3f7280 | https://github.com/nodejs/node/commit/d3f7280e75ce51979a3c965b65662242478a77b0 |
| #36748 | https://github.com/nodejs/node/pull/36748 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 22, 2021
| https://github.com/nodejs/node/pull/36748#ref-pullrequest-791653749 |
|
v15.7.0 proposal
#37020
| https://github.com/nodejs/node/pull/37020 |
| ruyadorno | https://github.com/ruyadorno |
|
Jan 25, 2021
| https://github.com/nodejs/node/pull/36748#ref-commit-89a7941 |
|
| https://github.com/yashLadha |
|
| https://github.com/ruyadorno |
| os: performance improvement in vector allocation | https://github.com/nodejs/node/commit/89a79414252d85917a46b113e48ba01be08db3d1 |
| 89a7941 | https://github.com/nodejs/node/commit/89a79414252d85917a46b113e48ba01be08db3d1 |
| #36748 | https://github.com/nodejs/node/pull/36748 |
| targos | https://github.com/targos |
|
May 1, 2021
| https://github.com/nodejs/node/pull/36748#ref-commit-991251f |
|
| https://github.com/yashLadha |
|
| https://github.com/targos |
| os: performance improvement in vector allocation | https://github.com/nodejs/node/commit/991251fbb2076d15fe3eec524d51d067e746337d |
| 991251f | https://github.com/nodejs/node/commit/991251fbb2076d15fe3eec524d51d067e746337d |
| #36748 | https://github.com/nodejs/node/pull/36748 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
May 3, 2021
| https://github.com/nodejs/node/pull/36748#ref-pullrequest-874193529 |
|
v14.17.0 proposal
#38507
| https://github.com/nodejs/node/pull/38507 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36748 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/36748/files/aa249295d2df6a0023612f4239dd6795d0b48f98 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/36748/files/aa249295d2df6a0023612f4239dd6795d0b48f98 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
os
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aos |
| Please reload this page | https://github.com/nodejs/node/pull/36748 |
|
| https://github.com/yashLadha |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/ronag |
|
| https://github.com/aduh95 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |