René's URL Explorer Experiment


Title: worker: refactor to avoid unsafe array iteration by aduh95 · Pull Request #36735 · nodejs/node · GitHub

Open Graph Title: worker: refactor to avoid unsafe array iteration by aduh95 · Pull Request #36735 · nodejs/node

X Title: worker: refactor to avoid unsafe array iteration by aduh95 · Pull Request #36735 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/36735

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:97a5a4b5-36e0-e995-650a-161eccd9f6fa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA66:B267E:39B242:4E3856:6A51C11E
html-safe-nonce12d86b6ffa0083ce7833ba39a68be38afcc5320fb59784ad861d98cb8b332aa9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTY2OkIyNjdFOjM5QjI0Mjo0RTM4NTY6NkE1MUMxMUUiLCJ2aXNpdG9yX2lkIjoiMTQyOTczNTk2Njg0MzcxNTg3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7609e0b5c8c56449cbb1a50bbbbacf0aa53946f313c84b72044e581cda980976
hovercard-subject-tagpull_request:547733889
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36735/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2c331235026f43146760746b9513c3b37094073fe92ec7d98adfa86e7b41a1b6/nodejs/node/pull/36735
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2c331235026f43146760746b9513c3b37094073fe92ec7d98adfa86e7b41a1b6/nodejs/node/pull/36735
og:image:altChecklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36735#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36735
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36735
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36735
Reloadhttps://github.com/nodejs/node/pull/36735
Reloadhttps://github.com/nodejs/node/pull/36735
Please reload this pagehttps://github.com/nodejs/node/pull/36735
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36735
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 983 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
aduh95:worker-array-iterationhttps://github.com/aduh95/node/tree/worker-array-iteration
Conversationhttps://github.com/nodejs/node/pull/36735
Commits1 (1)https://github.com/nodejs/node/pull/36735/commits
Checkshttps://github.com/nodejs/node/pull/36735/checks
Files changedhttps://github.com/nodejs/node/pull/36735/files
worker: refactor to avoid unsafe array iterationhttps://github.com/nodejs/node/pull/36735#top
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
aduh95:worker-array-iterationhttps://github.com/aduh95/node/tree/worker-array-iteration
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 2, 2021https://github.com/nodejs/node/pull/36735#issue-777431319
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/aduh95
aduh95https://github.com/aduh95
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
needs-benchmark-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-benchmark-ci
Jan 2, 2021https://github.com/nodejs/node/pull/36735#event-4161580631
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 2, 2021https://github.com/nodejs/node/pull/36735#issuecomment-753451180
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/854/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/854/
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Jan 2, 2021 https://github.com/nodejs/node/pull/36735#pullrequestreview-560633426
View reviewed changes https://github.com/nodejs/node/pull/36735/files
lib/internal/worker.jshttps://github.com/nodejs/node/pull/36735/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 2, 2021 https://github.com/nodejs/node/pull/36735#pullrequestreview-560651006
View reviewed changes https://github.com/nodejs/node/pull/36735/files
lib/internal/worker.jshttps://github.com/nodejs/node/pull/36735/files#diff-7ee37130d43feac3a3f96a16e0b9628597ff2d8aee8e3c86765a616ff684e564
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 2, 2021https://github.com/nodejs/node/pull/36735#issuecomment-753517875
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/854/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/854/
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/aduh95
aduh95https://github.com/aduh95
needs-benchmark-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-benchmark-ci
Jan 2, 2021https://github.com/nodejs/node/pull/36735#event-4161916891
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 3, 2021 https://github.com/nodejs/node/pull/36735#pullrequestreview-560687569
View reviewed changes https://github.com/nodejs/node/pull/36735/files
lib/internal/worker/io.jshttps://github.com/nodejs/node/pull/36735/files#diff-6d1a52d1f58f2b4873a485557c0033d0d408cc00c1df2a08cd4cc3298a4689f7
Please reload this pagehttps://github.com/nodejs/node/pull/36735
lib/internal/worker/io.jshttps://github.com/nodejs/node/pull/36735/files#diff-6d1a52d1f58f2b4873a485557c0033d0d408cc00c1df2a08cd4cc3298a4689f7
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/targos
targoshttps://github.com/targos
Jan 3, 2021https://github.com/nodejs/node/pull/36735#issuecomment-753601279
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 3, 2021https://github.com/nodejs/node/pull/36735#event-4162369001
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 3, 2021https://github.com/nodejs/node/pull/36735#issuecomment-753602210
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/ronag
ronaghttps://github.com/ronag
addaleaxhttps://github.com/addaleax
January 3, 2021 11:42https://github.com/nodejs/node/pull/36735#event-4162384030
https://github.com/aduh95
aduh95https://github.com/aduh95
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Jan 9, 2021https://github.com/nodejs/node/pull/36735#event-4186887739
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 12, 2021 https://github.com/nodejs/node/pull/36735#pullrequestreview-566780161
View reviewed changes https://github.com/nodejs/node/pull/36735/files
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 12, 2021https://github.com/nodejs/node/pull/36735#event-4198511086
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 12, 2021https://github.com/nodejs/node/pull/36735#event-4198511334
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 12, 2021 https://github.com/nodejs/node/pull/36735#pullrequestreview-566792800
View reviewed changes https://github.com/nodejs/node/pull/36735/files
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 13, 2021https://github.com/nodejs/node/pull/36735#event-4198704544
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 13, 2021https://github.com/nodejs/node/pull/36735#issuecomment-759116565
https://ci.nodejs.org/job/node-test-pull-request/35485/https://ci.nodejs.org/job/node-test-pull-request/35485/
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 13, 2021https://github.com/nodejs/node/pull/36735#issuecomment-759321009
https://ci.nodejs.org/job/node-test-pull-request/35495/https://ci.nodejs.org/job/node-test-pull-request/35495/
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/aduh95
worker: refactor to avoid unsafe array iterationhttps://github.com/nodejs/node/pull/36735/commits/7c37e046ebd5c41fc6ce6d6e5f5b4b43a37ef4cf
7c37e04https://github.com/nodejs/node/pull/36735/commits/7c37e046ebd5c41fc6ce6d6e5f5b4b43a37ef4cf
nodejs#36735https://github.com/nodejs/node/pull/36735
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/7f9a136319c41871d60bdab8cf76c82056525347..7c37e046ebd5c41fc6ce6d6e5f5b4b43a37ef4cf
7f9a136https://github.com/nodejs/node/commit/7f9a136319c41871d60bdab8cf76c82056525347
7c37e04https://github.com/nodejs/node/commit/7c37e046ebd5c41fc6ce6d6e5f5b4b43a37ef4cf
Compare https://github.com/nodejs/node/compare/7f9a136319c41871d60bdab8cf76c82056525347..7c37e046ebd5c41fc6ce6d6e5f5b4b43a37ef4cf
January 13, 2021 14:43https://github.com/nodejs/node/pull/36735#event-4201574400
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 13, 2021https://github.com/nodejs/node/pull/36735#issuecomment-759493847
7c37e04https://github.com/nodejs/node/commit/7c37e046ebd5c41fc6ce6d6e5f5b4b43a37ef4cf
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/aduh95
aduh95https://github.com/aduh95
7c37e04https://github.com/nodejs/node/commit/7c37e046ebd5c41fc6ce6d6e5f5b4b43a37ef4cf
Jan 13, 2021https://github.com/nodejs/node/pull/36735#event-4201575770
https://github.com/aduh95
aduh95https://github.com/aduh95
January 13, 2021 14:44https://github.com/nodejs/node/pull/36735#event-4201576209
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Jan 21, 2021https://github.com/nodejs/node/pull/36735#event-4235990074
ruyadornohttps://github.com/ruyadorno
Jan 22, 2021 https://github.com/nodejs/node/pull/36735#ref-commit-bf695eb
https://github.com/aduh95
https://github.com/ruyadorno
worker: refactor to avoid unsafe array iterationhttps://github.com/nodejs/node/commit/bf695ebdb1752d1eac70b3f1f817eeb7c36b84fd
bf695ebhttps://github.com/nodejs/node/commit/bf695ebdb1752d1eac70b3f1f817eeb7c36b84fd
#36735https://github.com/nodejs/node/pull/36735
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Jan 22, 2021 https://github.com/nodejs/node/pull/36735#ref-pullrequest-791653749
v15.7.0 proposal #37020 https://github.com/nodejs/node/pull/37020
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x
May 25, 2021https://github.com/nodejs/node/pull/36735#event-4793359495
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36735
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/36735/files/0ef68d1d23727b225e9dfad5669a45e2dcb438d0
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/36735/files/7f9a136319c41871d60bdab8cf76c82056525347
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/36735/files/7f9a136319c41871d60bdab8cf76c82056525347
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/aduh95
aduh95 https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Please reload this pagehttps://github.com/nodejs/node/pull/36735
https://github.com/aduh95
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Trott
https://github.com/RaisinTen
https://github.com/ruyadorno
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.