René's URL Explorer Experiment


Title: tls: doc-only deprecate new TLSSocket constructor by jasnell · Pull Request #36711 · nodejs/node · GitHub

Open Graph Title: tls: doc-only deprecate new TLSSocket constructor by jasnell · Pull Request #36711 · nodejs/node

X Title: tls: doc-only deprecate new TLSSocket constructor by jasnell · Pull Request #36711 · nodejs/node

Description: Fixes: #10555 Refs: #10846 The new tls.TLSSocket() constructor does not set up all of the necessary lifecycle management or event handlers necessary for proper use. The tls.connect() method really ...

Open Graph Description: Fixes: #10555 Refs: #10846 The new tls.TLSSocket() constructor does not set up all of the necessary lifecycle management or event handlers necessary for proper use. The tls.connect() method really ...

X Description: Fixes: #10555 Refs: #10846 The new tls.TLSSocket() constructor does not set up all of the necessary lifecycle management or event handlers necessary for proper use. The tls.connect() method really ...

Mail addresses
jasnell@gmail.com

Opengraph URL: https://github.com/nodejs/node/pull/36711

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:547d3abd-a8c7-a63d-aa87-4c74662de81b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90D8:1860A8:751B83:A3EF2B:696A7211
html-safe-nonce9c49ab869a35b93ec645fc6e3ed996da96988ce73ba3d2974081a0df4dca95d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEQ4OjE4NjBBODo3NTFCODM6QTNFRjJCOjY5NkE3MjExIiwidmlzaXRvcl9pZCI6IjgzNjMzMzMyNzg4NzI3OTM2MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3ab711898716816a55a61c20bd679ab22056870a0f63b9bb92ca8a6c473b3d61
hovercard-subject-tagpull_request:547516485
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36711/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/503955c1f5d1ae59a05bb7226d9bb048d15b7d360b6e5979ba1cdd7bf31ab96e/nodejs/node/pull/36711
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/503955c1f5d1ae59a05bb7226d9bb048d15b7d360b6e5979ba1cdd7bf31ab96e/nodejs/node/pull/36711
og:image:altFixes: #10555 Refs: #10846 The new tls.TLSSocket() constructor does not set up all of the necessary lifecycle management or event handlers necessary for proper use. The tls.connect() method really ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36711#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36711
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36711
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36711
Reloadhttps://github.com/nodejs/node/pull/36711
Reloadhttps://github.com/nodejs/node/pull/36711
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36711
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/36711
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/36711#issue-comment-box
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:doc-deprecate-new-tlssockethttps://github.com/jasnell/node/tree/doc-deprecate-new-tlssocket
tls: doc-only deprecate new TLSSocket constructor https://github.com/nodejs/node/pull/36711#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:doc-deprecate-new-tlssockethttps://github.com/jasnell/node/tree/doc-deprecate-new-tlssocket
Conversation 4 https://github.com/nodejs/node/pull/36711
Commits 1 https://github.com/nodejs/node/pull/36711/commits
Checks 0 https://github.com/nodejs/node/pull/36711/checks
Files changed https://github.com/nodejs/node/pull/36711/files
Please reload this pagehttps://github.com/nodejs/node/pull/36711
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 31, 2020https://github.com/nodejs/node/pull/36711#issue-777148224
#10555https://github.com/nodejs/node/issues/10555
#10846https://github.com/nodejs/node/pull/10846
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36711
https://github.com/jasnell
tls: doc-only deprecate new TLSSocket constructorhttps://github.com/nodejs/node/pull/36711/commits/d7e5b4588d4999445082e8842b1e3a264cbb2d85
d7e5b45https://github.com/nodejs/node/pull/36711/commits/d7e5b4588d4999445082e8842b1e3a264cbb2d85
nodejs#10555https://github.com/nodejs/node/issues/10555
nodejs#10846https://github.com/nodejs/node/pull/10846
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Dec 31, 2020https://github.com/nodejs/node/pull/36711#event-4160348163
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 31, 2020 https://github.com/nodejs/node/pull/36711#ref-issue-548275461
new tls.TLSSocket issue #31305 https://github.com/nodejs/node/issues/31305
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jan 1, 2021https://github.com/nodejs/node/pull/36711#issuecomment-753235968
Please reload this pagehttps://github.com/nodejs/node/pull/36711
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 1, 2021https://github.com/nodejs/node/pull/36711#issuecomment-753237244
Please reload this pagehttps://github.com/nodejs/node/pull/36711
https://github.com/jasnell
jasnellhttps://github.com/jasnell
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Jan 2, 2021https://github.com/nodejs/node/pull/36711#event-4161997456
https://github.com/jasnell
jasnellhttps://github.com/jasnell
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Jan 15, 2021https://github.com/nodejs/node/pull/36711#event-4211960426
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 22, 2021https://github.com/nodejs/node/pull/36711#issuecomment-765691932
Please reload this pagehttps://github.com/nodejs/node/pull/36711
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 22, 2021https://github.com/nodejs/node/pull/36711#event-4240459056
https://github.com/silverbucket
silverbuckethttps://github.com/silverbucket
Feb 10, 2021 https://github.com/nodejs/node/pull/36711#ref-issue-805690527
Tls not working Havvy/irc-socket#25 https://github.com/Havvy/irc-socket/issues/25
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
May 1, 2021https://github.com/nodejs/node/pull/36711#issuecomment-830473974
Please reload this pagehttps://github.com/nodejs/node/pull/36711
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36711
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
tls: secureConnect event will not be emitted if TLSSocket is created via constructor instead of tls.connect https://github.com/nodejs/node/issues/10555
Please reload this pagehttps://github.com/nodejs/node/pull/36711
https://github.com/jasnell
https://github.com/mscdex
https://github.com/mildsunrise
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.