| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7d03b95c-35b0-5329-11e6-57e30479ddcf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C604:1C15F1:3CFC9E:5170EE:6A52F048 |
| html-safe-nonce | 811f758d71e1a45aa09922c2133248d54ef8baf411260cc2814b071561b50ea2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjA0OjFDMTVGMTozQ0ZDOUU6NTE3MEVFOjZBNTJGMDQ4IiwidmlzaXRvcl9pZCI6IjY5MDgzMzI2Nzk4MTA0NDUzODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f6351032a5d289f7b98d193f70ebeb13c3955501d0de701bdfc0b1b92078c60e |
| hovercard-subject-tag | pull_request:546598768 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36679/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2dce102d693a0318faedabdb974df76d57d347ed2c2ecbc4610156cf8b7b3d86/nodejs/node/pull/36679 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2dce102d693a0318faedabdb974df76d57d347ed2c2ecbc4610156cf8b7b3d86/nodejs/node/pull/36679 |
| og:image:alt | StringPrototypeIncludes primordial in place of <string>.indexOf for truthy validation in if expression.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message fo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rchougule |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36679#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36679 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36679 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36679 |
| Reload | https://github.com/nodejs/node/pull/36679 |
| Reload | https://github.com/nodejs/node/pull/36679 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
996
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| rchougule | https://github.com/rchougule |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rchougule:primordials_lib_http2 | https://github.com/rchougule/node/tree/primordials_lib_http2 |
| Conversation | https://github.com/nodejs/node/pull/36679 |
| Commits1 (1) | https://github.com/nodejs/node/pull/36679/commits |
| Checks | https://github.com/nodejs/node/pull/36679/checks |
| Files changed | https://github.com/nodejs/node/pull/36679/files |
| lib: string indexOf to use primordials for http2/compat.js | https://github.com/nodejs/node/pull/36679#top |
| rchougule | https://github.com/rchougule |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| rchougule:primordials_lib_http2 | https://github.com/rchougule/node/tree/primordials_lib_http2 |
|
| https://github.com/rchougule |
| rchougule | https://github.com/rchougule |
| Dec 29, 2020 | https://github.com/nodejs/node/pull/36679#issue-776041214 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| Dec 29, 2020 | https://github.com/nodejs/node/pull/36679#event-4155474659 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Dec 29, 2020
| https://github.com/nodejs/node/pull/36679#pullrequestreview-559667495 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36679/files |
| lib/internal/http2/compat.js | https://github.com/nodejs/node/pull/36679/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| Dec 30, 2020 | https://github.com/nodejs/node/pull/36679#issuecomment-752287750 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/Lxxyx |
| Lxxyx | https://github.com/Lxxyx |
|
Dec 30, 2020
| https://github.com/nodejs/node/pull/36679#pullrequestreview-559769861 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36679/files |
| https://github.com/himself65 |
| himself65 | https://github.com/himself65 |
|
Dec 30, 2020
| https://github.com/nodejs/node/pull/36679#pullrequestreview-559771655 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36679/files |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Dec 30, 2020 | https://github.com/nodejs/node/pull/36679#issuecomment-752381403 |
| @yashLadha | https://github.com/yashLadha |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 30, 2020 | https://github.com/nodejs/node/pull/36679#event-4156674309 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 30, 2020 | https://github.com/nodejs/node/pull/36679#event-4156688652 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Dec 30, 2020 | https://github.com/nodejs/node/pull/36679#issuecomment-752387644 |
| https://ci.nodejs.org/job/node-test-pull-request/35141/ | https://ci.nodejs.org/job/node-test-pull-request/35141/ |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/PoojaDurgad |
| PoojaDurgad | https://github.com/PoojaDurgad |
|
Dec 31, 2020
| https://github.com/nodejs/node/pull/36679#pullrequestreview-560258109 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36679/files |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Dec 31, 2020
| https://github.com/nodejs/node/pull/36679#ref-issue-776121203 |
|
Cannot start CI jobs
nodejs/build#2506
| https://github.com/nodejs/build/issues/2506 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Dec 31, 2020 | https://github.com/nodejs/node/pull/36679#issuecomment-752894018 |
| https://ci.nodejs.org/job/node-test-pull-request/35169/ | https://ci.nodejs.org/job/node-test-pull-request/35169/ |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/rchougule |
| rchougule | https://github.com/rchougule |
| force-pushed | https://github.com/nodejs/node/compare/4bb6fabd33ac74581b28961772c877820f5b4c57..9d927f34754d3f01488827674f0a9ff4e6bd44f0 |
| 4bb6fab | https://github.com/nodejs/node/commit/4bb6fabd33ac74581b28961772c877820f5b4c57 |
| 9d927f3 | https://github.com/nodejs/node/commit/9d927f34754d3f01488827674f0a9ff4e6bd44f0 |
|
Compare
| https://github.com/nodejs/node/compare/4bb6fabd33ac74581b28961772c877820f5b4c57..9d927f34754d3f01488827674f0a9ff4e6bd44f0 |
| December 31, 2020 11:56 | https://github.com/nodejs/node/pull/36679#event-4159547589 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 31, 2020 | https://github.com/nodejs/node/pull/36679#event-4159850802 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 31, 2020 | https://github.com/nodejs/node/pull/36679#event-4159866180 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 31, 2020
| https://github.com/nodejs/node/pull/36679#pullrequestreview-560507736 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36679/files |
| lib/internal/http2/compat.js | https://github.com/nodejs/node/pull/36679/files#diff-e241fc9fee7eaeaf021850ee74d273cc350099b52c548d7fdb85c8440eef1c8f |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 31, 2020
| https://github.com/nodejs/node/pull/36679#pullrequestreview-560507780 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36679/files |
|
| https://github.com/rchougule |
| http2: refactor to use primordials instead of .indexOf | https://github.com/nodejs/node/pull/36679/commits/12c78aa1cc8de6583b8a325e92e37981582d911f |
| 12c78aa | https://github.com/nodejs/node/pull/36679/commits/12c78aa1cc8de6583b8a325e92e37981582d911f |
| https://github.com/rchougule |
| rchougule | https://github.com/rchougule |
| force-pushed | https://github.com/nodejs/node/compare/fcc389bce88ef04e9a9c10ba9cf1a7d4ad0281e8..12c78aa1cc8de6583b8a325e92e37981582d911f |
| fcc389b | https://github.com/nodejs/node/commit/fcc389bce88ef04e9a9c10ba9cf1a7d4ad0281e8 |
| 12c78aa | https://github.com/nodejs/node/commit/12c78aa1cc8de6583b8a325e92e37981582d911f |
|
Compare
| https://github.com/nodejs/node/compare/fcc389bce88ef04e9a9c10ba9cf1a7d4ad0281e8..12c78aa1cc8de6583b8a325e92e37981582d911f |
| December 31, 2020 18:19 | https://github.com/nodejs/node/pull/36679#event-4160068864 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 1, 2021 | https://github.com/nodejs/node/pull/36679#event-4160515903 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 1, 2021 | https://github.com/nodejs/node/pull/36679#event-4160534601 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| Jan 1, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-753281956 |
| https://ci.nodejs.org/job/node-test-pull-request/35187/ | https://ci.nodejs.org/job/node-test-pull-request/35187/ |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/rchougule |
| rchougule | https://github.com/rchougule |
|
Jan 1, 2021
| https://github.com/nodejs/node/pull/36679#ref-pullrequest-777246827 |
|
zlib: refactor to use primordial instead of .startsWith
#36718
| https://github.com/nodejs/node/pull/36718 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 2, 2021
| https://github.com/nodejs/node/pull/36679#pullrequestreview-560647856 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36679/files/12c78aa1cc8de6583b8a325e92e37981582d911f |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 2, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-753509653 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/856/ | https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/856/ |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/rchougule |
| rchougule | https://github.com/rchougule |
| Jan 3, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-753593405 |
| https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/856/ | https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/856/ |
| https://user-images.githubusercontent.com/22256912/103476075-9c91af00-4dd8-11eb-879e-9c6dda627593.png |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 3, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-753594445 |
| #36746 | https://github.com/nodejs/node/issues/36746 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 3, 2021 | https://github.com/nodejs/node/pull/36679#event-4162630362 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 3, 2021 | https://github.com/nodejs/node/pull/36679#event-4162630970 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36679 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36679 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 5, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-754463541 |
| https://ci.nodejs.org/job/node-test-pull-request/35270/ | https://ci.nodejs.org/job/node-test-pull-request/35270/ |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 6, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-755218930 |
| https://ci.nodejs.org/job/node-test-pull-request/35325/ | https://ci.nodejs.org/job/node-test-pull-request/35325/ |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/rchougule |
| rchougule | https://github.com/rchougule |
| Jan 6, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-755318289 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 6, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-755419756 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 6, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-755420008 |
| https://ci.nodejs.org/job/node-test-pull-request/35334/ | https://ci.nodejs.org/job/node-test-pull-request/35334/ |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 6, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-755452337 |
| https://ci.nodejs.org/job/node-test-pull-request/35335/ | https://ci.nodejs.org/job/node-test-pull-request/35335/ |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/rchougule |
| rchougule | https://github.com/rchougule |
| Jan 7, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-756318481 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 8, 2021 | https://github.com/nodejs/node/pull/36679#event-4184868259 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 8, 2021 | https://github.com/nodejs/node/pull/36679#event-4184909349 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 8, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-756821871 |
| https://ci.nodejs.org/job/node-test-pull-request/35367/ | https://ci.nodejs.org/job/node-test-pull-request/35367/ |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| yashLadha | https://github.com/yashLadha |
|
Jan 9, 2021
| https://github.com/nodejs/node/pull/36679#ref-commit-3af175f |
|
| https://github.com/rchougule |
|
| https://github.com/yashLadha |
| http2: refactor to use primordials instead of .indexOf | https://github.com/nodejs/node/commit/3af175fb5e6cfdb1de57dc19fc3827c804333545 |
| 3af175f | https://github.com/nodejs/node/commit/3af175fb5e6cfdb1de57dc19fc3827c804333545 |
| #36679 | https://github.com/nodejs/node/pull/36679 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| Jan 9, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-757127990 |
| 3af175f | https://github.com/nodejs/node/commit/3af175fb5e6cfdb1de57dc19fc3827c804333545 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| Jan 9, 2021 | https://github.com/nodejs/node/pull/36679#event-4186915465 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| Jan 10, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-757478656 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 10, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-757480773 |
| @Trott | https://github.com/Trott |
| what eventually happened in this case | https://github.com/nodejs/node/pull/36850 |
| nodejs/build#2521 | https://github.com/nodejs/build/pull/2521 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/Trott |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36679 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jan 11, 2021
| https://github.com/nodejs/node/pull/36679#ref-pullrequest-782862372 |
|
benchmark: fix http2 benchmarks
#36871
| https://github.com/nodejs/node/pull/36871 |
| https://github.com/yashLadha |
| yashLadha | https://github.com/yashLadha |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-757613950 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jan 11, 2021 | https://github.com/nodejs/node/pull/36679#issuecomment-757853125 |
| benchmark of a revert on CI didn't show anything of interest | https://github.com/nodejs/node/pull/36873#issuecomment-757760792 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
| danielleadams | https://github.com/danielleadams |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36679#ref-commit-a38ad07 |
|
| https://github.com/rchougule |
|
| https://github.com/danielleadams |
| http2: refactor to use primordials instead of .indexOf | https://github.com/nodejs/node/commit/a38ad0709cf7f53dfa884df553eee1293e433e77 |
| a38ad07 | https://github.com/nodejs/node/commit/a38ad0709cf7f53dfa884df553eee1293e433e77 |
| #36679 | https://github.com/nodejs/node/pull/36679 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Jan 12, 2021
| https://github.com/nodejs/node/pull/36679#ref-pullrequest-784259248 |
|
v15.6.0 proposal
#36889
| https://github.com/nodejs/node/pull/36889 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-blocked-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x |
| May 25, 2021 | https://github.com/nodejs/node/pull/36679#event-4793245119 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36679 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/36679/files/9d927f34754d3f01488827674f0a9ff4e6bd44f0 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/36679/files/12c78aa1cc8de6583b8a325e92e37981582d911f |
|
| https://github.com/Lxxyx |
|
Lxxyx
| https://github.com/Lxxyx |
|
| https://github.com/nodejs/node/pull/36679/files/4bb6fabd33ac74581b28961772c877820f5b4c57 |
|
| https://github.com/himself65 |
|
himself65
| https://github.com/himself65 |
|
| https://github.com/nodejs/node/pull/36679/files/4bb6fabd33ac74581b28961772c877820f5b4c57 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/36679/files/a03c1bd8b3a8c732c026f91b70ab4593946dd284 |
|
| https://github.com/PoojaDurgad |
|
PoojaDurgad
| https://github.com/PoojaDurgad |
|
| https://github.com/nodejs/node/pull/36679/files/4bb6fabd33ac74581b28961772c877820f5b4c57 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| Please reload this page | https://github.com/nodejs/node/pull/36679 |
|
| https://github.com/rchougule |
|
| https://github.com/yashLadha |
|
| https://github.com/aduh95 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/Lxxyx |
|
| https://github.com/himself65 |
|
| https://github.com/PoojaDurgad |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |