René's URL Explorer Experiment


Title: http: revert incomingmessage autodestroy by dnlup · Pull Request #36647 · nodejs/node · GitHub

Open Graph Title: http: revert incomingmessage autodestroy by dnlup · Pull Request #36647 · nodejs/node

X Title: http: revert incomingmessage autodestroy by dnlup · Pull Request #36647 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This reverts commits: 55e83cb 6120028 70eaf55 5ae9690 f20a88f a6bf74e 8154e47 Because of the breaking change in the order of emitting the close event in IncomingMessage described in #33035 (comme...

X Description: This reverts commits: 55e83cb 6120028 70eaf55 5ae9690 f20a88f a6bf74e 8154e47 Because of the breaking change in the order of emitting the close event in IncomingMessage described in #33035 (comme...

Opengraph URL: https://github.com/nodejs/node/pull/36647

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:843d0ff7-9dd4-71e9-3e07-80b03d2f0b56
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4E4:3F64F:5ABC6C:759951:6AED2937
html-safe-nonceae7ecd8dba731b4d9a47cb66cd229b82f674f0b622a539b08ea1a9d527354de3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEU0OjNGNjRGOjVBQkM2Qzo3NTk5NTE6NkFFRDI5MzciLCJ2aXNpdG9yX2lkIjoiNjM0MDAxMDg0NzU5MzM3NjA1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacada0b56f326816eb8eb2ad4f637ba06e0833363420a250b5f88dcbbc9e417e90
hovercard-subject-tagpull_request:545851092
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36647/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d06c1551c9d67d2a760c1974696f3766d4cbce82f8199e73a65ad9c83907aa37/nodejs/node/pull/36647
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d06c1551c9d67d2a760c1974696f3766d4cbce82f8199e73a65ad9c83907aa37/nodejs/node/pull/36647
og:image:altThis reverts commits: 55e83cb 6120028 70eaf55 5ae9690 f20a88f a6bf74e 8154e47 Because of the breaking change in the order of emitting the close event in IncomingMessage described in #33035 (comme...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamednlup
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36647#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36647
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36647
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36647
Reloadhttps://github.com/nodejs/node/pull/36647
Reloadhttps://github.com/nodejs/node/pull/36647
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
dnluphttps://github.com/dnlup
nodejs:v15.x-staginghttps://github.com/nodejs/node/tree/v15.x-staging
dnlup:fix/revert_incoming_autodestroyhttps://github.com/dnlup/node/tree/fix/revert_incoming_autodestroy
Conversationhttps://github.com/nodejs/node/pull/36647
Commits1 (1)https://github.com/nodejs/node/pull/36647/commits
Checkshttps://github.com/nodejs/node/pull/36647/checks
Files changedhttps://github.com/nodejs/node/pull/36647/files
http: revert incomingmessage autodestroyhttps://github.com/nodejs/node/pull/36647#top
dnluphttps://github.com/dnlup
nodejs:v15.x-staginghttps://github.com/nodejs/node/tree/v15.x-staging
dnlup:fix/revert_incoming_autodestroyhttps://github.com/dnlup/node/tree/fix/revert_incoming_autodestroy
https://github.com/dnlup
dnluphttps://github.com/dnlup
Dec 27, 2020https://github.com/nodejs/node/pull/36647#issue-775099256
55e83cbhttps://github.com/nodejs/node/commit/55e83cbe957de2c752521557ffd74d4496fa8b81
6120028https://github.com/nodejs/node/commit/6120028ee3ca88d009c62711a225b1af7fad1919
70eaf55https://github.com/nodejs/node/commit/70eaf55a9d2da25742df79a862edf16f122fdfbb
5ae9690https://github.com/nodejs/node/commit/5ae96908696b7a017df3efb48ec1f8c8be5c24b8
f20a88fhttps://github.com/nodejs/node/commit/f20a88fb866917d7dd489b88c233a5e123ff3271
a6bf74ehttps://github.com/nodejs/node/commit/a6bf74eac00516fd0767b585c8f304857dddd2aa
8154e47https://github.com/nodejs/node/commit/8154e47e2b407a906f2c1270e5fc76fe466cc886
#33035 (comment)https://github.com/nodejs/node/pull/33035#issuecomment-751476367
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36647
https://github.com/dnlup
Revert "http: use autoDestroy: true in incoming message"https://github.com/nodejs/node/pull/36647/commits/57f11caf06b7d3d41f83cbad9cf4c7e4f5fb2b6a
57f11cahttps://github.com/nodejs/node/pull/36647/commits/57f11caf06b7d3d41f83cbad9cf4c7e4f5fb2b6a
55e83cbhttps://github.com/dnlup/node/commit/55e83cbe957de2c752521557ffd74d4496fa8b81
6120028https://github.com/dnlup/node/commit/6120028ee3ca88d009c62711a225b1af7fad1919
70eaf55https://github.com/dnlup/node/commit/70eaf55a9d2da25742df79a862edf16f122fdfbb
5ae9690https://github.com/dnlup/node/commit/5ae96908696b7a017df3efb48ec1f8c8be5c24b8
f20a88fhttps://github.com/dnlup/node/commit/f20a88fb866917d7dd489b88c233a5e123ff3271
a6bf74ehttps://github.com/dnlup/node/commit/a6bf74eac00516fd0767b585c8f304857dddd2aa
8154e47https://github.com/dnlup/node/commit/8154e47e2b407a906f2c1270e5fc76fe466cc886
nodejs#33035 (comment)https://github.com/nodejs/node/pull/33035#issuecomment-751476367
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
v15.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av15.x
Dec 27, 2020https://github.com/nodejs/node/pull/36647#event-4150549096
https://github.com/dnlup
dnluphttps://github.com/dnlup
Dec 27, 2020 https://github.com/nodejs/node/pull/36647#ref-pullrequest-606092465
http: use autoDestroy: true in incoming message #33035 https://github.com/nodejs/node/pull/33035
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 27, 2020 https://github.com/nodejs/node/pull/36647#pullrequestreview-558956063
View reviewed changes https://github.com/nodejs/node/pull/36647/files/57f11caf06b7d3d41f83cbad9cf4c7e4f5fb2b6a
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
December 27, 2020 20:06https://github.com/nodejs/node/pull/36647#event-4150550598
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 27, 2020https://github.com/nodejs/node/pull/36647#issuecomment-751510344
Please reload this pagehttps://github.com/nodejs/node/pull/36647
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 27, 2020 https://github.com/nodejs/node/pull/36647#pullrequestreview-558958731
View reviewed changes https://github.com/nodejs/node/pull/36647/files/57f11caf06b7d3d41f83cbad9cf4c7e4f5fb2b6a
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/36647#pullrequestreview-558958731
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36647
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 28, 2020 https://github.com/nodejs/node/pull/36647#pullrequestreview-558978984
View reviewed changes https://github.com/nodejs/node/pull/36647/files/57f11caf06b7d3d41f83cbad9cf4c7e4f5fb2b6a
https://github.com/devinivy
devinivyhttps://github.com/devinivy
Dec 28, 2020 https://github.com/nodejs/node/pull/36647#ref-issue-774966858
Crashes upon request on Node.js v15.5.0 hapijs/hapi#4208 https://github.com/hapijs/hapi/issues/4208
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 28, 2020https://github.com/nodejs/node/pull/36647#event-4151355913
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 28, 2020https://github.com/nodejs/node/pull/36647#event-4151385338
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 28, 2020https://github.com/nodejs/node/pull/36647#issuecomment-751633049
https://ci.nodejs.org/job/node-test-pull-request/35111/https://ci.nodejs.org/job/node-test-pull-request/35111/
Please reload this pagehttps://github.com/nodejs/node/pull/36647
MylesBorinshttps://github.com/MylesBorins
Jan 5, 2021 https://github.com/nodejs/node/pull/36647#ref-commit-c784f15
https://github.com/dnlup
https://github.com/MylesBorins
Revert "http: use autoDestroy: true in incoming message"https://github.com/nodejs/node/commit/c784f15588bf659d0301fea1ba3587748c03f0bb
c784f15https://github.com/nodejs/node/commit/c784f15588bf659d0301fea1ba3587748c03f0bb
55e83cbhttps://github.com/nodejs/node/commit/55e83cbe957de2c752521557ffd74d4496fa8b81
6120028https://github.com/nodejs/node/commit/6120028ee3ca88d009c62711a225b1af7fad1919
70eaf55https://github.com/nodejs/node/commit/70eaf55a9d2da25742df79a862edf16f122fdfbb
5ae9690https://github.com/nodejs/node/commit/5ae96908696b7a017df3efb48ec1f8c8be5c24b8
f20a88fhttps://github.com/nodejs/node/commit/f20a88fb866917d7dd489b88c233a5e123ff3271
a6bf74ehttps://github.com/nodejs/node/commit/a6bf74eac00516fd0767b585c8f304857dddd2aa
8154e47https://github.com/nodejs/node/commit/8154e47e2b407a906f2c1270e5fc76fe466cc886
#33035 (comment)https://github.com/nodejs/node/pull/33035#issuecomment-751476367
#36647https://github.com/nodejs/node/pull/36647
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 5, 2021https://github.com/nodejs/node/pull/36647#issuecomment-754741162
c784f15https://github.com/nodejs/node/commit/c784f15588bf659d0301fea1ba3587748c03f0bb
Please reload this pagehttps://github.com/nodejs/node/pull/36647
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 5, 2021https://github.com/nodejs/node/pull/36647#event-4170691217
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Jan 5, 2021https://github.com/nodejs/node/pull/36647#event-4170692552
https://github.com/dnlup
dnluphttps://github.com/dnlup
January 5, 2021 16:23https://github.com/nodejs/node/pull/36647#event-4170697048
https://github.com/dnlup
dnluphttps://github.com/dnlup
Jan 12, 2021 https://github.com/nodejs/node/pull/36647#ref-pullrequest-780713832
http: align with stream.Writable #36816 https://github.com/nodejs/node/pull/36816
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Jan 12, 2021 https://github.com/nodejs/node/pull/36647#ref-pullrequest-784259248
v15.6.0 proposal #36889 https://github.com/nodejs/node/pull/36889
https://github.com/targos
targoshttps://github.com/targos
Jun 5, 2021 https://github.com/nodejs/node/pull/36647#ref-issue-911189070
Undocumented breaking change on v16.0.0 #38924 https://github.com/nodejs/node/issues/38924
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36647
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/36647/files/57f11caf06b7d3d41f83cbad9cf4c7e4f5fb2b6a
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/36647/files/57f11caf06b7d3d41f83cbad9cf4c7e4f5fb2b6a
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/36647/files/57f11caf06b7d3d41f83cbad9cf4c7e4f5fb2b6a
Please reload this pagehttps://github.com/nodejs/node/pull/36647
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/36647
https://github.com/dnlup
https://github.com/ronag
https://github.com/nodejs-github-bot
https://github.com/MylesBorins
https://github.com/mcollina
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.