René's URL Explorer Experiment


Title: http: don't cork noop .end() by ronag · Pull Request #36633 · nodejs/node · GitHub

Open Graph Title: http: don't cork noop .end() by ronag · Pull Request #36633 · nodejs/node

X Title: http: don't cork noop .end() by ronag · Pull Request #36633 · nodejs/node

Description: Calling .end() a second time should be a noop and not leave the socket corked. Fixes: #36620 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are includ...

Open Graph Description: Calling .end() a second time should be a noop and not leave the socket corked. Fixes: #36620 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are includ...

X Description: Calling .end() a second time should be a noop and not leave the socket corked. Fixes: #36620 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are includ...

Opengraph URL: https://github.com/nodejs/node/pull/36633

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0472cf42-209d-749e-3818-08a7f00ebfdf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB34:DE287:27A8A9E:344CA8F:696B26D5
html-safe-nonce675e0db2ae5098403af88fd0ea8a722ed15935aa3f20c64077377cde06d534f8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjM0OkRFMjg3OjI3QThBOUU6MzQ0Q0E4Rjo2OTZCMjZENSIsInZpc2l0b3JfaWQiOiI2MzQ3MjM2MjIzODA1NDk5MDkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacde2ca12ce7d2966647345af293cc9de6b6144aec249e6b3c851ecfe4febb3ce5
hovercard-subject-tagpull_request:545678614
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36633/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c786af87642abfeb9d5d6bfe17c8965896f430466ac6e702f4cbcef905a53f6a/nodejs/node/pull/36633
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c786af87642abfeb9d5d6bfe17c8965896f430466ac6e702f4cbcef905a53f6a/nodejs/node/pull/36633
og:image:altCalling .end() a second time should be a noop and not leave the socket corked. Fixes: #36620 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are includ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameronag
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36633#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36633
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36633
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36633
Reloadhttps://github.com/nodejs/node/pull/36633
Reloadhttps://github.com/nodejs/node/pull/36633
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36633
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/36633
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/36633#issue-comment-box
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-36620https://github.com/nxtedition/node/tree/fix-36620
http: don't cork noop .end() https://github.com/nodejs/node/pull/36633#top
ronaghttps://github.com/ronag
nodejs:masterhttps://github.com/nodejs/node/tree/master
nxtedition:fix-36620https://github.com/nxtedition/node/tree/fix-36620
Conversation 32 https://github.com/nodejs/node/pull/36633
Commits 2 https://github.com/nodejs/node/pull/36633/commits
Checks 0 https://github.com/nodejs/node/pull/36633/checks
Files changed https://github.com/nodejs/node/pull/36633/files
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 26, 2020https://github.com/nodejs/node/pull/36633#issue-774852844
#36620https://github.com/nodejs/node/issues/36620
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Dec 26, 2020https://github.com/nodejs/node/pull/36633#event-4149521904
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/45984ac501ca1ad3b10b86a5b0227f07707bc524..4cc48de47eac336c976198c023fde99b8ad2910f
45984achttps://github.com/nodejs/node/commit/45984ac501ca1ad3b10b86a5b0227f07707bc524
4cc48dehttps://github.com/nodejs/node/commit/4cc48de47eac336c976198c023fde99b8ad2910f
Compare https://github.com/nodejs/node/compare/45984ac501ca1ad3b10b86a5b0227f07707bc524..4cc48de47eac336c976198c023fde99b8ad2910f
December 26, 2020 10:13https://github.com/nodejs/node/pull/36633#event-4149522177
https://github.com/ronag
ronaghttps://github.com/ronag
mcollinahttps://github.com/mcollina
rickyeshttps://github.com/rickyes
December 26, 2020 10:13https://github.com/nodejs/node/pull/36633#event-4149522522
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 26, 2020https://github.com/nodejs/node/pull/36633#issuecomment-751341896
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
ronaghttps://github.com/ronag
v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av14.x
v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av14.x
Dec 26, 2020https://github.com/nodejs/node/pull/36633#event-4149525526
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 26, 2020https://github.com/nodejs/node/pull/36633#issuecomment-751344976
@kachkaevhttps://github.com/kachkaev
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 26, 2020 https://github.com/nodejs/node/pull/36633#pullrequestreview-558863029
View reviewed changes https://github.com/nodejs/node/pull/36633/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/36633#pullrequestreview-558863029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36633
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/36633/files#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/kachkaev
kachkaevhttps://github.com/kachkaev
Dec 26, 2020https://github.com/nodejs/node/pull/36633#issuecomment-751362960
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 26, 2020https://github.com/nodejs/node/pull/36633#issuecomment-751363093
@kachkaevhttps://github.com/kachkaev
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 26, 2020https://github.com/nodejs/node/pull/36633#issuecomment-751363643
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 26, 2020https://github.com/nodejs/node/pull/36633#issuecomment-751388049
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 26, 2020https://github.com/nodejs/node/pull/36633#issuecomment-751389257
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Dec 26, 2020 https://github.com/nodejs/node/pull/36633#pullrequestreview-558893785
View reviewed changes https://github.com/nodejs/node/pull/36633/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/36633#pullrequestreview-558893785
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
ronaghttps://github.com/ronag
v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av14.x
Dec 27, 2020https://github.com/nodejs/node/pull/36633#event-4150613850
https://github.com/ronag
ronaghttps://github.com/ronag
Dec 27, 2020https://github.com/nodejs/node/pull/36633#issuecomment-751520631
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/kachkaev
kachkaevhttps://github.com/kachkaev
Dec 27, 2020 https://github.com/nodejs/node/pull/36633#ref-issue-775109072
Calling .end on an already finished http response leaves the socket instance corked #36650 https://github.com/nodejs/node/issues/36650
https://github.com/mitsos1os
mitsos1oshttps://github.com/mitsos1os
Dec 27, 2020 https://github.com/nodejs/node/pull/36633#pullrequestreview-558963159
View reviewed changes https://github.com/nodejs/node/pull/36633/files
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/36633/files#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/mitsos1os
mitsos1oshttps://github.com/mitsos1os
Dec 28, 2020 https://github.com/nodejs/node/pull/36633#pullrequestreview-559260317
View reviewed changes https://github.com/nodejs/node/pull/36633/files
lib/_http_outgoing.jshttps://github.com/nodejs/node/pull/36633/files#diff-48d21edbddb6e855d1ee5716c49bcdc0d913c11ee8a24a98ea7dbc60cd253556
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/kachkaev
kachkaevhttps://github.com/kachkaev
Jan 4, 2021 https://github.com/nodejs/node/pull/36633#ref-pullrequest-774557800
Call res.write('') inside apiRes.redirect() helper to prevent an edge case vercel/next.js#20461 https://github.com/vercel/next.js/pull/20461
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v14.x
Jan 5, 2021https://github.com/nodejs/node/pull/36633#event-4170694306
https://github.com/mitsos1os
mitsos1oshttps://github.com/mitsos1os
Jan 8, 2021https://github.com/nodejs/node/pull/36633#issuecomment-756716538
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 8, 2021https://github.com/nodejs/node/pull/36633#issuecomment-756785682
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 9, 2021https://github.com/nodejs/node/pull/36633#issuecomment-757274868
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/mitsos1os
mitsos1oshttps://github.com/mitsos1os
Jan 9, 2021https://github.com/nodejs/node/pull/36633#issuecomment-757319966
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 9, 2021https://github.com/nodejs/node/pull/36633#issuecomment-757326199
Please reload this pagehttps://github.com/nodejs/node/pull/36633
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 10, 2021https://github.com/nodejs/node/pull/36633#issuecomment-757553139
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 10, 2021 https://github.com/nodejs/node/pull/36633#pullrequestreview-564905953
View reviewed changes https://github.com/nodejs/node/pull/36633/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/36633#pullrequestreview-564905953
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 11, 2021https://github.com/nodejs/node/pull/36633#issuecomment-757653379
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 11, 2021https://github.com/nodejs/node/pull/36633#issuecomment-758084610
https://ci.nodejs.org/job/node-test-pull-request/35448/https://ci.nodejs.org/job/node-test-pull-request/35448/
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/kachkaev
kachkaevhttps://github.com/kachkaev
Jan 11, 2021https://github.com/nodejs/node/pull/36633#issuecomment-758146718
Please reload this pagehttps://github.com/nodejs/node/pull/36633
@mcollinahttps://github.com/mcollina
@ronaghttps://github.com/ronag
https://github.com/kachkaev/node-http-response-double-end-call-breaking-drain-event/runs/1606418629https://github.com/kachkaev/node-http-response-double-end-call-breaking-drain-event/runs/1606418629
#36633https://github.com/nodejs/node/pull/36633
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/mcollina
mcollinahttps://github.com/mcollina
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Jan 11, 2021https://github.com/nodejs/node/pull/36633#event-4193077489
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jan 11, 2021https://github.com/nodejs/node/pull/36633#issuecomment-758263480
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Jan 12, 2021 https://github.com/nodejs/node/pull/36633#pullrequestreview-565862611
View reviewed changes https://github.com/nodejs/node/pull/36633/files
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Jan 12, 2021https://github.com/nodejs/node/pull/36633#issuecomment-758370496
Please reload this pagehttps://github.com/nodejs/node/pull/36633
@ronaghttps://github.com/ronag
bb17da1https://github.com/nodejs/node/commit/bb17da11bf24b498225b61c96f3fc92e515a9325
085bb3ahttps://github.com/nodejs/node/commit/085bb3abe5265ed1a01c27283478cb1fc9abdaa4
Please reload this pagehttps://github.com/nodejs/node/pull/36633
ronaghttps://github.com/ronag
January 12, 2021 10:58https://github.com/nodejs/node/pull/36633#commits-pushed-174fa33
https://github.com/ronag
http: don't cork noop .end()https://github.com/nodejs/node/pull/36633/commits/174fa33ec941b44325eb275710f15b639f7c7522
174fa33https://github.com/nodejs/node/pull/36633/commits/174fa33ec941b44325eb275710f15b639f7c7522
nodejs#36620https://github.com/nodejs/node/issues/36620
https://github.com/mitsos1os
https://github.com/ronag
test: http complete response after socket double endhttps://github.com/nodejs/node/pull/36633/commits/340a0169dc00d6e0a374e7ea82397253ddee11cd
340a016https://github.com/nodejs/node/pull/36633/commits/340a0169dc00d6e0a374e7ea82397253ddee11cd
https://github.com/ronag
ronaghttps://github.com/ronag
force-pushedhttps://github.com/nodejs/node/compare/76677af4fe3bd13c4657cfc4bf71e78f36bdbc27..340a0169dc00d6e0a374e7ea82397253ddee11cd
76677afhttps://github.com/nodejs/node/commit/76677af4fe3bd13c4657cfc4bf71e78f36bdbc27
340a016https://github.com/nodejs/node/commit/340a0169dc00d6e0a374e7ea82397253ddee11cd
Compare https://github.com/nodejs/node/compare/76677af4fe3bd13c4657cfc4bf71e78f36bdbc27..340a0169dc00d6e0a374e7ea82397253ddee11cd
January 12, 2021 09:59https://github.com/nodejs/node/pull/36633#event-4195002788
ronaghttps://github.com/ronag
Jan 12, 2021 https://github.com/nodejs/node/pull/36633#ref-commit-1b669b2
https://github.com/ronag
http: don't cork noop .end()https://github.com/nodejs/node/commit/1b669b2c12a53ede6a0cfa0462b47e867ea456c3
1b669b2https://github.com/nodejs/node/commit/1b669b2c12a53ede6a0cfa0462b47e867ea456c3
#36620https://github.com/nodejs/node/issues/36620
#36633https://github.com/nodejs/node/pull/36633
ronaghttps://github.com/ronag
Jan 12, 2021 https://github.com/nodejs/node/pull/36633#ref-commit-ec794f9
https://github.com/mitsos1os
https://github.com/ronag
test: http complete response after socket double endhttps://github.com/nodejs/node/commit/ec794f9796d089c2124c1d0b83efcdc938e548c3
ec794f9https://github.com/nodejs/node/commit/ec794f9796d089c2124c1d0b83efcdc938e548c3
#36633https://github.com/nodejs/node/pull/36633
#36620https://github.com/nodejs/node/issues/36620
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 12, 2021https://github.com/nodejs/node/pull/36633#issuecomment-758545573
2af43f6...ec794f9https://github.com/nodejs/node/compare/2af43f65055de2817eb7907d3a3d3b3a3de127f5...ec794f9796d089c2124c1d0b83efcdc938e548c3
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
ronaghttps://github.com/ronag
Jan 12, 2021https://github.com/nodejs/node/pull/36633#event-4195013134
danielleadamshttps://github.com/danielleadams
Jan 12, 2021 https://github.com/nodejs/node/pull/36633#ref-commit-a9a2dd3
https://github.com/ronag
https://github.com/danielleadams
http: don't cork noop .end()https://github.com/nodejs/node/commit/a9a2dd32e324a082e4d59d7d68f3c416feea2380
a9a2dd3https://github.com/nodejs/node/commit/a9a2dd32e324a082e4d59d7d68f3c416feea2380
#36620https://github.com/nodejs/node/issues/36620
#36633https://github.com/nodejs/node/pull/36633
danielleadamshttps://github.com/danielleadams
Jan 12, 2021 https://github.com/nodejs/node/pull/36633#ref-commit-17a5233
https://github.com/mitsos1os
https://github.com/danielleadams
test: http complete response after socket double endhttps://github.com/nodejs/node/commit/17a52337c467f89f030629e147ac75c56e7579bc
17a5233https://github.com/nodejs/node/commit/17a52337c467f89f030629e147ac75c56e7579bc
#36633https://github.com/nodejs/node/pull/36633
#36620https://github.com/nodejs/node/issues/36620
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Jan 12, 2021 https://github.com/nodejs/node/pull/36633#ref-pullrequest-784259248
v15.6.0 proposal #36889 https://github.com/nodejs/node/pull/36889
mitsos1oshttps://github.com/mitsos1os
Jan 15, 2021 https://github.com/nodejs/node/pull/36633#ref-commit-71aed6b
https://github.com/mitsos1os
test: http complete response after socket double endhttps://github.com/mitsos1os/node/commit/71aed6b384c4cc4dcf681f4be0f0f884e81bb7c6
71aed6bhttps://github.com/mitsos1os/node/commit/71aed6b384c4cc4dcf681f4be0f0f884e81bb7c6
nodejs#36633https://github.com/nodejs/node/pull/36633
nodejs#36620https://github.com/nodejs/node/issues/36620
ec794f9https://github.com/mitsos1os/node/commit/ec794f9796d089c2124c1d0b83efcdc938e548c3
https://github.com/mitsos1os
mitsos1oshttps://github.com/mitsos1os
Jan 15, 2021 https://github.com/nodejs/node/pull/36633#ref-pullrequest-786780251
[v14.x Backport] http: don't cork noop .end() #36940 https://github.com/nodejs/node/pull/36940
https://github.com/mitsos1os
mitsos1oshttps://github.com/mitsos1os
Jan 15, 2021https://github.com/nodejs/node/pull/36633#issuecomment-760948274
#36940https://github.com/nodejs/node/pull/36940
Please reload this pagehttps://github.com/nodejs/node/pull/36633
BethGriggshttps://github.com/BethGriggs
Jan 26, 2021 https://github.com/nodejs/node/pull/36633#ref-commit-f002f23
https://github.com/mitsos1os
https://github.com/BethGriggs
test: http complete response after socket double endhttps://github.com/nodejs/node/commit/f002f236bb210f5db4b286705de5922da40be7a9
f002f23https://github.com/nodejs/node/commit/f002f236bb210f5db4b286705de5922da40be7a9
#36633https://github.com/nodejs/node/pull/36633
#36940https://github.com/nodejs/node/pull/36940
#36620https://github.com/nodejs/node/issues/36620
BethGriggshttps://github.com/BethGriggs
Jan 26, 2021 https://github.com/nodejs/node/pull/36633#ref-commit-5593187
https://github.com/mitsos1os
https://github.com/BethGriggs
http: don't cork .end when not neededhttps://github.com/nodejs/node/commit/559318719e0a6a5bdffabb7f88868ee369a864fe
5593187https://github.com/nodejs/node/commit/559318719e0a6a5bdffabb7f88868ee369a864fe
#36633https://github.com/nodejs/node/pull/36633
#36940https://github.com/nodejs/node/pull/36940
#36620https://github.com/nodejs/node/issues/36620
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Jan 26, 2021 https://github.com/nodejs/node/pull/36633#ref-pullrequest-794173614
v14.15.5 proposal #37074 https://github.com/nodejs/node/pull/37074
BethGriggshttps://github.com/BethGriggs
Jan 28, 2021 https://github.com/nodejs/node/pull/36633#ref-commit-c03cddb
https://github.com/mitsos1os
https://github.com/BethGriggs
test: http complete response after socket double endhttps://github.com/nodejs/node/commit/c03cddb46f34b653482e20db343a605d4aa40d1b
c03cddbhttps://github.com/nodejs/node/commit/c03cddb46f34b653482e20db343a605d4aa40d1b
#36633https://github.com/nodejs/node/pull/36633
#36940https://github.com/nodejs/node/pull/36940
#36620https://github.com/nodejs/node/issues/36620
BethGriggshttps://github.com/BethGriggs
Jan 28, 2021 https://github.com/nodejs/node/pull/36633#ref-commit-25a3204
https://github.com/mitsos1os
https://github.com/BethGriggs
http: don't cork .end when not neededhttps://github.com/nodejs/node/commit/25a3204fe29a8470f5a90a6bf424059757a09363
25a3204https://github.com/nodejs/node/commit/25a3204fe29a8470f5a90a6bf424059757a09363
#36633https://github.com/nodejs/node/pull/36633
#36940https://github.com/nodejs/node/pull/36940
#36620https://github.com/nodejs/node/issues/36620
https://github.com/targos
targoshttps://github.com/targos
backported-to-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v14.x
lts-watch-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v14.x
Apr 25, 2021https://github.com/nodejs/node/pull/36633#event-4640758290
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36633
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/36633/files/76677af4fe3bd13c4657cfc4bf71e78f36bdbc27
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/36633/files/4cc48de47eac336c976198c023fde99b8ad2910f
https://github.com/rickyes
rickyes https://github.com/rickyes
https://github.com/mitsos1os
mitsos1os https://github.com/mitsos1os
https://github.com/nodejs/node/pull/36633/files/3947f0ea285c9693bd642a987c82da99c1e68338
https://github.com/danielleadams
danielleadams https://github.com/danielleadams
https://github.com/nodejs/node/pull/36633/files/76677af4fe3bd13c4657cfc4bf71e78f36bdbc27
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Calling res.end() twice stalls follow-up HTTP request (drain event is missing) https://github.com/nodejs/node/issues/36620
Please reload this pagehttps://github.com/nodejs/node/pull/36633
https://github.com/ronag
https://github.com/kachkaev
https://github.com/mcollina
https://github.com/mitsos1os
https://github.com/nodejs-github-bot
https://github.com/danielleadams
https://github.com/benjamingr
https://github.com/MylesBorins
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.