René's URL Explorer Experiment


Title: repl: refactor to avoid unsafe array iteration by RaisinTen · Pull Request #36444 · nodejs/node · GitHub

Open Graph Title: repl: refactor to avoid unsafe array iteration by RaisinTen · Pull Request #36444 · nodejs/node

X Title: repl: refactor to avoid unsafe array iteration by RaisinTen · Pull Request #36444 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This was the only for-let-of loop in lib so I'm trying to make it more consistent with the other for loops. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message ...

X Description: This was the only for-let-of loop in lib so I'm trying to make it more consistent with the other for loops. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit mess...

Opengraph URL: https://github.com/nodejs/node/pull/36444

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:584a1b3d-4e70-4ad3-dcd4-adead965426b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EEA:151FE8:8CA06:10E1AD:6A50B565
html-safe-nonce6b4b8fd418ea718e82d13245936f3be2c07890c9a851324f367d65ee019222bd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUVBOjE1MUZFODo4Q0EwNjoxMEUxQUQ6NkE1MEI1NjUiLCJ2aXNpdG9yX2lkIjoiODA4NTgzOTE5NDU2NzkzOTU3IiwicmVnaW9uX2VkZ2UiOiJ3ZXN0dXMyIiwicmVnaW9uX3JlbmRlciI6Indlc3R1czIifQ==
visitor-hmac69d4d4eefc57249e56f3494a35df4399e4ff2885103d444b107a989b447be28b
hovercard-subject-tagpull_request:534439623
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36444/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0bb1370d2f36d98a3349ae5ecf6f082d5a30e4b69b5bfd64c188b58f3eede308/nodejs/node/pull/36444
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0bb1370d2f36d98a3349ae5ecf6f082d5a30e4b69b5bfd64c188b58f3eede308/nodejs/node/pull/36444
og:image:altThis was the only for-let-of loop in lib so I'm trying to make it more consistent with the other for loops. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRaisinTen
hostnamegithub.com
expected-hostnamegithub.com
None63772747707af4093f0d5fc7aa1bb3bb55f412a9865207c4f421aa34c64cc404
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseded53fe94e3ff1bb4dbf8cc77e285396c92580fb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36444#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36444
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36444
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36444
Reloadhttps://github.com/nodejs/node/pull/36444
Reloadhttps://github.com/nodejs/node/pull/36444
Please reload this pagehttps://github.com/nodejs/node/pull/36444
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36444
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 979 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
RaisinTenhttps://github.com/RaisinTen
nodejs:masterhttps://github.com/nodejs/node/tree/master
RaisinTen:lib/refactor-to-remove-for-of-loop-with-let-in-repl.jshttps://github.com/RaisinTen/node/tree/lib/refactor-to-remove-for-of-loop-with-let-in-repl.js
Conversationhttps://github.com/nodejs/node/pull/36444
Commits20 (20)https://github.com/nodejs/node/pull/36444/commits
Checkshttps://github.com/nodejs/node/pull/36444/checks
Files changedhttps://github.com/nodejs/node/pull/36444/files
repl: refactor to avoid unsafe array iterationhttps://github.com/nodejs/node/pull/36444#top
RaisinTenhttps://github.com/RaisinTen
nodejs:masterhttps://github.com/nodejs/node/tree/master
RaisinTen:lib/refactor-to-remove-for-of-loop-with-let-in-repl.jshttps://github.com/RaisinTen/node/tree/lib/refactor-to-remove-for-of-loop-with-let-in-repl.js
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 8, 2020https://github.com/nodejs/node/pull/36444#issue-759432317
Please reload this pagehttps://github.com/nodejs/node/pull/36444
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
lib: refactor to remove for-let-of loop in repl.jshttps://github.com/nodejs/node/pull/36444/commits/b81f4480a3870dc1c8a214376d19da7e80b39285
b81f448https://github.com/nodejs/node/pull/36444/commits/b81f4480a3870dc1c8a214376d19da7e80b39285
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Dec 8, 2020https://github.com/nodejs/node/pull/36444#event-4084693860
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
December 8, 2020 14:18https://github.com/nodejs/node/pull/36444#event-4084995261
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 8, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-547376620
View reviewed changes https://github.com/nodejs/node/pull/36444/files/b81f4480a3870dc1c8a214376d19da7e80b39285
aduh95https://github.com/aduh95
https://github.com/nodejs/node/pull/36444#pullrequestreview-547376620
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 8, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-547377409
View reviewed changes https://github.com/nodejs/node/pull/36444/files/b81f4480a3870dc1c8a214376d19da7e80b39285
lib/repl.jshttps://github.com/nodejs/node/pull/36444/files/b81f4480a3870dc1c8a214376d19da7e80b39285#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 9, 2020https://github.com/nodejs/node/pull/36444#issuecomment-741752026
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 9, 2020https://github.com/nodejs/node/pull/36444#issuecomment-741815013
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 9, 2020https://github.com/nodejs/node/pull/36444#issuecomment-741826283
Please reload this pagehttps://github.com/nodejs/node/pull/36444
RaisinTenhttps://github.com/RaisinTen
December 10, 2020 20:58https://github.com/nodejs/node/pull/36444#commits-pushed-f5d6c33
https://github.com/RaisinTen
https://github.com/aduh95
Apply suggestion from code reviewhttps://github.com/nodejs/node/pull/36444/commits/f5d6c3394b6a10b0a982c4b73cc6c96c2d7874b9
f5d6c33https://github.com/nodejs/node/pull/36444/commits/f5d6c3394b6a10b0a982c4b73cc6c96c2d7874b9
https://github.com/RaisinTen
lib: require ArrayPrototypeForEach in repl.jshttps://github.com/nodejs/node/pull/36444/commits/b6b3c5b1d1c64922b0d785e32cc43597b2648ba9
b6b3c5bhttps://github.com/nodejs/node/pull/36444/commits/b6b3c5b1d1c64922b0d785e32cc43597b2648ba9
https://github.com/RaisinTen
lib: fix syntax error repl.jshttps://github.com/nodejs/node/pull/36444/commits/0a167a11b781f2193fe0bba8a7f8eee08bb8ac95
0a167a1https://github.com/nodejs/node/pull/36444/commits/0a167a11b781f2193fe0bba8a7f8eee08bb8ac95
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
December 10, 2020 15:40https://github.com/nodejs/node/pull/36444#event-4095768078
RaisinTenhttps://github.com/RaisinTen
December 10, 2020 21:12https://github.com/nodejs/node/pull/36444#commits-pushed-3a9491e
https://github.com/RaisinTen
lib: replace another loop repl.jshttps://github.com/nodejs/node/pull/36444/commits/3a9491ee5920f3f9f7159e106f51fae7b81a71b0
3a9491ehttps://github.com/nodejs/node/pull/36444/commits/3a9491ee5920f3f9f7159e106f51fae7b81a71b0
https://github.com/RaisinTen
lib: fix lint error repl.jshttps://github.com/nodejs/node/pull/36444/commits/846ac65cd7a5c8450514bc578f4657ed4bf590eb
846ac65https://github.com/nodejs/node/pull/36444/commits/846ac65cd7a5c8450514bc578f4657ed4bf590eb
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 10, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-549474764
View reviewed changes https://github.com/nodejs/node/pull/36444/files/846ac65cd7a5c8450514bc578f4657ed4bf590eb
lib/repl.jshttps://github.com/nodejs/node/pull/36444/files/846ac65cd7a5c8450514bc578f4657ed4bf590eb#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047
Please reload this pagehttps://github.com/nodejs/node/pull/36444
RaisinTenhttps://github.com/RaisinTen
December 11, 2020 18:46https://github.com/nodejs/node/pull/36444#commits-pushed-9367f9b
https://github.com/RaisinTen
https://github.com/aduh95
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/36444/commits/9367f9b6dcec01c62cf6e589cf82fce87dd42b5b
9367f9bhttps://github.com/nodejs/node/pull/36444/commits/9367f9b6dcec01c62cf6e589cf82fce87dd42b5b
https://github.com/RaisinTen
lib: replace all for loops with ArrayPrototypeForEach in repl.jshttps://github.com/nodejs/node/pull/36444/commits/61cb3b7fb1809d645829950c3efacc7776141b1c
61cb3b7https://github.com/nodejs/node/pull/36444/commits/61cb3b7fb1809d645829950c3efacc7776141b1c
https://github.com/RaisinTen
lib: fix syntax error repl.jshttps://github.com/nodejs/node/pull/36444/commits/10c1759567e5e34a214c5d9bfb874af3b8caee5d
10c1759https://github.com/nodejs/node/pull/36444/commits/10c1759567e5e34a214c5d9bfb874af3b8caee5d
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 11, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-550112190
View reviewed changes https://github.com/nodejs/node/pull/36444/files/10c1759567e5e34a214c5d9bfb874af3b8caee5d
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/36444#pullrequestreview-550112190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 11, 2020https://github.com/nodejs/node/pull/36444#issuecomment-743211263
@BridgeARhttps://github.com/BridgeAR
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
lib: fix lint errorhttps://github.com/nodejs/node/pull/36444/commits/669f93e109e12db874b2a6d9e1c099fe436895c7
669f93ehttps://github.com/nodejs/node/pull/36444/commits/669f93e109e12db874b2a6d9e1c099fe436895c7
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 11, 2020https://github.com/nodejs/node/pull/36444#issuecomment-743213755
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 11, 2020https://github.com/nodejs/node/pull/36444#issuecomment-743214618
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
lib: replace ArrayPrototypeSort with ArrayPrototypeForEach in repl.jshttps://github.com/nodejs/node/pull/36444/commits/dc678b029ccb5c7ecc72228c5a7727c3bc01db3d
dc678b0https://github.com/nodejs/node/pull/36444/commits/dc678b029ccb5c7ecc72228c5a7727c3bc01db3d
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 17, 2020https://github.com/nodejs/node/pull/36444#issuecomment-747447248
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 17, 2020https://github.com/nodejs/node/pull/36444#event-4125306410
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 17, 2020https://github.com/nodejs/node/pull/36444#issuecomment-747468550
https://github.com/nodejs/node/blob/9997aebf65f72246106c3d77f093a24b1aeda642/test/parallel/test-require-delete-array-iterator.jshttps://github.com/nodejs/node/blob/9997aebf65f72246106c3d77f093a24b1aeda642/test/parallel/test-require-delete-array-iterator.js
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
test: add unsafe array iteration test to replhttps://github.com/nodejs/node/pull/36444/commits/ddfbfc4a367728ea0489287b1528346440736ccf
ddfbfc4https://github.com/nodejs/node/pull/36444/commits/ddfbfc4a367728ea0489287b1528346440736ccf
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 18, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-555564220
View reviewed changes https://github.com/nodejs/node/pull/36444/files/ddfbfc4a367728ea0489287b1528346440736ccf
test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/files/dc678b029ccb5c7ecc72228c5a7727c3bc01db3d..ddfbfc4a367728ea0489287b1528346440736ccf#diff-3976ee06716bcfdb17b22f76b1a7c1c77b153e0368aebda7b801d40666154c76
aduh95https://github.com/aduh95
Dec 18, 2020https://github.com/nodejs/node/pull/36444#discussion_r545890198
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36444
RaisinTenhttps://github.com/RaisinTen
Dec 18, 2020https://github.com/nodejs/node/pull/36444#discussion_r545906647
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36444
test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/files/dc678b029ccb5c7ecc72228c5a7727c3bc01db3d..ddfbfc4a367728ea0489287b1528346440736ccf#diff-3976ee06716bcfdb17b22f76b1a7c1c77b153e0368aebda7b801d40666154c76
aduh95https://github.com/aduh95
Dec 18, 2020https://github.com/nodejs/node/pull/36444#discussion_r545890707
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
test: add notStrictEqual check instead for repl.jshttps://github.com/nodejs/node/pull/36444/commits/77a6be5dc84f430f536a7a0aad4de9231b3ca81b
77a6be5https://github.com/nodejs/node/pull/36444/commits/77a6be5dc84f430f536a7a0aad4de9231b3ca81b
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 18, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-555590370
View reviewed changes https://github.com/nodejs/node/pull/36444/files/77a6be5dc84f430f536a7a0aad4de9231b3ca81b
test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/files/77a6be5dc84f430f536a7a0aad4de9231b3ca81b#diff-3976ee06716bcfdb17b22f76b1a7c1c77b153e0368aebda7b801d40666154c76
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
https://github.com/aduh95
Update test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/commits/6c199913c0230b97d83547f09009b2f549eca493
6c19991https://github.com/nodejs/node/pull/36444/commits/6c199913c0230b97d83547f09009b2f549eca493
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 18, 2020https://github.com/nodejs/node/pull/36444#issuecomment-748164263
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 18, 2020https://github.com/nodejs/node/pull/36444#issuecomment-748175696
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 18, 2020https://github.com/nodejs/node/pull/36444#issuecomment-748358027
#36428https://github.com/nodejs/node/pull/36428
#36532https://github.com/nodejs/node/pull/36532
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
test: add test using child_process insteadhttps://github.com/nodejs/node/pull/36444/commits/ccc860aaaab16bb6d65d6676215fed6759d1e451
https://github.com/nodejs/node/commit/ccc860aaaab16bb6d65d6676215fed6759d1e451#comments
ccc860ahttps://github.com/nodejs/node/pull/36444/commits/ccc860aaaab16bb6d65d6676215fed6759d1e451
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 19, 2020https://github.com/nodejs/node/pull/36444#issuecomment-748489099
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
test: remove error code checkhttps://github.com/nodejs/node/pull/36444/commits/81776d6e9b3d04cc1a5f544a2c3dcaf60722fdcd
81776d6https://github.com/nodejs/node/pull/36444/commits/81776d6e9b3d04cc1a5f544a2c3dcaf60722fdcd
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 19, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-555951235
View reviewed changes https://github.com/nodejs/node/pull/36444/files/81776d6e9b3d04cc1a5f544a2c3dcaf60722fdcd
test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/files/81776d6e9b3d04cc1a5f544a2c3dcaf60722fdcd#diff-3976ee06716bcfdb17b22f76b1a7c1c77b153e0368aebda7b801d40666154c76
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
https://github.com/aduh95
Update test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/commits/a45f1ed65e3f58d9cb996ead89003cfd1074e184
a45f1edhttps://github.com/nodejs/node/pull/36444/commits/a45f1ed65e3f58d9cb996ead89003cfd1074e184
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 19, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-555951636
View reviewed changes https://github.com/nodejs/node/pull/36444/files/a45f1ed65e3f58d9cb996ead89003cfd1074e184
test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/files/a45f1ed65e3f58d9cb996ead89003cfd1074e184#diff-3976ee06716bcfdb17b22f76b1a7c1c77b153e0368aebda7b801d40666154c76
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
https://github.com/aduh95
Update test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/commits/c61b0b9fbc84a830256659fc23948946868d2e83
c61b0b9https://github.com/nodejs/node/pull/36444/commits/c61b0b9fbc84a830256659fc23948946868d2e83
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 19, 2020https://github.com/nodejs/node/pull/36444#issuecomment-748494719
Please reload this pagehttps://github.com/nodejs/node/pull/36444
@RaisinTenhttps://github.com/RaisinTen
#36444 (comment)https://github.com/nodejs/node/pull/36444#issuecomment-748358027
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 19, 2020https://github.com/nodejs/node/pull/36444#issuecomment-748494727
ccc860ahttps://github.com/nodejs/node/commit/ccc860aaaab16bb6d65d6676215fed6759d1e451
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 19, 2020https://github.com/nodejs/node/pull/36444#issuecomment-748495048
ccc860ahttps://github.com/nodejs/node/commit/ccc860aaaab16bb6d65d6676215fed6759d1e451
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 19, 2020https://github.com/nodejs/node/pull/36444#issuecomment-748498740
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 19, 2020https://github.com/nodejs/node/pull/36444#issuecomment-748501347
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 19, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-555959655
View reviewed changes https://github.com/nodejs/node/pull/36444/files/c61b0b9fbc84a830256659fc23948946868d2e83
test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/files/c61b0b9fbc84a830256659fc23948946868d2e83#diff-3976ee06716bcfdb17b22f76b1a7c1c77b153e0368aebda7b801d40666154c76
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
https://github.com/aduh95
Update test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/commits/71350bd3ba21a17bc44b6ae1497df4ee2e422464
71350bdhttps://github.com/nodejs/node/pull/36444/commits/71350bd3ba21a17bc44b6ae1497df4ee2e422464
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 20, 2020 https://github.com/nodejs/node/pull/36444#pullrequestreview-556042954
View reviewed changes https://github.com/nodejs/node/pull/36444/files/71350bd3ba21a17bc44b6ae1497df4ee2e422464
test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/files/c61b0b9fbc84a830256659fc23948946868d2e83..71350bd3ba21a17bc44b6ae1497df4ee2e422464#diff-3976ee06716bcfdb17b22f76b1a7c1c77b153e0368aebda7b801d40666154c76
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
https://github.com/aduh95
Update test/parallel/test-repl-unsafe-array-iteration.jshttps://github.com/nodejs/node/pull/36444/commits/1ec7036d4ac0ea8b36de3b4550f5d11088f1b5a9
1ec7036https://github.com/nodejs/node/pull/36444/commits/1ec7036d4ac0ea8b36de3b4550f5d11088f1b5a9
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 22, 2020https://github.com/nodejs/node/pull/36444#issuecomment-749564790
@RaisinTenhttps://github.com/RaisinTen
#36444 (comment)https://github.com/nodejs/node/pull/36444#issuecomment-748358027
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 22, 2020https://github.com/nodejs/node/pull/36444#issuecomment-749596369
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/aduh95
aduh95https://github.com/aduh95
Dec 27, 2020https://github.com/nodejs/node/pull/36444#issuecomment-751527321
@RaisinTenhttps://github.com/RaisinTen
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 28, 2020https://github.com/nodejs/node/pull/36444#event-4152197064
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 28, 2020https://github.com/nodejs/node/pull/36444#issuecomment-751733192
@aduh95https://github.com/aduh95
#36663https://github.com/nodejs/node/pull/36663
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
December 28, 2020 14:38https://github.com/nodejs/node/pull/36444#event-4152199376
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36444
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/36444/files/10c1759567e5e34a214c5d9bfb874af3b8caee5d
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/36444/files/71350bd3ba21a17bc44b6ae1497df4ee2e422464
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
Please reload this pagehttps://github.com/nodejs/node/pull/36444
https://github.com/RaisinTen
https://github.com/aduh95
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.