René's URL Explorer Experiment


Title: tls: forward new SecureContext options by mildsunrise · Pull Request #36416 · nodejs/node · GitHub

Open Graph Title: tls: forward new SecureContext options by mildsunrise · Pull Request #36416 · nodejs/node

X Title: tls: forward new SecureContext options by mildsunrise · Pull Request #36416 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We have a few places where we individually forward each parameter to tls.createSecureContext(). In #28973 and others, we added new SecureContext options but forgot to keep these places up to date. ...

X Description: We have a few places where we individually forward each parameter to tls.createSecureContext(). In #28973 and others, we added new SecureContext options but forgot to keep these places up to date. ...

Opengraph URL: https://github.com/nodejs/node/pull/36416

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:94c7c899-6c98-4190-7faf-fc75fbcd415c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7E8:176010:CB9B47:11186BA:6A532225
html-safe-nonceec07495b8c763526920f1e7393047f01619929de0ab8bed56a0219aacb08e76a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0U4OjE3NjAxMDpDQjlCNDc6MTExODZCQTo2QTUzMjIyNSIsInZpc2l0b3JfaWQiOiIxMjM2OTY5OTQ5MDM5MzcwNzg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac614eb29ba9ea725b0b8676e8d921ae320cb400f232ebd1dea1ad0bd3eb5aeb37
hovercard-subject-tagpull_request:533242011
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36416/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a76e4290034fdd912abf6af4e085b5bfc3cda87e3bef29a19eee533ccc611d30/nodejs/node/pull/36416
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a76e4290034fdd912abf6af4e085b5bfc3cda87e3bef29a19eee533ccc611d30/nodejs/node/pull/36416
og:image:altWe have a few places where we individually forward each parameter to tls.createSecureContext(). In #28973 and others, we added new SecureContext options but forgot to keep these places up to date. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemildsunrise
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36416#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36416
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36416
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36416
Reloadhttps://github.com/nodejs/node/pull/36416
Reloadhttps://github.com/nodejs/node/pull/36416
Please reload this pagehttps://github.com/nodejs/node/pull/36416
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36416
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 997 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mildsunrisehttps://github.com/mildsunrise
nodejs:masterhttps://github.com/nodejs/node/tree/master
mildsunrise:fix-securecontexthttps://github.com/mildsunrise/node/tree/fix-securecontext
Conversationhttps://github.com/nodejs/node/pull/36416
Commits1 (1)https://github.com/nodejs/node/pull/36416/commits
Checkshttps://github.com/nodejs/node/pull/36416/checks
Files changedhttps://github.com/nodejs/node/pull/36416/files
tls: forward new SecureContext optionshttps://github.com/nodejs/node/pull/36416#top
mildsunrisehttps://github.com/mildsunrise
nodejs:masterhttps://github.com/nodejs/node/tree/master
mildsunrise:fix-securecontexthttps://github.com/mildsunrise/node/tree/fix-securecontext
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
Dec 6, 2020https://github.com/nodejs/node/pull/36416#issue-757988423
Please reload this pagehttps://github.com/nodejs/node/pull/36416
#28973https://github.com/nodejs/node/pull/28973
#36322https://github.com/nodejs/node/issues/36322
#28973https://github.com/nodejs/node/pull/28973
Please reload this pagehttps://github.com/nodejs/node/pull/36416
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
https https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttps
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Dec 6, 2020https://github.com/nodejs/node/pull/36416#event-4076862661
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
Dec 6, 2020https://github.com/nodejs/node/pull/36416#issuecomment-739541661
Please reload this pagehttps://github.com/nodejs/node/pull/36416
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 6, 2020https://github.com/nodejs/node/pull/36416#event-4076865479
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 6, 2020https://github.com/nodejs/node/pull/36416#event-4076868387
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 6, 2020https://github.com/nodejs/node/pull/36416#issuecomment-739542522
https://ci.nodejs.org/job/node-test-pull-request/34802/https://ci.nodejs.org/job/node-test-pull-request/34802/
Please reload this pagehttps://github.com/nodejs/node/pull/36416
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
force-pushedhttps://github.com/nodejs/node/compare/b103954cd741e7040d4f2398df612c30a2feb596..1c5e4d829f29d3917ab78037a8c44cd2e6bf1b00
b103954https://github.com/nodejs/node/commit/b103954cd741e7040d4f2398df612c30a2feb596
1c5e4d8https://github.com/nodejs/node/commit/1c5e4d829f29d3917ab78037a8c44cd2e6bf1b00
Compare https://github.com/nodejs/node/compare/b103954cd741e7040d4f2398df612c30a2feb596..1c5e4d829f29d3917ab78037a8c44cd2e6bf1b00
December 6, 2020 18:24https://github.com/nodejs/node/pull/36416#event-4076868875
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 6, 2020https://github.com/nodejs/node/pull/36416#issuecomment-739542746
https://ci.nodejs.org/job/node-test-pull-request/34803/https://ci.nodejs.org/job/node-test-pull-request/34803/
Please reload this pagehttps://github.com/nodejs/node/pull/36416
https://github.com/mildsunrise
tls: forward new SecureContext optionshttps://github.com/nodejs/node/pull/36416/commits/3c353b6889e22b3792dee906ad3f4669ce825e11
3c353b6https://github.com/nodejs/node/pull/36416/commits/3c353b6889e22b3792dee906ad3f4669ce825e11
nodejs#28973https://github.com/nodejs/node/pull/28973
nodejs#36322https://github.com/nodejs/node/issues/36322
nodejs#28973https://github.com/nodejs/node/pull/28973
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
force-pushedhttps://github.com/nodejs/node/compare/1c5e4d829f29d3917ab78037a8c44cd2e6bf1b00..3c353b6889e22b3792dee906ad3f4669ce825e11
1c5e4d8https://github.com/nodejs/node/commit/1c5e4d829f29d3917ab78037a8c44cd2e6bf1b00
3c353b6https://github.com/nodejs/node/commit/3c353b6889e22b3792dee906ad3f4669ce825e11
Compare https://github.com/nodejs/node/compare/1c5e4d829f29d3917ab78037a8c44cd2e6bf1b00..3c353b6889e22b3792dee906ad3f4669ce825e11
December 7, 2020 00:39https://github.com/nodejs/node/pull/36416#event-4077218995
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 7, 2020https://github.com/nodejs/node/pull/36416#issuecomment-739905864
https://ci.nodejs.org/job/node-test-pull-request/34816/https://ci.nodejs.org/job/node-test-pull-request/34816/
Please reload this pagehttps://github.com/nodejs/node/pull/36416
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 7, 2020 https://github.com/nodejs/node/pull/36416#pullrequestreview-546410089
View reviewed changes https://github.com/nodejs/node/pull/36416/files/3c353b6889e22b3792dee906ad3f4669ce825e11
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 9, 2020https://github.com/nodejs/node/pull/36416#issuecomment-741812065
https://ci.nodejs.org/job/node-test-pull-request/34875/https://ci.nodejs.org/job/node-test-pull-request/34875/
Please reload this pagehttps://github.com/nodejs/node/pull/36416
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 9, 2020 https://github.com/nodejs/node/pull/36416#pullrequestreview-548245738
View reviewed changes https://github.com/nodejs/node/pull/36416/files/3c353b6889e22b3792dee906ad3f4669ce825e11
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
Dec 12, 2020https://github.com/nodejs/node/pull/36416#issuecomment-743917153
78d1f8dhttps://github.com/nodejs/node/commit/78d1f8db5da26d3b635b07348f465561895121fe
Please reload this pagehttps://github.com/nodejs/node/pull/36416
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
Dec 12, 2020https://github.com/nodejs/node/pull/36416#event-4105121496
mildsunrisehttps://github.com/mildsunrise
Dec 12, 2020 https://github.com/nodejs/node/pull/36416#ref-commit-78d1f8d
https://github.com/mildsunrise
tls: forward new SecureContext optionshttps://github.com/nodejs/node/commit/78d1f8db5da26d3b635b07348f465561895121fe
78d1f8dhttps://github.com/nodejs/node/commit/78d1f8db5da26d3b635b07348f465561895121fe
#28973https://github.com/nodejs/node/pull/28973
#36322https://github.com/nodejs/node/issues/36322
#28973https://github.com/nodejs/node/pull/28973
#36416https://github.com/nodejs/node/pull/36416
https://github.com/mildsunrise
mildsunrisehttps://github.com/mildsunrise
December 12, 2020 23:06https://github.com/nodejs/node/pull/36416#event-4105129973
targoshttps://github.com/targos
Dec 21, 2020 https://github.com/nodejs/node/pull/36416#ref-commit-58319d5
https://github.com/mildsunrise
https://github.com/targos
tls: forward new SecureContext optionshttps://github.com/nodejs/node/commit/58319d5336c0249f0a3734f62c268a0c0a58d304
58319d5https://github.com/nodejs/node/commit/58319d5336c0249f0a3734f62c268a0c0a58d304
#28973https://github.com/nodejs/node/pull/28973
#36322https://github.com/nodejs/node/issues/36322
#28973https://github.com/nodejs/node/pull/28973
#36416https://github.com/nodejs/node/pull/36416
https://github.com/targos
targoshttps://github.com/targos
Dec 22, 2020 https://github.com/nodejs/node/pull/36416#ref-pullrequest-772754760
v15.5.0 release proposal #36597 https://github.com/nodejs/node/pull/36597
targoshttps://github.com/targos
May 1, 2021 https://github.com/nodejs/node/pull/36416#ref-commit-08ed233
https://github.com/mildsunrise
https://github.com/targos
tls: forward new SecureContext optionshttps://github.com/nodejs/node/commit/08ed2337eaecf58b747e4d01ae18cbe4f1cf45ef
08ed233https://github.com/nodejs/node/commit/08ed2337eaecf58b747e4d01ae18cbe4f1cf45ef
#28973https://github.com/nodejs/node/pull/28973
#36322https://github.com/nodejs/node/issues/36322
#28973https://github.com/nodejs/node/pull/28973
#36416https://github.com/nodejs/node/pull/36416
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
May 3, 2021 https://github.com/nodejs/node/pull/36416#ref-pullrequest-874193529
v14.17.0 proposal #38507 https://github.com/nodejs/node/pull/38507
https://github.com/BenBaratte
BenBarattehttps://github.com/BenBaratte
Sep 6, 2021 https://github.com/nodejs/node/pull/36416#ref-issue-750699843
tls_wrap does not forward privateKeyEngine and privateKeyIdentifier to tls.createSecureContext() on Server opening nodejs/help#3094 https://github.com/nodejs/help/issues/3094
https://github.com/baby636
baby636https://github.com/baby636
Nov 28, 2023 https://github.com/nodejs/node/pull/36416#ref-pullrequest-2013481561
[Snyk] Fix for 37 vulnerabilities baby636/node#110 https://github.com/baby636/node/pull/110
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36416
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/36416/files/3c353b6889e22b3792dee906ad3f4669ce825e11
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/36416/files/3c353b6889e22b3792dee906ad3f4669ce825e11
https https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttps
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
tls_wrap does not forward privateKeyEngine and privateKeyIdentifier to tls.createSecureContext() on Server opening https://github.com/nodejs/node/issues/36322
Please reload this pagehttps://github.com/nodejs/node/pull/36416
https://github.com/mildsunrise
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.