René's URL Explorer Experiment


Title: [v14.x backport] http2: check write not scheduled in scope destructor by davedoesdev · Pull Request #36372 · nodejs/node · GitHub

Open Graph Title: [v14.x backport] http2: check write not scheduled in scope destructor by davedoesdev · Pull Request #36372 · nodejs/node

X Title: [v14.x backport] http2: check write not scheduled in scope destructor by davedoesdev · Pull Request #36372 · nodejs/node

Description: Fixes: #33156 PR-URL: #36241 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...

Open Graph Description: Fixes: #33156 PR-URL: #36241 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...

X Description: Fixes: #33156 PR-URL: #36241 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...

Mail addresses
matteo.collina@gmail.com
rtrott@gmail.com

Opengraph URL: https://github.com/nodejs/node/pull/36372

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:77da0c93-8bb6-79f9-8988-98102ca2683d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC24:15D295:129C36D:19DED96:696A90F5
html-safe-nonce726a4f23e69a29c6cdf756cae1147bbd8a8f40f26d2211c28c5ac02063d789ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzI0OjE1RDI5NToxMjlDMzZEOjE5REVEOTY6Njk2QTkwRjUiLCJ2aXNpdG9yX2lkIjoiMjQzNjcwNjM5OTU4ODg4MDYyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0b6a2d95d9f29a0d8c8290468e9017deb654693ea4480d7d1c80d59fb051743a
hovercard-subject-tagpull_request:532134049
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36372/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6257e3dcb23dc3ba8a3fbe0854e06cd77d9396555427d9c08a253e871e85be84/nodejs/node/pull/36372
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6257e3dcb23dc3ba8a3fbe0854e06cd77d9396555427d9c08a253e871e85be84/nodejs/node/pull/36372
og:image:altFixes: #33156 PR-URL: #36241 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedavedoesdev
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36372#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36372
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36372
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36372
Reloadhttps://github.com/nodejs/node/pull/36372
Reloadhttps://github.com/nodejs/node/pull/36372
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36372
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/36372
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/36372#issue-comment-box
davedoesdevhttps://github.com/davedoesdev
nodejs:v14.x-staginghttps://github.com/nodejs/node/tree/v14.x-staging
[v14.x backport] http2: check write not scheduled in scope destructor https://github.com/nodejs/node/pull/36372#top
davedoesdevhttps://github.com/davedoesdev
nodejs:v14.x-staginghttps://github.com/nodejs/node/tree/v14.x-staging
Conversation 6 https://github.com/nodejs/node/pull/36372
Commits 1 https://github.com/nodejs/node/pull/36372/commits
Checks 0 https://github.com/nodejs/node/pull/36372/checks
Files changed https://github.com/nodejs/node/pull/36372/files
Please reload this pagehttps://github.com/nodejs/node/pull/36372
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/davedoesdev
davedoesdevhttps://github.com/davedoesdev
Dec 3, 2020https://github.com/nodejs/node/pull/36372#issue-756611187
#33156https://github.com/nodejs/node/issues/33156
#36241https://github.com/nodejs/node/pull/36241
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36372
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av14.x
Dec 3, 2020https://github.com/nodejs/node/pull/36372#event-4069836111
https://github.com/davedoesdev
http2: check write not scheduled in scope destructorhttps://github.com/nodejs/node/pull/36372/commits/f6737f00ed6062c3583a3aeb76311e96451d2115
f6737f0https://github.com/nodejs/node/pull/36372/commits/f6737f00ed6062c3583a3aeb76311e96451d2115
#33156https://github.com/nodejs/node/issues/33156
#36241https://github.com/nodejs/node/pull/36241
#36372https://github.com/nodejs/node/pull/36372
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 9, 2020https://github.com/nodejs/node/pull/36372#event-4087384101
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 9, 2020https://github.com/nodejs/node/pull/36372#event-4087446953
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36372
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 9, 2020https://github.com/nodejs/node/pull/36372#event-4089377527
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 9, 2020https://github.com/nodejs/node/pull/36372#event-4089450464
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36372
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 10, 2020https://github.com/nodejs/node/pull/36372#event-4094628708
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 10, 2020https://github.com/nodejs/node/pull/36372#event-4094671159
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 10, 2020https://github.com/nodejs/node/pull/36372#issuecomment-742469724
Please reload this pagehttps://github.com/nodejs/node/pull/36372
https://ci.nodejs.org/job/node-test-pull-request/34884/https://ci.nodejs.org/job/node-test-pull-request/34884/
Please reload this pagehttps://github.com/nodejs/node/pull/36372
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020https://github.com/nodejs/node/pull/36372#issuecomment-742668569
Please reload this pagehttps://github.com/nodejs/node/pull/36372
nodejs/build#2482https://github.com/nodejs/build/issues/2482
#36241https://github.com/nodejs/node/pull/36241
Please reload this pagehttps://github.com/nodejs/node/pull/36372
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 10, 2020https://github.com/nodejs/node/pull/36372#issuecomment-742670206
Please reload this pagehttps://github.com/nodejs/node/pull/36372
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
force-pushedhttps://github.com/nodejs/node/compare/3168ac1efd549ede6d219f37e5fb8f28a760b358..c44b478889d36a7c4e181ac7677c67c1878ca6fa
3168ac1https://github.com/nodejs/node/commit/3168ac1efd549ede6d219f37e5fb8f28a760b358
c44b478https://github.com/nodejs/node/commit/c44b478889d36a7c4e181ac7677c67c1878ca6fa
Compare https://github.com/nodejs/node/compare/3168ac1efd549ede6d219f37e5fb8f28a760b358..c44b478889d36a7c4e181ac7677c67c1878ca6fa
December 10, 2020 20:12https://github.com/nodejs/node/pull/36372#event-4097035817
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/36372#pullrequestreview-549567573
View reviewed changes https://github.com/nodejs/node/pull/36372/files/f6737f00ed6062c3583a3aeb76311e96451d2115
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/36372#ref-commit-4b315a5
https://github.com/davedoesdev
https://github.com/BethGriggs
http2: check write not scheduled in scope destructorhttps://github.com/nodejs/node/commit/4b315a551f2307a769cddb682f1433cce71630fd
4b315a5https://github.com/nodejs/node/commit/4b315a551f2307a769cddb682f1433cce71630fd
#33156https://github.com/nodejs/node/issues/33156
#36241https://github.com/nodejs/node/pull/36241
#36372https://github.com/nodejs/node/pull/36372
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020https://github.com/nodejs/node/pull/36372#issuecomment-742781524
4b315a5https://github.com/nodejs/node/commit/4b315a551f2307a769cddb682f1433cce71630fd
Please reload this pagehttps://github.com/nodejs/node/pull/36372
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020https://github.com/nodejs/node/pull/36372#event-4097116784
BethGriggshttps://github.com/BethGriggs
Dec 15, 2020 https://github.com/nodejs/node/pull/36372#ref-commit-71c3efe
https://github.com/davedoesdev
https://github.com/BethGriggs
http2: check write not scheduled in scope destructorhttps://github.com/nodejs/node/commit/71c3efe278e4110138bd8071f31b1cf60bd8501d
71c3efehttps://github.com/nodejs/node/commit/71c3efe278e4110138bd8071f31b1cf60bd8501d
#33156https://github.com/nodejs/node/issues/33156
#36241https://github.com/nodejs/node/pull/36241
#36372https://github.com/nodejs/node/pull/36372
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36372
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/36372/files/f6737f00ed6062c3583a3aeb76311e96451d2115
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/36372
https://github.com/davedoesdev
https://github.com/nodejs-github-bot
https://github.com/BethGriggs
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.