René's URL Explorer Experiment


Title: [v12.x backport] http2: check write not scheduled in scope destructor by davedoesdev · Pull Request #36355 · nodejs/node · GitHub

Open Graph Title: [v12.x backport] http2: check write not scheduled in scope destructor by davedoesdev · Pull Request #36355 · nodejs/node

X Title: [v12.x backport] http2: check write not scheduled in scope destructor by davedoesdev · Pull Request #36355 · nodejs/node

Description: Fixes: #33156 PR-URL: #36241 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...

Open Graph Description: Fixes: #33156 PR-URL: #36241 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...

X Description: Fixes: #33156 PR-URL: #36241 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...

Mail addresses
matteo.collina@gmail.com
rtrott@gmail.com

Opengraph URL: https://github.com/nodejs/node/pull/36355

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:584dc085-e3bd-7784-a3b4-9abe226d3a9e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D2C:2BBCB0:1DD667C:279A379:696AFD4A
html-safe-noncec5380c6f8cc52b35d446ba633d5677142da4eaf40fde0a6c803ede4d4079d457
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDJDOjJCQkNCMDoxREQ2NjdDOjI3OUEzNzk6Njk2QUZENEEiLCJ2aXNpdG9yX2lkIjoiNTAyODgxMjQ0OTQxNDU3NzQ4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf574c82485a118d6b3713becf249a3b99bccbd807d397781a19dd8e70061d73b
hovercard-subject-tagpull_request:531333550
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36355/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ad773784e69d9d8562fde38b6a27733658f739502c481529226d5ceffb1adc54/nodejs/node/pull/36355
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ad773784e69d9d8562fde38b6a27733658f739502c481529226d5ceffb1adc54/nodejs/node/pull/36355
og:image:altFixes: #33156 PR-URL: #36241 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes test...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedavedoesdev
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36355#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36355
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36355
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36355
Reloadhttps://github.com/nodejs/node/pull/36355
Reloadhttps://github.com/nodejs/node/pull/36355
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36355
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/36355
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/36355#issue-comment-box
davedoesdevhttps://github.com/davedoesdev
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
[v12.x backport] http2: check write not scheduled in scope destructor https://github.com/nodejs/node/pull/36355#top
davedoesdevhttps://github.com/davedoesdev
nodejs:v12.x-staginghttps://github.com/nodejs/node/tree/v12.x-staging
Conversation 5 https://github.com/nodejs/node/pull/36355
Commits 1 https://github.com/nodejs/node/pull/36355/commits
Checks 0 https://github.com/nodejs/node/pull/36355/checks
Files changed https://github.com/nodejs/node/pull/36355/files
Please reload this pagehttps://github.com/nodejs/node/pull/36355
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/davedoesdev
davedoesdevhttps://github.com/davedoesdev
Dec 2, 2020https://github.com/nodejs/node/pull/36355#issue-755663594
#33156https://github.com/nodejs/node/issues/33156
#36241https://github.com/nodejs/node/pull/36241
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36355
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x
Dec 2, 2020https://github.com/nodejs/node/pull/36355#event-4064693939
https://github.com/davedoesdev
http2: check write not scheduled in scope destructorhttps://github.com/nodejs/node/pull/36355/commits/10c7e3a4f672678384d2370d66a3105a98e227a4
10c7e3ahttps://github.com/nodejs/node/pull/36355/commits/10c7e3a4f672678384d2370d66a3105a98e227a4
#33156https://github.com/nodejs/node/issues/33156
#36241https://github.com/nodejs/node/pull/36241
#36355https://github.com/nodejs/node/pull/36355
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 3, 2020 https://github.com/nodejs/node/pull/36355#pullrequestreview-544204883
View reviewed changes https://github.com/nodejs/node/pull/36355/files/10c7e3a4f672678384d2370d66a3105a98e227a4
https://github.com/davedoesdev
davedoesdevhttps://github.com/davedoesdev
Jan 16, 2021https://github.com/nodejs/node/pull/36355#issuecomment-761524621
Please reload this pagehttps://github.com/nodejs/node/pull/36355
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Feb 8, 2021 https://github.com/nodejs/node/pull/36355#pullrequestreview-585637973
View reviewed changes https://github.com/nodejs/node/pull/36355/files/10c7e3a4f672678384d2370d66a3105a98e227a4
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 8, 2021https://github.com/nodejs/node/pull/36355#issuecomment-775241748
https://ci.nodejs.org/job/node-test-pull-request/36012/https://ci.nodejs.org/job/node-test-pull-request/36012/
Please reload this pagehttps://github.com/nodejs/node/pull/36355
ruyadornohttps://github.com/ruyadorno
Feb 8, 2021 https://github.com/nodejs/node/pull/36355#ref-commit-97183ae
https://github.com/davedoesdev
https://github.com/ruyadorno
http2: check write not scheduled in scope destructorhttps://github.com/nodejs/node/commit/97183ae57d74e0f15bb040a4ce660b7703ea5928
97183aehttps://github.com/nodejs/node/commit/97183ae57d74e0f15bb040a4ce660b7703ea5928
#33156https://github.com/nodejs/node/issues/33156
#36241https://github.com/nodejs/node/pull/36241
#36355https://github.com/nodejs/node/pull/36355
ruyadornohttps://github.com/ruyadorno
Feb 10, 2021 https://github.com/nodejs/node/pull/36355#ref-commit-4ac8f37
https://github.com/davedoesdev
https://github.com/ruyadorno
http2: check write not scheduled in scope destructorhttps://github.com/nodejs/node/commit/4ac8f37800d1ab3ff74a7cd518d155d68dcba8e3
4ac8f37https://github.com/nodejs/node/commit/4ac8f37800d1ab3ff74a7cd518d155d68dcba8e3
#33156https://github.com/nodejs/node/issues/33156
#36241https://github.com/nodejs/node/pull/36241
#36355https://github.com/nodejs/node/pull/36355
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/06926116703f76af8c16c0200658f4e7ccc2712a..6cef0e3678345a12044519ed90faf9d943a89892
0692611https://github.com/nodejs/node/commit/06926116703f76af8c16c0200658f4e7ccc2712a
6cef0e3https://github.com/nodejs/node/commit/6cef0e3678345a12044519ed90faf9d943a89892
Compare https://github.com/nodejs/node/compare/06926116703f76af8c16c0200658f4e7ccc2712a..6cef0e3678345a12044519ed90faf9d943a89892
February 23, 2021 12:51https://github.com/nodejs/node/pull/36355#event-4364997323
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 16, 2021https://github.com/nodejs/node/pull/36355#issuecomment-799852980
https://ci.nodejs.org/job/node-test-pull-request/36730/https://ci.nodejs.org/job/node-test-pull-request/36730/
Please reload this pagehttps://github.com/nodejs/node/pull/36355
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 17, 2021https://github.com/nodejs/node/pull/36355#issuecomment-801009401
https://ci.nodejs.org/job/node-test-pull-request/36754/https://ci.nodejs.org/job/node-test-pull-request/36754/
Please reload this pagehttps://github.com/nodejs/node/pull/36355
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Mar 17, 2021https://github.com/nodejs/node/pull/36355#issuecomment-801424140
4ac8f37https://github.com/nodejs/node/commit/4ac8f37800d1ab3ff74a7cd518d155d68dcba8e3
#37286https://github.com/nodejs/node/pull/37286
Please reload this pagehttps://github.com/nodejs/node/pull/36355
https://github.com/targos
targoshttps://github.com/targos
force-pushedhttps://github.com/nodejs/node/compare/5cccd8f414d826c2859f1ac2b69073ac41196cfd..984eeb71310e00a85a325c4f81a1df8bf59b91e2
5cccd8fhttps://github.com/nodejs/node/commit/5cccd8f414d826c2859f1ac2b69073ac41196cfd
984eeb7https://github.com/nodejs/node/commit/984eeb71310e00a85a325c4f81a1df8bf59b91e2
Compare https://github.com/nodejs/node/compare/5cccd8f414d826c2859f1ac2b69073ac41196cfd..984eeb71310e00a85a325c4f81a1df8bf59b91e2
July 3, 2021 10:01https://github.com/nodejs/node/pull/36355#event-4974050013
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/984eeb71310e00a85a325c4f81a1df8bf59b91e2..ca90848ffa28e3db8f6b6ae32828c04c0011f95f
984eeb7https://github.com/nodejs/node/commit/984eeb71310e00a85a325c4f81a1df8bf59b91e2
ca90848https://github.com/nodejs/node/commit/ca90848ffa28e3db8f6b6ae32828c04c0011f95f
Compare https://github.com/nodejs/node/compare/984eeb71310e00a85a325c4f81a1df8bf59b91e2..ca90848ffa28e3db8f6b6ae32828c04c0011f95f
July 5, 2021 15:47https://github.com/nodejs/node/pull/36355#event-4979266229
https://github.com/richardlau
richardlauhttps://github.com/richardlau
force-pushedhttps://github.com/nodejs/node/compare/61c274b883f572280c4d28e5a201f87304d40667..6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f
61c274bhttps://github.com/nodejs/node/commit/61c274b883f572280c4d28e5a201f87304d40667
6ac4a9bhttps://github.com/nodejs/node/commit/6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f
Compare https://github.com/nodejs/node/compare/61c274b883f572280c4d28e5a201f87304d40667..6ac4a9b7d0e8211be8f8d02c5d884c4657d1391f
July 23, 2021 10:47https://github.com/nodejs/node/pull/36355#event-5060411366
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 23, 2021https://github.com/nodejs/node/pull/36355#event-5060471787
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36355
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/36355/files/10c7e3a4f672678384d2370d66a3105a98e227a4
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/36355/files/10c7e3a4f672678384d2370d66a3105a98e227a4
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Please reload this pagehttps://github.com/nodejs/node/pull/36355
https://github.com/davedoesdev
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/Trott
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.