| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:856f343b-baca-aaf6-597e-aafb53128036 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB62:2FB335:A3BE31:DC6E12:6A527DC0 |
| html-safe-nonce | 703777cf77c68f3a56b49f1a059bd4ac62aa58b6db7482e8cffe20ada78b73e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjYyOjJGQjMzNTpBM0JFMzE6REM2RTEyOjZBNTI3REMwIiwidmlzaXRvcl9pZCI6IjQyMDI4NTYzMjk2NDIxNDcyNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | be6713c52a0938af018c5029572e1defe8a0695eac0116758d8d0c3b7147c39f |
| hovercard-subject-tag | pull_request:527429244 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36258/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ef80ecb55a2ffd59f4d738dca630c9dabdbd868f3de437870ff250eedcde2b3f/nodejs/node/pull/36258 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ef80ecb55a2ffd59f4d738dca630c9dabdbd868f3de437870ff250eedcde2b3f/nodejs/node/pull/36258 |
| og:image:alt | Fixes: #36073
This is this feature whatwg/dom#911 I've implemented the spec I worked on in whatwg/dom#919 and ported the WPTs from web-platform-tests/wpt#26472
This is following implementations... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | benjamingr |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36258#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36258 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36258 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36258 |
| Reload | https://github.com/nodejs/node/pull/36258 |
| Reload | https://github.com/nodejs/node/pull/36258 |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
986
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| benjamingr | https://github.com/benjamingr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| benjamingr:event-target-signal | https://github.com/benjamingr/io.js/tree/event-target-signal |
| Conversation | https://github.com/nodejs/node/pull/36258 |
| Commits1 (1) | https://github.com/nodejs/node/pull/36258/commits |
| Checks | https://github.com/nodejs/node/pull/36258/checks |
| Files changed | https://github.com/nodejs/node/pull/36258/files |
| events: support signal in EventTarget | https://github.com/nodejs/node/pull/36258#top |
| benjamingr | https://github.com/benjamingr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| benjamingr:event-target-signal | https://github.com/benjamingr/io.js/tree/event-target-signal |
|
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#issue-750798936 |
| #36073 | https://github.com/nodejs/node/issues/36073 |
| whatwg/dom#911 | https://github.com/whatwg/dom/issues/911 |
| whatwg/dom#919 | https://github.com/whatwg/dom/pull/919 |
| web-platform-tests/wpt#26472 | https://github.com/web-platform-tests/wpt/pull/26472 |
| @jasnell | https://github.com/jasnell |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
|
| https://github.com/benjamingr |
| events: support signal in EventTarget | https://github.com/nodejs/node/pull/36258/commits/b70fdff5a345c811cb92ba4e028d05c8a087a86f |
| b70fdff | https://github.com/nodejs/node/pull/36258/commits/b70fdff5a345c811cb92ba4e028d05c8a087a86f |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
|
eventtarget
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aeventtarget |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#event-4037972467 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Nov 25, 2020
| https://github.com/nodejs/node/pull/36258#pullrequestreview-538471065 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36258/files/b70fdff5a345c811cb92ba4e028d05c8a087a86f |
| lib/internal/event_target.js | https://github.com/nodejs/node/pull/36258/files/b70fdff5a345c811cb92ba4e028d05c8a087a86f#diff-3a58267211ca7ef81843af880c461058fba2dc32379702b246a2d8aaec23c77e |
| benjamingr | https://github.com/benjamingr |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#discussion_r530357471 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Nov 25, 2020
| https://github.com/nodejs/node/pull/36258#pullrequestreview-538471802 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36258/files/b70fdff5a345c811cb92ba4e028d05c8a087a86f |
| lib/internal/event_target.js | https://github.com/nodejs/node/pull/36258/files/b70fdff5a345c811cb92ba4e028d05c8a087a86f#diff-3a58267211ca7ef81843af880c461058fba2dc32379702b246a2d8aaec23c77e |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Nov 25, 2020
| https://github.com/nodejs/node/pull/36258#pullrequestreview-538475277 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36258/files/b70fdff5a345c811cb92ba4e028d05c8a087a86f |
| lib/internal/event_target.js | https://github.com/nodejs/node/pull/36258/files/b70fdff5a345c811cb92ba4e028d05c8a087a86f#diff-3a58267211ca7ef81843af880c461058fba2dc32379702b246a2d8aaec23c77e |
| benjamingr | https://github.com/benjamingr |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#discussion_r530359975 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| addaleax | https://github.com/addaleax |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#discussion_r530370616 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| jasnell | https://github.com/jasnell |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#discussion_r530401071 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| benjamingr | https://github.com/benjamingr |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#discussion_r530411135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jasnell | https://github.com/jasnell |
| @addaleax | https://github.com/addaleax |
| whatwg/dom#920 | https://github.com/whatwg/dom/issues/920 |
| #35990 (comment) | https://github.com/nodejs/node/issues/35990#issuecomment-723218855 |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#event-4038023388 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#event-4038039483 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#issuecomment-733701324 |
| https://ci.nodejs.org/job/node-test-pull-request/34552/ | https://ci.nodejs.org/job/node-test-pull-request/34552/ |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#issuecomment-733850019 |
| https://ci.nodejs.org/job/node-test-pull-request/34560/ | https://ci.nodejs.org/job/node-test-pull-request/34560/ |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Nov 25, 2020 | https://github.com/nodejs/node/pull/36258#event-4039475963 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 29, 2020 | https://github.com/nodejs/node/pull/36258#issuecomment-735444685 |
| @jasnell | https://github.com/jasnell |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Dec 1, 2020 | https://github.com/nodejs/node/pull/36258#issuecomment-736698172 |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 1, 2020
| https://github.com/nodejs/node/pull/36258#pullrequestreview-542129397 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36258/files/b70fdff5a345c811cb92ba4e028d05c8a087a86f |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Dec 2, 2020 | https://github.com/nodejs/node/pull/36258#event-4062722221 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Dec 2, 2020 | https://github.com/nodejs/node/pull/36258#event-4062775980 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Dec 2, 2020 | https://github.com/nodejs/node/pull/36258#issuecomment-737280775 |
| 4a741b8...ef8d0e9 | https://github.com/nodejs/node/compare/4a741b8dc2c19efcef49ca39362bb7126d80a3d1...ef8d0e9798d3e6412ad5f8417a32275d8181bbe7 |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Dec 2, 2020 | https://github.com/nodejs/node/pull/36258#event-4062776926 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Dec 2, 2020
| https://github.com/nodejs/node/pull/36258#ref-commit-ef8d0e9 |
|
| https://github.com/benjamingr |
|
| https://github.com/nodejs-github-bot |
| events: support signal in EventTarget | https://github.com/nodejs/node/commit/ef8d0e9798d3e6412ad5f8417a32275d8181bbe7 |
| ef8d0e9 | https://github.com/nodejs/node/commit/ef8d0e9798d3e6412ad5f8417a32275d8181bbe7 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #36073 | https://github.com/nodejs/node/issues/36073 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| December 2, 2020 15:10 | https://github.com/nodejs/node/pull/36258#event-4062857252 |
| danielleadams | https://github.com/danielleadams |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/36258#ref-commit-855a85c |
|
| https://github.com/benjamingr |
|
| https://github.com/danielleadams |
| events: support signal in EventTarget | https://github.com/nodejs/node/commit/855a85c12464f426b4a26ad6a7c96c582340976d |
| 855a85c | https://github.com/nodejs/node/commit/855a85c12464f426b4a26ad6a7c96c582340976d |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #36073 | https://github.com/nodejs/node/issues/36073 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/36258#ref-pullrequest-758834739 |
|
v15.4.0 proposal
#36435
| https://github.com/nodejs/node/pull/36435 |
| danielleadams | https://github.com/danielleadams |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/36258#ref-commit-fde09a4 |
|
| https://github.com/danielleadams |
| 2020-12-08, Version 15.4.0 (Current) | https://github.com/nodejs/node/commit/fde09a4cdc9465e8ed51f2f8597e03d7384fc6c2 |
| fde09a4 | https://github.com/nodejs/node/commit/fde09a4cdc9465e8ed51f2f8597e03d7384fc6c2 |
| #36435 | https://github.com/nodejs/node/pull/36435 |
| #36308 | https://github.com/nodejs/node/pull/36308 |
| #36187 | https://github.com/nodejs/node/pull/36187 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #35949 | https://github.com/nodejs/node/pull/35949 |
| #35924 | https://github.com/nodejs/node/pull/35924 |
| #36263 | https://github.com/nodejs/node/pull/36263 |
| #36061 | https://github.com/nodejs/node/pull/36061 |
| #35922 | https://github.com/nodejs/node/pull/35922 |
| #36271 | https://github.com/nodejs/node/pull/36271 |
| cjihrig | https://github.com/cjihrig |
|
Dec 8, 2020
| https://github.com/nodejs/node/pull/36258#ref-commit-f59c6cd |
|
| https://github.com/benjamingr |
|
| https://github.com/cjihrig |
| events: support signal in EventTarget | https://github.com/cjihrig/node/commit/f59c6cdcadc50e5577abecf2be46af317078e3a5 |
| f59c6cd | https://github.com/cjihrig/node/commit/f59c6cdcadc50e5577abecf2be46af317078e3a5 |
| nodejs#36258 | https://github.com/nodejs/node/pull/36258 |
| nodejs#36073 | https://github.com/nodejs/node/issues/36073 |
| danielleadams | https://github.com/danielleadams |
|
Dec 9, 2020
| https://github.com/nodejs/node/pull/36258#ref-commit-5e5927e |
|
| https://github.com/danielleadams |
| 2020-12-09, Version 15.4.0 (Current) | https://github.com/nodejs/node/commit/5e5927ec2e685399689e4fcfe630565b3101207f |
| 5e5927e | https://github.com/nodejs/node/commit/5e5927ec2e685399689e4fcfe630565b3101207f |
| #36435 | https://github.com/nodejs/node/pull/36435 |
| #36308 | https://github.com/nodejs/node/pull/36308 |
| #36187 | https://github.com/nodejs/node/pull/36187 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #35949 | https://github.com/nodejs/node/pull/35949 |
| #35924 | https://github.com/nodejs/node/pull/35924 |
| #36263 | https://github.com/nodejs/node/pull/36263 |
| #36061 | https://github.com/nodejs/node/pull/36061 |
| #35922 | https://github.com/nodejs/node/pull/35922 |
| #36271 | https://github.com/nodejs/node/pull/36271 |
| danielleadams | https://github.com/danielleadams |
|
Dec 9, 2020
| https://github.com/nodejs/node/pull/36258#ref-commit-348b7a9 |
|
| https://github.com/danielleadams |
| 2020-12-09, Version 15.4.0 (Current) | https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb |
|
| https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb#comments |
| 348b7a9 | https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb |
| #36435 | https://github.com/nodejs/node/pull/36435 |
| #36308 | https://github.com/nodejs/node/pull/36308 |
| #36187 | https://github.com/nodejs/node/pull/36187 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #35949 | https://github.com/nodejs/node/pull/35949 |
| #35924 | https://github.com/nodejs/node/pull/35924 |
| #36263 | https://github.com/nodejs/node/pull/36263 |
| #36061 | https://github.com/nodejs/node/pull/36061 |
| #35922 | https://github.com/nodejs/node/pull/35922 |
| #36271 | https://github.com/nodejs/node/pull/36271 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-requested-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v14.x |
| Aug 4, 2021 | https://github.com/nodejs/node/pull/36258#event-5110674738 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 4, 2021 | https://github.com/nodejs/node/pull/36258#issuecomment-892601087 |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Aug 4, 2021 | https://github.com/nodejs/node/pull/36258#issuecomment-892695882 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
| aduh95 | https://github.com/aduh95 |
|
May 21, 2022
| https://github.com/nodejs/node/pull/36258#ref-commit-096d43b |
|
| https://github.com/aduh95 |
| doc: document signal option for EventTarget#addEventListener | https://github.com/aduh95/node/commit/096d43bc96ebfc2e5ce80a4c2c9800ac442db250 |
| 096d43b | https://github.com/aduh95/node/commit/096d43bc96ebfc2e5ce80a4c2c9800ac442db250 |
| nodejs#36258 | https://github.com/nodejs/node/pull/36258 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
May 21, 2022
| https://github.com/nodejs/node/pull/36258#ref-pullrequest-1244029184 |
|
doc: document signal option for EventTarget#addEventListener
#43170
| https://github.com/nodejs/node/pull/43170 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
May 25, 2022
| https://github.com/nodejs/node/pull/36258#ref-commit-a346572 |
|
| https://github.com/aduh95 |
| doc: document signal option for EventTarget#addEventListener | https://github.com/nodejs/node/commit/a346572b952e7942078af4105d34e049d28d3ea2 |
| a346572 | https://github.com/nodejs/node/commit/a346572b952e7942078af4105d34e049d28d3ea2 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #43170 | https://github.com/nodejs/node/pull/43170 |
| bengl | https://github.com/bengl |
|
May 30, 2022
| https://github.com/nodejs/node/pull/36258#ref-commit-76b4680 |
|
| https://github.com/aduh95 |
|
| https://github.com/bengl |
| doc: document signal option for EventTarget#addEventListener | https://github.com/nodejs/node/commit/76b46801f853ef5ac59dcd8cb8ff83974725061f |
| 76b4680 | https://github.com/nodejs/node/commit/76b46801f853ef5ac59dcd8cb8ff83974725061f |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #43170 | https://github.com/nodejs/node/pull/43170 |
| danielleadams | https://github.com/danielleadams |
|
Jun 27, 2022
| https://github.com/nodejs/node/pull/36258#ref-commit-1d1481c |
|
| https://github.com/aduh95 |
|
| https://github.com/danielleadams |
| doc: document signal option for EventTarget#addEventListener | https://github.com/nodejs/node/commit/1d1481c9723cdb0e8520d21f57a8aa39c7c142eb |
| 1d1481c | https://github.com/nodejs/node/commit/1d1481c9723cdb0e8520d21f57a8aa39c7c142eb |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #43170 | https://github.com/nodejs/node/pull/43170 |
| targos | https://github.com/targos |
|
Jul 12, 2022
| https://github.com/nodejs/node/pull/36258#ref-commit-4dd4f6c |
|
| https://github.com/aduh95 |
|
| https://github.com/targos |
| doc: document signal option for EventTarget#addEventListener | https://github.com/nodejs/node/commit/4dd4f6c9248a272dda5fb7c22e01edf41f7cb388 |
| 4dd4f6c | https://github.com/nodejs/node/commit/4dd4f6c9248a272dda5fb7c22e01edf41f7cb388 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #43170 | https://github.com/nodejs/node/pull/43170 |
| targos | https://github.com/targos |
|
Jul 31, 2022
| https://github.com/nodejs/node/pull/36258#ref-commit-1867462 |
|
| https://github.com/aduh95 |
|
| https://github.com/targos |
| doc: document signal option for EventTarget#addEventListener | https://github.com/nodejs/node/commit/1867462f15f815d6e90a77e6f689952c5f4a7145 |
| 1867462 | https://github.com/nodejs/node/commit/1867462f15f815d6e90a77e6f689952c5f4a7145 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #43170 | https://github.com/nodejs/node/pull/43170 |
| guangwong | https://github.com/guangwong |
|
Oct 10, 2022
| https://github.com/nodejs/node/pull/36258#ref-commit-d86d4d7 |
|
| https://github.com/aduh95 |
|
| https://github.com/guangwong |
| doc: document signal option for EventTarget#addEventListener | https://github.com/noslate-project/node/commit/d86d4d7bcecb5246c3b6b288b33ee07180175dd8 |
| d86d4d7 | https://github.com/noslate-project/node/commit/d86d4d7bcecb5246c3b6b288b33ee07180175dd8 |
| nodejs/node#36258 | https://github.com/nodejs/node/pull/36258 |
| nodejs/node#43170 | https://github.com/nodejs/node/pull/43170 |
|
api.EventTarget.addEventListener - options.signal is supported on node.js
mdn/browser-compat-data#18883
| https://github.com/mdn/browser-compat-data/issues/18883 |
|
Updated Node support for EventTarget
mdn/browser-compat-data#20889
| https://github.com/mdn/browser-compat-data/pull/20889 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36258 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/36258/files/b70fdff5a345c811cb92ba4e028d05c8a087a86f |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/36258/files/b70fdff5a345c811cb92ba4e028d05c8a087a86f |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
|
eventtarget
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aeventtarget |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
RFC - EventTarget API Enhancements
| https://github.com/nodejs/node/issues/36073 |
| Please reload this page | https://github.com/nodejs/node/pull/36258 |
|
| https://github.com/benjamingr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |