René's URL Explorer Experiment


Title: benchmark: fix build warnings by gabrielschulhof · Pull Request #36157 · nodejs/node · GitHub

Open Graph Title: benchmark: fix build warnings by gabrielschulhof · Pull Request #36157 · nodejs/node

X Title: benchmark: fix build warnings by gabrielschulhof · Pull Request #36157 · nodejs/node

Description: The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/...

Open Graph Description: The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/...

X Description: The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/...

Opengraph URL: https://github.com/nodejs/node/pull/36157

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5452ed05-776e-02ed-4f53-6a46ea34aec1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB72:3372CB:204853D:2C5C874:696ABA11
html-safe-nonce355767074d7b85fc2ffb33196b8187ca9ce70e2075489c0fe5a73118fcc5bb75
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjcyOjMzNzJDQjoyMDQ4NTNEOjJDNUM4NzQ6Njk2QUJBMTEiLCJ2aXNpdG9yX2lkIjoiNTQ0NTIwMDIzMDE1NzU2NDQzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc460a27010f3257e27b99879d45def988355902154ff0200d6471e5434c20465
hovercard-subject-tagpull_request:522800468
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36157/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90f008c4110de47cf2d83c23244e0b411a6f7ccc23259b7c3b1ee1d54883efbe/nodejs/node/pull/36157
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90f008c4110de47cf2d83c23244e0b411a6f7ccc23259b7c3b1ee1d54883efbe/nodejs/node/pull/36157
og:image:altThe napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36157#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36157
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36157
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36157
Reloadhttps://github.com/nodejs/node/pull/36157
Reloadhttps://github.com/nodejs/node/pull/36157
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36157
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/36157
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/36157#issue-comment-box
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:fix-function-call-bench-warninghttps://github.com/gabrielschulhof/node/tree/fix-function-call-bench-warning
benchmark: fix build warnings https://github.com/nodejs/node/pull/36157#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:fix-function-call-bench-warninghttps://github.com/gabrielschulhof/node/tree/fix-function-call-bench-warning
Conversation 3 https://github.com/nodejs/node/pull/36157
Commits 1 https://github.com/nodejs/node/pull/36157/commits
Checks 0 https://github.com/nodejs/node/pull/36157/checks
Files changed https://github.com/nodejs/node/pull/36157/files
Please reload this pagehttps://github.com/nodejs/node/pull/36157
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 18, 2020https://github.com/nodejs/node/pull/36157#issue-745200013
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36157
benchmark: fix build warningshttps://github.com/nodejs/node/pull/36157/commits/abad981209bf0af834fac4ff061609e52a7837e9
abad981https://github.com/nodejs/node/pull/36157/commits/abad981209bf0af834fac4ff061609e52a7837e9
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
Nov 18, 2020https://github.com/nodejs/node/pull/36157#event-4008192712
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 18, 2020 https://github.com/nodejs/node/pull/36157#pullrequestreview-533015184
View reviewed changes https://github.com/nodejs/node/pull/36157/files/abad981209bf0af834fac4ff061609e52a7837e9
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 18, 2020 https://github.com/nodejs/node/pull/36157#pullrequestreview-533391452
View reviewed changes https://github.com/nodejs/node/pull/36157/files/abad981209bf0af834fac4ff061609e52a7837e9
https://github.com/Trott
Trotthttps://github.com/Trott
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 18, 2020https://github.com/nodejs/node/pull/36157#event-4010393674
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 18, 2020https://github.com/nodejs/node/pull/36157#event-4010413422
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 18, 2020https://github.com/nodejs/node/pull/36157#issuecomment-729646213
https://ci.nodejs.org/job/node-test-pull-request/34451/https://ci.nodejs.org/job/node-test-pull-request/34451/
Please reload this pagehttps://github.com/nodejs/node/pull/36157
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 18, 2020https://github.com/nodejs/node/pull/36157#issuecomment-729822658
Please reload this pagehttps://github.com/nodejs/node/pull/36157
https://ci.nodejs.org/job/node-test-pull-request/34453/https://ci.nodejs.org/job/node-test-pull-request/34453/
Please reload this pagehttps://github.com/nodejs/node/pull/36157
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 18, 2020 https://github.com/nodejs/node/pull/36157#pullrequestreview-533830362
View reviewed changes https://github.com/nodejs/node/pull/36157/files/abad981209bf0af834fac4ff061609e52a7837e9
https://github.com/richardlau
richardlauhttps://github.com/richardlau
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 18, 2020https://github.com/nodejs/node/pull/36157#event-4012533857
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 19, 2020 https://github.com/nodejs/node/pull/36157#pullrequestreview-534526333
View reviewed changes https://github.com/nodejs/node/pull/36157/files/abad981209bf0af834fac4ff061609e52a7837e9
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 20, 2020 https://github.com/nodejs/node/pull/36157#ref-commit-39e4d82
benchmark: fix build warningshttps://github.com/nodejs/node/commit/39e4d82c70318863150b811425fba9de1957b5cf
39e4d82https://github.com/nodejs/node/commit/39e4d82c70318863150b811425fba9de1957b5cf
#36157https://github.com/nodejs/node/pull/36157
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 20, 2020https://github.com/nodejs/node/pull/36157#issuecomment-730815018
39e4d82https://github.com/nodejs/node/commit/39e4d82c70318863150b811425fba9de1957b5cf
Please reload this pagehttps://github.com/nodejs/node/pull/36157
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 20, 2020https://github.com/nodejs/node/pull/36157#event-4018881206
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
November 20, 2020 04:30https://github.com/nodejs/node/pull/36157#event-4019051784
codebyterehttps://github.com/codebytere
Nov 22, 2020 https://github.com/nodejs/node/pull/36157#ref-commit-3ee556a
https://github.com/codebytere
benchmark: fix build warningshttps://github.com/nodejs/node/commit/3ee556a8677fca74ce012f1daceb2f22c912ca26
3ee556ahttps://github.com/nodejs/node/commit/3ee556a8677fca74ce012f1daceb2f22c912ca26
#36157https://github.com/nodejs/node/pull/36157
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 22, 2020 https://github.com/nodejs/node/pull/36157#ref-pullrequest-748354048
v15.3.0 proposal #36232 https://github.com/nodejs/node/pull/36232
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/36157#ref-commit-db06543
https://github.com/BethGriggs
benchmark: fix build warningshttps://github.com/nodejs/node/commit/db065433cf48b8bf2c23096d091852ddf3420906
db06543https://github.com/nodejs/node/commit/db065433cf48b8bf2c23096d091852ddf3420906
#36157https://github.com/nodejs/node/pull/36157
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/36157#ref-commit-b1a1834
https://github.com/BethGriggs
benchmark: fix build warningshttps://github.com/nodejs/node/commit/b1a1834f32e978c9fa94ed37d3b361f44a6b3100
b1a1834https://github.com/nodejs/node/commit/b1a1834f32e978c9fa94ed37d3b361f44a6b3100
#36157https://github.com/nodejs/node/pull/36157
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/36157#ref-pullrequest-761612838
v14.15.2 proposal #36476 https://github.com/nodejs/node/pull/36476
BethGriggshttps://github.com/BethGriggs
Dec 15, 2020 https://github.com/nodejs/node/pull/36157#ref-commit-d49e0ca
https://github.com/BethGriggs
benchmark: fix build warningshttps://github.com/nodejs/node/commit/d49e0ca73ad0a18c3321e4b44eb759817c1cbef5
d49e0cahttps://github.com/nodejs/node/commit/d49e0ca73ad0a18c3321e4b44eb759817c1cbef5
#36157https://github.com/nodejs/node/pull/36157
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36157
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/36157/files/abad981209bf0af834fac4ff061609e52a7837e9
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/36157/files/abad981209bf0af834fac4ff061609e52a7837e9
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/36157/files/abad981209bf0af834fac4ff061609e52a7837e9
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/36157/files/abad981209bf0af834fac4ff061609e52a7837e9
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
Please reload this pagehttps://github.com/nodejs/node/pull/36157
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Trott
https://github.com/lpinca
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.