| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:665dafbe-226a-ccb5-95a0-b62053dbad08 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D902:1A4188:1B4E2B0:247C106:6AED880A |
| html-safe-nonce | 397281803bcd0e818a046ae7446907d0953d6d455361a9b798ce1cfbb655daef |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTAyOjFBNDE4ODoxQjRFMkIwOjI0N0MxMDY6NkFFRDg4MEEiLCJ2aXNpdG9yX2lkIjoiODkxNzE1MDIyNDg4MjY5ODI1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | dc3faa87c85dce76ff04367fa9f4dcb9c9a42c388d9561e0be864b123c6f7479 |
| hovercard-subject-tag | pull_request:522043274 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36141/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e5290cf013d0f7408c38e85e330440436e7cd51f64e85fb63db4bb933d2cc222/nodejs/node/pull/36141 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e5290cf013d0f7408c38e85e330440436e7cd51f64e85fb63db4bb933d2cc222/nodejs/node/pull/36141 |
| og:image:alt | This PR is trying to fix the behaviour of http2.getUnpackedSettings.
$ node --version
v16.0.0-pre
$ node -e "http2.getUnpackedSettings('')"
node:internal/http2/core:3167
throw... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/36141#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36141 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36141 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36141 |
| Reload | https://github.com/nodejs/node/pull/36141 |
| Reload | https://github.com/nodejs/node/pull/36141 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues654 (654) | https://github.com/nodejs/node/issues |
| Pull requests662 (662) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:http2-getUnpackedSettings-ArrayBufferView | https://github.com/aduh95/node/tree/http2-getUnpackedSettings-ArrayBufferView |
| Conversation | https://github.com/nodejs/node/pull/36141 |
| Commits3 (3) | https://github.com/nodejs/node/pull/36141/commits |
| Checks | https://github.com/nodejs/node/pull/36141/checks |
| Files changed | https://github.com/nodejs/node/pull/36141/files |
| http2: add support for TypedArray to getUnpackedSettings | https://github.com/nodejs/node/pull/36141#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:http2-getUnpackedSettings-ArrayBufferView | https://github.com/aduh95/node/tree/http2-getUnpackedSettings-ArrayBufferView |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Nov 16, 2020 | https://github.com/nodejs/node/pull/36141#issue-744289511 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/36141 |
|
| https://github.com/aduh95 |
| http2: add support for TypedArray to getUnpackedSettings | https://github.com/nodejs/node/pull/36141/commits/2699b66e8d61cfbefab103f36bb3b08aa51932ce |
| 2699b66 | https://github.com/nodejs/node/pull/36141/commits/2699b66e8d61cfbefab103f36bb3b08aa51932ce |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 16, 2020 | https://github.com/nodejs/node/pull/36141#issuecomment-728429708 |
| Please reload this page | https://github.com/nodejs/node/pull/36141 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| Nov 16, 2020 | https://github.com/nodejs/node/pull/36141#event-4002841064 |
| aduh95 | https://github.com/aduh95 |
| November 17, 2020 00:48 | https://github.com/nodejs/node/pull/36141#commits-pushed-b3f7873 |
|
| https://github.com/aduh95 |
| fixup! http2: add support for TypedArray to getUnpackedSettings | https://github.com/nodejs/node/pull/36141/commits/b3f787370c088610914ad883e1f8fcc9d4ee5938 |
| b3f7873 | https://github.com/nodejs/node/pull/36141/commits/b3f787370c088610914ad883e1f8fcc9d4ee5938 |
|
| https://github.com/aduh95 |
| fixup! http2: add support for TypedArray to getUnpackedSettings | https://github.com/nodejs/node/pull/36141/commits/80f8d3d9a4690b36fd374338e38224ae24b3f59b |
| 80f8d3d | https://github.com/nodejs/node/pull/36141/commits/80f8d3d9a4690b36fd374338e38224ae24b3f59b |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 17, 2020
| https://github.com/nodejs/node/pull/36141#pullrequestreview-532580013 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36141/files/80f8d3d9a4690b36fd374338e38224ae24b3f59b |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/36141#pullrequestreview-532580013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36141 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 17, 2020 | https://github.com/nodejs/node/pull/36141#event-4006660959 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 17, 2020 | https://github.com/nodejs/node/pull/36141#event-4006702108 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36141 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 17, 2020
| https://github.com/nodejs/node/pull/36141#pullrequestreview-532648326 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36141/files/80f8d3d9a4690b36fd374338e38224ae24b3f59b |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36141 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 17, 2020 | https://github.com/nodejs/node/pull/36141#issuecomment-729213812 |
| https://ci.nodejs.org/job/node-test-pull-request/34448/ | https://ci.nodejs.org/job/node-test-pull-request/34448/ |
| Please reload this page | https://github.com/nodejs/node/pull/36141 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 18, 2020
| https://github.com/nodejs/node/pull/36141#pullrequestreview-533399897 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36141/files/80f8d3d9a4690b36fd374338e38224ae24b3f59b |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 19, 2020 | https://github.com/nodejs/node/pull/36141#event-4017087936 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 19, 2020 | https://github.com/nodejs/node/pull/36141#event-4017147325 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 19, 2020 | https://github.com/nodejs/node/pull/36141#issuecomment-730535674 |
| 275aa68...ad0a01c | https://github.com/nodejs/node/compare/275aa6845ea7b17c73cc81ef80f64ffbf8eadc55...ad0a01caedbd792a7a62080439bf44ec27146798 |
| Please reload this page | https://github.com/nodejs/node/pull/36141 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 19, 2020 | https://github.com/nodejs/node/pull/36141#event-4017148000 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Nov 19, 2020
| https://github.com/nodejs/node/pull/36141#ref-commit-ad0a01c |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
| http2: add support for TypedArray to getUnpackedSettings | https://github.com/nodejs/node/commit/ad0a01caedbd792a7a62080439bf44ec27146798 |
| ad0a01c | https://github.com/nodejs/node/commit/ad0a01caedbd792a7a62080439bf44ec27146798 |
| #36141 | https://github.com/nodejs/node/pull/36141 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| November 19, 2020 18:12 | https://github.com/nodejs/node/pull/36141#event-4017247246 |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/36141#ref-commit-f0aed8c |
|
| https://github.com/aduh95 |
|
| https://github.com/codebytere |
| http2: add support for TypedArray to getUnpackedSettings | https://github.com/nodejs/node/commit/f0aed8c01c11706798da7732e4359011e0e9fb74 |
| f0aed8c | https://github.com/nodejs/node/commit/f0aed8c01c11706798da7732e4359011e0e9fb74 |
| #36141 | https://github.com/nodejs/node/pull/36141 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/36141#ref-pullrequest-748354048 |
|
v15.3.0 proposal
#36232
| https://github.com/nodejs/node/pull/36232 |
| targos | https://github.com/targos |
|
May 16, 2021
| https://github.com/nodejs/node/pull/36141#ref-commit-4d35416 |
|
| https://github.com/aduh95 |
|
| https://github.com/targos |
| http2: add support for TypedArray to getUnpackedSettings | https://github.com/nodejs/node/commit/4d35416b4bda55496f443b87ec9727ca46bed1d4 |
| 4d35416 | https://github.com/nodejs/node/commit/4d35416b4bda55496f443b87ec9727ca46bed1d4 |
| #36141 | https://github.com/nodejs/node/pull/36141 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jun 6, 2021
| https://github.com/nodejs/node/pull/36141#ref-pullrequest-912748369 |
|
v14.17.1 release proposal
#38948
| https://github.com/nodejs/node/pull/38948 |
| targos | https://github.com/targos |
|
Jun 11, 2021
| https://github.com/nodejs/node/pull/36141#ref-commit-74fe1d8 |
|
| https://github.com/aduh95 |
|
| https://github.com/targos |
| http2: add support for TypedArray to getUnpackedSettings | https://github.com/nodejs/node/commit/74fe1d8f0c8c1e51adca1ecba6780273a47a94cc |
| 74fe1d8 | https://github.com/nodejs/node/commit/74fe1d8f0c8c1e51adca1ecba6780273a47a94cc |
| #36141 | https://github.com/nodejs/node/pull/36141 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36141 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/36141/files/80f8d3d9a4690b36fd374338e38224ae24b3f59b |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/36141/files/80f8d3d9a4690b36fd374338e38224ae24b3f59b |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/36141/files/80f8d3d9a4690b36fd374338e38224ae24b3f59b |
| Please reload this page | https://github.com/nodejs/node/pull/36141 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
http2
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2 |
| Please reload this page | https://github.com/nodejs/node/pull/36141 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |