| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3269cd90-d00c-518b-e004-a056366ba8a6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 85C0:1D81B0:E7BA41:13EFB00:696A91E1 |
| html-safe-nonce | 9b7e2599694e76647a8ac2f399278c051cebdd980dcab754e3d98b2ef3b2c17c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUMwOjFEODFCMDpFN0JBNDE6MTNFRkIwMDo2OTZBOTFFMSIsInZpc2l0b3JfaWQiOiIzMjI5Njg5MjYwODc2MTQxMDI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 55a8d1d189b8b92768e174974b373ba02523f41a7b026ab81b973054b4d7eead |
| hovercard-subject-tag | pull_request:521045577 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36122/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f7d38e49b9c52406f403b6f05995210ef7454a71afc843c51497f89c450d41a3/nodejs/node/pull/36122 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f7d38e49b9c52406f403b6f05995210ef7454a71afc843c51497f89c450d41a3/nodejs/node/pull/36122 |
| og:image:alt | In preparation for #36099
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36122#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36122 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36122 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36122 |
| Reload | https://github.com/nodejs/node/pull/36122 |
| Reload | https://github.com/nodejs/node/pull/36122 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36122 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/36122 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/36122#issue-comment-box |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:license-builder-bashisms | https://github.com/aduh95/node/tree/license-builder-bashisms |
|
tools: remove bashisms from license builder script
| https://github.com/nodejs/node/pull/36122#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:license-builder-bashisms | https://github.com/aduh95/node/tree/license-builder-bashisms |
|
Conversation
3
| https://github.com/nodejs/node/pull/36122 |
|
Commits
1
| https://github.com/nodejs/node/pull/36122/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/36122/checks |
|
Files changed
| https://github.com/nodejs/node/pull/36122/files |
| Please reload this page | https://github.com/nodejs/node/pull/36122 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Nov 14, 2020 | https://github.com/nodejs/node/pull/36122#issue-743058576 |
| #36099 | https://github.com/nodejs/node/pull/36099 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/36122 |
|
| https://github.com/aduh95 |
| tools: remove bashisms from license builder script | https://github.com/nodejs/node/pull/36122/commits/73fbe5b1b756b5fa4870c9b5b2acb96abd7e69dc |
| 73fbe5b | https://github.com/nodejs/node/pull/36122/commits/73fbe5b1b756b5fa4870c9b5b2acb96abd7e69dc |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Nov 14, 2020 | https://github.com/nodejs/node/pull/36122#event-3996674136 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 14, 2020
| https://github.com/nodejs/node/pull/36122#ref-pullrequest-741806224 |
|
tools: lint shell scripts
#36099
| https://github.com/nodejs/node/pull/36099 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 16, 2020
| https://github.com/nodejs/node/pull/36122#pullrequestreview-531397307 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36122/files/73fbe5b1b756b5fa4870c9b5b2acb96abd7e69dc |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 16, 2020 | https://github.com/nodejs/node/pull/36122#event-4002711305 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 16, 2020 | https://github.com/nodejs/node/pull/36122#event-4002730541 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36122 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 17, 2020 | https://github.com/nodejs/node/pull/36122#issuecomment-728797206 |
| https://ci.nodejs.org/job/node-test-pull-request/34422/ | https://ci.nodejs.org/job/node-test-pull-request/34422/ |
| Please reload this page | https://github.com/nodejs/node/pull/36122 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 17, 2020
| https://github.com/nodejs/node/pull/36122#pullrequestreview-532251145 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36122/files/73fbe5b1b756b5fa4870c9b5b2acb96abd7e69dc |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 18, 2020 | https://github.com/nodejs/node/pull/36122#event-4012208878 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 18, 2020 | https://github.com/nodejs/node/pull/36122#event-4012266025 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 18, 2020 | https://github.com/nodejs/node/pull/36122#issuecomment-729887528 |
| 665da27...ed26808 | https://github.com/nodejs/node/compare/665da27e7e8d11a70d57468af806eb7493529da8...ed26808bdf1606017950b87fdc5bbdabf18d85ae |
| Please reload this page | https://github.com/nodejs/node/pull/36122 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 18, 2020 | https://github.com/nodejs/node/pull/36122#event-4012266614 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Nov 18, 2020
| https://github.com/nodejs/node/pull/36122#ref-commit-ed26808 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
| tools: remove bashisms from license builder script | https://github.com/nodejs/node/commit/ed26808bdf1606017950b87fdc5bbdabf18d85ae |
| ed26808 | https://github.com/nodejs/node/commit/ed26808bdf1606017950b87fdc5bbdabf18d85ae |
| #36122 | https://github.com/nodejs/node/pull/36122 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| November 18, 2020 19:10 | https://github.com/nodejs/node/pull/36122#event-4012312423 |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/36122#ref-commit-d8fcf2c |
|
| https://github.com/aduh95 |
|
| https://github.com/codebytere |
| tools: remove bashisms from license builder script | https://github.com/nodejs/node/commit/d8fcf2c324438e6f38d49466de6866bacd349383 |
| d8fcf2c | https://github.com/nodejs/node/commit/d8fcf2c324438e6f38d49466de6866bacd349383 |
| #36122 | https://github.com/nodejs/node/pull/36122 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/36122#ref-pullrequest-748354048 |
|
v15.3.0 proposal
#36232
| https://github.com/nodejs/node/pull/36232 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/36122#ref-commit-478b203 |
|
| https://github.com/aduh95 |
|
| https://github.com/BethGriggs |
| tools: remove bashisms from license builder script | https://github.com/nodejs/node/commit/478b203a540e2e409322a14fc413232afeb626ce |
| 478b203 | https://github.com/nodejs/node/commit/478b203a540e2e409322a14fc413232afeb626ce |
| #36122 | https://github.com/nodejs/node/pull/36122 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/36122#ref-commit-ca875f7 |
|
| https://github.com/aduh95 |
|
| https://github.com/BethGriggs |
| tools: remove bashisms from license builder script | https://github.com/nodejs/node/commit/ca875f729f743424f760303f27aaf4dd6bb31b41 |
| ca875f7 | https://github.com/nodejs/node/commit/ca875f729f743424f760303f27aaf4dd6bb31b41 |
| #36122 | https://github.com/nodejs/node/pull/36122 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/36122#ref-pullrequest-761612838 |
|
v14.15.2 proposal
#36476
| https://github.com/nodejs/node/pull/36476 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/36122#ref-commit-75e49b8 |
|
| https://github.com/aduh95 |
|
| https://github.com/BethGriggs |
| tools: remove bashisms from license builder script | https://github.com/nodejs/node/commit/75e49b833b933752d88fcfd222c3a2d335178fc9 |
| 75e49b8 | https://github.com/nodejs/node/commit/75e49b833b933752d88fcfd222c3a2d335178fc9 |
| #36122 | https://github.com/nodejs/node/pull/36122 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36122 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/36122/files/73fbe5b1b756b5fa4870c9b5b2acb96abd7e69dc |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/36122/files/73fbe5b1b756b5fa4870c9b5b2acb96abd7e69dc |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/36122 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |