René's URL Explorer Experiment


Title: tls: use the most recently added matching SecureContext in default SN… by mkrawczuk · Pull Request #36072 · nodejs/node · GitHub

Open Graph Title: tls: use the most recently added matching SecureContext in default SN… by mkrawczuk · Pull Request #36072 · nodejs/node

X Title: tls: use the most recently added matching SecureContext in default SN… by mkrawczuk · Pull Request #36072 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Sorry, ruined the previous PR (#34638) with a merge. Fixes: #34110 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is change...

X Description: Sorry, ruined the previous PR (#34638) with a merge. Fixes: #34110 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is change...

Opengraph URL: https://github.com/nodejs/node/pull/36072

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:103b32e3-9829-27ad-9be2-d2b3344ca6bb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF98:145E3B:4E131:6529E:6A524A37
html-safe-nonce04705a7be7c0cacc426c2b356dff4aa4a143f82228e4f982c5c3aba561a45a93
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjk4OjE0NUUzQjo0RTEzMTo2NTI5RTo2QTUyNEEzNyIsInZpc2l0b3JfaWQiOiIyMzMwMzAyNTA2MTUwODA4MTE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac547f6d23950d280fd08f5a5e0a4fef2ad4fdd52ff4faf8313b25171b340d61a0
hovercard-subject-tagpull_request:518678645
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36072/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5dac4d215c3d92d10d6db3576769576b6b803cbbb5c7d39a3415c01fe782bb2f/nodejs/node/pull/36072
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5dac4d215c3d92d10d6db3576769576b6b803cbbb5c7d39a3415c01fe782bb2f/nodejs/node/pull/36072
og:image:altSorry, ruined the previous PR (#34638) with a merge. Fixes: #34110 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is change...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemkrawczuk
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36072#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36072
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36072
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36072
Reloadhttps://github.com/nodejs/node/pull/36072
Reloadhttps://github.com/nodejs/node/pull/36072
Please reload this pagehttps://github.com/nodejs/node/pull/36072
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36072
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 984 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
mkrawczuk:34110_2https://github.com/mkrawczuk/node/tree/34110_2
Conversationhttps://github.com/nodejs/node/pull/36072
Commits1 (1)https://github.com/nodejs/node/pull/36072/commits
Checkshttps://github.com/nodejs/node/pull/36072/checks
Files changedhttps://github.com/nodejs/node/pull/36072/files
tls: use the most recently added matching SecureContext in default SN…https://github.com/nodejs/node/pull/36072#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
mkrawczuk:34110_2https://github.com/mkrawczuk/node/tree/34110_2
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Nov 10, 2020https://github.com/nodejs/node/pull/36072#issue-740139373
Please reload this pagehttps://github.com/nodejs/node/pull/36072
#34638https://github.com/nodejs/node/pull/34638
#34110https://github.com/nodejs/node/issues/34110
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Nov 10, 2020https://github.com/nodejs/node/pull/36072#event-3980333068
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Nov 10, 2020 https://github.com/nodejs/node/pull/36072#ref-pullrequest-673892091
tls: use the most recently added matching SecureContext in default SNICallback. #34638 https://github.com/nodejs/node/pull/34638
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Nov 10, 2020 https://github.com/nodejs/node/pull/36072#pullrequestreview-527699191
View reviewed changes https://github.com/nodejs/node/pull/36072/files
test/parallel/test-tls-secure-context-usage-order.jshttps://github.com/nodejs/node/pull/36072/files#diff-23fb75d0240f7311f0130250bd470ca567927b22c346197af8d13bfb658467cb
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Nov 10, 2020 https://github.com/nodejs/node/pull/36072#pullrequestreview-527700439
View reviewed changes https://github.com/nodejs/node/pull/36072/files
test/parallel/test-tls-secure-context-usage-order.jshttps://github.com/nodejs/node/pull/36072/files#diff-23fb75d0240f7311f0130250bd470ca567927b22c346197af8d13bfb658467cb
mscdexhttps://github.com/mscdex
Nov 10, 2020https://github.com/nodejs/node/pull/36072#discussion_r520948417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2020 https://github.com/nodejs/node/pull/36072#pullrequestreview-529101183
View reviewed changes https://github.com/nodejs/node/pull/36072/files
doc/api/tls.mdhttps://github.com/nodejs/node/pull/36072/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2020 https://github.com/nodejs/node/pull/36072#pullrequestreview-529101887
View reviewed changes https://github.com/nodejs/node/pull/36072/files
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 12, 2020https://github.com/nodejs/node/pull/36072#issuecomment-726089276
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/Trott
Trotthttps://github.com/Trott
addaleaxhttps://github.com/addaleax
November 16, 2020 14:41https://github.com/nodejs/node/pull/36072#event-4000607974
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Dec 16, 2020https://github.com/nodejs/node/pull/36072#issuecomment-746584248
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/Trott
Trotthttps://github.com/Trott
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 23, 2020https://github.com/nodejs/node/pull/36072#event-4143958402
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 23, 2020https://github.com/nodejs/node/pull/36072#event-4143958732
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 23, 2020https://github.com/nodejs/node/pull/36072#issuecomment-750278519
https://ci.nodejs.org/job/node-test-pull-request/35053/https://ci.nodejs.org/job/node-test-pull-request/35053/
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
force-pushedhttps://github.com/nodejs/node/compare/c377e1039a457f39228ba31dac1be88c316566aa..e4838cae8a1cdeecfc30f162a8e659f852f38815
c377e10https://github.com/nodejs/node/commit/c377e1039a457f39228ba31dac1be88c316566aa
e4838cahttps://github.com/nodejs/node/commit/e4838cae8a1cdeecfc30f162a8e659f852f38815
Compare https://github.com/nodejs/node/compare/c377e1039a457f39228ba31dac1be88c316566aa..e4838cae8a1cdeecfc30f162a8e659f852f38815
December 23, 2020 13:19https://github.com/nodejs/node/pull/36072#event-4144105142
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Dec 23, 2020https://github.com/nodejs/node/pull/36072#issuecomment-750298306
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 28, 2020https://github.com/nodejs/node/pull/36072#issuecomment-751556441
https://ci.nodejs.org/job/node-test-pull-request/35104/https://ci.nodejs.org/job/node-test-pull-request/35104/
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 7, 2021 https://github.com/nodejs/node/pull/36072#pullrequestreview-563676434
View reviewed changes https://github.com/nodejs/node/pull/36072/files
https://github.com/mkrawczuk
https://github.com/Trott
tls: use recently added matching SecureContext in default SNICallbackhttps://github.com/nodejs/node/pull/36072/commits/8cf5281da2bccfb467c64cbc88519f802ff540ec
8cf5281https://github.com/nodejs/node/pull/36072/commits/8cf5281da2bccfb467c64cbc88519f802ff540ec
nodejs#36072https://github.com/nodejs/node/pull/36072
nodejs#34110https://github.com/nodejs/node/issues/34110
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/e4838cae8a1cdeecfc30f162a8e659f852f38815..8cf5281da2bccfb467c64cbc88519f802ff540ec
e4838cahttps://github.com/nodejs/node/commit/e4838cae8a1cdeecfc30f162a8e659f852f38815
8cf5281https://github.com/nodejs/node/commit/8cf5281da2bccfb467c64cbc88519f802ff540ec
Compare https://github.com/nodejs/node/compare/e4838cae8a1cdeecfc30f162a8e659f852f38815..8cf5281da2bccfb467c64cbc88519f802ff540ec
January 15, 2021 12:50https://github.com/nodejs/node/pull/36072#event-4211018355
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 15, 2021https://github.com/nodejs/node/pull/36072#issuecomment-760923838
8cf5281https://github.com/nodejs/node/commit/8cf5281da2bccfb467c64cbc88519f802ff540ec
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/Trott
Trotthttps://github.com/Trott
8cf5281https://github.com/nodejs/node/commit/8cf5281da2bccfb467c64cbc88519f802ff540ec
Jan 15, 2021https://github.com/nodejs/node/pull/36072#event-4211019694
ruyadornohttps://github.com/ruyadorno
Jan 22, 2021 https://github.com/nodejs/node/pull/36072#ref-commit-864b97b
https://github.com/mkrawczuk
https://github.com/ruyadorno
tls: use recently added matching SecureContext in default SNICallbackhttps://github.com/nodejs/node/commit/864b97b24dc07c13fafd2cd717e33035c28e67e2
864b97bhttps://github.com/nodejs/node/commit/864b97b24dc07c13fafd2cd717e33035c28e67e2
#36072https://github.com/nodejs/node/pull/36072
#34110https://github.com/nodejs/node/issues/34110
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Jan 22, 2021 https://github.com/nodejs/node/pull/36072#ref-pullrequest-791653749
v15.7.0 proposal #37020 https://github.com/nodejs/node/pull/37020
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
May 25, 2021https://github.com/nodejs/node/pull/36072#event-4793282583
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
Aug 6, 2024 https://github.com/nodejs/node/pull/36072#ref-issue-2451742244
Root certificate is prioritized over SNICallback context in HTTPS Server #54235 https://github.com/nodejs/node/issues/54235
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36072
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/36072/files/e7b455e0ecf2852a04c6675e4c7025245ba19cff
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/36072/files/e4838cae8a1cdeecfc30f162a8e659f852f38815
https://github.com/mscdex
mscdex https://github.com/mscdex
https://github.com/nodejs/node/pull/36072/files/e7b455e0ecf2852a04c6675e4c7025245ba19cff
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
tls: server.addContext does not update the context if there was one registered for a given servername wildcard. https://github.com/nodejs/node/issues/34110
Please reload this pagehttps://github.com/nodejs/node/pull/36072
https://github.com/mkrawczuk
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/mscdex
https://github.com/addaleax
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.