René's URL Explorer Experiment


Title: n-api: improve consistency of how we get context by mhdawson · Pull Request #36068 · nodejs/node · GitHub

Open Graph Title: n-api: improve consistency of how we get context by mhdawson · Pull Request #36068 · nodejs/node

X Title: n-api: improve consistency of how we get context by mhdawson · Pull Request #36068 · nodejs/node

Description: Refs: nodejs/node-addon-api#764 Improve the consistency of how we get a context when needed. We generally used env->context() in N-API but there were are few exceptions that this PR addresses. Sign...

Open Graph Description: Refs: nodejs/node-addon-api#764 Improve the consistency of how we get a context when needed. We generally used env->context() in N-API but there were are few exceptions that this PR addresses. S...

X Description: Refs: nodejs/node-addon-api#764 Improve the consistency of how we get a context when needed. We generally used env->context() in N-API but there were are few exceptions that this PR addresse...

Mail addresses
mdawson@devrus.com

Opengraph URL: https://github.com/nodejs/node/pull/36068

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:855e0c7c-51bc-21d0-fe7b-392a714b02d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7DA:388B78:17384E9:1E2B21B:696B2762
html-safe-noncee7aa3c6a43ee4619890cb7e41e75285977312ebd18c6ffca2fe30bea9ed6b426
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0RBOjM4OEI3ODoxNzM4NEU5OjFFMkIyMUI6Njk2QjI3NjIiLCJ2aXNpdG9yX2lkIjoiNjgyMTE0MDQ3OTk5OTY4MjQwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8fdfacdf51088f4092fc76c41dcb734bc7d498a944852dd66152216ab65f0f2b
hovercard-subject-tagpull_request:518566957
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36068/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7aecc5ba916cf2b16e5b04888eecdfed343d6cea5ddc40863526b6365601c745/nodejs/node/pull/36068
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7aecc5ba916cf2b16e5b04888eecdfed343d6cea5ddc40863526b6365601c745/nodejs/node/pull/36068
og:image:altRefs: nodejs/node-addon-api#764 Improve the consistency of how we get a context when needed. We generally used env->context() in N-API but there were are few exceptions that this PR addresses. S...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhdawson
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36068#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36068
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36068
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36068
Reloadhttps://github.com/nodejs/node/pull/36068
Reloadhttps://github.com/nodejs/node/pull/36068
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36068
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/36068
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/36068#issue-comment-box
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node/tree/master
mhdawson:napi-consistencyhttps://github.com/mhdawson/io.js/tree/napi-consistency
n-api: improve consistency of how we get context https://github.com/nodejs/node/pull/36068#top
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node/tree/master
mhdawson:napi-consistencyhttps://github.com/mhdawson/io.js/tree/napi-consistency
Conversation 9 https://github.com/nodejs/node/pull/36068
Commits 1 https://github.com/nodejs/node/pull/36068/commits
Checks 0 https://github.com/nodejs/node/pull/36068/checks
Files changed https://github.com/nodejs/node/pull/36068/files
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 10, 2020https://github.com/nodejs/node/pull/36068#issue-740004667
nodejs/node-addon-api#764https://github.com/nodejs/node-addon-api/issues/764
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.com/mhdawson
n-api: improve consistency of how we get contexthttps://github.com/nodejs/node/pull/36068/commits/9f559af8c9b9664b3f592eb374ec25128309f7a1
9f559afhttps://github.com/nodejs/node/pull/36068/commits/9f559af8c9b9664b3f592eb374ec25128309f7a1
nodejs/node-addon-api#764https://github.com/nodejs/node-addon-api/issues/764
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 10, 2020https://github.com/nodejs/node/pull/36068#issuecomment-724772768
Please reload this pagehttps://github.com/nodejs/node/pull/36068
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Nov 10, 2020https://github.com/nodejs/node/pull/36068#event-3979486818
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 10, 2020 https://github.com/nodejs/node/pull/36068#pullrequestreview-527395657
View reviewed changes https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/NickNaso
NickNasohttps://github.com/NickNaso
Nov 10, 2020 https://github.com/nodejs/node/pull/36068#pullrequestreview-527440927
View reviewed changes https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
NickNasohttps://github.com/NickNaso
https://github.com/nodejs/node/pull/36068#pullrequestreview-527440927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 10, 2020 https://github.com/nodejs/node/pull/36068#pullrequestreview-527457417
View reviewed changes https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Nov 10, 2020https://github.com/nodejs/node/pull/36068#event-3980199209
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 10, 2020 https://github.com/nodejs/node/pull/36068#pullrequestreview-527570363
View reviewed changes https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 11, 2020 https://github.com/nodejs/node/pull/36068#pullrequestreview-528228031
View reviewed changes https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 11, 2020https://github.com/nodejs/node/pull/36068#event-3984209966
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 11, 2020https://github.com/nodejs/node/pull/36068#event-3984269571
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36068
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 12, 2020https://github.com/nodejs/node/pull/36068#issuecomment-725773818
https://ci.nodejs.org/job/node-test-pull-request/34351/https://ci.nodejs.org/job/node-test-pull-request/34351/
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.com/legendecas
legendecashttps://github.com/legendecas
Nov 13, 2020 https://github.com/nodejs/node/pull/36068#pullrequestreview-529818044
View reviewed changes https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 14, 2020https://github.com/nodejs/node/pull/36068#issuecomment-727208208
https://ci.nodejs.org/job/node-test-pull-request/34393/https://ci.nodejs.org/job/node-test-pull-request/34393/
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 17, 2020https://github.com/nodejs/node/pull/36068#issuecomment-728630014
https://ci.nodejs.org/job/node-test-pull-request/34418/https://ci.nodejs.org/job/node-test-pull-request/34418/
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 17, 2020https://github.com/nodejs/node/pull/36068#issuecomment-728776854
https://ci.nodejs.org/job/node-test-pull-request/34419/https://ci.nodejs.org/job/node-test-pull-request/34419/
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 17, 2020https://github.com/nodejs/node/pull/36068#issuecomment-729239212
Please reload this pagehttps://github.com/nodejs/node/pull/36068
mhdawsonhttps://github.com/mhdawson
Nov 17, 2020 https://github.com/nodejs/node/pull/36068#ref-commit-cbfa2d1
https://github.com/mhdawson
n-api: improve consistency of how we get contexthttps://github.com/nodejs/node/commit/cbfa2d11d4e42ea7f6a847a6930fd1022773252e
cbfa2d1https://github.com/nodejs/node/commit/cbfa2d11d4e42ea7f6a847a6930fd1022773252e
nodejs/node-addon-api#764https://github.com/nodejs/node-addon-api/issues/764
#36068https://github.com/nodejs/node/pull/36068
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 17, 2020https://github.com/nodejs/node/pull/36068#issuecomment-729245624
cbfa2d1https://github.com/nodejs/node/commit/cbfa2d11d4e42ea7f6a847a6930fd1022773252e
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 17, 2020https://github.com/nodejs/node/pull/36068#event-4007770924
codebyterehttps://github.com/codebytere
Nov 22, 2020 https://github.com/nodejs/node/pull/36068#ref-commit-3d623d8
https://github.com/mhdawson
https://github.com/codebytere
n-api: improve consistency of how we get contexthttps://github.com/nodejs/node/commit/3d623d850c80eee6b000f95d3b8c1b576bc8798e
3d623d8https://github.com/nodejs/node/commit/3d623d850c80eee6b000f95d3b8c1b576bc8798e
nodejs/node-addon-api#764https://github.com/nodejs/node-addon-api/issues/764
#36068https://github.com/nodejs/node/pull/36068
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 22, 2020 https://github.com/nodejs/node/pull/36068#ref-pullrequest-748354048
v15.3.0 proposal #36232 https://github.com/nodejs/node/pull/36232
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/36068#ref-commit-b42949f
https://github.com/mhdawson
https://github.com/BethGriggs
n-api: improve consistency of how we get contexthttps://github.com/nodejs/node/commit/b42949f0c953841b84617b28a9df9c3643d062ca
b42949fhttps://github.com/nodejs/node/commit/b42949f0c953841b84617b28a9df9c3643d062ca
nodejs/node-addon-api#764https://github.com/nodejs/node-addon-api/issues/764
#36068https://github.com/nodejs/node/pull/36068
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/36068#ref-commit-4b383e1
https://github.com/mhdawson
https://github.com/BethGriggs
n-api: improve consistency of how we get contexthttps://github.com/nodejs/node/commit/4b383e18afa130ef4c61d27f2ba86e73c6e5fc74
4b383e1https://github.com/nodejs/node/commit/4b383e18afa130ef4c61d27f2ba86e73c6e5fc74
nodejs/node-addon-api#764https://github.com/nodejs/node-addon-api/issues/764
#36068https://github.com/nodejs/node/pull/36068
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/36068#ref-pullrequest-761612838
v14.15.2 proposal #36476 https://github.com/nodejs/node/pull/36476
BethGriggshttps://github.com/BethGriggs
Dec 15, 2020 https://github.com/nodejs/node/pull/36068#ref-commit-dde727e
https://github.com/mhdawson
https://github.com/BethGriggs
n-api: improve consistency of how we get contexthttps://github.com/nodejs/node/commit/dde727e72f9b06f3287d9940d5bb14763d12e08f
dde727ehttps://github.com/nodejs/node/commit/dde727e72f9b06f3287d9940d5bb14763d12e08f
nodejs/node-addon-api#764https://github.com/nodejs/node-addon-api/issues/764
#36068https://github.com/nodejs/node/pull/36068
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36068
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
https://github.com/NickNaso
NickNaso https://github.com/NickNaso
https://github.com/nodejs/node/pull/36068/files/9f559af8c9b9664b3f592eb374ec25128309f7a1
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/36068
https://github.com/mhdawson
https://github.com/nodejs-github-bot
https://github.com/NickNaso
https://github.com/Trott
https://github.com/gabrielschulhof
https://github.com/benjamingr
https://github.com/legendecas
https://github.com/juanarbol
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.