| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:52ad858a-11de-d62b-5576-5382e8d5bf7b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C304:917F8:7823E:9D8A2:6A52E933 |
| html-safe-nonce | 6db8ea74891e1a9fd35f20997cffb681c3344e22e8b7f793ef0663c94436dc39 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzA0OjkxN0Y4Ojc4MjNFOjlEOEEyOjZBNTJFOTMzIiwidmlzaXRvcl9pZCI6IjIyMjAyNTEzMzUwNTk3NjE0NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 19cd1da504dbef05a03c35424e406ae2003a336e0d165ed014d333c71409cb54 |
| hovercard-subject-tag | pull_request:518327902 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36061/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a5d7f0e5d9edede963d9ea25f50bf47c4029e9d1488f62b8f0b926b552a5f42d/nodejs/node/pull/36061 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a5d7f0e5d9edede963d9ea25f50bf47c4029e9d1488f62b8f0b926b552a5f42d/nodejs/node/pull/36061 |
| og:image:alt | Mostly opened for discussion about semantics.
Are these semantics correct? Do they make sense?
This is WIP: I want to test this thoroughly before considering merging + docs need to be updated.
Chec... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | benjamingr |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36061#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36061 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36061 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36061 |
| Reload | https://github.com/nodejs/node/pull/36061 |
| Reload | https://github.com/nodejs/node/pull/36061 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
995
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| benjamingr | https://github.com/benjamingr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| benjamingr:abort-signal-stream | https://github.com/benjamingr/io.js/tree/abort-signal-stream |
| Conversation | https://github.com/nodejs/node/pull/36061 |
| Commits1 (1) | https://github.com/nodejs/node/pull/36061/commits |
| Checks | https://github.com/nodejs/node/pull/36061/checks |
| Files changed | https://github.com/nodejs/node/pull/36061/files |
| stream: abort signal in readable streams | https://github.com/nodejs/node/pull/36061#top |
| benjamingr | https://github.com/benjamingr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| benjamingr:abort-signal-stream | https://github.com/benjamingr/io.js/tree/abort-signal-stream |
|
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/36061#issue-739715378 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/36061#event-3977737958 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| mcollina | https://github.com/mcollina |
| ronag | https://github.com/ronag |
| November 10, 2020 08:54 | https://github.com/nodejs/node/pull/36061#event-3977737975 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-724559241 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-724736875 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-724742679 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-724750373 |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-724759791 |
| @bterlson | https://github.com/bterlson |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-724787768 |
| 6a92d8c | https://github.com/nodejs/node/commit/6a92d8c83221eaf4c96bb6649f77c5af242757fe |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 10, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-527358465 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| lib/internal/streams/add-abort-signal.js | https://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| November 20, 2020 09:56 | https://github.com/nodejs/node/pull/36061#event-4020087097 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-731068929 |
| @mcollina | https://github.com/mcollina |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| force-pushed | https://github.com/nodejs/node/compare/6a92d8c83221eaf4c96bb6649f77c5af242757fe..52d3dd601f5ed42f6788a4875e7fbf0b207a6a78 |
| 6a92d8c | https://github.com/nodejs/node/commit/6a92d8c83221eaf4c96bb6649f77c5af242757fe |
| 52d3dd6 | https://github.com/nodejs/node/commit/52d3dd601f5ed42f6788a4875e7fbf0b207a6a78 |
|
Compare
| https://github.com/nodejs/node/compare/6a92d8c83221eaf4c96bb6649f77c5af242757fe..52d3dd601f5ed42f6788a4875e7fbf0b207a6a78 |
| November 20, 2020 09:57 | https://github.com/nodejs/node/pull/36061#event-4020092223 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/36061#event-4021335029 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/36061#event-4021390399 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-731231715 |
| https://ci.nodejs.org/job/node-test-pull-request/34485/ | https://ci.nodejs.org/job/node-test-pull-request/34485/ |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 20, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535534996 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/36061/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| jasnell | https://github.com/jasnell |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/36061#discussion_r527773851 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Nov 20, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535536397 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| test/parallel/test-stream-readable-destroy.js | https://github.com/nodejs/node/pull/36061/files#diff-09507a28825d29050670af0f06e9e0bc78bb258ad51d52703ff085445db8efc2 |
| jasnell | https://github.com/jasnell |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/36061#discussion_r527774877 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 20, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535458595 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| lib/internal/streams/add-abort-signal.js | https://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Nov 20, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535562151 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| doc/api/stream.md | https://github.com/nodejs/node/pull/36061/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 20, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535564187 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| test/parallel/test-stream-readable-destroy.js | https://github.com/nodejs/node/pull/36061/files#diff-09507a28825d29050670af0f06e9e0bc78bb258ad51d52703ff085445db8efc2 |
| mcollina | https://github.com/mcollina |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/36061#discussion_r527796109 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 21, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-731556065 |
| @mcollina | https://github.com/mcollina |
| @jasnell | https://github.com/jasnell |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 21, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535966465 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| lib/internal/streams/add-abort-signal.js | https://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed |
| mcollina | https://github.com/mcollina |
| Nov 21, 2020 | https://github.com/nodejs/node/pull/36061#discussion_r528196490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| lib/internal/streams/add-abort-signal.js | https://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| lib/internal/streams/add-abort-signal.js | https://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed |
| mcollina | https://github.com/mcollina |
| Nov 21, 2020 | https://github.com/nodejs/node/pull/36061#discussion_r528196568 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| benjamingr | https://github.com/benjamingr |
| Nov 21, 2020 | https://github.com/nodejs/node/pull/36061#discussion_r528200698 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| lib/internal/streams/add-abort-signal.js | https://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Nov 21, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535966885 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| lib/internal/streams/add-abort-signal.js | https://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Nov 21, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535966899 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| lib/internal/streams/readable.js | https://github.com/nodejs/node/pull/36061/files#diff-040c1f5a53844e600d40b33c4624f1fe39fcf2f8d62c76ca3fc5ea5442231469 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Nov 21, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535966930 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| lib/internal/streams/add-abort-signal.js | https://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Nov 21, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-731581503 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 21, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-731585199 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 21, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-731586132 |
| @mcollina | https://github.com/mcollina |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Nov 21, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-535971021 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files |
| lib/internal/streams/add-abort-signal.js | https://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
|
| https://github.com/benjamingr |
| stream: support abort signal | https://github.com/nodejs/node/pull/36061/commits/04cf1c7662dd5d70fd02d544ddb41334525c7f62 |
| 04cf1c7 | https://github.com/nodejs/node/pull/36061/commits/04cf1c7662dd5d70fd02d544ddb41334525c7f62 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| force-pushed | https://github.com/nodejs/node/compare/4b21891ad9a000455651f9fdf0de863eabf56851..04cf1c7662dd5d70fd02d544ddb41334525c7f62 |
| 4b21891 | https://github.com/nodejs/node/commit/4b21891ad9a000455651f9fdf0de863eabf56851 |
| 04cf1c7 | https://github.com/nodejs/node/commit/04cf1c7662dd5d70fd02d544ddb41334525c7f62 |
|
Compare
| https://github.com/nodejs/node/compare/4b21891ad9a000455651f9fdf0de863eabf56851..04cf1c7662dd5d70fd02d544ddb41334525c7f62 |
| December 6, 2020 20:35 | https://github.com/nodejs/node/pull/36061#event-4076981877 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 6, 2020 | https://github.com/nodejs/node/pull/36061#event-4077012406 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 6, 2020 | https://github.com/nodejs/node/pull/36061#event-4077022007 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 6, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-739566055 |
| https://ci.nodejs.org/job/node-test-pull-request/34804/ | https://ci.nodejs.org/job/node-test-pull-request/34804/ |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-739826633 |
| https://ci.nodejs.org/job/node-test-pull-request/34813/ | https://ci.nodejs.org/job/node-test-pull-request/34813/ |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-739907769 |
| https://ci.nodejs.org/job/node-test-pull-request/34817/ | https://ci.nodejs.org/job/node-test-pull-request/34817/ |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#event-4079963670 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#event-4079976372 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-739958974 |
| https://github.com/nodejs/node/actions/runs/406052944 | https://github.com/nodejs/node/actions/runs/406052944 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-739986158 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/36061#pullrequestreview-546289946 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36061/files/04cf1c7662dd5d70fd02d544ddb41334525c7f62 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/36061#pullrequestreview-546289946 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#event-4080419813 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#event-4080428810 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-740014471 |
| 5122456...5bd1eec | https://github.com/nodejs/node/compare/5122456883071d3a06047293f17c6f86b7476113...5bd1eecfa986f1d1ccec08dfdfb269489efc18cc |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#event-4080429483 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/36061#ref-commit-5bd1eec |
|
| https://github.com/benjamingr |
|
| https://github.com/nodejs-github-bot |
| stream: support abort signal | https://github.com/nodejs/node/commit/5bd1eecfa986f1d1ccec08dfdfb269489efc18cc |
| 5bd1eec | https://github.com/nodejs/node/commit/5bd1eecfa986f1d1ccec08dfdfb269489efc18cc |
| #36061 | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Dec 7, 2020 | https://github.com/nodejs/node/pull/36061#issuecomment-740017089 |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| December 7, 2020 16:12 | https://github.com/nodejs/node/pull/36061#event-4080450936 |
| danielleadams | https://github.com/danielleadams |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/36061#ref-commit-197ba21 |
|
| https://github.com/benjamingr |
|
| https://github.com/danielleadams |
| stream: support abort signal | https://github.com/nodejs/node/commit/197ba212793728a36f23553061a9a4ff50bdc685 |
| 197ba21 | https://github.com/nodejs/node/commit/197ba212793728a36f23553061a9a4ff50bdc685 |
| #36061 | https://github.com/nodejs/node/pull/36061 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/36061#ref-pullrequest-758834739 |
|
v15.4.0 proposal
#36435
| https://github.com/nodejs/node/pull/36435 |
| danielleadams | https://github.com/danielleadams |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/36061#ref-commit-fde09a4 |
|
| https://github.com/danielleadams |
| 2020-12-08, Version 15.4.0 (Current) | https://github.com/nodejs/node/commit/fde09a4cdc9465e8ed51f2f8597e03d7384fc6c2 |
| fde09a4 | https://github.com/nodejs/node/commit/fde09a4cdc9465e8ed51f2f8597e03d7384fc6c2 |
| #36435 | https://github.com/nodejs/node/pull/36435 |
| #36308 | https://github.com/nodejs/node/pull/36308 |
| #36187 | https://github.com/nodejs/node/pull/36187 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #35949 | https://github.com/nodejs/node/pull/35949 |
| #35924 | https://github.com/nodejs/node/pull/35924 |
| #36263 | https://github.com/nodejs/node/pull/36263 |
| #36061 | https://github.com/nodejs/node/pull/36061 |
| #35922 | https://github.com/nodejs/node/pull/35922 |
| #36271 | https://github.com/nodejs/node/pull/36271 |
| cjihrig | https://github.com/cjihrig |
|
Dec 8, 2020
| https://github.com/nodejs/node/pull/36061#ref-commit-0ae0eb5 |
|
| https://github.com/benjamingr |
|
| https://github.com/cjihrig |
| stream: support abort signal | https://github.com/cjihrig/node/commit/0ae0eb5b39545870749029f074e2f98082b9e34a |
| 0ae0eb5 | https://github.com/cjihrig/node/commit/0ae0eb5b39545870749029f074e2f98082b9e34a |
| nodejs#36061 | https://github.com/nodejs/node/pull/36061 |
| danielleadams | https://github.com/danielleadams |
|
Dec 9, 2020
| https://github.com/nodejs/node/pull/36061#ref-commit-5e5927e |
|
| https://github.com/danielleadams |
| 2020-12-09, Version 15.4.0 (Current) | https://github.com/nodejs/node/commit/5e5927ec2e685399689e4fcfe630565b3101207f |
| 5e5927e | https://github.com/nodejs/node/commit/5e5927ec2e685399689e4fcfe630565b3101207f |
| #36435 | https://github.com/nodejs/node/pull/36435 |
| #36308 | https://github.com/nodejs/node/pull/36308 |
| #36187 | https://github.com/nodejs/node/pull/36187 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #35949 | https://github.com/nodejs/node/pull/35949 |
| #35924 | https://github.com/nodejs/node/pull/35924 |
| #36263 | https://github.com/nodejs/node/pull/36263 |
| #36061 | https://github.com/nodejs/node/pull/36061 |
| #35922 | https://github.com/nodejs/node/pull/35922 |
| #36271 | https://github.com/nodejs/node/pull/36271 |
| danielleadams | https://github.com/danielleadams |
|
Dec 9, 2020
| https://github.com/nodejs/node/pull/36061#ref-commit-348b7a9 |
|
| https://github.com/danielleadams |
| 2020-12-09, Version 15.4.0 (Current) | https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb |
|
| https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb#comments |
| 348b7a9 | https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb |
| #36435 | https://github.com/nodejs/node/pull/36435 |
| #36308 | https://github.com/nodejs/node/pull/36308 |
| #36187 | https://github.com/nodejs/node/pull/36187 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #35949 | https://github.com/nodejs/node/pull/35949 |
| #35924 | https://github.com/nodejs/node/pull/35924 |
| #36263 | https://github.com/nodejs/node/pull/36263 |
| #36061 | https://github.com/nodejs/node/pull/36061 |
| #35922 | https://github.com/nodejs/node/pull/35922 |
| #36271 | https://github.com/nodejs/node/pull/36271 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
|
Oct 29, 2021
| https://github.com/nodejs/node/pull/36061#ref-pullrequest-1039684604 |
|
lib: make validateAbortSignal stricter
#40657
| https://github.com/nodejs/node/pull/40657 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Apr 24, 2024
| https://github.com/nodejs/node/pull/36061#ref-pullrequest-2262279643 |
|
Adding VersionStream for nodejs-22
wolfi-dev/os#17646
| https://github.com/wolfi-dev/os/pull/17646 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36061 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/36061/files/52d3dd601f5ed42f6788a4875e7fbf0b207a6a78 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/36061/files/04cf1c7662dd5d70fd02d544ddb41334525c7f62 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/36061/files/c1fd1fa512df306628d1290d8ab855b9ddc382c3 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/36061 |
|
| https://github.com/benjamingr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ronag |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |