René's URL Explorer Experiment


Title: stream: abort signal in readable streams by benjamingr · Pull Request #36061 · nodejs/node · GitHub

Open Graph Title: stream: abort signal in readable streams by benjamingr · Pull Request #36061 · nodejs/node

X Title: stream: abort signal in readable streams by benjamingr · Pull Request #36061 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Mostly opened for discussion about semantics. Are these semantics correct? Do they make sense? This is WIP: I want to test this thoroughly before considering merging + docs need to be updated. Chec...

X Description: Mostly opened for discussion about semantics. Are these semantics correct? Do they make sense? This is WIP: I want to test this thoroughly before considering merging + docs need to be updated. Chec...

Opengraph URL: https://github.com/nodejs/node/pull/36061

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:52ad858a-11de-d62b-5576-5382e8d5bf7b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC304:917F8:7823E:9D8A2:6A52E933
html-safe-nonce6db8ea74891e1a9fd35f20997cffb681c3344e22e8b7f793ef0663c94436dc39
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzA0OjkxN0Y4Ojc4MjNFOjlEOEEyOjZBNTJFOTMzIiwidmlzaXRvcl9pZCI6IjIyMjAyNTEzMzUwNTk3NjE0NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac19cd1da504dbef05a03c35424e406ae2003a336e0d165ed014d333c71409cb54
hovercard-subject-tagpull_request:518327902
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36061/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a5d7f0e5d9edede963d9ea25f50bf47c4029e9d1488f62b8f0b926b552a5f42d/nodejs/node/pull/36061
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a5d7f0e5d9edede963d9ea25f50bf47c4029e9d1488f62b8f0b926b552a5f42d/nodejs/node/pull/36061
og:image:altMostly opened for discussion about semantics. Are these semantics correct? Do they make sense? This is WIP: I want to test this thoroughly before considering merging + docs need to be updated. Chec...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebenjamingr
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36061#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36061
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36061
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36061
Reloadhttps://github.com/nodejs/node/pull/36061
Reloadhttps://github.com/nodejs/node/pull/36061
Please reload this pagehttps://github.com/nodejs/node/pull/36061
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36061
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 995 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
benjamingrhttps://github.com/benjamingr
nodejs:masterhttps://github.com/nodejs/node/tree/master
benjamingr:abort-signal-streamhttps://github.com/benjamingr/io.js/tree/abort-signal-stream
Conversationhttps://github.com/nodejs/node/pull/36061
Commits1 (1)https://github.com/nodejs/node/pull/36061/commits
Checkshttps://github.com/nodejs/node/pull/36061/checks
Files changedhttps://github.com/nodejs/node/pull/36061/files
stream: abort signal in readable streamshttps://github.com/nodejs/node/pull/36061#top
benjamingrhttps://github.com/benjamingr
nodejs:masterhttps://github.com/nodejs/node/tree/master
benjamingr:abort-signal-streamhttps://github.com/benjamingr/io.js/tree/abort-signal-stream
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 10, 2020https://github.com/nodejs/node/pull/36061#issue-739715378
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Nov 10, 2020https://github.com/nodejs/node/pull/36061#event-3977737958
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
mcollinahttps://github.com/mcollina
ronaghttps://github.com/ronag
November 10, 2020 08:54https://github.com/nodejs/node/pull/36061#event-3977737975
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 10, 2020https://github.com/nodejs/node/pull/36061#issuecomment-724559241
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 10, 2020https://github.com/nodejs/node/pull/36061#issuecomment-724736875
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 10, 2020https://github.com/nodejs/node/pull/36061#issuecomment-724742679
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 10, 2020https://github.com/nodejs/node/pull/36061#issuecomment-724750373
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 10, 2020https://github.com/nodejs/node/pull/36061#issuecomment-724759791
@bterlsonhttps://github.com/bterlson
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 10, 2020https://github.com/nodejs/node/pull/36061#issuecomment-724787768
6a92d8chttps://github.com/nodejs/node/commit/6a92d8c83221eaf4c96bb6649f77c5af242757fe
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 10, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-527358465
View reviewed changes https://github.com/nodejs/node/pull/36061/files
lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
November 20, 2020 09:56https://github.com/nodejs/node/pull/36061#event-4020087097
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 20, 2020https://github.com/nodejs/node/pull/36061#issuecomment-731068929
@mcollinahttps://github.com/mcollina
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
force-pushedhttps://github.com/nodejs/node/compare/6a92d8c83221eaf4c96bb6649f77c5af242757fe..52d3dd601f5ed42f6788a4875e7fbf0b207a6a78
6a92d8chttps://github.com/nodejs/node/commit/6a92d8c83221eaf4c96bb6649f77c5af242757fe
52d3dd6https://github.com/nodejs/node/commit/52d3dd601f5ed42f6788a4875e7fbf0b207a6a78
Compare https://github.com/nodejs/node/compare/6a92d8c83221eaf4c96bb6649f77c5af242757fe..52d3dd601f5ed42f6788a4875e7fbf0b207a6a78
November 20, 2020 09:57https://github.com/nodejs/node/pull/36061#event-4020092223
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 20, 2020https://github.com/nodejs/node/pull/36061#event-4021335029
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 20, 2020https://github.com/nodejs/node/pull/36061#event-4021390399
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2020https://github.com/nodejs/node/pull/36061#issuecomment-731231715
https://ci.nodejs.org/job/node-test-pull-request/34485/https://ci.nodejs.org/job/node-test-pull-request/34485/
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 20, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535534996
View reviewed changes https://github.com/nodejs/node/pull/36061/files
doc/api/stream.mdhttps://github.com/nodejs/node/pull/36061/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90
jasnellhttps://github.com/jasnell
Nov 20, 2020https://github.com/nodejs/node/pull/36061#discussion_r527773851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 20, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535536397
View reviewed changes https://github.com/nodejs/node/pull/36061/files
test/parallel/test-stream-readable-destroy.jshttps://github.com/nodejs/node/pull/36061/files#diff-09507a28825d29050670af0f06e9e0bc78bb258ad51d52703ff085445db8efc2
jasnellhttps://github.com/jasnell
Nov 20, 2020https://github.com/nodejs/node/pull/36061#discussion_r527774877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 20, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535458595
View reviewed changes https://github.com/nodejs/node/pull/36061/files
lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 20, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535562151
View reviewed changes https://github.com/nodejs/node/pull/36061/files
doc/api/stream.mdhttps://github.com/nodejs/node/pull/36061/files#diff-00d8d040a3fe90e3052af39cb55dc9bcac70539d5d17791449cbfe7e3b55fb90
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 20, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535564187
View reviewed changes https://github.com/nodejs/node/pull/36061/files
test/parallel/test-stream-readable-destroy.jshttps://github.com/nodejs/node/pull/36061/files#diff-09507a28825d29050670af0f06e9e0bc78bb258ad51d52703ff085445db8efc2
mcollinahttps://github.com/mcollina
Nov 20, 2020https://github.com/nodejs/node/pull/36061#discussion_r527796109
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 21, 2020https://github.com/nodejs/node/pull/36061#issuecomment-731556065
@mcollinahttps://github.com/mcollina
@jasnellhttps://github.com/jasnell
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Nov 21, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535966465
View reviewed changes https://github.com/nodejs/node/pull/36061/files
lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed
mcollinahttps://github.com/mcollina
Nov 21, 2020https://github.com/nodejs/node/pull/36061#discussion_r528196490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36061
lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed
Please reload this pagehttps://github.com/nodejs/node/pull/36061
lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed
mcollinahttps://github.com/mcollina
Nov 21, 2020https://github.com/nodejs/node/pull/36061#discussion_r528196568
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36061
benjamingrhttps://github.com/benjamingr
Nov 21, 2020https://github.com/nodejs/node/pull/36061#discussion_r528200698
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36061
lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 21, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535966885
View reviewed changes https://github.com/nodejs/node/pull/36061/files
lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 21, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535966899
View reviewed changes https://github.com/nodejs/node/pull/36061/files
lib/internal/streams/readable.jshttps://github.com/nodejs/node/pull/36061/files#diff-040c1f5a53844e600d40b33c4624f1fe39fcf2f8d62c76ca3fc5ea5442231469
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 21, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535966930
View reviewed changes https://github.com/nodejs/node/pull/36061/files
lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 21, 2020https://github.com/nodejs/node/pull/36061#issuecomment-731581503
Please reload this pagehttps://github.com/nodejs/node/pull/36061
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 21, 2020https://github.com/nodejs/node/pull/36061#issuecomment-731585199
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 21, 2020https://github.com/nodejs/node/pull/36061#issuecomment-731586132
@mcollinahttps://github.com/mcollina
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/ronag
ronaghttps://github.com/ronag
Nov 21, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-535971021
View reviewed changes https://github.com/nodejs/node/pull/36061/files
lib/internal/streams/add-abort-signal.jshttps://github.com/nodejs/node/pull/36061/files#diff-eb7a7381249df9a97ef2298e07f02f60cca849f82215f6613ede7494dd7a77ed
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
stream: support abort signalhttps://github.com/nodejs/node/pull/36061/commits/04cf1c7662dd5d70fd02d544ddb41334525c7f62
04cf1c7https://github.com/nodejs/node/pull/36061/commits/04cf1c7662dd5d70fd02d544ddb41334525c7f62
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
force-pushedhttps://github.com/nodejs/node/compare/4b21891ad9a000455651f9fdf0de863eabf56851..04cf1c7662dd5d70fd02d544ddb41334525c7f62
4b21891https://github.com/nodejs/node/commit/4b21891ad9a000455651f9fdf0de863eabf56851
04cf1c7https://github.com/nodejs/node/commit/04cf1c7662dd5d70fd02d544ddb41334525c7f62
Compare https://github.com/nodejs/node/compare/4b21891ad9a000455651f9fdf0de863eabf56851..04cf1c7662dd5d70fd02d544ddb41334525c7f62
December 6, 2020 20:35https://github.com/nodejs/node/pull/36061#event-4076981877
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 6, 2020https://github.com/nodejs/node/pull/36061#event-4077012406
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 6, 2020https://github.com/nodejs/node/pull/36061#event-4077022007
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 6, 2020https://github.com/nodejs/node/pull/36061#issuecomment-739566055
https://ci.nodejs.org/job/node-test-pull-request/34804/https://ci.nodejs.org/job/node-test-pull-request/34804/
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 7, 2020https://github.com/nodejs/node/pull/36061#issuecomment-739826633
https://ci.nodejs.org/job/node-test-pull-request/34813/https://ci.nodejs.org/job/node-test-pull-request/34813/
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 7, 2020https://github.com/nodejs/node/pull/36061#issuecomment-739907769
https://ci.nodejs.org/job/node-test-pull-request/34817/https://ci.nodejs.org/job/node-test-pull-request/34817/
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/mcollina
mcollinahttps://github.com/mcollina
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Dec 7, 2020https://github.com/nodejs/node/pull/36061#event-4079963670
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Dec 7, 2020https://github.com/nodejs/node/pull/36061#event-4079976372
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Dec 7, 2020https://github.com/nodejs/node/pull/36061#issuecomment-739958974
https://github.com/nodejs/node/actions/runs/406052944https://github.com/nodejs/node/actions/runs/406052944
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Dec 7, 2020https://github.com/nodejs/node/pull/36061#issuecomment-739986158
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Dec 7, 2020 https://github.com/nodejs/node/pull/36061#pullrequestreview-546289946
View reviewed changes https://github.com/nodejs/node/pull/36061/files/04cf1c7662dd5d70fd02d544ddb41334525c7f62
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/36061#pullrequestreview-546289946
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Dec 7, 2020https://github.com/nodejs/node/pull/36061#event-4080419813
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Dec 7, 2020https://github.com/nodejs/node/pull/36061#event-4080428810
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Dec 7, 2020https://github.com/nodejs/node/pull/36061#issuecomment-740014471
5122456...5bd1eechttps://github.com/nodejs/node/compare/5122456883071d3a06047293f17c6f86b7476113...5bd1eecfa986f1d1ccec08dfdfb269489efc18cc
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Dec 7, 2020https://github.com/nodejs/node/pull/36061#event-4080429483
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 7, 2020 https://github.com/nodejs/node/pull/36061#ref-commit-5bd1eec
https://github.com/benjamingr
https://github.com/nodejs-github-bot
stream: support abort signalhttps://github.com/nodejs/node/commit/5bd1eecfa986f1d1ccec08dfdfb269489efc18cc
5bd1eechttps://github.com/nodejs/node/commit/5bd1eecfa986f1d1ccec08dfdfb269489efc18cc
#36061https://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Dec 7, 2020https://github.com/nodejs/node/pull/36061#issuecomment-740017089
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
December 7, 2020 16:12https://github.com/nodejs/node/pull/36061#event-4080450936
danielleadamshttps://github.com/danielleadams
Dec 7, 2020 https://github.com/nodejs/node/pull/36061#ref-commit-197ba21
https://github.com/benjamingr
https://github.com/danielleadams
stream: support abort signalhttps://github.com/nodejs/node/commit/197ba212793728a36f23553061a9a4ff50bdc685
197ba21https://github.com/nodejs/node/commit/197ba212793728a36f23553061a9a4ff50bdc685
#36061https://github.com/nodejs/node/pull/36061
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Dec 7, 2020 https://github.com/nodejs/node/pull/36061#ref-pullrequest-758834739
v15.4.0 proposal #36435 https://github.com/nodejs/node/pull/36435
danielleadamshttps://github.com/danielleadams
Dec 7, 2020 https://github.com/nodejs/node/pull/36061#ref-commit-fde09a4
https://github.com/danielleadams
2020-12-08, Version 15.4.0 (Current)https://github.com/nodejs/node/commit/fde09a4cdc9465e8ed51f2f8597e03d7384fc6c2
fde09a4https://github.com/nodejs/node/commit/fde09a4cdc9465e8ed51f2f8597e03d7384fc6c2
#36435https://github.com/nodejs/node/pull/36435
#36308https://github.com/nodejs/node/pull/36308
#36187https://github.com/nodejs/node/pull/36187
#36258https://github.com/nodejs/node/pull/36258
#35949https://github.com/nodejs/node/pull/35949
#35924https://github.com/nodejs/node/pull/35924
#36263https://github.com/nodejs/node/pull/36263
#36061https://github.com/nodejs/node/pull/36061
#35922https://github.com/nodejs/node/pull/35922
#36271https://github.com/nodejs/node/pull/36271
cjihrighttps://github.com/cjihrig
Dec 8, 2020 https://github.com/nodejs/node/pull/36061#ref-commit-0ae0eb5
https://github.com/benjamingr
https://github.com/cjihrig
stream: support abort signalhttps://github.com/cjihrig/node/commit/0ae0eb5b39545870749029f074e2f98082b9e34a
0ae0eb5https://github.com/cjihrig/node/commit/0ae0eb5b39545870749029f074e2f98082b9e34a
nodejs#36061https://github.com/nodejs/node/pull/36061
danielleadamshttps://github.com/danielleadams
Dec 9, 2020 https://github.com/nodejs/node/pull/36061#ref-commit-5e5927e
https://github.com/danielleadams
2020-12-09, Version 15.4.0 (Current)https://github.com/nodejs/node/commit/5e5927ec2e685399689e4fcfe630565b3101207f
5e5927ehttps://github.com/nodejs/node/commit/5e5927ec2e685399689e4fcfe630565b3101207f
#36435https://github.com/nodejs/node/pull/36435
#36308https://github.com/nodejs/node/pull/36308
#36187https://github.com/nodejs/node/pull/36187
#36258https://github.com/nodejs/node/pull/36258
#35949https://github.com/nodejs/node/pull/35949
#35924https://github.com/nodejs/node/pull/35924
#36263https://github.com/nodejs/node/pull/36263
#36061https://github.com/nodejs/node/pull/36061
#35922https://github.com/nodejs/node/pull/35922
#36271https://github.com/nodejs/node/pull/36271
danielleadamshttps://github.com/danielleadams
Dec 9, 2020 https://github.com/nodejs/node/pull/36061#ref-commit-348b7a9
https://github.com/danielleadams
2020-12-09, Version 15.4.0 (Current)https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb
https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb#comments
348b7a9https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb
#36435https://github.com/nodejs/node/pull/36435
#36308https://github.com/nodejs/node/pull/36308
#36187https://github.com/nodejs/node/pull/36187
#36258https://github.com/nodejs/node/pull/36258
#35949https://github.com/nodejs/node/pull/35949
#35924https://github.com/nodejs/node/pull/35924
#36263https://github.com/nodejs/node/pull/36263
#36061https://github.com/nodejs/node/pull/36061
#35922https://github.com/nodejs/node/pull/35922
#36271https://github.com/nodejs/node/pull/36271
https://github.com/Linkgoron
Linkgoronhttps://github.com/Linkgoron
Oct 29, 2021 https://github.com/nodejs/node/pull/36061#ref-pullrequest-1039684604
lib: make validateAbortSignal stricter #40657 https://github.com/nodejs/node/pull/40657
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 24, 2024 https://github.com/nodejs/node/pull/36061#ref-pullrequest-2262279643
Adding VersionStream for nodejs-22 wolfi-dev/os#17646 https://github.com/wolfi-dev/os/pull/17646
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36061
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/36061/files/52d3dd601f5ed42f6788a4875e7fbf0b207a6a78
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/36061/files/04cf1c7662dd5d70fd02d544ddb41334525c7f62
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/36061/files/c1fd1fa512df306628d1290d8ab855b9ddc382c3
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/36061
https://github.com/benjamingr
https://github.com/nodejs-github-bot
https://github.com/ronag
https://github.com/mcollina
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.