René's URL Explorer Experiment


Title: http: add support for abortsignal to http.request by benjamingr · Pull Request #36048 · nodejs/node · GitHub

Open Graph Title: http: add support for abortsignal to http.request by benjamingr · Pull Request #36048 · nodejs/node

X Title: http: add support for abortsignal to http.request by benjamingr · Pull Request #36048 · nodejs/node

Description: cc @mcollina @jasnell @addaleax This is the last one from #35877 (comment) - if you have any more APIs you want me to add support for AbortSignal in before I go back to that list I started making back then please let me know :] Also we should talk about streams and this probably. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: cc @mcollina @jasnell @addaleax This is the last one from #35877 (comment) - if you have any more APIs you want me to add support for AbortSignal in before I go back to that list I started making b...

X Description: cc @mcollina @jasnell @addaleax This is the last one from #35877 (comment) - if you have any more APIs you want me to add support for AbortSignal in before I go back to that list I started making b...

Opengraph URL: https://github.com/nodejs/node/pull/36048

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5dfb370c-a175-05dc-214a-7c3b7288ee61
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDAF4:257A3D:1B33FCB:246F624:6AED8AF7
html-safe-noncef5940c38159461a7260da755fc827caacd82166c91b58b579d6dcb2f7581129b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUY0OjI1N0EzRDoxQjMzRkNCOjI0NkY2MjQ6NkFFRDhBRjciLCJ2aXNpdG9yX2lkIjoiODM5ODY0NDk5MjQ3MjM1MzUyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdbcaaccda0e986a1f4970a5debcfb990a2b5e81aa1ea52d8242640902bb3b22a
hovercard-subject-tagpull_request:517672642
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/36048/files
twitter:imagehttps://avatars.githubusercontent.com/u/1315533?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1315533?s=400&v=4
og:image:altcc @mcollina @jasnell @addaleax This is the last one from #35877 (comment) - if you have any more APIs you want me to add support for AbortSignal in before I go back to that list I started making b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36048/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36048%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36048%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36048/files
Reloadhttps://github.com/nodejs/node/pull/36048/files
Reloadhttps://github.com/nodejs/node/pull/36048/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
benjamingrhttps://github.com/benjamingr
nodejs:masterhttps://github.com/nodejs/node/tree/master
benjamingr:add-abortsignal-http-requesthttps://github.com/benjamingr/io.js/tree/add-abortsignal-http-request
Conversation 37 https://github.com/nodejs/node/pull/36048
Commits 1 https://github.com/nodejs/node/pull/36048/commits
Checks 0 https://github.com/nodejs/node/pull/36048/checks
Files changed https://github.com/nodejs/node/pull/36048/files
Please reload this pagehttps://github.com/nodejs/node/pull/36048/files
http: add support for abortsignal to http.request https://github.com/nodejs/node/pull/36048/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/36048/files
45117b5 http: add support for abortsignal to http.request benjamingr Nov 9, 2020 https://github.com/nodejs/node/pull/36048/commits/45117b5a1c43355463e4d883a799ff49404824a3
Clear filters https://github.com/nodejs/node/pull/36048/files
Please reload this pagehttps://github.com/nodejs/node/pull/36048/files
Please reload this pagehttps://github.com/nodejs/node/pull/36048/files
http.md https://github.com/nodejs/node/pull/36048/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641
.eslintrc.yaml https://github.com/nodejs/node/pull/36048/files#diff-a36322e55dc4faed79296547f0da2740f29391f0305b82d7c788f8e6e8a46c00
_http_client.js https://github.com/nodejs/node/pull/36048/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
errors.js https://github.com/nodejs/node/pull/36048/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
test-http-client-abort-destroy.js https://github.com/nodejs/node/pull/36048/files#diff-5131b1dcb747ec6d13f58709404382737749e97bff51443a03a8741ff9521a46
doc/api/http.mdhttps://github.com/nodejs/node/pull/36048/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641
View file https://github.com/benjamingr/io.js/blob/45117b5a1c43355463e4d883a799ff49404824a3/doc/api/http.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/36048/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/36048/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641
https://github.com/nodejs/node/pull/36048/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641
https://github.com/nodejs/node/pull/36048/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641
https://github.com/nodejs/node/pull/36048/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641
https://github.com/nodejs/node/pull/36048/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641
https://github.com/nodejs/node/pull/36048/files#diff-d692ac4524379ec6a1201165e8ff8d3267c8130e07014e8221ebf7e6f80c6641
lib/.eslintrc.yamlhttps://github.com/nodejs/node/pull/36048/files#diff-a36322e55dc4faed79296547f0da2740f29391f0305b82d7c788f8e6e8a46c00
View file https://github.com/benjamingr/io.js/blob/45117b5a1c43355463e4d883a799ff49404824a3/lib/.eslintrc.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/36048/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/36048/files#diff-a36322e55dc4faed79296547f0da2740f29391f0305b82d7c788f8e6e8a46c00
https://github.com/nodejs/node/pull/36048/files#diff-a36322e55dc4faed79296547f0da2740f29391f0305b82d7c788f8e6e8a46c00
lib/_http_client.jshttps://github.com/nodejs/node/pull/36048/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
View file https://github.com/benjamingr/io.js/blob/45117b5a1c43355463e4d883a799ff49404824a3/lib/_http_client.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/36048/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/36048/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/36048/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/36048/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/36048/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
lib/internal/errors.jshttps://github.com/nodejs/node/pull/36048/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
View file https://github.com/benjamingr/io.js/blob/45117b5a1c43355463e4d883a799ff49404824a3/lib/internal/errors.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/36048/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/36048/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
Please reload this pagehttps://github.com/nodejs/node/pull/36048/files
https://github.com/nodejs/node/pull/36048/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
https://github.com/nodejs/node/pull/36048/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c
test/parallel/test-http-client-abort-destroy.jshttps://github.com/nodejs/node/pull/36048/files#diff-5131b1dcb747ec6d13f58709404382737749e97bff51443a03a8741ff9521a46
View file https://github.com/benjamingr/io.js/blob/45117b5a1c43355463e4d883a799ff49404824a3/test/parallel/test-http-client-abort-destroy.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/36048/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/36048/files#diff-5131b1dcb747ec6d13f58709404382737749e97bff51443a03a8741ff9521a46
https://github.com/nodejs/node/pull/36048/files#diff-5131b1dcb747ec6d13f58709404382737749e97bff51443a03a8741ff9521a46
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.