| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:72ff7c40-23bc-ca20-7eb5-1589cba133d3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 88BC:165BE9:F34940:151E959:696A9163 |
| html-safe-nonce | 0a6bd245991cf20e7833fd9f5204522608b8b1b5b8356a371551dde12bd3fc10 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEJDOjE2NUJFOTpGMzQ5NDA6MTUxRTk1OTo2OTZBOTE2MyIsInZpc2l0b3JfaWQiOiIyNTgyMDY2Nzc1OTkzMjU4MzM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 342591e76e86cf7dacc2e8e5d3210652197efdefbec04781b5731f1929c0bfe7 |
| hovercard-subject-tag | pull_request:517128847 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36019/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a3868e3ed90d32441ae176e77b8d72b0efde5ddd14f7dc53069fff0e8bfdbd4f/nodejs/node/pull/36019 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a3868e3ed90d32441ae176e77b8d72b0efde5ddd14f7dc53069fff0e8bfdbd4f/nodejs/node/pull/36019 |
| og:image:alt | Use more primordials and internals.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/36019#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36019 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36019 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/36019 |
| Reload | https://github.com/nodejs/node/pull/36019 |
| Reload | https://github.com/nodejs/node/pull/36019 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/36019 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/36019 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/36019#issue-comment-box |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:esm-primordials | https://github.com/aduh95/node/tree/esm-primordials |
|
esm: refactor to use more primordials
| https://github.com/nodejs/node/pull/36019#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:esm-primordials | https://github.com/aduh95/node/tree/esm-primordials |
|
Conversation
5
| https://github.com/nodejs/node/pull/36019 |
|
Commits
2
| https://github.com/nodejs/node/pull/36019/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/36019/checks |
|
Files changed
| https://github.com/nodejs/node/pull/36019/files |
| Please reload this page | https://github.com/nodejs/node/pull/36019 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Nov 7, 2020 | https://github.com/nodejs/node/pull/36019#issue-738230542 |
| Please reload this page | https://github.com/nodejs/node/pull/36019 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/36019 |
|
| https://github.com/aduh95 |
| esm: refactor to use more primordials | https://github.com/nodejs/node/pull/36019/commits/da71fa6eddf431c366198c66d3693f38912e2a23 |
| da71fa6 | https://github.com/nodejs/node/pull/36019/commits/da71fa6eddf431c366198c66d3693f38912e2a23 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 7, 2020 | https://github.com/nodejs/node/pull/36019#issuecomment-723438433 |
| Please reload this page | https://github.com/nodejs/node/pull/36019 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Nov 7, 2020 | https://github.com/nodejs/node/pull/36019#event-3969846325 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 7, 2020 | https://github.com/nodejs/node/pull/36019#event-3969847594 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 7, 2020 | https://github.com/nodejs/node/pull/36019#event-3969847659 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36019 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36019 |
|
| https://github.com/aduh95 |
| fixup! esm: refactor to use more primordials | https://github.com/nodejs/node/pull/36019/commits/365fb01024c08f6e103ae2d454f99391c9efd049 |
| 365fb01 | https://github.com/nodejs/node/pull/36019/commits/365fb01024c08f6e103ae2d454f99391c9efd049 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 7, 2020 | https://github.com/nodejs/node/pull/36019#event-3970253953 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 7, 2020 | https://github.com/nodejs/node/pull/36019#event-3970256369 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 7, 2020 | https://github.com/nodejs/node/pull/36019#issuecomment-723502058 |
| https://ci.nodejs.org/job/node-test-pull-request/34185/ | https://ci.nodejs.org/job/node-test-pull-request/34185/ |
| Please reload this page | https://github.com/nodejs/node/pull/36019 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 8, 2020
| https://github.com/nodejs/node/pull/36019#ref-pullrequest-738278344 |
|
tools,lib: recommend using safe primordials
#36026
| https://github.com/nodejs/node/pull/36026 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
| Nov 9, 2020 | https://github.com/nodejs/node/pull/36019#event-3972500216 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 10, 2020
| https://github.com/nodejs/node/pull/36019#pullrequestreview-526852598 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/36019/files/365fb01024c08f6e103ae2d454f99391c9efd049 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 10, 2020 | https://github.com/nodejs/node/pull/36019#event-3977676375 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 14, 2020 | https://github.com/nodejs/node/pull/36019#event-3996480272 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 14, 2020 | https://github.com/nodejs/node/pull/36019#issuecomment-727217477 |
| 5c3944f...8297860 | https://github.com/nodejs/node/compare/5c3944fa204f161335ace6e65834c57e7a4b27e9...829786088a1945bc6829758930045a34d8abba9c |
| Please reload this page | https://github.com/nodejs/node/pull/36019 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 14, 2020 | https://github.com/nodejs/node/pull/36019#event-3996480470 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Nov 14, 2020
| https://github.com/nodejs/node/pull/36019#ref-commit-8297860 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
| esm: refactor to use more primordials | https://github.com/nodejs/node/commit/829786088a1945bc6829758930045a34d8abba9c |
| 8297860 | https://github.com/nodejs/node/commit/829786088a1945bc6829758930045a34d8abba9c |
| #36019 | https://github.com/nodejs/node/pull/36019 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| November 14, 2020 14:49 | https://github.com/nodejs/node/pull/36019#event-3996484337 |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/36019#ref-commit-6678897 |
|
| https://github.com/aduh95 |
|
| https://github.com/codebytere |
| esm: refactor to use more primordials | https://github.com/nodejs/node/commit/66788970ac1dd79d948fc0fa5f9e2d1e4127b7b4 |
| 6678897 | https://github.com/nodejs/node/commit/66788970ac1dd79d948fc0fa5f9e2d1e4127b7b4 |
| #36019 | https://github.com/nodejs/node/pull/36019 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/36019#ref-pullrequest-748354048 |
|
v15.3.0 proposal
#36232
| https://github.com/nodejs/node/pull/36232 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2020
| https://github.com/nodejs/node/pull/36019#ref-commit-0c89e26 |
|
| https://github.com/aduh95 |
|
| https://github.com/BethGriggs |
| esm: refactor to use more primordials | https://github.com/nodejs/node/commit/0c89e26aaff697ae9b185bc52fec1dcd6b55a7aa |
| 0c89e26 | https://github.com/nodejs/node/commit/0c89e26aaff697ae9b185bc52fec1dcd6b55a7aa |
| #36019 | https://github.com/nodejs/node/pull/36019 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/36019#ref-commit-75c10ba |
|
| https://github.com/aduh95 |
|
| https://github.com/BethGriggs |
| esm: refactor to use more primordials | https://github.com/nodejs/node/commit/75c10baa67ec88be72565535167ad40eb163183f |
| 75c10ba | https://github.com/nodejs/node/commit/75c10baa67ec88be72565535167ad40eb163183f |
| #36019 | https://github.com/nodejs/node/pull/36019 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/36019#ref-pullrequest-761612838 |
|
v14.15.2 proposal
#36476
| https://github.com/nodejs/node/pull/36476 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/36019#ref-commit-8d672b8 |
|
| https://github.com/aduh95 |
|
| https://github.com/BethGriggs |
| esm: refactor to use more primordials | https://github.com/nodejs/node/commit/8d672b8e5364e0a00f4df623d0b514755df36d14 |
| 8d672b8 | https://github.com/nodejs/node/commit/8d672b8e5364e0a00f4df623d0b514755df36d14 |
| #36019 | https://github.com/nodejs/node/pull/36019 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36019 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/36019/files/365fb01024c08f6e103ae2d454f99391c9efd049 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
| Please reload this page | https://github.com/nodejs/node/pull/36019 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |