René's URL Explorer Experiment


Title: test: use global.EventTarget instead of internals by aduh95 · Pull Request #36002 · nodejs/node · GitHub

Open Graph Title: test: use global.EventTarget instead of internals by aduh95 · Pull Request #36002 · nodejs/node

X Title: test: use global.EventTarget instead of internals by aduh95 · Pull Request #36002 · nodejs/node

Description: EventTarget and Event are available from the global scope, there is no need to use the --expose-internals flag in the tests. Refs: #35496 Checklist make -j4 test (UNIX), or vcbuild test (Window...

Open Graph Description: EventTarget and Event are available from the global scope, there is no need to use the --expose-internals flag in the tests. Refs: #35496 Checklist make -j4 test (UNIX), or vcbuild test (Window...

X Description: EventTarget and Event are available from the global scope, there is no need to use the --expose-internals flag in the tests. Refs: #35496 Checklist make -j4 test (UNIX), or vcbuild test (Window...

Opengraph URL: https://github.com/nodejs/node/pull/36002

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2325b3bd-9608-691d-eb18-d9ce31842405
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC22:CFAA3:7AB49:A0E39:696AF47A
html-safe-nonce8867de840d807669af574811044e50934c728a80e50808cf76c1dace2cb7b48a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzIyOkNGQUEzOjdBQjQ5OkEwRTM5OjY5NkFGNDdBIiwidmlzaXRvcl9pZCI6IjQ3Mzc2MDk3Nzg1MzgwNTY5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2afba05109f6260896656d13baaf5303e819c125c8a3cc144ec09763a87230d4
hovercard-subject-tagpull_request:516872743
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/36002/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e430324abe81bc5513b37d238c2b371345277248038e844ddab4ab4b616db864/nodejs/node/pull/36002
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e430324abe81bc5513b37d238c2b371345277248038e844ddab4ab4b616db864/nodejs/node/pull/36002
og:image:altEventTarget and Event are available from the global scope, there is no need to use the --expose-internals flag in the tests. Refs: #35496 Checklist make -j4 test (UNIX), or vcbuild test (Window...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/36002#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36002
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36002
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/36002
Reloadhttps://github.com/nodejs/node/pull/36002
Reloadhttps://github.com/nodejs/node/pull/36002
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/36002
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/36002
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/36002#issue-comment-box
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
aduh95:test-global-eventtargethttps://github.com/aduh95/node/tree/test-global-eventtarget
test: use global.EventTarget instead of internals https://github.com/nodejs/node/pull/36002#top
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
aduh95:test-global-eventtargethttps://github.com/aduh95/node/tree/test-global-eventtarget
Conversation 3 https://github.com/nodejs/node/pull/36002
Commits 1 https://github.com/nodejs/node/pull/36002/commits
Checks 0 https://github.com/nodejs/node/pull/36002/checks
Files changed https://github.com/nodejs/node/pull/36002/files
Please reload this pagehttps://github.com/nodejs/node/pull/36002
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 6, 2020https://github.com/nodejs/node/pull/36002#issue-737913903
#35496https://github.com/nodejs/node/pull/35496
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/36002
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 6, 2020https://github.com/nodejs/node/pull/36002#event-3968133188
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 6, 2020 https://github.com/nodejs/node/pull/36002#ref-pullrequest-649989737
Add EventTarget WPT test AddEventListenerOptions-once #34169 https://github.com/nodejs/node/pull/34169
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 6, 2020https://github.com/nodejs/node/pull/36002#event-3968442770
https://github.com/targos
targoshttps://github.com/targos
Nov 7, 2020 https://github.com/nodejs/node/pull/36002#pullrequestreview-525633448
View reviewed changes https://github.com/nodejs/node/pull/36002/files
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 7, 2020https://github.com/nodejs/node/pull/36002#event-3969655863
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36002
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 7, 2020 https://github.com/nodejs/node/pull/36002#pullrequestreview-525638098
View reviewed changes https://github.com/nodejs/node/pull/36002/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 7, 2020https://github.com/nodejs/node/pull/36002#issuecomment-723418925
https://ci.nodejs.org/job/node-test-pull-request/34156/https://ci.nodejs.org/job/node-test-pull-request/34156/
Please reload this pagehttps://github.com/nodejs/node/pull/36002
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 7, 2020https://github.com/nodejs/node/pull/36002#event-3969929789
https://github.com/aduh95
test: use global.EventTarget instead of internalshttps://github.com/nodejs/node/pull/36002/commits/36fbbe0b86131fa2dcca558872b02335586e0089
36fbbe0https://github.com/nodejs/node/pull/36002/commits/36fbbe0b86131fa2dcca558872b02335586e0089
nodejs#35496https://github.com/nodejs/node/pull/35496
nodejs#36002https://github.com/nodejs/node/pull/36002
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/06bd33a63f65f552413759732f911a27da2d724e..36fbbe0b86131fa2dcca558872b02335586e0089
06bd33ahttps://github.com/nodejs/node/commit/06bd33a63f65f552413759732f911a27da2d724e
36fbbe0https://github.com/nodejs/node/commit/36fbbe0b86131fa2dcca558872b02335586e0089
Compare https://github.com/nodejs/node/compare/06bd33a63f65f552413759732f911a27da2d724e..36fbbe0b86131fa2dcca558872b02335586e0089
November 9, 2020 18:25https://github.com/nodejs/node/pull/36002#event-3975183510
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 9, 2020https://github.com/nodejs/node/pull/36002#issuecomment-724191413
36fbbe0https://github.com/nodejs/node/commit/36fbbe0b86131fa2dcca558872b02335586e0089
Please reload this pagehttps://github.com/nodejs/node/pull/36002
https://github.com/aduh95
aduh95https://github.com/aduh95
36fbbe0https://github.com/nodejs/node/commit/36fbbe0b86131fa2dcca558872b02335586e0089
Nov 9, 2020https://github.com/nodejs/node/pull/36002#event-3975185166
https://github.com/aduh95
aduh95https://github.com/aduh95
November 9, 2020 18:26https://github.com/nodejs/node/pull/36002#event-3975185560
danielleadamshttps://github.com/danielleadams
Nov 10, 2020 https://github.com/nodejs/node/pull/36002#ref-commit-0a4c96a
https://github.com/aduh95
https://github.com/danielleadams
test: use global.EventTarget instead of internalshttps://github.com/nodejs/node/commit/0a4c96a7dfd6bc2f193a539f23538dda82f0df58
0a4c96ahttps://github.com/nodejs/node/commit/0a4c96a7dfd6bc2f193a539f23538dda82f0df58
#35496https://github.com/nodejs/node/pull/35496
#36002https://github.com/nodejs/node/pull/36002
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Nov 10, 2020 https://github.com/nodejs/node/pull/36002#ref-pullrequest-739316609
v15.2.0 proposal #36055 https://github.com/nodejs/node/pull/36055
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F36002
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/36002/files/06bd33a63f65f552413759732f911a27da2d724e
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/36002/files/06bd33a63f65f552413759732f911a27da2d724e
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/36002
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.