René's URL Explorer Experiment


Title: fs: replace finally with PromisePrototypeFinally by baruchiro · Pull Request #35995 · nodejs/node · GitHub

Open Graph Title: fs: replace finally with PromisePrototypeFinally by baruchiro · Pull Request #35995 · nodejs/node

X Title: fs: replace finally with PromisePrototypeFinally by baruchiro · Pull Request #35995 · nodejs/node

Description: See suggestion here- #35993 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: See suggestion here- #35993 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: See suggestion here- #35993 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/35995

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0349c112-912e-2a78-7ec7-e7b330b27644
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA20:F74F6:3EA561:55832C:696AA7A0
html-safe-nonce959e60017d7c8b79a643a9829512787a957896fbfb6bce5808bda9575ddb9385
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTIwOkY3NEY2OjNFQTU2MTo1NTgzMkM6Njk2QUE3QTAiLCJ2aXNpdG9yX2lkIjoiNTI3MzI0OTIxNzMwMjQwNzA3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd80ed3763a2a93136e5dd9717bc72f390fb8484ce4f27732570aa4e120b6d197
hovercard-subject-tagpull_request:516723067
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35995/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3fccfce24d62686e956e7e7924f83628fd3ec5f03a684b68aee97675f32ea5ad/nodejs/node/pull/35995
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3fccfce24d62686e956e7e7924f83628fd3ec5f03a684b68aee97675f32ea5ad/nodejs/node/pull/35995
og:image:altSee suggestion here- #35993 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebaruchiro
hostnamegithub.com
expected-hostnamegithub.com
None3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd9a979046e6382bd084e2bd873bf65f797125ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35995#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35995
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35995
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35995
Reloadhttps://github.com/nodejs/node/pull/35995
Reloadhttps://github.com/nodejs/node/pull/35995
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35995
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35995
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35995#issue-comment-box
baruchirohttps://github.com/baruchiro
nodejs:masterhttps://github.com/nodejs/node/tree/master
baruchiro:patch-1https://github.com/baruchiro/node/tree/patch-1
fs: replace finally with PromisePrototypeFinally https://github.com/nodejs/node/pull/35995#top
baruchirohttps://github.com/baruchiro
nodejs:masterhttps://github.com/nodejs/node/tree/master
baruchiro:patch-1https://github.com/baruchiro/node/tree/patch-1
Conversation 17 https://github.com/nodejs/node/pull/35995
Commits 1 https://github.com/nodejs/node/pull/35995/commits
Checks 0 https://github.com/nodejs/node/pull/35995/checks
Files changed https://github.com/nodejs/node/pull/35995/files
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
Nov 6, 2020https://github.com/nodejs/node/pull/35995#issue-737733018
Please reload this pagehttps://github.com/nodejs/node/pull/35995
#35993 (comment)https://github.com/nodejs/node/pull/35993#discussion_r518703665
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Nov 6, 2020https://github.com/nodejs/node/pull/35995#event-3967057889
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
Nov 6, 2020 https://github.com/nodejs/node/pull/35995#ref-pullrequest-737698907
fs: support abortsignal in writeFile #35993 https://github.com/nodejs/node/pull/35993
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 6, 2020 https://github.com/nodejs/node/pull/35995#pullrequestreview-525123420
View reviewed changes https://github.com/nodejs/node/pull/35995/files
lib/internal/fs/promises.jshttps://github.com/nodejs/node/pull/35995/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 6, 2020https://github.com/nodejs/node/pull/35995#issuecomment-723095420
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
force-pushedhttps://github.com/nodejs/node/compare/a6ca29c25f6d5ba5975bb4e3715821393510dba2..14453525c1b77067ce452fc1059640b4ace1e60b
a6ca29chttps://github.com/nodejs/node/commit/a6ca29c25f6d5ba5975bb4e3715821393510dba2
1445352https://github.com/nodejs/node/commit/14453525c1b77067ce452fc1059640b4ace1e60b
Compare https://github.com/nodejs/node/compare/a6ca29c25f6d5ba5975bb4e3715821393510dba2..14453525c1b77067ce452fc1059640b4ace1e60b
November 7, 2020 19:52https://github.com/nodejs/node/pull/35995#event-3970168158
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
Nov 7, 2020https://github.com/nodejs/node/pull/35995#issuecomment-723487352
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
Nov 7, 2020https://github.com/nodejs/node/pull/35995#event-3970172633
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 7, 2020https://github.com/nodejs/node/pull/35995#issuecomment-723504878
@baruchirohttps://github.com/baruchiro
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/baruchiro
fs: replace finally with PromisePrototypeFinallyhttps://github.com/nodejs/node/pull/35995/commits/b3d82e0b544d7e724d0e366dcc036ccab4e1a528
b3d82e0https://github.com/nodejs/node/pull/35995/commits/b3d82e0b544d7e724d0e366dcc036ccab4e1a528
nodejs#35993 (comment)https://github.com/nodejs/node/pull/35993#discussion_r518703665
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
force-pushedhttps://github.com/nodejs/node/compare/53081c58662c5e0fc2b1b61604581ba85e73271d..b3d82e0b544d7e724d0e366dcc036ccab4e1a528
53081c5https://github.com/nodejs/node/commit/53081c58662c5e0fc2b1b61604581ba85e73271d
b3d82e0https://github.com/nodejs/node/commit/b3d82e0b544d7e724d0e366dcc036ccab4e1a528
Compare https://github.com/nodejs/node/compare/53081c58662c5e0fc2b1b61604581ba85e73271d..b3d82e0b544d7e724d0e366dcc036ccab4e1a528
November 8, 2020 07:52https://github.com/nodejs/node/pull/35995#event-3970527695
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
Nov 8, 2020https://github.com/nodejs/node/pull/35995#issuecomment-723552514
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 8, 2020https://github.com/nodejs/node/pull/35995#issuecomment-723552862
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/aduh95
aduh95https://github.com/aduh95
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 8, 2020https://github.com/nodejs/node/pull/35995#event-3970637944
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 8, 2020 https://github.com/nodejs/node/pull/35995#pullrequestreview-525795886
View reviewed changes https://github.com/nodejs/node/pull/35995/files/b3d82e0b544d7e724d0e366dcc036ccab4e1a528
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 8, 2020https://github.com/nodejs/node/pull/35995#event-3970638195
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 8, 2020https://github.com/nodejs/node/pull/35995#event-3970640537
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35995
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35995
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 8, 2020https://github.com/nodejs/node/pull/35995#issuecomment-723576824
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://ci.nodejs.org/job/node-test-pull-request/34203/https://ci.nodejs.org/job/node-test-pull-request/34203/
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 8, 2020 https://github.com/nodejs/node/pull/35995#pullrequestreview-525807585
View reviewed changes https://github.com/nodejs/node/pull/35995/files/b3d82e0b544d7e724d0e366dcc036ccab4e1a528
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
Nov 9, 2020https://github.com/nodejs/node/pull/35995#issuecomment-723951480
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 9, 2020https://github.com/nodejs/node/pull/35995#issuecomment-723956465
@baruchirohttps://github.com/baruchiro
author readyhttps://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#author-ready-pull-requests
https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#accepting-modificationshttps://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#accepting-modifications
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 9, 2020https://github.com/nodejs/node/pull/35995#event-3975172831
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 9, 2020https://github.com/nodejs/node/pull/35995#event-3975340725
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 9, 2020https://github.com/nodejs/node/pull/35995#issuecomment-724214266
36fbbe0...a8b9edehttps://github.com/nodejs/node/compare/36fbbe0b86131fa2dcca558872b02335586e0089...a8b9ede3c10eadb775c5e0f5eab7c31cea7e8b53
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 9, 2020https://github.com/nodejs/node/pull/35995#event-3975341258
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 9, 2020 https://github.com/nodejs/node/pull/35995#ref-commit-a8b9ede
https://github.com/baruchiro
https://github.com/nodejs-github-bot
fs: replace finally with PromisePrototypeFinallyhttps://github.com/nodejs/node/commit/a8b9ede3c10eadb775c5e0f5eab7c31cea7e8b53
a8b9edehttps://github.com/nodejs/node/commit/a8b9ede3c10eadb775c5e0f5eab7c31cea7e8b53
#35993 (comment)https://github.com/nodejs/node/pull/35993#discussion_r518703665
#35995https://github.com/nodejs/node/pull/35995
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
Nov 9, 2020https://github.com/nodejs/node/pull/35995#issuecomment-724216238
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 9, 2020https://github.com/nodejs/node/pull/35995#issuecomment-724217775
@baruchirohttps://github.com/baruchiro
https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#landing-pull-requestshttps://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#landing-pull-requests
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
November 9, 2020 19:15https://github.com/nodejs/node/pull/35995#event-3975387161
https://github.com/baruchiro
baruchirohttps://github.com/baruchiro
Nov 9, 2020https://github.com/nodejs/node/pull/35995#issuecomment-724221698
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Nov 9, 2020https://github.com/nodejs/node/pull/35995#issuecomment-724225330
Please reload this pagehttps://github.com/nodejs/node/pull/35995
danielleadamshttps://github.com/danielleadams
Nov 10, 2020 https://github.com/nodejs/node/pull/35995#ref-commit-7ef9c70
https://github.com/baruchiro
https://github.com/danielleadams
fs: replace finally with PromisePrototypeFinallyhttps://github.com/nodejs/node/commit/7ef9c707e9815fdd56e3bf6ab5e89c51c52f5fff
7ef9c70https://github.com/nodejs/node/commit/7ef9c707e9815fdd56e3bf6ab5e89c51c52f5fff
#35993 (comment)https://github.com/nodejs/node/pull/35993#discussion_r518703665
#35995https://github.com/nodejs/node/pull/35995
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Nov 10, 2020 https://github.com/nodejs/node/pull/35995#ref-pullrequest-739316609
v15.2.0 proposal #36055 https://github.com/nodejs/node/pull/36055
BethGriggshttps://github.com/BethGriggs
Dec 9, 2020 https://github.com/nodejs/node/pull/35995#ref-commit-1ed0a03
https://github.com/baruchiro
https://github.com/BethGriggs
fs: replace finally with PromisePrototypeFinallyhttps://github.com/nodejs/node/commit/1ed0a030ff6d449e5fffd7c89751310057578d82
1ed0a03https://github.com/nodejs/node/commit/1ed0a030ff6d449e5fffd7c89751310057578d82
#35993 (comment)https://github.com/nodejs/node/pull/35993#discussion_r518703665
#35995https://github.com/nodejs/node/pull/35995
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/35995#ref-commit-affa710
https://github.com/baruchiro
https://github.com/BethGriggs
fs: replace finally with PromisePrototypeFinallyhttps://github.com/nodejs/node/commit/affa71001b81d9a061f8c005fa5e6879dcc6aeaf
affa710https://github.com/nodejs/node/commit/affa71001b81d9a061f8c005fa5e6879dcc6aeaf
#35993 (comment)https://github.com/nodejs/node/pull/35993#discussion_r518703665
#35995https://github.com/nodejs/node/pull/35995
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/35995#ref-pullrequest-761612838
v14.15.2 proposal #36476 https://github.com/nodejs/node/pull/36476
BethGriggshttps://github.com/BethGriggs
Dec 15, 2020 https://github.com/nodejs/node/pull/35995#ref-commit-7c3b6f1
https://github.com/baruchiro
https://github.com/BethGriggs
fs: replace finally with PromisePrototypeFinallyhttps://github.com/nodejs/node/commit/7c3b6f17e373fa18f13378b2aed2ee4b56ad7ea5
7c3b6f1https://github.com/nodejs/node/commit/7c3b6f17e373fa18f13378b2aed2ee4b56ad7ea5
#35993 (comment)https://github.com/nodejs/node/pull/35993#discussion_r518703665
#35995https://github.com/nodejs/node/pull/35995
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35995
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/35995/files/a6ca29c25f6d5ba5975bb4e3715821393510dba2
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/35995/files/b3d82e0b544d7e724d0e366dcc036ccab4e1a528
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/35995/files/b3d82e0b544d7e724d0e366dcc036ccab4e1a528
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/35995
https://github.com/baruchiro
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.