| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8c7eb35a-c9e9-4e74-403c-010547cc07ab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A472:7E20E:F7D219:1547BD5:696A916B |
| html-safe-nonce | b4b16ba727d152d5af64fa64e5494357feb7cdc87d15c4d1d04a6ae10eaff20a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDcyOjdFMjBFOkY3RDIxOToxNTQ3QkQ1OjY5NkE5MTZCIiwidmlzaXRvcl9pZCI6IjkxNzA2MjI3NzgwMzk3MDkyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 323adf5e79ac3d38d90e65db2ab69c41dae6aae69fbbe74eb3d26e84beb9203f |
| hovercard-subject-tag | pull_request:514614975 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35941/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/672388571c931c5a813b4c1b82f1ca4c6e9c9ce93e3c83f2cc8cd42b4763fe4e/nodejs/node/pull/35941 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/672388571c931c5a813b4c1b82f1ca4c6e9c9ce93e3c83f2cc8cd42b4763fe4e/nodejs/node/pull/35941 |
| og:image:alt | Decide the return status of writeOrBuffer before
calling stream.write which can reset state.length
Fixes: #35926
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or b... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mmomtchev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35941#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35941 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35941 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35941 |
| Reload | https://github.com/nodejs/node/pull/35941 |
| Reload | https://github.com/nodejs/node/pull/35941 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35941#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mmomtchev:duplex-end | https://github.com/mmomtchev/node/tree/duplex-end |
|
stream: fix regression on duplex end
| https://github.com/nodejs/node/pull/35941#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mmomtchev:duplex-end | https://github.com/mmomtchev/node/tree/duplex-end |
|
Conversation
33
| https://github.com/nodejs/node/pull/35941 |
|
Commits
1
| https://github.com/nodejs/node/pull/35941/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35941/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35941/files |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issue-735176632 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721014344 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721017848 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#event-3952085119 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35941#pullrequestreview-522351968 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35941/files |
| test/parallel/test-stream-duplex-readable-end.js | https://github.com/nodejs/node/pull/35941/files#diff-24f934bacbf8b234170ea61739422bcbcc27d559ff39a628475ee06e4703bc52 |
| mcollina | https://github.com/mcollina |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#discussion_r516556528 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| mmomtchev | https://github.com/mmomtchev |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#discussion_r516563325 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35941#pullrequestreview-522352577 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35941/files |
| test/parallel/test-stream-duplex-readable-end.js | https://github.com/nodejs/node/pull/35941/files#diff-24f934bacbf8b234170ea61739422bcbcc27d559ff39a628475ee06e4703bc52 |
| mcollina | https://github.com/mcollina |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#discussion_r516556962 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#event-3952135627 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721029435 |
| https://ci.nodejs.org/job/node-test-pull-request/34034/ | https://ci.nodejs.org/job/node-test-pull-request/34034/ |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721031852 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721034747 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721037692 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721040505 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721043493 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| here | https://github.com/nodejs/node/issues/35926#issuecomment-720679842 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721044603 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35941#pullrequestreview-522386029 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35941/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/35941#pullrequestreview-522386029 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#event-3952287881 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#event-3952350823 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721054813 |
| https://ci.nodejs.org/job/node-test-pull-request/34035/ | https://ci.nodejs.org/job/node-test-pull-request/34035/ |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35941#pullrequestreview-522432122 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35941/files |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/35941#pullrequestreview-522432122 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/puzrin |
| puzrin | https://github.com/puzrin |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721273876 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721283539 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721285784 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721287442 |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/puzrin |
| puzrin | https://github.com/puzrin |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721297986 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721316883 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721319005 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#event-3954385803 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Nov 3, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-721319174 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35941#ref-pullrequest-735596211 |
|
v15.1.0 release proposal
#35948
| https://github.com/nodejs/node/pull/35948 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-731263191 |
| @Trott | https://github.com/Trott |
| @lpinca | https://github.com/lpinca |
| @mmomtchev | https://github.com/mmomtchev |
| https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md | https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/puzrin |
| puzrin | https://github.com/puzrin |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-731279706 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| Nov 20, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-731286555 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| mmomtchev | https://github.com/mmomtchev |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-c6fa9a6 |
|
| https://github.com/mmomtchev |
| stream: fix regression on duplex end | https://github.com/mmomtchev/node/commit/c6fa9a63355dfe98d820611cbeba5d6289d1a77e |
| c6fa9a6 | https://github.com/mmomtchev/node/commit/c6fa9a63355dfe98d820611cbeba5d6289d1a77e |
| nodejs#35941 | https://github.com/nodejs/node/pull/35941 |
| nodejs#35926 | https://github.com/nodejs/node/issues/35926 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/35941#ref-pullrequest-748305396 |
|
[14.x] stream: fix regression on duplex end
#36229
| https://github.com/nodejs/node/pull/36229 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| Nov 22, 2020 | https://github.com/nodejs/node/pull/35941#issuecomment-731789581 |
| @puzrin | https://github.com/puzrin |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
| https://github.com/wa-Nadoo |
| wa-Nadoo | https://github.com/wa-Nadoo |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/35941#ref-pullrequest-601406318 |
|
stream: avoid drain for sync streams
#32887
| https://github.com/nodejs/node/pull/32887 |
| codebytere | https://github.com/codebytere |
|
Nov 22, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-9405cdd |
|
| https://github.com/lpinca |
|
| https://github.com/codebytere |
| test: improve test-stream-duplex-readable-end | https://github.com/nodejs/node/commit/9405cddbeef44ed14ec0d6c48f003dddec2fe5df |
| 9405cdd | https://github.com/nodejs/node/commit/9405cddbeef44ed14ec0d6c48f003dddec2fe5df |
| #36056 | https://github.com/nodejs/node/pull/36056 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| enov | https://github.com/enov |
|
Dec 4, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-b0a1830 |
|
| https://github.com/mmomtchev |
|
| https://github.com/enov |
| stream: fix regression on duplex end | https://github.com/enov/node/commit/b0a18300e1048aa6e263c0deaf8fd05cd946b563 |
| b0a1830 | https://github.com/enov/node/commit/b0a18300e1048aa6e263c0deaf8fd05cd946b563 |
| nodejs#35941 | https://github.com/nodejs/node/pull/35941 |
| nodejs#35926 | https://github.com/nodejs/node/issues/35926 |
| https://github.com/enov |
| enov | https://github.com/enov |
|
Dec 4, 2020
| https://github.com/nodejs/node/pull/35941#ref-pullrequest-756703792 |
|
[14.x] stream: fix regression on duplex end
#36375
| https://github.com/nodejs/node/pull/36375 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-5904671 |
|
| https://github.com/mmomtchev |
|
| https://github.com/BethGriggs |
| stream: fix regression on duplex end | https://github.com/nodejs/node/commit/5904671c5ad5d1f33840b5c64692f7b5e34f9f33 |
| 5904671 | https://github.com/nodejs/node/commit/5904671c5ad5d1f33840b5c64692f7b5e34f9f33 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| #36375 | https://github.com/nodejs/node/pull/36375 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 9, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-ac6b0c6 |
|
| https://github.com/lpinca |
|
| https://github.com/BethGriggs |
| test: improve test-stream-duplex-readable-end | https://github.com/nodejs/node/commit/ac6b0c6e019fbee96c90baea420c8365e474ea23 |
| ac6b0c6 | https://github.com/nodejs/node/commit/ac6b0c6e019fbee96c90baea420c8365e474ea23 |
| #36056 | https://github.com/nodejs/node/pull/36056 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-631b021 |
|
| https://github.com/mmomtchev |
|
| https://github.com/BethGriggs |
| stream: fix regression on duplex end | https://github.com/nodejs/node/commit/631b02106203360aea3acff56b77bb7b69a3ef91 |
| 631b021 | https://github.com/nodejs/node/commit/631b02106203360aea3acff56b77bb7b69a3ef91 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| #36375 | https://github.com/nodejs/node/pull/36375 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-a82b916 |
|
| https://github.com/lpinca |
|
| https://github.com/BethGriggs |
| test: improve test-stream-duplex-readable-end | https://github.com/nodejs/node/commit/a82b91636c404a0497606a2c0ff9bfd7000891b5 |
| a82b916 | https://github.com/nodejs/node/commit/a82b91636c404a0497606a2c0ff9bfd7000891b5 |
| #36056 | https://github.com/nodejs/node/pull/36056 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35941#ref-pullrequest-761612838 |
|
v14.15.2 proposal
#36476
| https://github.com/nodejs/node/pull/36476 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-2b6dd9c |
|
| https://github.com/BethGriggs |
| 2020-12-15, Version 14.15.2 'Fermium' (LTS) | https://github.com/nodejs/node/commit/2b6dd9c5f81e915eb8716099890c3c975403aef3 |
| 2b6dd9c | https://github.com/nodejs/node/commit/2b6dd9c5f81e915eb8716099890c3c975403aef3 |
| #36450 | https://github.com/nodejs/node/pull/36450 |
| #35791 | https://github.com/nodejs/node/pull/35791 |
| #35545 | https://github.com/nodejs/node/pull/35545 |
| #36241 | https://github.com/nodejs/node/pull/36241 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| #36476 | https://github.com/nodejs/node/pull/36476 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-1cefb7e |
|
| https://github.com/mmomtchev |
|
| https://github.com/BethGriggs |
| stream: fix regression on duplex end | https://github.com/nodejs/node/commit/1cefb7e710f6bb1c6f13d000d1525bc25b83bb06 |
| 1cefb7e | https://github.com/nodejs/node/commit/1cefb7e710f6bb1c6f13d000d1525bc25b83bb06 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| #36375 | https://github.com/nodejs/node/pull/36375 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| #35926 | https://github.com/nodejs/node/issues/35926 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-8516c2e |
|
| https://github.com/lpinca |
|
| https://github.com/BethGriggs |
| test: improve test-stream-duplex-readable-end | https://github.com/nodejs/node/commit/8516c2ef9063e5c09ac770ea3974c91838629e14 |
| 8516c2e | https://github.com/nodejs/node/commit/8516c2ef9063e5c09ac770ea3974c91838629e14 |
| #36056 | https://github.com/nodejs/node/pull/36056 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-a2f9a70 |
|
| https://github.com/BethGriggs |
| 2020-12-15, Version 14.15.2 'Fermium' (LTS) | https://github.com/nodejs/node/commit/a2f9a70900a7cde073b1426d71fd211bbd25c342 |
| a2f9a70 | https://github.com/nodejs/node/commit/a2f9a70900a7cde073b1426d71fd211bbd25c342 |
| #36450 | https://github.com/nodejs/node/pull/36450 |
| #35791 | https://github.com/nodejs/node/pull/35791 |
| #35545 | https://github.com/nodejs/node/pull/35545 |
| #36241 | https://github.com/nodejs/node/pull/36241 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| #36476 | https://github.com/nodejs/node/pull/36476 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/35941#ref-commit-a150926 |
|
| https://github.com/BethGriggs |
| 2020-12-15, Version 14.15.2 'Fermium' (LTS) | https://github.com/nodejs/node/commit/a1509261770cb64527e55645503e0d9b9d61ae87 |
| a150926 | https://github.com/nodejs/node/commit/a1509261770cb64527e55645503e0d9b9d61ae87 |
| #36450 | https://github.com/nodejs/node/pull/36450 |
| #35791 | https://github.com/nodejs/node/pull/35791 |
| #35545 | https://github.com/nodejs/node/pull/35545 |
| #36241 | https://github.com/nodejs/node/pull/36241 |
| #35941 | https://github.com/nodejs/node/pull/35941 |
| #36476 | https://github.com/nodejs/node/pull/36476 |
|
[bug] POST -> Premature close stream
fastify/fastify#2739
| https://github.com/fastify/fastify/issues/2739 |
|
POST -> Premature close?
sindresorhus/got#1556
| https://github.com/sindresorhus/got/issues/1556 |
| https://github.com/amotzte |
| amotzte | https://github.com/amotzte |
|
Jan 5, 2021
| https://github.com/nodejs/node/pull/35941#ref-issue-779185707 |
|
Can you upgrade chrome docker to latest LTS node.js?
browserless/browserless#1200
| https://github.com/browserless/browserless/issues/1200 |
| https://github.com/Heerschop |
| Heerschop | https://github.com/Heerschop |
|
Jan 19, 2021
| https://github.com/nodejs/node/pull/35941#ref-issue-788803446 |
|
Script execution can freeze
chanzo/script-launcher#128
| https://github.com/chanzo/script-launcher/issues/128 |
| https://github.com/clshortfuse |
| clshortfuse | https://github.com/clshortfuse |
|
Feb 3, 2021
| https://github.com/nodejs/node/pull/35941#ref-issue-800477210 |
|
HTTP responses on Node v14.15.2+ hang
#37210
| https://github.com/nodejs/node/issues/37210 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backported-to-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v14.x |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Apr 25, 2021 | https://github.com/nodejs/node/pull/35941#event-4640759111 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35941 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/35941/files/2eefff745419692c713595cfea4b135e5c2a91c8 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/35941/files/2eefff745419692c713595cfea4b135e5c2a91c8 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/35941/files/2eefff745419692c713595cfea4b135e5c2a91c8 |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
stream: regression in v14, this.push(null) in Transform doesn't emit end
| https://github.com/nodejs/node/issues/35926 |
| Please reload this page | https://github.com/nodejs/node/pull/35941 |
|
| https://github.com/mmomtchev |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ronag |
|
| https://github.com/puzrin |
|
| https://github.com/mcollina |
|
| https://github.com/richardlau |
|
| https://github.com/MylesBorins |
|
| https://github.com/Trott |
|
| https://github.com/benjamingr |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |