| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:584d6f11-2173-3ca6-30aa-8f4f1759c691 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 84BC:20ED06:902D86:C0E39D:6A5290AB |
| html-safe-nonce | e3b3d3051b1beb5c7628fffb7a6a7a12f1735190aa7c7e7b6ecc5fc12b5021a6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEJDOjIwRUQwNjo5MDJEODY6QzBFMzlEOjZBNTI5MEFCIiwidmlzaXRvcl9pZCI6IjYxMDkyNDEzNzg1OTU4MzYwNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b4a3f278143e5946d7e120635151e0942d05d019ce94469d6792b39f923d23b4 |
| hovercard-subject-tag | pull_request:514025841 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35922/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1030268767941ff0ba212df56b67dd25e09019b84f074fdd16c020dabb42a4cc/nodejs/node/pull/35922 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1030268767941ff0ba212df56b67dd25e09019b84f074fdd16c020dabb42a4cc/nodejs/node/pull/35922 |
| og:image:alt | Support creating a Read/WriteStream from a
FileHandle instead of a raw file descriptor
Add an EventEmitter to FileHandle with a single
'close' event
Refs: #35240
Checklist
make -j4 test... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mmomtchev |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35922#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35922 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35922 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35922 |
| Reload | https://github.com/nodejs/node/pull/35922 |
| Reload | https://github.com/nodejs/node/pull/35922 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.2k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
986
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mmomtchev | https://github.com/mmomtchev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mmomtchev:stream-filehandle | https://github.com/mmomtchev/node/tree/stream-filehandle |
| Conversation | https://github.com/nodejs/node/pull/35922 |
| Commits20 (20) | https://github.com/nodejs/node/pull/35922/commits |
| Checks | https://github.com/nodejs/node/pull/35922/checks |
| Files changed | https://github.com/nodejs/node/pull/35922/files |
| stream: add FileHandle support to Read/WriteStream | https://github.com/nodejs/node/pull/35922#top |
| mmomtchev | https://github.com/mmomtchev |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mmomtchev:stream-filehandle | https://github.com/mmomtchev/node/tree/stream-filehandle |
|
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| Nov 2, 2020 | https://github.com/nodejs/node/pull/35922#issue-734465996 |
| #35240 | https://github.com/nodejs/node/issues/35240 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Nov 2, 2020 | https://github.com/nodejs/node/pull/35922#event-3947857392 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Nov 2, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-521596218 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/35922/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Nov 2, 2020 | https://github.com/nodejs/node/pull/35922#event-3948347251 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 2, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-521674615 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/35922#pullrequestreview-521674615 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/promises.js | https://github.com/nodejs/node/pull/35922/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/35922/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/promises.js | https://github.com/nodejs/node/pull/35922/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/35922/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/35922/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/35922/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/35922/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 2, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-521723991 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| lib/internal/fs/promises.js | https://github.com/nodejs/node/pull/35922/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 2, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-521771601 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| lib/internal/fs/promises.js | https://github.com/nodejs/node/pull/35922/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/35922/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Nov 2, 2020 | https://github.com/nodejs/node/pull/35922#issuecomment-720568614 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| Nov 2, 2020 | https://github.com/nodejs/node/pull/35922#issuecomment-720576859 |
| #35862 | https://github.com/nodejs/node/issues/35862 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 2, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-521867027 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| lib/internal/fs/promises.js | https://github.com/nodejs/node/pull/35922/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/35922/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/streams.js | https://github.com/nodejs/node/pull/35922/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/promises.js | https://github.com/nodejs/node/pull/35922/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/promises.js | https://github.com/nodejs/node/pull/35922/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/events.js | https://github.com/nodejs/node/pull/35922/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/events.js | https://github.com/nodejs/node/pull/35922/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/events.js | https://github.com/nodejs/node/pull/35922/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 2, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-521891492 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| lib/events.js | https://github.com/nodejs/node/pull/35922/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/internal/fs/promises.js | https://github.com/nodejs/node/pull/35922/files#diff-408a6d8eb0a23c586754d4f3af46c8b1927a32d80a6bdfd3bbd87c0f2a012b1a |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Nov 2, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-522015763 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/35922#pullrequestreview-522015763 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| test/parallel/test-fs-write-stream-file-handle.js | https://github.com/nodejs/node/pull/35922/files#diff-ff8537fb471e03b98fa5a6f1fe6450d69dffe1d81526818d3b4ac0629300f130 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 2, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-522082047 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| lib/internal/event_target.js | https://github.com/nodejs/node/pull/35922/files#diff-3a58267211ca7ef81843af880c461058fba2dc32379702b246a2d8aaec23c77e |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| lib/events.js | https://github.com/nodejs/node/pull/35922/files#diff-330bdd22a188135540523f69deb4f9563e03b00a913cd369e1ee84d899f178a9 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 13, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-530115056 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/35922/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 13, 2020
| https://github.com/nodejs/node/pull/35922#pullrequestreview-530115445 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35922/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 13, 2020 | https://github.com/nodejs/node/pull/35922#issuecomment-726801442 |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| force-pushed | https://github.com/nodejs/node/compare/488fa5b8cf7b15beda039c6ea08f3b9b64fe6101..0725ed0381c15af6b99949149e7dbca0c9503ab5 |
| 488fa5b | https://github.com/nodejs/node/commit/488fa5b8cf7b15beda039c6ea08f3b9b64fe6101 |
| 0725ed0 | https://github.com/nodejs/node/commit/0725ed0381c15af6b99949149e7dbca0c9503ab5 |
|
Compare
| https://github.com/nodejs/node/compare/488fa5b8cf7b15beda039c6ea08f3b9b64fe6101..0725ed0381c15af6b99949149e7dbca0c9503ab5 |
| November 13, 2020 16:21 | https://github.com/nodejs/node/pull/35922#event-3994221866 |
| mmomtchev | https://github.com/mmomtchev |
| December 2, 2020 18:50 | https://github.com/nodejs/node/pull/35922#commits-pushed-ea37dd7 |
|
| https://github.com/mmomtchev |
| stream: linting | https://github.com/nodejs/node/pull/35922/commits/ea37dd7cc2ae106a8b701e59e032aaf2f5732963 |
| ea37dd7 | https://github.com/nodejs/node/pull/35922/commits/ea37dd7cc2ae106a8b701e59e032aaf2f5732963 |
|
| https://github.com/mmomtchev |
| stream: remove useless initializiation of stream.fd | https://github.com/nodejs/node/pull/35922/commits/403a7aab38b0623bd331cab8821ffec97d0bb0b6 |
| 403a7aa | https://github.com/nodejs/node/pull/35922/commits/403a7aab38b0623bd331cab8821ffec97d0bb0b6 |
|
| https://github.com/mmomtchev |
| stream: create tmpdir only in main thread | https://github.com/nodejs/node/pull/35922/commits/c267bc1e22b73737d05bc62231e6b72545729109 |
| c267bc1 | https://github.com/nodejs/node/pull/35922/commits/c267bc1e22b73737d05bc62231e6b72545729109 |
|
| https://github.com/mmomtchev |
|
| https://github.com/aduh95 |
| Remove useless / from path.join | https://github.com/nodejs/node/pull/35922/commits/68f98fbe3bf52986ebb20be355fbfe14c7e133a4 |
| 68f98fb | https://github.com/nodejs/node/pull/35922/commits/68f98fbe3bf52986ebb20be355fbfe14c7e133a4 |
|
| https://github.com/mmomtchev |
| stream: compatibility with the --work test | https://github.com/nodejs/node/pull/35922/commits/8d0a717e79bbc97dd455922a0f4be509c30b6146 |
| 8d0a717 | https://github.com/nodejs/node/pull/35922/commits/8d0a717e79bbc97dd455922a0f4be509c30b6146 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| force-pushed | https://github.com/nodejs/node/compare/c231f4b86ba9daccae0854d7fb0f2f2e740a6348..8d0a717e79bbc97dd455922a0f4be509c30b6146 |
| c231f4b | https://github.com/nodejs/node/commit/c231f4b86ba9daccae0854d7fb0f2f2e740a6348 |
| 8d0a717 | https://github.com/nodejs/node/commit/8d0a717e79bbc97dd455922a0f4be509c30b6146 |
|
Compare
| https://github.com/nodejs/node/compare/c231f4b86ba9daccae0854d7fb0f2f2e740a6348..8d0a717e79bbc97dd455922a0f4be509c30b6146 |
| December 2, 2020 17:50 | https://github.com/nodejs/node/pull/35922#event-4063645632 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 2, 2020 | https://github.com/nodejs/node/pull/35922#event-4064190740 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 2, 2020 | https://github.com/nodejs/node/pull/35922#event-4064225238 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 2, 2020 | https://github.com/nodejs/node/pull/35922#issuecomment-737473084 |
| https://ci.nodejs.org/job/node-test-pull-request/34694/ | https://ci.nodejs.org/job/node-test-pull-request/34694/ |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Dec 4, 2020 | https://github.com/nodejs/node/pull/35922#issuecomment-739081448 |
| 0fd121e | https://github.com/nodejs/node/commit/0fd121e00c9d5987c20c27a4ee4295da7735d9de |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Dec 4, 2020 | https://github.com/nodejs/node/pull/35922#event-4074903412 |
| aduh95 | https://github.com/aduh95 |
|
Dec 4, 2020
| https://github.com/nodejs/node/pull/35922#ref-commit-0fd121e |
|
| https://github.com/mmomtchev |
|
| https://github.com/aduh95 |
| stream: add FileHandle support to Read/WriteStream | https://github.com/nodejs/node/commit/0fd121e00c9d5987c20c27a4ee4295da7735d9de |
|
| https://github.com/nodejs/node/commit/0fd121e00c9d5987c20c27a4ee4295da7735d9de#comments |
| 0fd121e | https://github.com/nodejs/node/commit/0fd121e00c9d5987c20c27a4ee4295da7735d9de |
| #35240 | https://github.com/nodejs/node/issues/35240 |
| #35922 | https://github.com/nodejs/node/pull/35922 |
| https://github.com/ronag |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35922 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| Dec 5, 2020 | https://github.com/nodejs/node/pull/35922#event-4074918556 |
| https://github.com/mmomtchev |
| mmomtchev | https://github.com/mmomtchev |
| Dec 6, 2020 | https://github.com/nodejs/node/pull/35922#issuecomment-739480309 |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
| Dec 6, 2020 | https://github.com/nodejs/node/pull/35922#issuecomment-739496953 |
| @mmomtchev | https://github.com/mmomtchev |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
dont-land-on-v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x |
| Dec 6, 2020 | https://github.com/nodejs/node/pull/35922#event-4076579196 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Dec 6, 2020
| https://github.com/nodejs/node/pull/35922#ref-pullrequest-757928012 |
|
fs,stream: introduce FileSystemStream
#36408
| https://github.com/nodejs/node/pull/36408 |
| danielleadams | https://github.com/danielleadams |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/35922#ref-commit-6033d30 |
|
| https://github.com/mmomtchev |
|
| https://github.com/danielleadams |
| stream: add FileHandle support to Read/WriteStream | https://github.com/nodejs/node/commit/6033d30361e83e1efc639dbfc02bff8e2afb95b3 |
| 6033d30 | https://github.com/nodejs/node/commit/6033d30361e83e1efc639dbfc02bff8e2afb95b3 |
| #35240 | https://github.com/nodejs/node/issues/35240 |
| #35922 | https://github.com/nodejs/node/pull/35922 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/35922#ref-pullrequest-758834739 |
|
v15.4.0 proposal
#36435
| https://github.com/nodejs/node/pull/36435 |
| danielleadams | https://github.com/danielleadams |
|
Dec 7, 2020
| https://github.com/nodejs/node/pull/35922#ref-commit-fde09a4 |
|
| https://github.com/danielleadams |
| 2020-12-08, Version 15.4.0 (Current) | https://github.com/nodejs/node/commit/fde09a4cdc9465e8ed51f2f8597e03d7384fc6c2 |
| fde09a4 | https://github.com/nodejs/node/commit/fde09a4cdc9465e8ed51f2f8597e03d7384fc6c2 |
| #36435 | https://github.com/nodejs/node/pull/36435 |
| #36308 | https://github.com/nodejs/node/pull/36308 |
| #36187 | https://github.com/nodejs/node/pull/36187 |
| #36258 | https://github.com/nodejs/node/pull/36258 |
| #35949 | https://github.com/nodejs/node/pull/35949 |
| #35924 | https://github.com/nodejs/node/pull/35924 |
| #36263 | https://github.com/nodejs/node/pull/36263 |
| #36061 | https://github.com/nodejs/node/pull/36061 |
| #35922 | https://github.com/nodejs/node/pull/35922 |
| #36271 | https://github.com/nodejs/node/pull/36271 |
| cjihrig | https://github.com/cjihrig |
|
Dec 8, 2020
| https://github.com/nodejs/node/pull/35922#ref-commit-424858b |
|
| https://github.com/mmomtchev |
|
| https://github.com/cjihrig |
| stream: add FileHandle support to Read/WriteStream | https://github.com/cjihrig/node/commit/424858b457168b6f78a7ae361719d1930f8f10ab |
| 424858b | https://github.com/cjihrig/node/commit/424858b457168b6f78a7ae361719d1930f8f10ab |
| nodejs#35240 | https://github.com/nodejs/node/issues/35240 |
| nodejs#35922 | https://github.com/nodejs/node/pull/35922 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35922 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/35922/files/2e507c441479e374935774ada888125980e2cc36 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/35922/files/d1db768c538a35a7e672e02d16958a7799a9b8a4 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/35922/files/2e507c441479e374935774ada888125980e2cc36 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/35922/files/7a30f6b0f271cbf6ccaf68f363d9f4af8fd87f71 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/35922 |
|
| https://github.com/mmomtchev |
|
| https://github.com/benjamingr |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/aduh95 |
|
| https://github.com/addaleax |
|
| https://github.com/ronag |
|
| https://github.com/richardlau |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |