| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:26a4e9bb-4768-caa6-1f9c-dbfdd6dfebda |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5C6:2780A3:129A0E4:199BBAB:696A90CC |
| html-safe-nonce | 08c14aa1c7ecdb2a8f1109ed11ebb356e3370555d855a4e8c7e4451ad79cb920 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUM2OjI3ODBBMzoxMjlBMEU0OjE5OUJCQUI6Njk2QTkwQ0MiLCJ2aXNpdG9yX2lkIjoiMzY1NjYwMTY3NDI5NDM5OTE4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2aed0fe3185416d8ed39dc876e0ae4b98addb9efda24487326239dc78f46064f |
| hovercard-subject-tag | pull_request:513064422 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35883/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6e194f9fcfc884e502faffd56b4d7fe3e9bca1870b42581ee0632d114ce3e9f0/nodejs/node/pull/35883 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6e194f9fcfc884e502faffd56b4d7fe3e9bca1870b42581ee0632d114ce3e9f0/nodejs/node/pull/35883 |
| og:image:alt | This is now failing inconsistently across many platforms. This
appears to be the result of the addition of mustSucceed being
added to the test during testing refactoring.
We should mark flaky until... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MylesBorins |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35883#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35883 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35883 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35883 |
| Reload | https://github.com/nodejs/node/pull/35883 |
| Reload | https://github.com/nodejs/node/pull/35883 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35883#issue-comment-box |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| MylesBorins:mark-test-http2-respond-file-error-pipe-offset-flaky | https://github.com/MylesBorins/node/tree/mark-test-http2-respond-file-error-pipe-offset-flaky |
|
test: mark test-http2-respond-file-error-pipe-offset flaky
| https://github.com/nodejs/node/pull/35883#top |
| MylesBorins | https://github.com/MylesBorins |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| MylesBorins:mark-test-http2-respond-file-error-pipe-offset-flaky | https://github.com/MylesBorins/node/tree/mark-test-http2-respond-file-error-pipe-offset-flaky |
|
Conversation
5
| https://github.com/nodejs/node/pull/35883 |
|
Commits
1
| https://github.com/nodejs/node/pull/35883/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35883/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35883/files |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#issue-733252116 |
| #35881 | https://github.com/nodejs/node/issues/35881 |
| @Trott | https://github.com/Trott |
| @tniessen | https://github.com/tniessen |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
|
| https://github.com/MylesBorins |
| test: mark test-http2-respond-file-error-pipe-offset flaky | https://github.com/nodejs/node/pull/35883/commits/0fc36156101ff724d12991161c3c2f94b52e181d |
| 0fc3615 | https://github.com/nodejs/node/pull/35883/commits/0fc36156101ff724d12991161c3c2f94b52e181d |
| nodejs#35881 | https://github.com/nodejs/node/issues/35881 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#event-3941638743 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#event-3941640105 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#issuecomment-719602253 |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#event-3941650274 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#issuecomment-719603651 |
| https://ci.nodejs.org/job/node-test-pull-request/33972/ | https://ci.nodejs.org/job/node-test-pull-request/33972/ |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Oct 30, 2020
| https://github.com/nodejs/node/pull/35883#pullrequestreview-520753016 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35883/files/0fc36156101ff724d12991161c3c2f94b52e181d |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#issuecomment-719604230 |
| #35881 (comment) | https://github.com/nodejs/node/issues/35881#issuecomment-719588419 |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 30, 2020
| https://github.com/nodejs/node/pull/35883#pullrequestreview-520756851 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35883/files/0fc36156101ff724d12991161c3c2f94b52e181d |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#issuecomment-719657177 |
| #35886 | https://github.com/nodejs/node/pull/35886 |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#issuecomment-719716284 |
| 5da2512 | https://github.com/nodejs/node/commit/5da2512a72f56031a11c928792392110d4001b24 |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35883#event-3942530361 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 30, 2020
| https://github.com/nodejs/node/pull/35883#ref-commit-5da2512 |
|
| https://github.com/MylesBorins |
| test: mark test-http2-respond-file-error-pipe-offset flaky | https://github.com/nodejs/node/commit/5da2512a72f56031a11c928792392110d4001b24 |
| 5da2512 | https://github.com/nodejs/node/commit/5da2512a72f56031a11c928792392110d4001b24 |
| #35881 | https://github.com/nodejs/node/issues/35881 |
| #35883 | https://github.com/nodejs/node/pull/35883 |
| targos | https://github.com/targos |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35883#ref-commit-7691b67 |
|
| https://github.com/MylesBorins |
|
| https://github.com/targos |
| test: mark test-http2-respond-file-error-pipe-offset flaky | https://github.com/nodejs/node/commit/7691b673dcba4233124dd384bd27380205fff05c |
| 7691b67 | https://github.com/nodejs/node/commit/7691b673dcba4233124dd384bd27380205fff05c |
| #35881 | https://github.com/nodejs/node/issues/35881 |
| #35883 | https://github.com/nodejs/node/pull/35883 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35883#ref-pullrequest-735596211 |
|
v15.1.0 release proposal
#35948
| https://github.com/nodejs/node/pull/35948 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 8, 2020
| https://github.com/nodejs/node/pull/35883#ref-commit-8447e47 |
|
| https://github.com/MylesBorins |
|
| https://github.com/BethGriggs |
| test: mark test-http2-respond-file-error-pipe-offset flaky | https://github.com/nodejs/node/commit/8447e47f90a6c7813d5910e2f100ffbd7d6e9135 |
| 8447e47 | https://github.com/nodejs/node/commit/8447e47f90a6c7813d5910e2f100ffbd7d6e9135 |
| #35881 | https://github.com/nodejs/node/issues/35881 |
| #35883 | https://github.com/nodejs/node/pull/35883 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35883#ref-commit-1dc9cdd |
|
| https://github.com/MylesBorins |
|
| https://github.com/BethGriggs |
| test: mark test-http2-respond-file-error-pipe-offset flaky | https://github.com/nodejs/node/commit/1dc9cdd3593e49066668b8b96d4d68d1eaad8fe5 |
| 1dc9cdd | https://github.com/nodejs/node/commit/1dc9cdd3593e49066668b8b96d4d68d1eaad8fe5 |
| #35881 | https://github.com/nodejs/node/issues/35881 |
| #35883 | https://github.com/nodejs/node/pull/35883 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35883#ref-pullrequest-761612838 |
|
v14.15.2 proposal
#36476
| https://github.com/nodejs/node/pull/36476 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/35883#ref-commit-4ed4b64 |
|
| https://github.com/MylesBorins |
|
| https://github.com/BethGriggs |
| test: mark test-http2-respond-file-error-pipe-offset flaky | https://github.com/nodejs/node/commit/4ed4b64293dd4fa6dda9a473050d7645123d7064 |
| 4ed4b64 | https://github.com/nodejs/node/commit/4ed4b64293dd4fa6dda9a473050d7645123d7064 |
| #35881 | https://github.com/nodejs/node/issues/35881 |
| #35883 | https://github.com/nodejs/node/pull/35883 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35883 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/35883/files/0fc36156101ff724d12991161c3c2f94b52e181d |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/35883/files/0fc36156101ff724d12991161c3c2f94b52e181d |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
flaky-test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aflaky-test |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/35883 |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/tniessen |
|
| https://github.com/gireeshpunathil |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |