| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cd1050d1-e77c-340f-1943-c313b228a69d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C182:309720:DF09FD:1354FB2:696A912A |
| html-safe-nonce | 4291a972b9dd37975686ce65159891f2dd83de284d4065d6bfb9b02be411a74a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTgyOjMwOTcyMDpERjA5RkQ6MTM1NEZCMjo2OTZBOTEyQSIsInZpc2l0b3JfaWQiOiIzMjM0MDc5NDk5MTM2NzAwNzE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 053eb934a69508080de82d2dc25f8fbe7e221c7e3a89feffd31e3bd5b93a489a |
| hovercard-subject-tag | pull_request:510795156 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35828/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/31ddc6b7050c98a673c26248da01410b77ad3fadb055d7b2d82c2b0feeaa2a3c/nodejs/node/pull/35828 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/31ddc6b7050c98a673c26248da01410b77ad3fadb055d7b2d82c2b0feeaa2a3c/nodejs/node/pull/35828 |
| og:image:alt | In email, ronkorving indicated that he could/should be moved to emeritus
at this time.
Checklist
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35828#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35828 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35828 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35828 |
| Reload | https://github.com/nodejs/node/pull/35828 |
| Reload | https://github.com/nodejs/node/pull/35828 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35828 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35828 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35828#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:rk-em | https://github.com/Trott/io.js/tree/rk-em |
|
doc: move ronkorving to emeritus
| https://github.com/nodejs/node/pull/35828#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:rk-em | https://github.com/Trott/io.js/tree/rk-em |
|
Conversation
3
| https://github.com/nodejs/node/pull/35828 |
|
Commits
1
| https://github.com/nodejs/node/pull/35828/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35828/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35828/files |
| Please reload this page | https://github.com/nodejs/node/pull/35828 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 27, 2020 | https://github.com/nodejs/node/pull/35828#issue-730501508 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/35828 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Oct 27, 2020 | https://github.com/nodejs/node/pull/35828#event-3926231222 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| ronkorving | https://github.com/ronkorving |
| October 27, 2020 14:25 | https://github.com/nodejs/node/pull/35828#event-3926231681 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
Oct 27, 2020
| https://github.com/nodejs/node/pull/35828#pullrequestreview-517766647 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35828/files |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Oct 27, 2020 | https://github.com/nodejs/node/pull/35828#event-3927663730 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 28, 2020
| https://github.com/nodejs/node/pull/35828#pullrequestreview-518372967 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35828/files |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Oct 28, 2020
| https://github.com/nodejs/node/pull/35828#pullrequestreview-518426002 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35828/files |
| https://github.com/ronkorving |
| ronkorving | https://github.com/ronkorving |
| Oct 29, 2020 | https://github.com/nodejs/node/pull/35828#issuecomment-718328364 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/35828 |
| https://github.com/ronkorving |
| ronkorving | https://github.com/ronkorving |
|
Oct 29, 2020
| https://github.com/nodejs/node/pull/35828#pullrequestreview-519297521 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35828/files |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
Oct 30, 2020
| https://github.com/nodejs/node/pull/35828#pullrequestreview-520508605 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35828/files |
| watilde | https://github.com/watilde |
| https://github.com/nodejs/node/pull/35828#pullrequestreview-520508605 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35828 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
|
Oct 30, 2020
| https://github.com/nodejs/node/pull/35828#pullrequestreview-520509625 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35828/files |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Oct 30, 2020
| https://github.com/nodejs/node/pull/35828#pullrequestreview-520518924 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35828/files |
|
| https://github.com/Trott |
| doc: move ronkorving to emeritus | https://github.com/nodejs/node/pull/35828/commits/dc9f108c5cd7120f78658237ece0a5d64185796b |
| dc9f108 | https://github.com/nodejs/node/pull/35828/commits/dc9f108c5cd7120f78658237ece0a5d64185796b |
| nodejs#35828 | https://github.com/nodejs/node/pull/35828 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/d9d1c1c8d4bd89e6132bfc94786009251c8b9862..dc9f108c5cd7120f78658237ece0a5d64185796b |
| d9d1c1c | https://github.com/nodejs/node/commit/d9d1c1c8d4bd89e6132bfc94786009251c8b9862 |
| dc9f108 | https://github.com/nodejs/node/commit/dc9f108c5cd7120f78658237ece0a5d64185796b |
|
Compare
| https://github.com/nodejs/node/compare/d9d1c1c8d4bd89e6132bfc94786009251c8b9862..dc9f108c5cd7120f78658237ece0a5d64185796b |
| October 30, 2020 13:15 | https://github.com/nodejs/node/pull/35828#event-3941147113 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35828#issuecomment-719545273 |
| dc9f108 | https://github.com/nodejs/node/commit/dc9f108c5cd7120f78658237ece0a5d64185796b |
| Please reload this page | https://github.com/nodejs/node/pull/35828 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| dc9f108 | https://github.com/nodejs/node/commit/dc9f108c5cd7120f78658237ece0a5d64185796b |
| Oct 30, 2020 | https://github.com/nodejs/node/pull/35828#event-3941148851 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| October 30, 2020 13:15 | https://github.com/nodejs/node/pull/35828#event-3941149359 |
| targos | https://github.com/targos |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35828#ref-commit-c14889b |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: move ronkorving to emeritus | https://github.com/nodejs/node/commit/c14889bcc1192ae0bfa8d2d0d566233529581d5c |
| c14889b | https://github.com/nodejs/node/commit/c14889bcc1192ae0bfa8d2d0d566233529581d5c |
| #35828 | https://github.com/nodejs/node/pull/35828 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35828#ref-pullrequest-735596211 |
|
v15.1.0 release proposal
#35948
| https://github.com/nodejs/node/pull/35948 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 8, 2020
| https://github.com/nodejs/node/pull/35828#ref-commit-d43445d |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: move ronkorving to emeritus | https://github.com/nodejs/node/commit/d43445d840578fbdb2eff36ab6b34963559113bd |
| d43445d | https://github.com/nodejs/node/commit/d43445d840578fbdb2eff36ab6b34963559113bd |
| #35828 | https://github.com/nodejs/node/pull/35828 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35828#ref-commit-d3ea6dd |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: move ronkorving to emeritus | https://github.com/nodejs/node/commit/d3ea6ddec9f3ad415dc826b3b6d0b191b41ec12a |
| d3ea6dd | https://github.com/nodejs/node/commit/d3ea6ddec9f3ad415dc826b3b6d0b191b41ec12a |
| #35828 | https://github.com/nodejs/node/pull/35828 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35828#ref-pullrequest-761612838 |
|
v14.15.2 proposal
#36476
| https://github.com/nodejs/node/pull/36476 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/35828#ref-commit-9486f5f |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: move ronkorving to emeritus | https://github.com/nodejs/node/commit/9486f5fc37bd31f412ba5014671e56ce7c025f5a |
| 9486f5f | https://github.com/nodejs/node/commit/9486f5fc37bd31f412ba5014671e56ce7c025f5a |
| #35828 | https://github.com/nodejs/node/pull/35828 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35828 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/35828/files/d9d1c1c8d4bd89e6132bfc94786009251c8b9862 |
|
| https://github.com/watilde |
|
watilde
| https://github.com/watilde |
|
| https://github.com/nodejs/node/pull/35828/files/d9d1c1c8d4bd89e6132bfc94786009251c8b9862 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/35828/files/d9d1c1c8d4bd89e6132bfc94786009251c8b9862 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/35828/files/d9d1c1c8d4bd89e6132bfc94786009251c8b9862 |
|
| https://github.com/ChALkeR |
|
ChALkeR
| https://github.com/ChALkeR |
|
| https://github.com/nodejs/node/pull/35828/files/d9d1c1c8d4bd89e6132bfc94786009251c8b9862 |
|
| https://github.com/ronkorving |
|
ronkorving
| https://github.com/ronkorving |
|
| https://github.com/nodejs/node/pull/35828/files/d9d1c1c8d4bd89e6132bfc94786009251c8b9862 |
|
| https://github.com/hiroppy |
|
hiroppy
| https://github.com/hiroppy |
|
| https://github.com/nodejs/node/pull/35828/files/d9d1c1c8d4bd89e6132bfc94786009251c8b9862 |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Please reload this page | https://github.com/nodejs/node/pull/35828 |
|
| https://github.com/Trott |
|
| https://github.com/ronkorving |
|
| https://github.com/ChALkeR |
|
| https://github.com/benjamingr |
|
| https://github.com/watilde |
|
| https://github.com/targos |
|
| https://github.com/hiroppy |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |