René's URL Explorer Experiment


Title: events: make eventTarget.removeAllListeners() return this by lpinca · Pull Request #35805 · nodejs/node · GitHub

Open Graph Title: events: make eventTarget.removeAllListeners() return this by lpinca · Pull Request #35805 · nodejs/node

X Title: events: make eventTarget.removeAllListeners() return this by lpinca · Pull Request #35805 · nodejs/node

Description: Fixes: #35762 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Open Graph Description: Fixes: #35762 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: Fixes: #35762 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/35805

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e7586cc-f20d-a4c1-2728-34feed1aabdd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B76:22DEEF:E71937:13F231E:696A9196
html-safe-nonce20ba1f5a744d752faecaa69df052753bb8f9caf596dcb2b4681de8d1247b5384
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Qjc2OjIyREVFRjpFNzE5Mzc6MTNGMjMxRTo2OTZBOTE5NiIsInZpc2l0b3JfaWQiOiI2NDMyOTA2ODcxMzA2ODgzNDc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdda829a589f0527b321d90f38d0099627169689e0b4d0dfe754154571ec0a484
hovercard-subject-tagpull_request:509853811
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35805/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a9194dadbcca81d282fd8bd3e3c1f3ac40e87a139f99769d35a81a3ca568a1be/nodejs/node/pull/35805
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a9194dadbcca81d282fd8bd3e3c1f3ac40e87a139f99769d35a81a3ca568a1be/nodejs/node/pull/35805
og:image:altFixes: #35762 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35805#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35805
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35805
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35805
Reloadhttps://github.com/nodejs/node/pull/35805
Reloadhttps://github.com/nodejs/node/pull/35805
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35805
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35805
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35805#issue-comment-box
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:fix/issue-35762https://github.com/lpinca/node/tree/fix/issue-35762
events: make eventTarget.removeAllListeners() return this https://github.com/nodejs/node/pull/35805#top
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:fix/issue-35762https://github.com/lpinca/node/tree/fix/issue-35762
Conversation 5 https://github.com/nodejs/node/pull/35805
Commits 1 https://github.com/nodejs/node/pull/35805/commits
Checks 0 https://github.com/nodejs/node/pull/35805/checks
Files changed https://github.com/nodejs/node/pull/35805/files
Please reload this pagehttps://github.com/nodejs/node/pull/35805
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 26, 2020https://github.com/nodejs/node/pull/35805#issue-729348438
#35762https://github.com/nodejs/node/issues/35762
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35805
https://github.com/targos
targoshttps://github.com/targos
Oct 26, 2020 https://github.com/nodejs/node/pull/35805#pullrequestreview-516545528
View reviewed changes https://github.com/nodejs/node/pull/35805/files
test/parallel/test-nodeeventtarget.jshttps://github.com/nodejs/node/pull/35805/files#diff-86f4a966c0ac28259c5422385e22d4c2ad6a455cf31f1ef23b0591bb2f7c0429
Please reload this pagehttps://github.com/nodejs/node/pull/35805
test/parallel/test-nodeeventtarget.jshttps://github.com/nodejs/node/pull/35805/files#diff-86f4a966c0ac28259c5422385e22d4c2ad6a455cf31f1ef23b0591bb2f7c0429
Please reload this pagehttps://github.com/nodejs/node/pull/35805
https://github.com/lpinca
events: make eventTarget.removeAllListeners() return thishttps://github.com/nodejs/node/pull/35805/commits/906e9b6258f32277a5beea4f9d48de04ff4d27cb
906e9b6https://github.com/nodejs/node/pull/35805/commits/906e9b6258f32277a5beea4f9d48de04ff4d27cb
nodejs#35762https://github.com/nodejs/node/issues/35762
https://github.com/lpinca
lpincahttps://github.com/lpinca
force-pushedhttps://github.com/nodejs/node/compare/d5c1f204f77a5d77477222fac45d7564aed6e6bf..906e9b6258f32277a5beea4f9d48de04ff4d27cb
d5c1f20https://github.com/nodejs/node/commit/d5c1f204f77a5d77477222fac45d7564aed6e6bf
906e9b6https://github.com/nodejs/node/commit/906e9b6258f32277a5beea4f9d48de04ff4d27cb
Compare https://github.com/nodejs/node/compare/d5c1f204f77a5d77477222fac45d7564aed6e6bf..906e9b6258f32277a5beea4f9d48de04ff4d27cb
October 26, 2020 08:21https://github.com/nodejs/node/pull/35805#event-3919440597
https://github.com/targos
targoshttps://github.com/targos
Oct 26, 2020 https://github.com/nodejs/node/pull/35805#pullrequestreview-516565189
View reviewed changes https://github.com/nodejs/node/pull/35805/files/906e9b6258f32277a5beea4f9d48de04ff4d27cb
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Oct 26, 2020 https://github.com/nodejs/node/pull/35805#pullrequestreview-516585173
View reviewed changes https://github.com/nodejs/node/pull/35805/files/906e9b6258f32277a5beea4f9d48de04ff4d27cb
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
Oct 26, 2020https://github.com/nodejs/node/pull/35805#issuecomment-716419039
Please reload this pagehttps://github.com/nodejs/node/pull/35805
Codecovhttps://codecov.io/gh/nodejs/node/pull/35805?src=pr&el=h1
#35805https://codecov.io/gh/nodejs/node/pull/35805?src=pr&el=desc
masterhttps://codecov.io/gh/nodejs/node/commit/ba907ff750ea18df743252b09f2c29d35ebe285d?el=desc
Impacted Fileshttps://codecov.io/gh/nodejs/node/pull/35805?src=pr&el=tree
lib/internal/event_target.jshttps://codecov.io/gh/nodejs/node/pull/35805/diff?src=pr&el=tree#diff-bGliL2ludGVybmFsL2V2ZW50X3RhcmdldC5qcw==
src/node_api.cchttps://codecov.io/gh/nodejs/node/pull/35805/diff?src=pr&el=tree#diff-c3JjL25vZGVfYXBpLmNj
src/api/environment.cchttps://codecov.io/gh/nodejs/node/pull/35805/diff?src=pr&el=tree#diff-c3JjL2FwaS9lbnZpcm9ubWVudC5jYw==
lib/internal/main/worker_thread.jshttps://codecov.io/gh/nodejs/node/pull/35805/diff?src=pr&el=tree#diff-bGliL2ludGVybmFsL21haW4vd29ya2VyX3RocmVhZC5qcw==
lib/_http_server.jshttps://codecov.io/gh/nodejs/node/pull/35805/diff?src=pr&el=tree#diff-bGliL19odHRwX3NlcnZlci5qcw==
lib/internal/child_process.jshttps://codecov.io/gh/nodejs/node/pull/35805/diff?src=pr&el=tree#diff-bGliL2ludGVybmFsL2NoaWxkX3Byb2Nlc3MuanM=
src/node_http_parser.cchttps://codecov.io/gh/nodejs/node/pull/35805/diff?src=pr&el=tree#diff-c3JjL25vZGVfaHR0cF9wYXJzZXIuY2M=
src/memory_tracker-inl.hhttps://codecov.io/gh/nodejs/node/pull/35805/diff?src=pr&el=tree#diff-c3JjL21lbW9yeV90cmFja2VyLWlubC5o
Please reload this pagehttps://github.com/nodejs/node/pull/35805
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 26, 2020 https://github.com/nodejs/node/pull/35805#pullrequestreview-516667231
View reviewed changes https://github.com/nodejs/node/pull/35805/files/906e9b6258f32277a5beea4f9d48de04ff4d27cb
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 26, 2020 https://github.com/nodejs/node/pull/35805#pullrequestreview-516675162
View reviewed changes https://github.com/nodejs/node/pull/35805/files/906e9b6258f32277a5beea4f9d48de04ff4d27cb
https://github.com/lpinca
lpincahttps://github.com/lpinca
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 28, 2020https://github.com/nodejs/node/pull/35805#event-3930373512
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 28, 2020https://github.com/nodejs/node/pull/35805#event-3930495106
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 28, 2020https://github.com/nodejs/node/pull/35805#issuecomment-717842515
https://ci.nodejs.org/job/node-test-pull-request/33898/https://ci.nodejs.org/job/node-test-pull-request/33898/
Please reload this pagehttps://github.com/nodejs/node/pull/35805
Trotthttps://github.com/Trott
Oct 28, 2020 https://github.com/nodejs/node/pull/35805#ref-commit-81ba3ae
https://github.com/lpinca
https://github.com/Trott
events: make eventTarget.removeAllListeners() return thishttps://github.com/Trott/io.js/commit/81ba3ae699a8ee04e3a5a05b0f7e066b5a486c42
81ba3aehttps://github.com/Trott/io.js/commit/81ba3ae699a8ee04e3a5a05b0f7e066b5a486c42
nodejs#35762https://github.com/nodejs/node/issues/35762
nodejs#35805https://github.com/nodejs/node/pull/35805
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 28, 2020https://github.com/nodejs/node/pull/35805#issuecomment-717940195
81ba3aehttps://github.com/nodejs/node/commit/81ba3ae699a8ee04e3a5a05b0f7e066b5a486c42
Please reload this pagehttps://github.com/nodejs/node/pull/35805
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 28, 2020https://github.com/nodejs/node/pull/35805#event-3931308823
https://github.com/lpinca
lpincahttps://github.com/lpinca
October 28, 2020 14:10https://github.com/nodejs/node/pull/35805#event-3931470920
targoshttps://github.com/targos
Nov 3, 2020 https://github.com/nodejs/node/pull/35805#ref-commit-438d9de
https://github.com/lpinca
https://github.com/targos
events: make eventTarget.removeAllListeners() return thishttps://github.com/nodejs/node/commit/438d9debfd935cc53c0bc3a377eb1346ace7eddd
438d9dehttps://github.com/nodejs/node/commit/438d9debfd935cc53c0bc3a377eb1346ace7eddd
#35762https://github.com/nodejs/node/issues/35762
#35805https://github.com/nodejs/node/pull/35805
https://github.com/targos
targoshttps://github.com/targos
Nov 3, 2020 https://github.com/nodejs/node/pull/35805#ref-pullrequest-735596211
v15.1.0 release proposal #35948 https://github.com/nodejs/node/pull/35948
BethGriggshttps://github.com/BethGriggs
Dec 8, 2020 https://github.com/nodejs/node/pull/35805#ref-commit-9c74875
https://github.com/lpinca
https://github.com/BethGriggs
events: make eventTarget.removeAllListeners() return thishttps://github.com/nodejs/node/commit/9c74875c3397db3d89971bf805b0a5b5c860c1e6
9c74875https://github.com/nodejs/node/commit/9c74875c3397db3d89971bf805b0a5b5c860c1e6
#35762https://github.com/nodejs/node/issues/35762
#35805https://github.com/nodejs/node/pull/35805
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/35805#ref-commit-253f65c
https://github.com/lpinca
https://github.com/BethGriggs
events: make eventTarget.removeAllListeners() return thishttps://github.com/nodejs/node/commit/253f65c52d6c42d00a1120d25e4dadd947f27056
253f65chttps://github.com/nodejs/node/commit/253f65c52d6c42d00a1120d25e4dadd947f27056
#35762https://github.com/nodejs/node/issues/35762
#35805https://github.com/nodejs/node/pull/35805
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/35805#ref-pullrequest-761612838
v14.15.2 proposal #36476 https://github.com/nodejs/node/pull/36476
BethGriggshttps://github.com/BethGriggs
Dec 15, 2020 https://github.com/nodejs/node/pull/35805#ref-commit-8ef4557
https://github.com/lpinca
https://github.com/BethGriggs
events: make eventTarget.removeAllListeners() return thishttps://github.com/nodejs/node/commit/8ef4557c6524fffe88956b2ae367ab42ebaaccfa
8ef4557https://github.com/nodejs/node/commit/8ef4557c6524fffe88956b2ae367ab42ebaaccfa
#35762https://github.com/nodejs/node/issues/35762
#35805https://github.com/nodejs/node/pull/35805
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35805
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/35805/files/906e9b6258f32277a5beea4f9d48de04ff4d27cb
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/35805/files/906e9b6258f32277a5beea4f9d48de04ff4d27cb
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/35805/files/906e9b6258f32277a5beea4f9d48de04ff4d27cb
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/35805/files/906e9b6258f32277a5beea4f9d48de04ff4d27cb
[v15.0] NodeEventTarget#removeAllListeners has different return type than EventEmitter#removeAllListeners https://github.com/nodejs/node/issues/35762
Please reload this pagehttps://github.com/nodejs/node/pull/35805
https://github.com/lpinca
https://github.com/codecov-io
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/benjamingr
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.