| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:df3892c5-68f1-da70-d953-cbfaf34a84a0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9856:DE287:9DF63E:D70892:696ABA00 |
| html-safe-nonce | 7c352643fdc389ccfd7fa2b6ef1388a52b3727a5f39e75d1e8990116de072179 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODU2OkRFMjg3OjlERjYzRTpENzA4OTI6Njk2QUJBMDAiLCJ2aXNpdG9yX2lkIjoiOTAzNTYzMjA4MTc0MzAzNDg4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f258f035ebb338fbc9ae77914b6912c670eaa291cf924f8a61060d713f68e57f |
| hovercard-subject-tag | pull_request:507483798 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35737/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/67148a468092c0c503cb788af24be53ee9d4ea95c0be2a5446aa8299b688b2b1/nodejs/node/pull/35737 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/67148a468092c0c503cb788af24be53ee9d4ea95c0be2a5446aa8299b688b2b1/nodejs/node/pull/35737 |
| og:image:alt | The kbd element has already been added in the keybindings table, but we
missed it in one line in the prose.
Checklist
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35737#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35737 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35737 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35737 |
| Reload | https://github.com/nodejs/node/pull/35737 |
| Reload | https://github.com/nodejs/node/pull/35737 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35737 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35737 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35737#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:one-moar-kbd | https://github.com/Trott/io.js/tree/one-moar-kbd |
|
doc: use kbd element in readline doc prose
| https://github.com/nodejs/node/pull/35737#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:one-moar-kbd | https://github.com/Trott/io.js/tree/one-moar-kbd |
|
Conversation
3
| https://github.com/nodejs/node/pull/35737 |
|
Commits
1
| https://github.com/nodejs/node/pull/35737/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35737/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35737/files |
| Please reload this page | https://github.com/nodejs/node/pull/35737 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 21, 2020 | https://github.com/nodejs/node/pull/35737#issue-726416628 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/35737 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
| Oct 21, 2020 | https://github.com/nodejs/node/pull/35737#event-3903483482 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 21, 2020 | https://github.com/nodejs/node/pull/35737#issuecomment-713521356 |
| https://user-images.githubusercontent.com/718899/96717382-3362d980-135b-11eb-8f55-fc4b725f443b.png |
| https://user-images.githubusercontent.com/718899/96717303-1a5a2880-135b-11eb-8865-16d2d46e6f8d.png |
| Please reload this page | https://github.com/nodejs/node/pull/35737 |
| https://github.com/codecov-io |
| codecov-io | https://github.com/codecov-io |
| Oct 21, 2020 | https://github.com/nodejs/node/pull/35737#issuecomment-713559406 |
| Codecov | https://codecov.io/gh/nodejs/node/pull/35737?src=pr&el=h1 |
| #35737 | https://codecov.io/gh/nodejs/node/pull/35737?src=pr&el=desc |
| master | https://codecov.io/gh/nodejs/node/commit/6c4239bea786a3e231943c283fe236832987939d?el=desc |
| https://codecov.io/gh/nodejs/node/pull/35737?src=pr&el=tree |
| Impacted Files | https://codecov.io/gh/nodejs/node/pull/35737?src=pr&el=tree |
| lib/_http_server.js | https://codecov.io/gh/nodejs/node/pull/35737/diff?src=pr&el=tree#diff-bGliL19odHRwX3NlcnZlci5qcw== |
| Continue to review full report at Codecov | https://codecov.io/gh/nodejs/node/pull/35737?src=pr&el=continue |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta |
| Codecov | https://codecov.io/gh/nodejs/node/pull/35737?src=pr&el=footer |
| 6c4239b...8234f2d | https://codecov.io/gh/nodejs/node/pull/35737?src=pr&el=lastupdated |
| comment docs | https://docs.codecov.io/docs/pull-request-comments |
| Please reload this page | https://github.com/nodejs/node/pull/35737 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
|
Oct 21, 2020
| https://github.com/nodejs/node/pull/35737#pullrequestreview-513940879 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35737/files |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
|
Oct 26, 2020
| https://github.com/nodejs/node/pull/35737#pullrequestreview-516539896 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35737/files |
|
| https://github.com/Trott |
| doc: use kbd element in readline doc prose | https://github.com/nodejs/node/pull/35737/commits/dd43715caaffcfe2dafddd3e792cc0fb2b7b9d20 |
| dd43715 | https://github.com/nodejs/node/pull/35737/commits/dd43715caaffcfe2dafddd3e792cc0fb2b7b9d20 |
| nodejs#35737 | https://github.com/nodejs/node/pull/35737 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/8234f2d16ed12c1f08d57c1da36a01f8b16c6131..dd43715caaffcfe2dafddd3e792cc0fb2b7b9d20 |
| 8234f2d | https://github.com/nodejs/node/commit/8234f2d16ed12c1f08d57c1da36a01f8b16c6131 |
| dd43715 | https://github.com/nodejs/node/commit/dd43715caaffcfe2dafddd3e792cc0fb2b7b9d20 |
|
Compare
| https://github.com/nodejs/node/compare/8234f2d16ed12c1f08d57c1da36a01f8b16c6131..dd43715caaffcfe2dafddd3e792cc0fb2b7b9d20 |
| October 26, 2020 10:34 | https://github.com/nodejs/node/pull/35737#event-3920004112 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| dd43715 | https://github.com/nodejs/node/commit/dd43715caaffcfe2dafddd3e792cc0fb2b7b9d20 |
| Oct 26, 2020 | https://github.com/nodejs/node/pull/35737#event-3920006243 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 26, 2020 | https://github.com/nodejs/node/pull/35737#issuecomment-716459871 |
| dd43715 | https://github.com/nodejs/node/commit/dd43715caaffcfe2dafddd3e792cc0fb2b7b9d20 |
| Please reload this page | https://github.com/nodejs/node/pull/35737 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| October 26, 2020 10:34 | https://github.com/nodejs/node/pull/35737#event-3920006464 |
| targos | https://github.com/targos |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35737#ref-commit-afbe23d |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: use kbd element in readline doc prose | https://github.com/nodejs/node/commit/afbe23d800ed3832e6bbb88036bac5dffc7f49e5 |
| afbe23d | https://github.com/nodejs/node/commit/afbe23d800ed3832e6bbb88036bac5dffc7f49e5 |
| #35737 | https://github.com/nodejs/node/pull/35737 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35737#ref-pullrequest-735596211 |
|
v15.1.0 release proposal
#35948
| https://github.com/nodejs/node/pull/35948 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 8, 2020
| https://github.com/nodejs/node/pull/35737#ref-commit-a3a0aca |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: use kbd element in readline doc prose | https://github.com/nodejs/node/commit/a3a0acafe67260c22e3ee5652f4b9a1abd2094ed |
| a3a0aca | https://github.com/nodejs/node/commit/a3a0acafe67260c22e3ee5652f4b9a1abd2094ed |
| #35737 | https://github.com/nodejs/node/pull/35737 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35737#ref-commit-b7e5d62 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: use kbd element in readline doc prose | https://github.com/nodejs/node/commit/b7e5d62de0a234edf4e90f9a32ec7c82c4d2c764 |
| b7e5d62 | https://github.com/nodejs/node/commit/b7e5d62de0a234edf4e90f9a32ec7c82c4d2c764 |
| #35737 | https://github.com/nodejs/node/pull/35737 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35737#ref-pullrequest-761612838 |
|
v14.15.2 proposal
#36476
| https://github.com/nodejs/node/pull/36476 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/35737#ref-commit-41937f7 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: use kbd element in readline doc prose | https://github.com/nodejs/node/commit/41937f76f0dd2b9239e23b25ff7ed5063af169bf |
| 41937f7 | https://github.com/nodejs/node/commit/41937f76f0dd2b9239e23b25ff7ed5063af169bf |
| #35737 | https://github.com/nodejs/node/pull/35737 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35737 |
|
| https://github.com/fhinkel |
|
fhinkel
| https://github.com/fhinkel |
|
| https://github.com/nodejs/node/pull/35737/files/8234f2d16ed12c1f08d57c1da36a01f8b16c6131 |
|
| https://github.com/silverwind |
|
silverwind
| https://github.com/silverwind |
|
| https://github.com/nodejs/node/pull/35737/files/8234f2d16ed12c1f08d57c1da36a01f8b16c6131 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
| Please reload this page | https://github.com/nodejs/node/pull/35737 |
|
| https://github.com/Trott |
|
| https://github.com/codecov-io |
|
| https://github.com/fhinkel |
|
| https://github.com/silverwind |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |