René's URL Explorer Experiment


Title: build: do not pass mode option to test-v8 command by targos · Pull Request #35705 · nodejs/node · GitHub

Open Graph Title: build: do not pass mode option to test-v8 command by targos · Pull Request #35705 · nodejs/node

X Title: build: do not pass mode option to test-v8 command by targos · Pull Request #35705 · nodejs/node

Description: It was removed upstream and is now inferred from the build config. Refs: nodejs/node-v8#180 (comment)

Open Graph Description: It was removed upstream and is now inferred from the build config. Refs: nodejs/node-v8#180 (comment)

X Description: It was removed upstream and is now inferred from the build config. Refs: nodejs/node-v8#180 (comment)

Opengraph URL: https://github.com/nodejs/node/pull/35705

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e6f0a0c7-2d19-eaab-4bee-189425bcafc3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95B0:12343F:4E0EEB:69E62A:696AAA6C
html-safe-noncef9c62431e11e845be1886b8d8f594ec241811d6b11acebba12e61e11a1ddca89
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUIwOjEyMzQzRjo0RTBFRUI6NjlFNjJBOjY5NkFBQTZDIiwidmlzaXRvcl9pZCI6IjM3Nzg0NTU1NDQzNjM5MTk5ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaab788808acaa413363783b7070e444295beafed51539658b979b93dd84ee13c
hovercard-subject-tagpull_request:505819348
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35705/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/89164dddfc313de2d845ecd9991b7a85d6b8fd4b911ab0d9698f503bd7fb45da/nodejs/node/pull/35705
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/89164dddfc313de2d845ecd9991b7a85d6b8fd4b911ab0d9698f503bd7fb45da/nodejs/node/pull/35705
og:image:altIt was removed upstream and is now inferred from the build config. Refs: nodejs/node-v8#180 (comment)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametargos
hostnamegithub.com
expected-hostnamegithub.com
None3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd9a979046e6382bd084e2bd873bf65f797125ff
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35705#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35705
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35705
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35705
Reloadhttps://github.com/nodejs/node/pull/35705
Reloadhttps://github.com/nodejs/node/pull/35705
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35705
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35705
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35705#issue-comment-box
targoshttps://github.com/targos
nodejs:masterhttps://github.com/nodejs/node/tree/master
targos:fix-v8-cihttps://github.com/targos/node/tree/fix-v8-ci
build: do not pass mode option to test-v8 command https://github.com/nodejs/node/pull/35705#top
targoshttps://github.com/targos
nodejs:masterhttps://github.com/nodejs/node/tree/master
targos:fix-v8-cihttps://github.com/targos/node/tree/fix-v8-ci
Conversation 6 https://github.com/nodejs/node/pull/35705
Commits 1 https://github.com/nodejs/node/pull/35705/commits
Checks 0 https://github.com/nodejs/node/pull/35705/checks
Files changed https://github.com/nodejs/node/pull/35705/files
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/targos
targoshttps://github.com/targos
Oct 19, 2020https://github.com/nodejs/node/pull/35705#issue-724430884
nodejs/node-v8#180 (comment)https://github.com/nodejs/node-v8/issues/180#issuecomment-711883431
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://github.com/targos
build: do not pass mode option to test-v8 commandhttps://github.com/nodejs/node/pull/35705/commits/de14755f083f26d5375155530edb6fcf83781c0e
de14755https://github.com/nodejs/node/pull/35705/commits/de14755f083f26d5375155530edb6fcf83781c0e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Oct 19, 2020https://github.com/nodejs/node/pull/35705#event-3892268646
https://github.com/targos
targoshttps://github.com/targos
Oct 19, 2020https://github.com/nodejs/node/pull/35705#issuecomment-711894335
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Oct 19, 2020https://github.com/nodejs/node/pull/35705#event-3892270886
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 19, 2020 https://github.com/nodejs/node/pull/35705#pullrequestreview-511565587
View reviewed changes https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 19, 2020https://github.com/nodejs/node/pull/35705#issuecomment-711896635
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://ci.nodejs.org/job/node-test-pull-request/33715/https://ci.nodejs.org/job/node-test-pull-request/33715/
https://ci.nodejs.org/job/node-test-commit-v8-linux/3486/https://ci.nodejs.org/job/node-test-commit-v8-linux/3486/
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 19, 2020https://github.com/nodejs/node/pull/35705#issuecomment-711898423
@BethGriggshttps://github.com/BethGriggs
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://github.com/targos
targoshttps://github.com/targos
Oct 19, 2020 https://github.com/nodejs/node/pull/35705#ref-pullrequest-690440226
2020-10-20, Version 15.0.0 (Current) #35014 https://github.com/nodejs/node/pull/35014
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Oct 19, 2020 https://github.com/nodejs/node/pull/35705#pullrequestreview-511569296
View reviewed changes https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Oct 19, 2020 https://github.com/nodejs/node/pull/35705#pullrequestreview-511569865
View reviewed changes https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
Oct 19, 2020https://github.com/nodejs/node/pull/35705#issuecomment-711988988
Codecovhttps://codecov.io/gh/nodejs/node/pull/35705?src=pr&el=h1
#35705https://codecov.io/gh/nodejs/node/pull/35705?src=pr&el=desc
masterhttps://codecov.io/gh/nodejs/node/commit/c55f661551d7368778ae6f9adc584467151bce8a?el=desc
https://codecov.io/gh/nodejs/node/pull/35705?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/nodejs/node/pull/35705?src=pr&el=tree
lib/internal/util/inspect.jshttps://codecov.io/gh/nodejs/node/pull/35705/diff?src=pr&el=tree#diff-bGliL2ludGVybmFsL3V0aWwvaW5zcGVjdC5qcw==
Continue to review full report at Codecovhttps://codecov.io/gh/nodejs/node/pull/35705?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/nodejs/node/pull/35705?src=pr&el=footer
c55f661...de14755https://codecov.io/gh/nodejs/node/pull/35705?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://github.com/watilde
watildehttps://github.com/watilde
Oct 19, 2020 https://github.com/nodejs/node/pull/35705#pullrequestreview-511650173
View reviewed changes https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 19, 2020https://github.com/nodejs/node/pull/35705#issuecomment-712076479
https://ci.nodejs.org/job/node-test-pull-request/33716/https://ci.nodejs.org/job/node-test-pull-request/33716/
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 19, 2020 https://github.com/nodejs/node/pull/35705#pullrequestreview-511692447
View reviewed changes https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
gengjiawenhttps://github.com/gengjiawen
Oct 19, 2020 https://github.com/nodejs/node/pull/35705#ref-commit-b18651b
https://github.com/targos
https://github.com/gengjiawen
build: do not pass mode option to test-v8 commandhttps://github.com/nodejs/node/commit/b18651bcd2c289cfad9750571f514dbdab12eb51
b18651bhttps://github.com/nodejs/node/commit/b18651bcd2c289cfad9750571f514dbdab12eb51
#35705https://github.com/nodejs/node/pull/35705
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Oct 19, 2020https://github.com/nodejs/node/pull/35705#issuecomment-712207205
b18651bhttps://github.com/nodejs/node/commit/b18651bcd2c289cfad9750571f514dbdab12eb51
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Oct 19, 2020https://github.com/nodejs/node/pull/35705#event-3893816999
https://github.com/targos
targoshttps://github.com/targos
October 19, 2020 14:43https://github.com/nodejs/node/pull/35705#event-3893871866
https://github.com/targos
targoshttps://github.com/targos
backported-to-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v14.x
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
Apr 20, 2021https://github.com/nodejs/node/pull/35705#event-4617825181
targoshttps://github.com/targos
Apr 20, 2021 https://github.com/nodejs/node/pull/35705#ref-commit-8970e9a
https://github.com/targos
build: do not pass mode option to test-v8 commandhttps://github.com/targos/node/commit/8970e9a60908cbcb51cefc92c8a9ca4e2b5c4223
8970e9ahttps://github.com/targos/node/commit/8970e9a60908cbcb51cefc92c8a9ca4e2b5c4223
nodejs#35705https://github.com/nodejs/node/pull/35705
targoshttps://github.com/targos
Apr 27, 2021 https://github.com/nodejs/node/pull/35705#ref-commit-6d9800e
https://github.com/targos
build: do not pass mode option to test-v8 commandhttps://github.com/targos/node/commit/6d9800e4b7d02a599d2df721cb6bf86d5122e260
6d9800ehttps://github.com/targos/node/commit/6d9800e4b7d02a599d2df721cb6bf86d5122e260
nodejs#35705https://github.com/nodejs/node/pull/35705
targoshttps://github.com/targos
Apr 30, 2021 https://github.com/nodejs/node/pull/35705#ref-commit-d8f8719
https://github.com/targos
build: do not pass mode option to test-v8 commandhttps://github.com/nodejs/node/commit/d8f8719415211ac98ddec4f1aecd406a6cdb89d1
d8f8719https://github.com/nodejs/node/commit/d8f8719415211ac98ddec4f1aecd406a6cdb89d1
#35705https://github.com/nodejs/node/pull/35705
#38275https://github.com/nodejs/node/pull/38275
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jun 16, 2021 https://github.com/nodejs/node/pull/35705#ref-pullrequest-922488647
build: don't pass --mode argument to V8 test-runner #39055 https://github.com/nodejs/node/pull/39055
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 23, 2021 https://github.com/nodejs/node/pull/35705#ref-commit-d65514b
https://github.com/richardlau
https://github.com/nodejs-github-bot
build: don't pass --mode argument to V8 test-runnerhttps://github.com/nodejs/node/commit/d65514bc29ff4e91ae560884d10483e33012e095
d65514bhttps://github.com/nodejs/node/commit/d65514bc29ff4e91ae560884d10483e33012e095
#39055https://github.com/nodejs/node/pull/39055
#35705https://github.com/nodejs/node/pull/35705
targoshttps://github.com/targos
Jul 11, 2021 https://github.com/nodejs/node/pull/35705#ref-commit-171ca6b
https://github.com/richardlau
https://github.com/targos
build: don't pass --mode argument to V8 test-runnerhttps://github.com/nodejs/node/commit/171ca6bb3c312f93b3491e97c6a1fb8a5bccd6b1
171ca6bhttps://github.com/nodejs/node/commit/171ca6bb3c312f93b3491e97c6a1fb8a5bccd6b1
#39055https://github.com/nodejs/node/pull/39055
#35705https://github.com/nodejs/node/pull/35705
targoshttps://github.com/targos
Sep 4, 2021 https://github.com/nodejs/node/pull/35705#ref-commit-8d84154
https://github.com/richardlau
https://github.com/targos
build: don't pass --mode argument to V8 test-runnerhttps://github.com/nodejs/node/commit/8d8415415b583039862879eb6964cb17b4421fe1
8d84154https://github.com/nodejs/node/commit/8d8415415b583039862879eb6964cb17b4421fe1
#39055https://github.com/nodejs/node/pull/39055
#35705https://github.com/nodejs/node/pull/35705
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35705
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
https://github.com/watilde
watilde https://github.com/watilde
https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/35705/files/de14755f083f26d5375155530edb6fcf83781c0e
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/35705
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/codecov-io
https://github.com/gengjiawen
https://github.com/Trott
https://github.com/watilde
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.