| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c1b8bb3b-31d7-e013-dcc9-7c48539365c6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D04:23E3D6:E62A95:13DD346:696A908B |
| html-safe-nonce | 4a90b4debc88d0811871f3078bf3f3bab412701050c5332ec9064ec555763e90 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDA0OjIzRTNENjpFNjJBOTU6MTNERDM0Njo2OTZBOTA4QiIsInZpc2l0b3JfaWQiOiI0MDEwMzY1MDY1MTc1NDA0NjgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | da23d53d15865bc013c0580349a27a02cc9663543a8a48080c979a8b94a54f1b |
| hovercard-subject-tag | pull_request:505476151 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35698/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/61b5eba1ae330d062fc7e535f169e82ce36d4e385efcee6dbbc9dffc5d844601/nodejs/node/pull/35698 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/61b5eba1ae330d062fc7e535f169e82ce36d4e385efcee6dbbc9dffc5d844601/nodejs/node/pull/35698 |
| og:image:alt | Checklist
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35698#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35698 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35698 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35698 |
| Reload | https://github.com/nodejs/node/pull/35698 |
| Reload | https://github.com/nodejs/node/pull/35698 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35698#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:readline-kbd | https://github.com/Trott/io.js/tree/readline-kbd |
|
doc: use kbd element in readline doc
| https://github.com/nodejs/node/pull/35698#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:readline-kbd | https://github.com/Trott/io.js/tree/readline-kbd |
|
Conversation
5
| https://github.com/nodejs/node/pull/35698 |
|
Commits
1
| https://github.com/nodejs/node/pull/35698/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35698/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35698/files |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 18, 2020 | https://github.com/nodejs/node/pull/35698#issue-724012039 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
| Oct 18, 2020 | https://github.com/nodejs/node/pull/35698#event-3890266598 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 18, 2020 | https://github.com/nodejs/node/pull/35698#issuecomment-711171414 |
| https://user-images.githubusercontent.com/718899/96369459-e68ac300-110e-11eb-9453-affd8978cb67.png |
| https://user-images.githubusercontent.com/718899/96369463-ec80a400-110e-11eb-934f-d168764217ee.png |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
Oct 18, 2020
| https://github.com/nodejs/node/pull/35698#pullrequestreview-511152756 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35698/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 18, 2020
| https://github.com/nodejs/node/pull/35698#pullrequestreview-511169513 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35698/files |
| doc/api/readline.md | https://github.com/nodejs/node/pull/35698/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
| doc/api/readline.md | https://github.com/nodejs/node/pull/35698/files#diff-c7dc978445adbf0629bdf9808c3992f5a37e805f95b2f6b06ef563703701a3f1 |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
| https://github.com/codecov-io |
| codecov-io | https://github.com/codecov-io |
| Oct 18, 2020 | https://github.com/nodejs/node/pull/35698#issuecomment-711438231 |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
| Codecov | https://codecov.io/gh/nodejs/node/pull/35698?src=pr&el=h1 |
| #35698 | https://codecov.io/gh/nodejs/node/pull/35698?src=pr&el=desc |
| master | https://codecov.io/gh/nodejs/node/commit/fbe33aa52e331c53cf0b47169cec59aeaeaa18fe?el=desc |
| https://codecov.io/gh/nodejs/node/pull/35698?src=pr&el=tree |
| Impacted Files | https://codecov.io/gh/nodejs/node/pull/35698?src=pr&el=tree |
| lib/_http_server.js | https://codecov.io/gh/nodejs/node/pull/35698/diff?src=pr&el=tree#diff-bGliL19odHRwX3NlcnZlci5qcw== |
| Continue to review full report at Codecov | https://codecov.io/gh/nodejs/node/pull/35698?src=pr&el=continue |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta |
| Codecov | https://codecov.io/gh/nodejs/node/pull/35698?src=pr&el=footer |
| fbe33aa...7b17c36 | https://codecov.io/gh/nodejs/node/pull/35698?src=pr&el=lastupdated |
| comment docs | https://docs.codecov.io/docs/pull-request-comments |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
|
| https://github.com/Trott |
| doc: use kbd element in readline doc | https://github.com/nodejs/node/pull/35698/commits/6c4239bea786a3e231943c283fe236832987939d |
| 6c4239b | https://github.com/nodejs/node/pull/35698/commits/6c4239bea786a3e231943c283fe236832987939d |
| nodejs#35698 | https://github.com/nodejs/node/pull/35698 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/7b17c3611c91ebc5774e7b9277584c2b0aa1f244..6c4239bea786a3e231943c283fe236832987939d |
| 7b17c36 | https://github.com/nodejs/node/commit/7b17c3611c91ebc5774e7b9277584c2b0aa1f244 |
| 6c4239b | https://github.com/nodejs/node/commit/6c4239bea786a3e231943c283fe236832987939d |
|
Compare
| https://github.com/nodejs/node/compare/7b17c3611c91ebc5774e7b9277584c2b0aa1f244..6c4239bea786a3e231943c283fe236832987939d |
| October 21, 2020 11:45 | https://github.com/nodejs/node/pull/35698#event-3903404874 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 21, 2020 | https://github.com/nodejs/node/pull/35698#issuecomment-713511032 |
| 6c4239b | https://github.com/nodejs/node/commit/6c4239bea786a3e231943c283fe236832987939d |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| 6c4239b | https://github.com/nodejs/node/commit/6c4239bea786a3e231943c283fe236832987939d |
| Oct 21, 2020 | https://github.com/nodejs/node/pull/35698#event-3903410897 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| October 21, 2020 11:46 | https://github.com/nodejs/node/pull/35698#event-3903411186 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 21, 2020
| https://github.com/nodejs/node/pull/35698#ref-commit-b78294d |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: use kbd element in readline doc | https://github.com/nodejs/node/commit/b78294dc0041d2277ab904c35b56c0163bccdaab |
| b78294d | https://github.com/nodejs/node/commit/b78294dc0041d2277ab904c35b56c0163bccdaab |
| #35698 | https://github.com/nodejs/node/pull/35698 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 21, 2020
| https://github.com/nodejs/node/pull/35698#ref-pullrequest-726387480 |
|
v15.0.1 proposal
#35736
| https://github.com/nodejs/node/pull/35736 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 8, 2020
| https://github.com/nodejs/node/pull/35698#ref-commit-f348fca |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: use kbd element in readline doc | https://github.com/nodejs/node/commit/f348fca8799164e088d61b3ba3b74c008e1067e2 |
| f348fca | https://github.com/nodejs/node/commit/f348fca8799164e088d61b3ba3b74c008e1067e2 |
| #35698 | https://github.com/nodejs/node/pull/35698 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35698#ref-commit-d900015 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: use kbd element in readline doc | https://github.com/nodejs/node/commit/d90001515a724e0737e620873218e96e8adf5a1c |
| d900015 | https://github.com/nodejs/node/commit/d90001515a724e0737e620873218e96e8adf5a1c |
| #35698 | https://github.com/nodejs/node/pull/35698 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 10, 2020
| https://github.com/nodejs/node/pull/35698#ref-pullrequest-761612838 |
|
v14.15.2 proposal
#36476
| https://github.com/nodejs/node/pull/36476 |
| BethGriggs | https://github.com/BethGriggs |
|
Dec 15, 2020
| https://github.com/nodejs/node/pull/35698#ref-commit-7c089ad |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: use kbd element in readline doc | https://github.com/nodejs/node/commit/7c089ad04c614bdff97ffca95933918daf55afc9 |
| 7c089ad | https://github.com/nodejs/node/commit/7c089ad04c614bdff97ffca95933918daf55afc9 |
| #35698 | https://github.com/nodejs/node/pull/35698 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35698 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/35698/files/23cbc1ede2319641c047e19d2fca4851542449c4 |
|
| https://github.com/watilde |
|
watilde
| https://github.com/watilde |
|
| https://github.com/nodejs/node/pull/35698/files/23cbc1ede2319641c047e19d2fca4851542449c4 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
| Please reload this page | https://github.com/nodejs/node/pull/35698 |
|
| https://github.com/Trott |
|
| https://github.com/codecov-io |
|
| https://github.com/lpinca |
|
| https://github.com/watilde |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |