René's URL Explorer Experiment


Title: test: add windows and c++ coverage by bcoe · Pull Request #35670 · nodejs/node · GitHub

Open Graph Title: test: add windows and c++ coverage by bcoe · Pull Request #35670 · nodejs/node

X Title: test: add windows and c++ coverage by bcoe · Pull Request #35670 · nodejs/node

Description: Experiment to see if collecting coverage for Windows will "just work". Refs: #35653 Refs: #35646 Fixes: #35696 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or ben...

Open Graph Description: Experiment to see if collecting coverage for Windows will "just work". Refs: #35653 Refs: #35646 Fixes: #35696 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests ...

X Description: Experiment to see if collecting coverage for Windows will "just work". Refs: #35653 Refs: #35646 Fixes: #35696 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes...

Opengraph URL: https://github.com/nodejs/node/pull/35670

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bf420aed-787e-c8e4-0fa2-9a765040034a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA90:284E5C:1FDF7A5:2BC49EA:696ABA21
html-safe-nonce8cb8969f92ffeabdc2a23332f7bc1ee18ddd331f37c5049363dec19cbdb380ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTkwOjI4NEU1QzoxRkRGN0E1OjJCQzQ5RUE6Njk2QUJBMjEiLCJ2aXNpdG9yX2lkIjoiNDA5OTEzNzAwNTQ4MjA2NDQxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf5b9681e1b6e55e8b9c88bbb310df1fdf53359fd0745903e155ac6b742ec1804
hovercard-subject-tagpull_request:504584174
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35670/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5dd43b7df6c040ca1922be917b9ecf232be5d72ba589665afb26eb07302651ae/nodejs/node/pull/35670
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5dd43b7df6c040ca1922be917b9ecf232be5d72ba589665afb26eb07302651ae/nodejs/node/pull/35670
og:image:altExperiment to see if collecting coverage for Windows will "just work". Refs: #35653 Refs: #35646 Fixes: #35696 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebcoe
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35670#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35670
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35670
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35670
Reloadhttps://github.com/nodejs/node/pull/35670
Reloadhttps://github.com/nodejs/node/pull/35670
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35670
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35670
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35670#issue-comment-box
bcoehttps://github.com/bcoe
nodejs:masterhttps://github.com/nodejs/node/tree/master
bcoe:windows-coverage-actionhttps://github.com/bcoe/node-1/tree/windows-coverage-action
test: add windows and c++ coverage https://github.com/nodejs/node/pull/35670#top
bcoehttps://github.com/bcoe
nodejs:masterhttps://github.com/nodejs/node/tree/master
bcoe:windows-coverage-actionhttps://github.com/bcoe/node-1/tree/windows-coverage-action
Conversation 36 https://github.com/nodejs/node/pull/35670
Commits 12 https://github.com/nodejs/node/pull/35670/commits
Checks 0 https://github.com/nodejs/node/pull/35670/checks
Files changed https://github.com/nodejs/node/pull/35670/files
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 16, 2020https://github.com/nodejs/node/pull/35670#issue-722902364
Please reload this pagehttps://github.com/nodejs/node/pull/35670
#35653https://github.com/nodejs/node/pull/35653
#35646https://github.com/nodejs/node/issues/35646
#35696https://github.com/nodejs/node/issues/35696
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
Oct 16, 2020https://github.com/nodejs/node/pull/35670#event-3884545960
https://github.com/bcoe
bcoehttps://github.com/bcoe
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 16, 2020https://github.com/nodejs/node/pull/35670#event-3884742599
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 17, 2020https://github.com/nodejs/node/pull/35670#event-3889422148
test: add windows and C++ coveragehttps://github.com/nodejs/node/pull/35670/commits/df981ea3789d5a5c6db18c055e13833db64bd4f5
df981eahttps://github.com/nodejs/node/pull/35670/commits/df981ea3789d5a5c6db18c055e13833db64bd4f5
https://github.com/bcoe
bcoehttps://github.com/bcoe
force-pushedhttps://github.com/nodejs/node/compare/aaa926eb373cca37786abe1a5dd42e4318c9031e..df981ea3789d5a5c6db18c055e13833db64bd4f5
aaa926ehttps://github.com/nodejs/node/commit/aaa926eb373cca37786abe1a5dd42e4318c9031e
df981eahttps://github.com/nodejs/node/commit/df981ea3789d5a5c6db18c055e13833db64bd4f5
Compare https://github.com/nodejs/node/compare/aaa926eb373cca37786abe1a5dd42e4318c9031e..df981ea3789d5a5c6db18c055e13833db64bd4f5
October 17, 2020 16:13https://github.com/nodejs/node/pull/35670#event-3889425887
build: improve coverage configurationhttps://github.com/nodejs/node/pull/35670/commits/d91b81d87a6fa260451cda124d6c5d72b2e19acd
d91b81dhttps://github.com/nodejs/node/pull/35670/commits/d91b81d87a6fa260451cda124d6c5d72b2e19acd
https://github.com/nodejs
nodejshttps://github.com/nodejs
codecov-iohttps://github.com/codecov-io
Oct 18, 2020https://github.com/nodejs/node/pull/35670#event-3889878707
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 18, 2020 https://github.com/nodejs/node/pull/35670#ref-issue-723900856
Coverage report left in comments is "noisy" #35696 https://github.com/nodejs/node/issues/35696
October 17, 2020 22:04https://github.com/nodejs/node/pull/35670#commits-pushed-656160f
chore: attempt to build with gcovhttps://github.com/nodejs/node/pull/35670/commits/656160fd853d07c743d80599418cdc06fb204ae6
656160fhttps://github.com/nodejs/node/pull/35670/commits/656160fd853d07c743d80599418cdc06fb204ae6
build: ensure gcovr tool existshttps://github.com/nodejs/node/pull/35670/commits/9eac50be90c16e4a41df44bde9cc8494b682625f
9eac50bhttps://github.com/nodejs/node/pull/35670/commits/9eac50be90c16e4a41df44bde9cc8494b682625f
chore: tweak codecov.yml filehttps://github.com/nodejs/node/pull/35670/commits/f8692553858403d970d2a0227eab868d96c58739
f869255https://github.com/nodejs/node/pull/35670/commits/f8692553858403d970d2a0227eab868d96c58739
multi-line command had issueshttps://github.com/nodejs/node/pull/35670/commits/f5d62726dfb31584cf66c6856acbbbb0c34a34ea
f5d6272https://github.com/nodejs/node/pull/35670/commits/f5d62726dfb31584cf66c6856acbbbb0c34a34ea
https://github.com/nodejs
nodejshttps://github.com/nodejs
codecov-iohttps://github.com/codecov-io
Oct 18, 2020https://github.com/nodejs/node/pull/35670#event-3890276273
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 18, 2020 https://github.com/nodejs/node/pull/35670#pullrequestreview-511148236
View reviewed changes https://github.com/nodejs/node/pull/35670/files/f5d62726dfb31584cf66c6856acbbbb0c34a34ea
.github/workflows/coverage-linux.ymlhttps://github.com/nodejs/node/pull/35670/files/f5d62726dfb31584cf66c6856acbbbb0c34a34ea#diff-6cba3942dfc59a35064405a295bfacaa584593c3a444c5d7963b4cb60df93cfa
bcoehttps://github.com/bcoe
Oct 18, 2020https://github.com/nodejs/node/pull/35670#discussion_r507163290
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/35670
mhdawsonhttps://github.com/mhdawson
Oct 19, 2020https://github.com/nodejs/node/pull/35670#discussion_r508076552
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/35670
bcoehttps://github.com/bcoe
Oct 20, 2020https://github.com/nodejs/node/pull/35670#discussion_r508193994
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 18, 2020 https://github.com/nodejs/node/pull/35670#pullrequestreview-511148337
View reviewed changes https://github.com/nodejs/node/pull/35670/files/f5d62726dfb31584cf66c6856acbbbb0c34a34ea
codecov.ymlhttps://github.com/nodejs/node/pull/35670/files/f5d62726dfb31584cf66c6856acbbbb0c34a34ea#diff-3e878d9bdc47f29a0ab909a7db939acf08d2d2f1aaba81e6f897b32361fa40db
Please reload this pagehttps://github.com/nodejs/node/pull/35670
October 18, 2020 08:35https://github.com/nodejs/node/pull/35670#commits-pushed-40cb785
chore: delete more output fileshttps://github.com/nodejs/node/pull/35670/commits/40cb785bacbb862066dd2ae92a596fb628a67b39
40cb785https://github.com/nodejs/node/pull/35670/commits/40cb785bacbb862066dd2ae92a596fb628a67b39
build: run test-cov rather than test-cihttps://github.com/nodejs/node/pull/35670/commits/fc7c05c356531de604155bf7030721df058c0940
fc7c05chttps://github.com/nodejs/node/pull/35670/commits/fc7c05c356531de604155bf7030721df058c0940
https://github.com/bcoe
bcoehttps://github.com/bcoe
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Oct 18, 2020https://github.com/nodejs/node/pull/35670#event-3890580859
https://github.com/bcoe
bcoehttps://github.com/bcoe
Trotthttps://github.com/Trott
mhdawsonhttps://github.com/mhdawson
richardlauhttps://github.com/richardlau
watildehttps://github.com/watilde
mhdawsonhttps://github.com/mhdawson
October 18, 2020 19:41https://github.com/nodejs/node/pull/35670#event-3890582189
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 18, 2020https://github.com/nodejs/node/pull/35670#issuecomment-711412546
@richardlauhttps://github.com/richardlau
@Trotthttps://github.com/Trott
@watildehttps://github.com/watilde
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/bcoe
bcoehttps://github.com/bcoe
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 18, 2020https://github.com/nodejs/node/pull/35670#event-3890599797
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 18, 2020https://github.com/nodejs/node/pull/35670#event-3890602524
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 18, 2020 https://github.com/nodejs/node/pull/35670#pullrequestreview-511263425
View reviewed changes https://github.com/nodejs/node/pull/35670/files/fc7c05c356531de604155bf7030721df058c0940
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 19, 2020 https://github.com/nodejs/node/pull/35670#pullrequestreview-511600020
View reviewed changes https://github.com/nodejs/node/pull/35670/files/fc7c05c356531de604155bf7030721df058c0940
.github/workflows/coverage-windows.ymlhttps://github.com/nodejs/node/pull/35670/files/fc7c05c356531de604155bf7030721df058c0940#diff-29094741d50149aa772b3e577ad509116bad722ad2de85689b6cb2c01e806a46
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 19, 2020https://github.com/nodejs/node/pull/35670#issuecomment-712459113
https://user-images.githubusercontent.com/9373002/96514897-5e054300-1232-11eb-9955-a93c35bc1a69.png
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 19, 2020https://github.com/nodejs/node/pull/35670#issuecomment-712459674
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/bcoe
bcoehttps://github.com/bcoe
mhdawsonhttps://github.com/mhdawson
October 20, 2020 05:09https://github.com/nodejs/node/pull/35670#event-3896621645
https://github.com/bcoe
bcoehttps://github.com/bcoe
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 20, 2020https://github.com/nodejs/node/pull/35670#event-3896622312
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 20, 2020 https://github.com/nodejs/node/pull/35670#pullrequestreview-512507057
View reviewed changes https://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071
.github/workflows/coverage-linux.ymlhttps://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071#diff-6cba3942dfc59a35064405a295bfacaa584593c3a444c5d7963b4cb60df93cfa
Please reload this pagehttps://github.com/nodejs/node/pull/35670
.github/workflows/coverage-linux.ymlhttps://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071#diff-6cba3942dfc59a35064405a295bfacaa584593c3a444c5d7963b4cb60df93cfa
Please reload this pagehttps://github.com/nodejs/node/pull/35670
.github/workflows/coverage-windows.ymlhttps://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071#diff-29094741d50149aa772b3e577ad509116bad722ad2de85689b6cb2c01e806a46
Please reload this pagehttps://github.com/nodejs/node/pull/35670
.github/workflows/coverage-windows.ymlhttps://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071#diff-29094741d50149aa772b3e577ad509116bad722ad2de85689b6cb2c01e806a46
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 20, 2020 https://github.com/nodejs/node/pull/35670#pullrequestreview-512511506
View reviewed changes https://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Oct 20, 2020 https://github.com/nodejs/node/pull/35670#pullrequestreview-512603990
View reviewed changes https://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071
build: a couple more small tweaks to reportshttps://github.com/nodejs/node/pull/35670/commits/c646f6d3a7c5b5a1f5b50e1b38130ec6ac28290a
c646f6dhttps://github.com/nodejs/node/pull/35670/commits/c646f6d3a7c5b5a1f5b50e1b38130ec6ac28290a
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 20, 2020https://github.com/nodejs/node/pull/35670#issuecomment-712949655
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 20, 2020 https://github.com/nodejs/node/pull/35670#pullrequestreview-512884261
View reviewed changes https://github.com/nodejs/node/pull/35670/files/c646f6d3a7c5b5a1f5b50e1b38130ec6ac28290a
.nycrchttps://github.com/nodejs/node/pull/35670/files/c646f6d3a7c5b5a1f5b50e1b38130ec6ac28290a#diff-ed87f441d2b6161076f7bbcc6e7f683648406048cb96177e0390c4c9943a6462
bcoehttps://github.com/bcoe
Oct 20, 2020https://github.com/nodejs/node/pull/35670#discussion_r508635738
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/nodejs
nodejshttps://github.com/nodejs
codecov-iohttps://github.com/codecov-io
Oct 20, 2020https://github.com/nodejs/node/pull/35670#event-3899505457
https://github.com/targos
targoshttps://github.com/targos
Oct 20, 2020https://github.com/nodejs/node/pull/35670#issuecomment-712950888
@bcoehttps://github.com/bcoe
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 20, 2020https://github.com/nodejs/node/pull/35670#issuecomment-712953627
Please reload this pagehttps://github.com/nodejs/node/pull/35670
@thomasrockhuhttps://github.com/thomasrockhu
@bcoehttps://github.com/bcoe
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 20, 2020https://github.com/nodejs/node/pull/35670#issuecomment-713047491
@targoshttps://github.com/targos
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/targos
targoshttps://github.com/targos
Oct 20, 2020https://github.com/nodejs/node/pull/35670#issuecomment-713070544
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 21, 2020https://github.com/nodejs/node/pull/35670#issuecomment-713717948
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 21, 2020 https://github.com/nodejs/node/pull/35670#pullrequestreview-513966148
View reviewed changes https://github.com/nodejs/node/pull/35670/files/c646f6d3a7c5b5a1f5b50e1b38130ec6ac28290a
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/35670#pullrequestreview-513966148
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35670
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 21, 2020https://github.com/nodejs/node/pull/35670#issuecomment-713968150
https://ci.nodejs.org/job/node-test-pull-request/33792/https://ci.nodejs.org/job/node-test-pull-request/33792/
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 22, 2020https://github.com/nodejs/node/pull/35670#issuecomment-714186324
7657f62https://github.com/nodejs/node/commit/7657f62b1810b94acbe7db68089b608213b34749
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 22, 2020https://github.com/nodejs/node/pull/35670#event-3906789610
https://github.com/bcoe
bcoehttps://github.com/bcoe
October 22, 2020 02:46https://github.com/nodejs/node/pull/35670#event-3906789737
bcoehttps://github.com/bcoe
Oct 22, 2020 https://github.com/nodejs/node/pull/35670#ref-commit-7657f62
test: add windows and C++ coveragehttps://github.com/nodejs/node/commit/7657f62b1810b94acbe7db68089b608213b34749
7657f62https://github.com/nodejs/node/commit/7657f62b1810b94acbe7db68089b608213b34749
#35670https://github.com/nodejs/node/pull/35670
#35696https://github.com/nodejs/node/issues/35696
#35653https://github.com/nodejs/node/pull/35653
#35646https://github.com/nodejs/node/issues/35646
https://github.com/thomasrockhu
thomasrockhuhttps://github.com/thomasrockhu
Oct 22, 2020https://github.com/nodejs/node/pull/35670#issuecomment-714487758
Please reload this pagehttps://github.com/nodejs/node/pull/35670
@bcoehttps://github.com/bcoe
this tickethttps://community.codecov.io/t/github-api-forbidden-when-viewing-coverage-report-for-pr/2197/2
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Oct 22, 2020 https://github.com/nodejs/node/pull/35670#ref-issue-727537573
Total regression in codecov coverage report looks suspicious #35759 https://github.com/nodejs/node/issues/35759
targoshttps://github.com/targos
Nov 3, 2020 https://github.com/nodejs/node/pull/35670#ref-commit-11eca36
https://github.com/targos
test: add windows and C++ coveragehttps://github.com/nodejs/node/commit/11eca36e8337503f0dffe366cd0e7574b0a90732
11eca36https://github.com/nodejs/node/commit/11eca36e8337503f0dffe366cd0e7574b0a90732
#35670https://github.com/nodejs/node/pull/35670
#35696https://github.com/nodejs/node/issues/35696
#35653https://github.com/nodejs/node/pull/35653
#35646https://github.com/nodejs/node/issues/35646
https://github.com/targos
targoshttps://github.com/targos
Nov 3, 2020 https://github.com/nodejs/node/pull/35670#ref-pullrequest-735596211
v15.1.0 release proposal #35948 https://github.com/nodejs/node/pull/35948
BethGriggshttps://github.com/BethGriggs
Dec 8, 2020 https://github.com/nodejs/node/pull/35670#ref-commit-6badea2
https://github.com/BethGriggs
test: add windows and C++ coveragehttps://github.com/nodejs/node/commit/6badea2be50f807aabfa66e020fc6335f58f700e
6badea2https://github.com/nodejs/node/commit/6badea2be50f807aabfa66e020fc6335f58f700e
#35670https://github.com/nodejs/node/pull/35670
#35696https://github.com/nodejs/node/issues/35696
#35653https://github.com/nodejs/node/pull/35653
#35646https://github.com/nodejs/node/issues/35646
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/35670#ref-commit-d70c928
https://github.com/BethGriggs
test: add windows and C++ coveragehttps://github.com/nodejs/node/commit/d70c92845b310097f29ed00f4eac97e344f197ef
d70c928https://github.com/nodejs/node/commit/d70c92845b310097f29ed00f4eac97e344f197ef
#35670https://github.com/nodejs/node/pull/35670
#35696https://github.com/nodejs/node/issues/35696
#35653https://github.com/nodejs/node/pull/35653
#35646https://github.com/nodejs/node/issues/35646
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/35670#ref-pullrequest-761612838
v14.15.2 proposal #36476 https://github.com/nodejs/node/pull/36476
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
Jan 18, 2021https://github.com/nodejs/node/pull/35670#event-4219429627
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35670
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/35670/files/fc7c05c356531de604155bf7030721df058c0940
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/35670/files/15d170e8a2bc7a9d658076c984757860eaab1071
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/35670/files/c646f6d3a7c5b5a1f5b50e1b38130ec6ac28290a
https://github.com/watilde
watilde https://github.com/watilde
https://github.com/bnb
bnb https://github.com/bnb
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
meta https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta
Coverage report left in comments is "noisy" https://github.com/nodejs/node/issues/35696
Please reload this pagehttps://github.com/nodejs/node/pull/35670
https://github.com/bcoe
https://github.com/mhdawson
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com/thomasrockhu
https://github.com/bnb
https://github.com/Trott
https://github.com/gengjiawen
https://github.com/richardlau
https://github.com/aduh95
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.