René's URL Explorer Experiment


Title: fs: small rmdir() and validateRmOptions() cleanup by cjihrig · Pull Request #35567 · nodejs/node · GitHub

Open Graph Title: fs: small rmdir() and validateRmOptions() cleanup by cjihrig · Pull Request #35567 · nodejs/node

X Title: fs: small rmdir() and validateRmOptions() cleanup by cjihrig · Pull Request #35567 · nodejs/node

Description: The first commit simplifies some error handling in validateRmOptions(). The second commit removes two unnecessary assignments in rmdir(). Checklist make -j4 test (UNIX), or vcbuild test (Windows)...

Open Graph Description: The first commit simplifies some error handling in validateRmOptions(). The second commit removes two unnecessary assignments in rmdir(). Checklist make -j4 test (UNIX), or vcbuild test (Windows)...

X Description: The first commit simplifies some error handling in validateRmOptions(). The second commit removes two unnecessary assignments in rmdir(). Checklist make -j4 test (UNIX), or vcbuild test (Windows)...

Opengraph URL: https://github.com/nodejs/node/pull/35567

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2bd59b75-1d95-9c81-7482-41ef62372ff5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC31E:3C7D7F:23E5911:30B2620:696AD7E4
html-safe-nonceae6ce5664a0025afb01ccba2f20f545135de3cf52dcc52c1fbab54c3d407178b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzFFOjNDN0Q3RjoyM0U1OTExOjMwQjI2MjA6Njk2QUQ3RTQiLCJ2aXNpdG9yX2lkIjoiMzgwNTY5MzA4ODc4ODgzMDE4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdf3aec41c2ea1f5257471f6e67d903e79604583a54264deda891aff951e291d9
hovercard-subject-tagpull_request:500296038
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35567/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/baad90eef96ca595b007714e7e96d81897508a8caf5c58e36890f50f10ff407b/nodejs/node/pull/35567
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/baad90eef96ca595b007714e7e96d81897508a8caf5c58e36890f50f10ff407b/nodejs/node/pull/35567
og:image:altThe first commit simplifies some error handling in validateRmOptions(). The second commit removes two unnecessary assignments in rmdir(). Checklist make -j4 test (UNIX), or vcbuild test (Windows)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35567#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35567
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35567
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35567
Reloadhttps://github.com/nodejs/node/pull/35567
Reloadhttps://github.com/nodejs/node/pull/35567
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35567
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35567
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35567#issue-comment-box
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:err-handlehttps://github.com/cjihrig/node/tree/err-handle
fs: small rmdir() and validateRmOptions() cleanup https://github.com/nodejs/node/pull/35567#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:err-handlehttps://github.com/cjihrig/node/tree/err-handle
Conversation 3 https://github.com/nodejs/node/pull/35567
Commits 2 https://github.com/nodejs/node/pull/35567/commits
Checks 0 https://github.com/nodejs/node/pull/35567/checks
Files changed https://github.com/nodejs/node/pull/35567/files
Please reload this pagehttps://github.com/nodejs/node/pull/35567
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 9, 2020https://github.com/nodejs/node/pull/35567#issue-717792835
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35567
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Oct 9, 2020https://github.com/nodejs/node/pull/35567#event-3858085497
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
Oct 9, 2020 https://github.com/nodejs/node/pull/35567#pullrequestreview-505342437
View reviewed changes https://github.com/nodejs/node/pull/35567/files
https://github.com/gengjiawen
gengjiawenhttps://github.com/gengjiawen
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 9, 2020https://github.com/nodejs/node/pull/35567#event-3858301737
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 9, 2020https://github.com/nodejs/node/pull/35567#event-3858311657
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 9, 2020https://github.com/nodejs/node/pull/35567#issuecomment-705950964
https://ci.nodejs.org/job/node-test-pull-request/33482/https://ci.nodejs.org/job/node-test-pull-request/33482/
Please reload this pagehttps://github.com/nodejs/node/pull/35567
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 9, 2020 https://github.com/nodejs/node/pull/35567#pullrequestreview-505469595
View reviewed changes https://github.com/nodejs/node/pull/35567/files
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Oct 9, 2020 https://github.com/nodejs/node/pull/35567#pullrequestreview-505606658
View reviewed changes https://github.com/nodejs/node/pull/35567/files
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 9, 2020 https://github.com/nodejs/node/pull/35567#pullrequestreview-505664814
View reviewed changes https://github.com/nodejs/node/pull/35567/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 9, 2020https://github.com/nodejs/node/pull/35567#issuecomment-706261234
Please reload this pagehttps://github.com/nodejs/node/pull/35567
https://ci.nodejs.org/job/node-test-pull-request/33496/https://ci.nodejs.org/job/node-test-pull-request/33496/
Please reload this pagehttps://github.com/nodejs/node/pull/35567
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 9, 2020https://github.com/nodejs/node/pull/35567#event-3861282765
https://github.com/antsmartian
antsmartianhttps://github.com/antsmartian
Oct 10, 2020 https://github.com/nodejs/node/pull/35567#pullrequestreview-506089701
View reviewed changes https://github.com/nodejs/node/pull/35567/files
cjihrighttps://github.com/cjihrig
October 10, 2020 21:57https://github.com/nodejs/node/pull/35567#commits-pushed-94b0908
https://github.com/cjihrig
fs: simplify validateRmOptions() error handlinghttps://github.com/nodejs/node/pull/35567/commits/94b090850389621172292e9c946388ca080e1ccb
94b0908https://github.com/nodejs/node/pull/35567/commits/94b090850389621172292e9c946388ca080e1ccb
nodejs#35567https://github.com/nodejs/node/pull/35567
https://github.com/cjihrig
fs: remove extraneous assignments in rmdir()https://github.com/nodejs/node/pull/35567/commits/91e0d9bc30948dc58f8675a10a85843e0de65650
91e0d9bhttps://github.com/nodejs/node/pull/35567/commits/91e0d9bc30948dc58f8675a10a85843e0de65650
nodejs#35567https://github.com/nodejs/node/pull/35567
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/a4093dcee23e2260a8c338f5696a58dde93b9496..91e0d9bc30948dc58f8675a10a85843e0de65650
a4093dchttps://github.com/nodejs/node/commit/a4093dcee23e2260a8c338f5696a58dde93b9496
91e0d9bhttps://github.com/nodejs/node/commit/91e0d9bc30948dc58f8675a10a85843e0de65650
Compare https://github.com/nodejs/node/compare/a4093dcee23e2260a8c338f5696a58dde93b9496..91e0d9bc30948dc58f8675a10a85843e0de65650
October 11, 2020 02:02https://github.com/nodejs/node/pull/35567#event-3863264533
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
91e0d9bhttps://github.com/nodejs/node/commit/91e0d9bc30948dc58f8675a10a85843e0de65650
Oct 11, 2020https://github.com/nodejs/node/pull/35567#event-3863264784
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
October 11, 2020 02:03https://github.com/nodejs/node/pull/35567#event-3863264814
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 11, 2020https://github.com/nodejs/node/pull/35567#issuecomment-706638032
278d38f...91e0d9bhttps://github.com/nodejs/node/compare/278d38f4cf3d2821984660b4de73f8d414db17c7...91e0d9bc30948dc58f8675a10a85843e0de65650
Please reload this pagehttps://github.com/nodejs/node/pull/35567
MylesBorinshttps://github.com/MylesBorins
Oct 14, 2020 https://github.com/nodejs/node/pull/35567#ref-commit-1fadcf2
https://github.com/cjihrig
https://github.com/MylesBorins
fs: simplify validateRmOptions() error handlinghttps://github.com/nodejs/node/commit/1fadcf2163b24b9d3182bde244cf8e1d4269bcd9
1fadcf2https://github.com/nodejs/node/commit/1fadcf2163b24b9d3182bde244cf8e1d4269bcd9
#35567https://github.com/nodejs/node/pull/35567
MylesBorinshttps://github.com/MylesBorins
Oct 14, 2020 https://github.com/nodejs/node/pull/35567#ref-commit-1ad9aca
https://github.com/cjihrig
https://github.com/MylesBorins
fs: remove extraneous assignments in rmdir()https://github.com/nodejs/node/commit/1ad9aca19472f0cf3818e96237605e30335e34ed
1ad9acahttps://github.com/nodejs/node/commit/1ad9aca19472f0cf3818e96237605e30335e34ed
#35567https://github.com/nodejs/node/pull/35567
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 14, 2020 https://github.com/nodejs/node/pull/35567#ref-pullrequest-721778951
v14.14.0 proposal #35648 https://github.com/nodejs/node/pull/35648
joesepihttps://github.com/joesepi
Jan 8, 2021 https://github.com/nodejs/node/pull/35567#ref-commit-e41b7fe
https://github.com/cjihrig
https://github.com/joesepi
fs: simplify validateRmOptions() error handlinghttps://github.com/joesepi/node/commit/e41b7fe86151eda028fe6d948db58a850c705b9b
e41b7fehttps://github.com/joesepi/node/commit/e41b7fe86151eda028fe6d948db58a850c705b9b
nodejs#35567https://github.com/nodejs/node/pull/35567
joesepihttps://github.com/joesepi
Jan 8, 2021 https://github.com/nodejs/node/pull/35567#ref-commit-a989359
https://github.com/cjihrig
https://github.com/joesepi
fs: remove extraneous assignments in rmdir()https://github.com/joesepi/node/commit/a9893598fb7a7fba6be600707550a0327e569606
a989359https://github.com/joesepi/node/commit/a9893598fb7a7fba6be600707550a0327e569606
nodejs#35567https://github.com/nodejs/node/pull/35567
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35567
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/35567/files/a4093dcee23e2260a8c338f5696a58dde93b9496
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/35567/files/a4093dcee23e2260a8c338f5696a58dde93b9496
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/35567/files/a4093dcee23e2260a8c338f5696a58dde93b9496
https://github.com/gengjiawen
gengjiawen https://github.com/gengjiawen
https://github.com/nodejs/node/pull/35567/files/a4093dcee23e2260a8c338f5696a58dde93b9496
https://github.com/antsmartian
antsmartian https://github.com/antsmartian
https://github.com/nodejs/node/pull/35567/files/a4093dcee23e2260a8c338f5696a58dde93b9496
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Please reload this pagehttps://github.com/nodejs/node/pull/35567
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/antsmartian
https://github.com/benjamingr
https://github.com/lpinca
https://github.com/gengjiawen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.