René's URL Explorer Experiment


Title: fs: rimraf should not recurse on failure by bcoe · Pull Request #35566 · nodejs/node · GitHub

Open Graph Title: fs: rimraf should not recurse on failure by bcoe · Pull Request #35566 · nodejs/node

X Title: fs: rimraf should not recurse on failure by bcoe · Pull Request #35566 · nodejs/node

Description: When an error occurs while running rimrafSync, we pass the original options through to the call to rmdirSync, this in turn spawns another call to rimraf, rather than simply removing the file. Fixes...

Open Graph Description: When an error occurs while running rimrafSync, we pass the original options through to the call to rmdirSync, this in turn spawns another call to rimraf, rather than simply removing the file. Fixes...

X Description: When an error occurs while running rimrafSync, we pass the original options through to the call to rmdirSync, this in turn spawns another call to rimraf, rather than simply removing the file. Fixes...

Opengraph URL: https://github.com/nodejs/node/pull/35566

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b9834c87-a378-1967-abed-9e6165540f79
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD26A:2C2C4D:CFAB92:11F9304:696A8BEE
html-safe-nonce15a43fbb724c721290fbfb0df54d30882a4c25671b1a53a68f060a759cf6e464
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjZBOjJDMkM0RDpDRkFCOTI6MTFGOTMwNDo2OTZBOEJFRSIsInZpc2l0b3JfaWQiOiIzMDQ0MjUyMjYxMTY0OTQ0MzY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6ac2ebd028eee1b3677ac41edc668ddc8c686cc8e45a2e3670b1af9532f2a06f
hovercard-subject-tagpull_request:500265133
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35566/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bed674a0d27631f99ecd5c61dea2a2c38ca9e7fdda90384e99098ab937c28026/nodejs/node/pull/35566
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bed674a0d27631f99ecd5c61dea2a2c38ca9e7fdda90384e99098ab937c28026/nodejs/node/pull/35566
og:image:altWhen an error occurs while running rimrafSync, we pass the original options through to the call to rmdirSync, this in turn spawns another call to rimraf, rather than simply removing the file. Fixes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebcoe
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35566#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35566
Reloadhttps://github.com/nodejs/node/pull/35566
Reloadhttps://github.com/nodejs/node/pull/35566
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35566
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35566
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35566#issue-comment-box
bcoehttps://github.com/bcoe
nodejs:masterhttps://github.com/nodejs/node/tree/master
bcoe:rimraf-fixhttps://github.com/bcoe/node-1/tree/rimraf-fix
fs: rimraf should not recurse on failure https://github.com/nodejs/node/pull/35566#top
bcoehttps://github.com/bcoe
nodejs:masterhttps://github.com/nodejs/node/tree/master
bcoe:rimraf-fixhttps://github.com/bcoe/node-1/tree/rimraf-fix
Conversation 17 https://github.com/nodejs/node/pull/35566
Commits 5 https://github.com/nodejs/node/pull/35566/commits
Checks 0 https://github.com/nodejs/node/pull/35566/checks
Files changed https://github.com/nodejs/node/pull/35566/files
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 9, 2020https://github.com/nodejs/node/pull/35566#issue-717756158
Please reload this pagehttps://github.com/nodejs/node/pull/35566
#34266https://github.com/nodejs/node/issues/34266
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.com/bcoe
bcoehttps://github.com/bcoe
cjihrighttps://github.com/cjihrig
October 9, 2020 00:21https://github.com/nodejs/node/pull/35566#event-3857895522
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Oct 9, 2020https://github.com/nodejs/node/pull/35566#event-3857895625
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 9, 2020https://github.com/nodejs/node/pull/35566#issuecomment-705895666
@iansuhttps://github.com/iansu
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.com/iansu
iansuhttps://github.com/iansu
Oct 9, 2020https://github.com/nodejs/node/pull/35566#issuecomment-705899625
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 9, 2020 https://github.com/nodejs/node/pull/35566#pullrequestreview-505277602
View reviewed changes https://github.com/nodejs/node/pull/35566/files
lib/internal/fs/rimraf.jshttps://github.com/nodejs/node/pull/35566/files#diff-102db77122b5d23f42d497abfc7d626e60723d911caa6293fd16a5ec92b0d653
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 9, 2020https://github.com/nodejs/node/pull/35566#issuecomment-705900575
@iansuhttps://github.com/iansu
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 9, 2020 https://github.com/nodejs/node/pull/35566#pullrequestreview-505665627
View reviewed changes https://github.com/nodejs/node/pull/35566/files
https://github.com/bcoe
bcoehttps://github.com/bcoe
Trotthttps://github.com/Trott
cjihrighttps://github.com/cjihrig
October 11, 2020 18:46https://github.com/nodejs/node/pull/35566#event-3863972909
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 11, 2020https://github.com/nodejs/node/pull/35566#issuecomment-706750012
@Trotthttps://github.com/Trott
@cjihrighttps://github.com/cjihrig
@iansuhttps://github.com/iansu
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.com/iansu
iansuhttps://github.com/iansu
Oct 11, 2020 https://github.com/nodejs/node/pull/35566#pullrequestreview-506206487
View reviewed changes https://github.com/nodejs/node/pull/35566/files
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/bcoe
bcoehttps://github.com/bcoe
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 11, 2020https://github.com/nodejs/node/pull/35566#event-3864027328
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/bcoe
bcoehttps://github.com/bcoe
force-pushedhttps://github.com/nodejs/node/compare/8f01850a21362a9ab4b6ff5ee72eaa5debe23219..6a8e41933487fa9737265c420e49d0675ced03fe
8f01850https://github.com/nodejs/node/commit/8f01850a21362a9ab4b6ff5ee72eaa5debe23219
6a8e419https://github.com/nodejs/node/commit/6a8e41933487fa9737265c420e49d0675ced03fe
Compare https://github.com/nodejs/node/compare/8f01850a21362a9ab4b6ff5ee72eaa5debe23219..6a8e41933487fa9737265c420e49d0675ced03fe
October 12, 2020 16:17https://github.com/nodejs/node/pull/35566#event-3867380855
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
October 13, 2020 07:59https://github.com/nodejs/node/pull/35566#commits-pushed-ab8731c
fs: rimraf should not recurse on failurehttps://github.com/nodejs/node/pull/35566/commits/ab8731c568fd6fe548fe33d1e3c8322932be76aa
ab8731chttps://github.com/nodejs/node/pull/35566/commits/ab8731c568fd6fe548fe33d1e3c8322932be76aa
chore: run the linterhttps://github.com/nodejs/node/pull/35566/commits/c1f8562a5b5a8b2ce19ea49583e8bbf30661f6c4
c1f8562https://github.com/nodejs/node/pull/35566/commits/c1f8562a5b5a8b2ce19ea49583e8bbf30661f6c4
chore: code reviewhttps://github.com/nodejs/node/pull/35566/commits/3dfc53f79e4677398be4757c42191450977b34e1
3dfc53fhttps://github.com/nodejs/node/pull/35566/commits/3dfc53f79e4677398be4757c42191450977b34e1
test: added a testhttps://github.com/nodejs/node/pull/35566/commits/3ef437bf994cbdc24a0a3379241eae8cb48b8342
3ef437bhttps://github.com/nodejs/node/pull/35566/commits/3ef437bf994cbdc24a0a3379241eae8cb48b8342
test: rimraf fix seems to have fixed known issuehttps://github.com/nodejs/node/pull/35566/commits/0c7e55d80cfaaaf2125a1423671a8319511e4e91
0c7e55dhttps://github.com/nodejs/node/pull/35566/commits/0c7e55d80cfaaaf2125a1423671a8319511e4e91
https://github.com/bcoe
bcoehttps://github.com/bcoe
force-pushedhttps://github.com/nodejs/node/compare/ae2f9395d3de99ed330e0e4461312d898ebfd027..0c7e55d80cfaaaf2125a1423671a8319511e4e91
ae2f939https://github.com/nodejs/node/commit/ae2f9395d3de99ed330e0e4461312d898ebfd027
0c7e55dhttps://github.com/nodejs/node/commit/0c7e55d80cfaaaf2125a1423671a8319511e4e91
Compare https://github.com/nodejs/node/compare/ae2f9395d3de99ed330e0e4461312d898ebfd027..0c7e55d80cfaaaf2125a1423671a8319511e4e91
October 13, 2020 14:59https://github.com/nodejs/node/pull/35566#event-3871857724
https://github.com/bcoe
bcoehttps://github.com/bcoe
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 13, 2020https://github.com/nodejs/node/pull/35566#event-3871863053
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 13, 2020 https://github.com/nodejs/node/pull/35566#ref-issue-599573592
Release plan - v14.x Maintenance LTS nodejs/Release#567 https://github.com/nodejs/Release/issues/567
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 13, 2020https://github.com/nodejs/node/pull/35566#issuecomment-707937544
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://ci.nodejs.org/job/node-test-pull-request/33594/https://ci.nodejs.org/job/node-test-pull-request/33594/
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 13, 2020 https://github.com/nodejs/node/pull/35566#pullrequestreview-507741044
View reviewed changes https://github.com/nodejs/node/pull/35566/files/0c7e55d80cfaaaf2125a1423671a8319511e4e91
https://github.com/bcoe
bcoehttps://github.com/bcoe
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 13, 2020https://github.com/nodejs/node/pull/35566#event-3873410004
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 13, 2020https://github.com/nodejs/node/pull/35566#event-3873449137
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/bcoe
bcoehttps://github.com/bcoe
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Oct 13, 2020https://github.com/nodejs/node/pull/35566#event-3873617314
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 13, 2020https://github.com/nodejs/node/pull/35566#event-3873653073
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/bcoe
bcoehttps://github.com/bcoe
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Oct 13, 2020https://github.com/nodejs/node/pull/35566#event-3873760970
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 13, 2020https://github.com/nodejs/node/pull/35566#issuecomment-708035392
7d66722https://github.com/nodejs/node/commit/7d6672226b93f49d823cd58359f4b2331ca712f5
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 13, 2020https://github.com/nodejs/node/pull/35566#event-3873778155
bcoehttps://github.com/bcoe
Oct 13, 2020 https://github.com/nodejs/node/pull/35566#ref-commit-7d66722
fs: rimraf should not recurse on failurehttps://github.com/nodejs/node/commit/7d6672226b93f49d823cd58359f4b2331ca712f5
7d66722https://github.com/nodejs/node/commit/7d6672226b93f49d823cd58359f4b2331ca712f5
#35566https://github.com/nodejs/node/pull/35566
https://github.com/bcoe
bcoehttps://github.com/bcoe
October 13, 2020 22:06https://github.com/nodejs/node/pull/35566#event-3873778406
https://github.com/bcoe
bcoehttps://github.com/bcoe
Oct 13, 2020 https://github.com/nodejs/node/pull/35566#ref-issue-653663160
fs.open() can keep the event loop open in some cases #34266 https://github.com/nodejs/node/issues/34266
MylesBorinshttps://github.com/MylesBorins
Oct 14, 2020 https://github.com/nodejs/node/pull/35566#ref-commit-a3c7f8e
https://github.com/MylesBorins
fs: rimraf should not recurse on failurehttps://github.com/nodejs/node/commit/a3c7f8e5766fef01a30711ddcc4d5f1f7bb2e8c2
a3c7f8ehttps://github.com/nodejs/node/commit/a3c7f8e5766fef01a30711ddcc4d5f1f7bb2e8c2
#35566https://github.com/nodejs/node/pull/35566
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 14, 2020 https://github.com/nodejs/node/pull/35566#ref-pullrequest-721778951
v14.14.0 proposal #35648 https://github.com/nodejs/node/pull/35648
joesepihttps://github.com/joesepi
Jan 8, 2021 https://github.com/nodejs/node/pull/35566#ref-commit-5f3b5bd
https://github.com/joesepi
fs: rimraf should not recurse on failurehttps://github.com/joesepi/node/commit/5f3b5bda4861c023b0aa52929e16832a55180f9d
5f3b5bdhttps://github.com/joesepi/node/commit/5f3b5bda4861c023b0aa52929e16832a55180f9d
nodejs#35566https://github.com/nodejs/node/pull/35566
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35566
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/35566/files/0c7e55d80cfaaaf2125a1423671a8319511e4e91
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/iansu
iansu https://github.com/iansu
https://github.com/nodejs/node/pull/35566/files/8f01850a21362a9ab4b6ff5ee72eaa5debe23219
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
fs.open() can keep the event loop open in some cases https://github.com/nodejs/node/issues/34266
Please reload this pagehttps://github.com/nodejs/node/pull/35566
https://github.com/bcoe
https://github.com/iansu
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.