René's URL Explorer Experiment


Title: test: do not use the same EventEmitter instance by lpinca · Pull Request #35560 · nodejs/node · GitHub

Open Graph Title: test: do not use the same EventEmitter instance by lpinca · Pull Request #35560 · nodejs/node

X Title: test: do not use the same EventEmitter instance by lpinca · Pull Request #35560 · nodejs/node

Description: Prevent multiple listeners for the 'error' event to be added to the same EventEmitter instance. Refs: #35557 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests an...

Open Graph Description: Prevent multiple listeners for the 'error' event to be added to the same EventEmitter instance. Refs: #35557 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...

X Description: Prevent multiple listeners for the 'error' event to be added to the same EventEmitter instance. Refs: #35557 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) ...

Opengraph URL: https://github.com/nodejs/node/pull/35560

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0c57a988-63c8-29b4-6ba9-750932980c96
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCDF2:30E6E5:1607A7C:1E2C7E0:696AAA5E
html-safe-noncea11c82029bdc73c7232972482465e3005ffe0d19bb47771fd817ba1820bc354c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREYyOjMwRTZFNToxNjA3QTdDOjFFMkM3RTA6Njk2QUFBNUUiLCJ2aXNpdG9yX2lkIjoiNDQyMjg1MTg2ODg1NzM3OTQyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb20a9515d6276d75269f5dcd4ab2cd43457c6da1a180f3473386e0f9b7c3cc6b
hovercard-subject-tagpull_request:500125012
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35560/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/21c600b2b03eb3cc4caad944140f01bb6f154a321568feb82ad51829a0a9f237/nodejs/node/pull/35560
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/21c600b2b03eb3cc4caad944140f01bb6f154a321568feb82ad51829a0a9f237/nodejs/node/pull/35560
og:image:altPrevent multiple listeners for the 'error' event to be added to the same EventEmitter instance. Refs: #35557 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
None3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd9a979046e6382bd084e2bd873bf65f797125ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35560#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35560
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35560
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35560
Reloadhttps://github.com/nodejs/node/pull/35560
Reloadhttps://github.com/nodejs/node/pull/35560
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35560
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35560
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35560#issue-comment-box
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:use/different-ee-instancehttps://github.com/lpinca/node/tree/use/different-ee-instance
test: do not use the same EventEmitter instance https://github.com/nodejs/node/pull/35560#top
lpincahttps://github.com/lpinca
nodejs:masterhttps://github.com/nodejs/node/tree/master
lpinca:use/different-ee-instancehttps://github.com/lpinca/node/tree/use/different-ee-instance
Conversation 3 https://github.com/nodejs/node/pull/35560
Commits 1 https://github.com/nodejs/node/pull/35560/commits
Checks 0 https://github.com/nodejs/node/pull/35560/checks
Files changed https://github.com/nodejs/node/pull/35560/files
Please reload this pagehttps://github.com/nodejs/node/pull/35560
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 8, 2020https://github.com/nodejs/node/pull/35560#issue-717588703
#35557 (comment)https://github.com/nodejs/node/pull/35557#issuecomment-705476640
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35560
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 8, 2020https://github.com/nodejs/node/pull/35560#event-3856936436
https://github.com/lpinca
lpincahttps://github.com/lpinca
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Oct 8, 2020https://github.com/nodejs/node/pull/35560#event-3856937421
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 8, 2020 https://github.com/nodejs/node/pull/35560#pullrequestreview-505186593
View reviewed changes https://github.com/nodejs/node/pull/35560/files
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Oct 8, 2020 https://github.com/nodejs/node/pull/35560#pullrequestreview-505188460
View reviewed changes https://github.com/nodejs/node/pull/35560/files
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 8, 2020 https://github.com/nodejs/node/pull/35560#pullrequestreview-505198571
View reviewed changes https://github.com/nodejs/node/pull/35560/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/35560#pullrequestreview-505198571
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/35560
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 8, 2020 https://github.com/nodejs/node/pull/35560#pullrequestreview-505229748
View reviewed changes https://github.com/nodejs/node/pull/35560/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 9, 2020https://github.com/nodejs/node/pull/35560#event-3858443876
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 9, 2020https://github.com/nodejs/node/pull/35560#event-3858476401
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 9, 2020https://github.com/nodejs/node/pull/35560#issuecomment-705972588
https://ci.nodejs.org/job/node-test-pull-request/33483/https://ci.nodejs.org/job/node-test-pull-request/33483/
Please reload this pagehttps://github.com/nodejs/node/pull/35560
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 9, 2020 https://github.com/nodejs/node/pull/35560#pullrequestreview-505595958
View reviewed changes https://github.com/nodejs/node/pull/35560/files
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 10, 2020 https://github.com/nodejs/node/pull/35560#pullrequestreview-506096367
View reviewed changes https://github.com/nodejs/node/pull/35560/files
https://github.com/lpinca
test: do not use the same EventEmitter instancehttps://github.com/nodejs/node/pull/35560/commits/c739f371c316c066abad935cc4bfbe00990d38b3
c739f37https://github.com/nodejs/node/pull/35560/commits/c739f371c316c066abad935cc4bfbe00990d38b3
nodejs#35560https://github.com/nodejs/node/pull/35560
nodejs#35557 (comment)https://github.com/nodejs/node/pull/35557#issuecomment-705476640
https://github.com/lpinca
lpincahttps://github.com/lpinca
force-pushedhttps://github.com/nodejs/node/compare/24a6b739c12d8ef61887238110cedc1dfeaa8f69..c739f371c316c066abad935cc4bfbe00990d38b3
24a6b73https://github.com/nodejs/node/commit/24a6b739c12d8ef61887238110cedc1dfeaa8f69
c739f37https://github.com/nodejs/node/commit/c739f371c316c066abad935cc4bfbe00990d38b3
Compare https://github.com/nodejs/node/compare/24a6b739c12d8ef61887238110cedc1dfeaa8f69..c739f371c316c066abad935cc4bfbe00990d38b3
October 12, 2020 17:08https://github.com/nodejs/node/pull/35560#event-3867563182
https://github.com/lpinca
lpincahttps://github.com/lpinca
c739f37https://github.com/nodejs/node/commit/c739f371c316c066abad935cc4bfbe00990d38b3
Oct 12, 2020https://github.com/nodejs/node/pull/35560#event-3867564443
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 12, 2020https://github.com/nodejs/node/pull/35560#issuecomment-707241251
c739f37https://github.com/nodejs/node/commit/c739f371c316c066abad935cc4bfbe00990d38b3
Please reload this pagehttps://github.com/nodejs/node/pull/35560
https://github.com/lpinca
lpincahttps://github.com/lpinca
October 12, 2020 17:08https://github.com/nodejs/node/pull/35560#event-3867565182
MylesBorinshttps://github.com/MylesBorins
Oct 14, 2020 https://github.com/nodejs/node/pull/35560#ref-commit-4a2ba43
https://github.com/lpinca
https://github.com/MylesBorins
test: do not use the same EventEmitter instancehttps://github.com/nodejs/node/commit/4a2ba4384bc7d37327fae98a645386033cffee1c
4a2ba43https://github.com/nodejs/node/commit/4a2ba4384bc7d37327fae98a645386033cffee1c
#35560https://github.com/nodejs/node/pull/35560
#35557 (comment)https://github.com/nodejs/node/pull/35557#issuecomment-705476640
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 14, 2020 https://github.com/nodejs/node/pull/35560#ref-pullrequest-721778951
v14.14.0 proposal #35648 https://github.com/nodejs/node/pull/35648
joesepihttps://github.com/joesepi
Jan 8, 2021 https://github.com/nodejs/node/pull/35560#ref-commit-abd8cbf
https://github.com/lpinca
https://github.com/joesepi
test: do not use the same EventEmitter instancehttps://github.com/joesepi/node/commit/abd8cbfd28c9fb933636d35fd8230f7725c2c3f6
abd8cbfhttps://github.com/joesepi/node/commit/abd8cbfd28c9fb933636d35fd8230f7725c2c3f6
nodejs#35560https://github.com/nodejs/node/pull/35560
nodejs#35557 (comment)https://github.com/nodejs/node/pull/35557#issuecomment-705476640
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35560
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/35560/files/24a6b739c12d8ef61887238110cedc1dfeaa8f69
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/35560/files/24a6b739c12d8ef61887238110cedc1dfeaa8f69
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/35560/files/24a6b739c12d8ef61887238110cedc1dfeaa8f69
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/35560/files/24a6b739c12d8ef61887238110cedc1dfeaa8f69
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/35560/files/24a6b739c12d8ef61887238110cedc1dfeaa8f69
https://github.com/Flarna
Flarna https://github.com/Flarna
https://github.com/nodejs/node/pull/35560/files/24a6b739c12d8ef61887238110cedc1dfeaa8f69
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/35560
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/ronag
https://github.com/mhdawson
https://github.com/Flarna
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.