René's URL Explorer Experiment


Title: doc: document Buffer.concat may use internal pool by puzpuzpuz · Pull Request #35541 · nodejs/node · GitHub

Open Graph Title: doc: document Buffer.concat may use internal pool by puzpuzpuz · Pull Request #35541 · nodejs/node

X Title: doc: document Buffer.concat may use internal pool by puzpuzpuz · Pull Request #35541 · nodejs/node

Description: Refs: #32703 The documentation was silent about the fact that Buffer.concat() uses Buffer.allocaUnsafe() and, thus, may return pooled buffers. This PR fixes that. Checklist make -j4 test (UNIX),...

Open Graph Description: Refs: #32703 The documentation was silent about the fact that Buffer.concat() uses Buffer.allocaUnsafe() and, thus, may return pooled buffers. This PR fixes that. Checklist make -j4 test (UNIX),...

X Description: Refs: #32703 The documentation was silent about the fact that Buffer.concat() uses Buffer.allocaUnsafe() and, thus, may return pooled buffers. This PR fixes that. Checklist make -j4 test (UNIX),...

Opengraph URL: https://github.com/nodejs/node/pull/35541

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c0c9b8aa-f4c7-76d7-26b3-b745e6b7ce5a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE54C:FC316:11BA2BD:17B1ED3:696AD2D1
html-safe-nonce075e1383c7826d9063fab2ec001b3b370abd8c3f3cb709222b20a2e12c41bae3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTRDOkZDMzE2OjExQkEyQkQ6MTdCMUVEMzo2OTZBRDJEMSIsInZpc2l0b3JfaWQiOiIzNzY1MTk5NTIyOTQxODE3NTU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7aaa84b41013455552a8ff460e484c38dc7a2eb54f77267131bdbd16d1fdf6f2
hovercard-subject-tagpull_request:499281925
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35541/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e3d71e4325b52defa8d0f87b04e02c8f95704269e0a7fce59439d0727b1726d5/nodejs/node/pull/35541
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e3d71e4325b52defa8d0f87b04e02c8f95704269e0a7fce59439d0727b1726d5/nodejs/node/pull/35541
og:image:altRefs: #32703 The documentation was silent about the fact that Buffer.concat() uses Buffer.allocaUnsafe() and, thus, may return pooled buffers. This PR fixes that. Checklist make -j4 test (UNIX),...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepuzpuzpuz
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35541#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35541
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35541
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35541
Reloadhttps://github.com/nodejs/node/pull/35541
Reloadhttps://github.com/nodejs/node/pull/35541
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35541
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35541
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35541#issue-comment-box
puzpuzpuzhttps://github.com/puzpuzpuz
nodejs:masterhttps://github.com/nodejs/node/tree/master
puzpuzpuz:documentation/improve-buffer-pool-dochttps://github.com/puzpuzpuz/node/tree/documentation/improve-buffer-pool-doc
doc: document Buffer.concat may use internal pool https://github.com/nodejs/node/pull/35541#top
puzpuzpuzhttps://github.com/puzpuzpuz
nodejs:masterhttps://github.com/nodejs/node/tree/master
puzpuzpuz:documentation/improve-buffer-pool-dochttps://github.com/puzpuzpuz/node/tree/documentation/improve-buffer-pool-doc
Conversation 11 https://github.com/nodejs/node/pull/35541
Commits 1 https://github.com/nodejs/node/pull/35541/commits
Checks 0 https://github.com/nodejs/node/pull/35541/checks
Files changed https://github.com/nodejs/node/pull/35541/files
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Oct 7, 2020https://github.com/nodejs/node/pull/35541#issue-716568067
#32703https://github.com/nodejs/node/pull/32703
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/puzpuzpuz
doc: document Buffer.concat may use internal poolhttps://github.com/nodejs/node/pull/35541/commits/4dcac6bbbae16da7816aec98eabb78eb226162ef
4dcac6bhttps://github.com/nodejs/node/pull/35541/commits/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Oct 7, 2020https://github.com/nodejs/node/pull/35541#event-3850772668
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 7, 2020 https://github.com/nodejs/node/pull/35541#pullrequestreview-504104885
View reviewed changes https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 7, 2020 https://github.com/nodejs/node/pull/35541#pullrequestreview-504138618
View reviewed changes https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/HarshithaKP
HarshithaKPhttps://github.com/HarshithaKP
Oct 8, 2020 https://github.com/nodejs/node/pull/35541#pullrequestreview-504474317
View reviewed changes https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/Trott
Trotthttps://github.com/Trott
Oct 8, 2020 https://github.com/nodejs/node/pull/35541#pullrequestreview-504709466
View reviewed changes https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 13, 2020https://github.com/nodejs/node/pull/35541#event-3870826841
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 13, 2020https://github.com/nodejs/node/pull/35541#event-3870851713
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 13, 2020https://github.com/nodejs/node/pull/35541#issuecomment-707685985
https://ci.nodejs.org/job/node-test-pull-request/33572/https://ci.nodejs.org/job/node-test-pull-request/33572/
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 13, 2020https://github.com/nodejs/node/pull/35541#issuecomment-707694299
Please reload this pagehttps://github.com/nodejs/node/pull/35541
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 13, 2020https://github.com/nodejs/node/pull/35541#issuecomment-707695933
@ronaghttps://github.com/ronag
#32759https://github.com/nodejs/node/pull/32759
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 13, 2020https://github.com/nodejs/node/pull/35541#issuecomment-707701243
@ronaghttps://github.com/ronag
#32759https://github.com/nodejs/node/pull/32759
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Oct 13, 2020https://github.com/nodejs/node/pull/35541#issuecomment-707724356
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 13, 2020https://github.com/nodejs/node/pull/35541#issuecomment-707729861
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 13, 2020 https://github.com/nodejs/node/pull/35541#pullrequestreview-507421136
View reviewed changes https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 13, 2020https://github.com/nodejs/node/pull/35541#issuecomment-707825829
https://ci.nodejs.org/job/node-test-pull-request/33581/https://ci.nodejs.org/job/node-test-pull-request/33581/
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 14, 2020https://github.com/nodejs/node/pull/35541#issuecomment-708217720
https://ci.nodejs.org/job/node-test-pull-request/33608/https://ci.nodejs.org/job/node-test-pull-request/33608/
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 14, 2020https://github.com/nodejs/node/pull/35541#issuecomment-708281326
https://ci.nodejs.org/job/node-test-pull-request/33610/https://ci.nodejs.org/job/node-test-pull-request/33610/
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 14, 2020https://github.com/nodejs/node/pull/35541#issuecomment-708444569
https://ci.nodejs.org/job/node-test-pull-request/33621/https://ci.nodejs.org/job/node-test-pull-request/33621/
Please reload this pagehttps://github.com/nodejs/node/pull/35541
puzpuzpuzhttps://github.com/puzpuzpuz
Oct 14, 2020 https://github.com/nodejs/node/pull/35541#ref-commit-ef1645e
https://github.com/puzpuzpuz
doc: document Buffer.concat may use internal poolhttps://github.com/nodejs/node/commit/ef1645e2b3f609492af7f25e4468db9b7801f4aa
ef1645ehttps://github.com/nodejs/node/commit/ef1645e2b3f609492af7f25e4468db9b7801f4aa
#35541https://github.com/nodejs/node/pull/35541
#32703https://github.com/nodejs/node/pull/32703
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Oct 14, 2020https://github.com/nodejs/node/pull/35541#issuecomment-708559883
ef1645ehttps://github.com/nodejs/node/commit/ef1645e2b3f609492af7f25e4468db9b7801f4aa
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Oct 14, 2020https://github.com/nodejs/node/pull/35541#event-3877807808
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
October 14, 2020 17:48https://github.com/nodejs/node/pull/35541#event-3877808148
MylesBorinshttps://github.com/MylesBorins
Oct 14, 2020 https://github.com/nodejs/node/pull/35541#ref-commit-0c87776
https://github.com/puzpuzpuz
https://github.com/MylesBorins
doc: document Buffer.concat may use internal poolhttps://github.com/nodejs/node/commit/0c877762ea37ab08b11cd242a01356629263a323
0c87776https://github.com/nodejs/node/commit/0c877762ea37ab08b11cd242a01356629263a323
#35541https://github.com/nodejs/node/pull/35541
#32703https://github.com/nodejs/node/pull/32703
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Oct 14, 2020 https://github.com/nodejs/node/pull/35541#ref-pullrequest-721778951
v14.14.0 proposal #35648 https://github.com/nodejs/node/pull/35648
MylesBorinshttps://github.com/MylesBorins
Nov 3, 2020 https://github.com/nodejs/node/pull/35541#ref-commit-54a29f1
https://github.com/puzpuzpuz
https://github.com/MylesBorins
doc: document Buffer.concat may use internal poolhttps://github.com/nodejs/node/commit/54a29f15578d130c81c9c911ca6927a0b610ba49
54a29f1https://github.com/nodejs/node/commit/54a29f15578d130c81c9c911ca6927a0b610ba49
#35541https://github.com/nodejs/node/pull/35541
#32703https://github.com/nodejs/node/pull/32703
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 3, 2020 https://github.com/nodejs/node/pull/35541#ref-pullrequest-735694919
v12.20.0 proposal #35950 https://github.com/nodejs/node/pull/35950
MylesBorinshttps://github.com/MylesBorins
Nov 16, 2020 https://github.com/nodejs/node/pull/35541#ref-commit-df52814
https://github.com/puzpuzpuz
https://github.com/MylesBorins
doc: document Buffer.concat may use internal poolhttps://github.com/nodejs/node/commit/df52814113796201dd1662f606e1302e598372e1
df52814https://github.com/nodejs/node/commit/df52814113796201dd1662f606e1302e598372e1
#35541https://github.com/nodejs/node/pull/35541
#32703https://github.com/nodejs/node/pull/32703
joesepihttps://github.com/joesepi
Jan 8, 2021 https://github.com/nodejs/node/pull/35541#ref-commit-8d03adb
https://github.com/puzpuzpuz
https://github.com/joesepi
doc: document Buffer.concat may use internal poolhttps://github.com/joesepi/node/commit/8d03adb601dc341c3261bf91e136ccd76208ccfa
8d03adbhttps://github.com/joesepi/node/commit/8d03adb601dc341c3261bf91e136ccd76208ccfa
nodejs#35541https://github.com/nodejs/node/pull/35541
nodejs#32703https://github.com/nodejs/node/pull/32703
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35541
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
https://github.com/HarshithaKP
HarshithaKP https://github.com/HarshithaKP
https://github.com/nodejs/node/pull/35541/files/4dcac6bbbae16da7816aec98eabb78eb226162ef
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Please reload this pagehttps://github.com/nodejs/node/pull/35541
https://github.com/puzpuzpuz
https://github.com/nodejs-github-bot
https://github.com/ronag
https://github.com/addaleax
https://github.com/Trott
https://github.com/lpinca
https://github.com/HarshithaKP
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.