| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4610fa5b-f3dc-d6d3-d8e2-59927fcba353 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 82DE:22BD75:C83E15:1187FF8:696A64F0 |
| html-safe-nonce | 919399adab9404acb325d2199647ff907b0d2ca35a5b50a8669ad797358918c3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkRFOjIyQkQ3NTpDODNFMTU6MTE4N0ZGODo2OTZBNjRGMCIsInZpc2l0b3JfaWQiOiI0NzczMjg2NDA2NjgwODk2NzUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 94a4f40b91def54c327ca6cebb9463924c1051c52114feeff9cf0ae28fa7840e |
| hovercard-subject-tag | pull_request:498113866 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35508/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/12fa3fcc913cdd2a9c424c1c20a1c175e4bc2c14d8d4353e90b281aa05891512/nodejs/node/pull/35508 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12fa3fcc913cdd2a9c424c1c20a1c175e4bc2c14d8d4353e90b281aa05891512/nodejs/node/pull/35508 |
| og:image:alt | changed path assignment in http client lib from let to const (it's more appropriate in this case).
I addition to that, since the inner condition is the only referencing the variable, moved the ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35508#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35508 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35508 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35508 |
| Reload | https://github.com/nodejs/node/pull/35508 |
| Reload | https://github.com/nodejs/node/pull/35508 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35508 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35508 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35508#issue-comment-box |
| ghost | https://github.com/ghost |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
lib: change http client path assignment
| https://github.com/nodejs/node/pull/35508#top |
| ghost | https://github.com/ghost |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
6
| https://github.com/nodejs/node/pull/35508 |
|
Commits
1
| https://github.com/nodejs/node/pull/35508/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35508/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35508/files |
| Please reload this page | https://github.com/nodejs/node/pull/35508 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/ghost |
| ghost | https://github.com/ghost |
| Oct 5, 2020 | https://github.com/nodejs/node/pull/35508#issue-715157485 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/35508 |
|
| https://github.com/dekinderfiets |
| lib: change http client path assignment | https://github.com/nodejs/node/pull/35508/commits/f5c4a56f59f74ec223446fb5b44a95209f5b3878 |
| f5c4a56 | https://github.com/nodejs/node/pull/35508/commits/f5c4a56f59f74ec223446fb5b44a95209f5b3878 |
| code owner | https://github.com/nodejs/node/blob/642f2064c06793b799959d7df0488f14df594181/.github/CODEOWNERS#L68 |
| October 5, 2020 20:57 | https://github.com/nodejs/node/pull/35508#event-3842403759 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 5, 2020 | https://github.com/nodejs/node/pull/35508#issuecomment-703887912 |
| Please reload this page | https://github.com/nodejs/node/pull/35508 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Oct 5, 2020 | https://github.com/nodejs/node/pull/35508#event-3842426882 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 6, 2020
| https://github.com/nodejs/node/pull/35508#pullrequestreview-502858229 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35508/files/f5c4a56f59f74ec223446fb5b44a95209f5b3878 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 6, 2020 | https://github.com/nodejs/node/pull/35508#event-3845001884 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 6, 2020 | https://github.com/nodejs/node/pull/35508#event-3845005611 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35508 |
| https://github.com/morpalgi |
| morpalgi | https://github.com/morpalgi |
|
Oct 6, 2020
| https://github.com/nodejs/node/pull/35508#pullrequestreview-502895915 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35508/files/f5c4a56f59f74ec223446fb5b44a95209f5b3878 |
| https://github.com/ghost |
| ghost | https://github.com/ghost |
| Oct 8, 2020 | https://github.com/nodejs/node/pull/35508#issuecomment-705362930 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/35508 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Oct 8, 2020
| https://github.com/nodejs/node/pull/35508#pullrequestreview-504466626 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35508/files/f5c4a56f59f74ec223446fb5b44a95209f5b3878 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 8, 2020 | https://github.com/nodejs/node/pull/35508#event-3853774369 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 8, 2020 | https://github.com/nodejs/node/pull/35508#event-3853798992 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35508 |
| https://github.com/rickyes |
| rickyes | https://github.com/rickyes |
|
Oct 8, 2020
| https://github.com/nodejs/node/pull/35508#pullrequestreview-504513911 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35508/files/f5c4a56f59f74ec223446fb5b44a95209f5b3878 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 8, 2020 | https://github.com/nodejs/node/pull/35508#issuecomment-705508524 |
| https://ci.nodejs.org/job/node-test-pull-request/33475/ | https://ci.nodejs.org/job/node-test-pull-request/33475/ |
| Please reload this page | https://github.com/nodejs/node/pull/35508 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Oct 8, 2020 | https://github.com/nodejs/node/pull/35508#event-3857479446 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Oct 8, 2020 | https://github.com/nodejs/node/pull/35508#event-3857496311 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 8, 2020 | https://github.com/nodejs/node/pull/35508#issuecomment-705839364 |
| f512ce6 | https://github.com/nodejs/node/commit/f512ce6aa0ce7fdfb560a40cb09abcdbc8de1ad9 |
| Please reload this page | https://github.com/nodejs/node/pull/35508 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 8, 2020 | https://github.com/nodejs/node/pull/35508#event-3857496978 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Oct 8, 2020
| https://github.com/nodejs/node/pull/35508#ref-commit-f512ce6 |
|
| https://github.com/dekinderfiets |
|
| https://github.com/nodejs-github-bot |
| lib: change http client path assignment | https://github.com/nodejs/node/commit/f512ce6aa0ce7fdfb560a40cb09abcdbc8de1ad9 |
| f512ce6 | https://github.com/nodejs/node/commit/f512ce6aa0ce7fdfb560a40cb09abcdbc8de1ad9 |
| #35508 | https://github.com/nodejs/node/pull/35508 |
| October 9, 2020 11:29 | https://github.com/nodejs/node/pull/35508#event-3859712270 |
| BethGriggs | https://github.com/BethGriggs |
|
Oct 13, 2020
| https://github.com/nodejs/node/pull/35508#ref-commit-7092756 |
|
| https://github.com/dekinderfiets |
|
| https://github.com/BethGriggs |
| lib: change http client path assignment | https://github.com/nodejs/node/commit/70927560f6581a6b670765f0ff141f0b171caee0 |
| 7092756 | https://github.com/nodejs/node/commit/70927560f6581a6b670765f0ff141f0b171caee0 |
| #35508 | https://github.com/nodejs/node/pull/35508 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 14, 2020
| https://github.com/nodejs/node/pull/35508#ref-pullrequest-721778951 |
|
v14.14.0 proposal
#35648
| https://github.com/nodejs/node/pull/35648 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35508#ref-commit-bd3cb68 |
|
| https://github.com/dekinderfiets |
|
| https://github.com/MylesBorins |
| lib: change http client path assignment | https://github.com/nodejs/node/commit/bd3cb680e481067ca8af07c92f1729345035e4c0 |
| bd3cb68 | https://github.com/nodejs/node/commit/bd3cb680e481067ca8af07c92f1729345035e4c0 |
| #35508 | https://github.com/nodejs/node/pull/35508 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35508#ref-pullrequest-735694919 |
|
v12.20.0 proposal
#35950
| https://github.com/nodejs/node/pull/35950 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 16, 2020
| https://github.com/nodejs/node/pull/35508#ref-commit-6efa140 |
|
| https://github.com/dekinderfiets |
|
| https://github.com/MylesBorins |
| lib: change http client path assignment | https://github.com/nodejs/node/commit/6efa140f8f0ef3779515afff72264cda83c75e30 |
| 6efa140 | https://github.com/nodejs/node/commit/6efa140f8f0ef3779515afff72264cda83c75e30 |
| #35508 | https://github.com/nodejs/node/pull/35508 |
| joesepi | https://github.com/joesepi |
|
Jan 8, 2021
| https://github.com/nodejs/node/pull/35508#ref-commit-127f032 |
|
| https://github.com/dekinderfiets |
|
| https://github.com/joesepi |
| lib: change http client path assignment | https://github.com/joesepi/node/commit/127f032d19f4b97a6bafabad1af9f7ca42e17814 |
| 127f032 | https://github.com/joesepi/node/commit/127f032d19f4b97a6bafabad1af9f7ca42e17814 |
| nodejs#35508 | https://github.com/nodejs/node/pull/35508 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35508 |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Please reload this page | https://github.com/nodejs/node/pull/35508 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Trott |
|
| https://github.com/morpalgi |
|
| https://github.com/Flarna |
|
| https://github.com/rickyes |
|
| https://github.com/dekinderfiets |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |