René's URL Explorer Experiment


Title: module: fix builtin reexport tracing by guybedford · Pull Request #35500 · nodejs/node · GitHub

Open Graph Title: module: fix builtin reexport tracing by guybedford · Pull Request #35500 · nodejs/node

X Title: module: fix builtin reexport tracing by guybedford · Pull Request #35500 · nodejs/node

Description: This fixes #35483 by ensuring that reexport tracing in the named exports extraction does not attempt to operate on builtin modules. Since this is a regression it would be good to fast track this fi...

Open Graph Description: This fixes #35483 by ensuring that reexport tracing in the named exports extraction does not attempt to operate on builtin modules. Since this is a regression it would be good to fast track this fi...

X Description: This fixes #35483 by ensuring that reexport tracing in the named exports extraction does not attempt to operate on builtin modules. Since this is a regression it would be good to fast track this fi...

Opengraph URL: https://github.com/nodejs/node/pull/35500

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4d5e960b-9902-84b9-8ef2-4612d79b66dd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9042:22476E:D390C5:1284FD9:696A65B6
html-safe-nonce0d1a07ae420491e8b3e53342b3ed2d22dce07924408ba5933c897a118171b565
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDQyOjIyNDc2RTpEMzkwQzU6MTI4NEZEOTo2OTZBNjVCNiIsInZpc2l0b3JfaWQiOiI2NTIwNDI3MjMyMzczNjYzMTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9b3da8310eae6daec723367e259bb17f1c0e308345db0fca46225409c7aa7862
hovercard-subject-tagpull_request:497443752
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35500/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f50df74e37e6f8b181d6def4e8c8b8149c7a106780b970cd74d80e1b1223fdaf/nodejs/node/pull/35500
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f50df74e37e6f8b181d6def4e8c8b8149c7a106780b970cd74d80e1b1223fdaf/nodejs/node/pull/35500
og:image:altThis fixes #35483 by ensuring that reexport tracing in the named exports extraction does not attempt to operate on builtin modules. Since this is a regression it would be good to fast track this fi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
None9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87cbd411c2982752221b5751d583a515b23bf5fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35500#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35500
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35500
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35500
Reloadhttps://github.com/nodejs/node/pull/35500
Reloadhttps://github.com/nodejs/node/pull/35500
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35500
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35500
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35500#issue-comment-box
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:builtin-reexportshttps://github.com/guybedford/node/tree/builtin-reexports
module: fix builtin reexport tracing https://github.com/nodejs/node/pull/35500#top
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:builtin-reexportshttps://github.com/guybedford/node/tree/builtin-reexports
Conversation 5 https://github.com/nodejs/node/pull/35500
Commits 1 https://github.com/nodejs/node/pull/35500/commits
Checks 0 https://github.com/nodejs/node/pull/35500/checks
Files changed https://github.com/nodejs/node/pull/35500/files
Please reload this pagehttps://github.com/nodejs/node/pull/35500
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Oct 4, 2020https://github.com/nodejs/node/pull/35500#issue-714327660
#35483https://github.com/nodejs/node/issues/35483
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35500
https://github.com/guybedford
module: fix builtin reexport tracinghttps://github.com/nodejs/node/pull/35500/commits/8e3831e1daa2150d391fae7977aafdbe98ac8483
8e3831ehttps://github.com/nodejs/node/pull/35500/commits/8e3831e1daa2150d391fae7977aafdbe98ac8483
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 4, 2020https://github.com/nodejs/node/pull/35500#issuecomment-703264796
Please reload this pagehttps://github.com/nodejs/node/pull/35500
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Oct 4, 2020https://github.com/nodejs/node/pull/35500#event-3837622311
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Oct 4, 2020 https://github.com/nodejs/node/pull/35500#ref-issue-714149846
Node 14.13 problematic (default?) import combinations #35483 https://github.com/nodejs/node/issues/35483
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Oct 4, 2020 https://github.com/nodejs/node/pull/35500#pullrequestreview-501629940
View reviewed changes https://github.com/nodejs/node/pull/35500/files/8e3831e1daa2150d391fae7977aafdbe98ac8483
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Oct 4, 2020https://github.com/nodejs/node/pull/35500#issuecomment-703265726
Please reload this pagehttps://github.com/nodejs/node/pull/35500
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Oct 4, 2020https://github.com/nodejs/node/pull/35500#event-3837629913
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 4, 2020 https://github.com/nodejs/node/pull/35500#pullrequestreview-501630706
View reviewed changes https://github.com/nodejs/node/pull/35500/files/8e3831e1daa2150d391fae7977aafdbe98ac8483
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
targoshttps://github.com/targos
October 4, 2020 14:52https://github.com/nodejs/node/pull/35500#event-3837635881
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 4, 2020https://github.com/nodejs/node/pull/35500#issuecomment-703266934
https://ci.nodejs.org/job/node-test-pull-request/33381/https://ci.nodejs.org/job/node-test-pull-request/33381/
Please reload this pagehttps://github.com/nodejs/node/pull/35500
https://github.com/targos
targoshttps://github.com/targos
Oct 4, 2020 https://github.com/nodejs/node/pull/35500#pullrequestreview-501631876
View reviewed changes https://github.com/nodejs/node/pull/35500/files/8e3831e1daa2150d391fae7977aafdbe98ac8483
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 4, 2020https://github.com/nodejs/node/pull/35500#issuecomment-703283946
https://ci.nodejs.org/job/node-test-pull-request/33387/https://ci.nodejs.org/job/node-test-pull-request/33387/
Please reload this pagehttps://github.com/nodejs/node/pull/35500
https://github.com/targos
targoshttps://github.com/targos
Oct 4, 2020 https://github.com/nodejs/node/pull/35500#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
guybedfordhttps://github.com/guybedford
Oct 4, 2020 https://github.com/nodejs/node/pull/35500#ref-commit-5e605c0
https://github.com/guybedford
module: fix builtin reexport tracinghttps://github.com/nodejs/node/commit/5e605c0dd9c8b3012e5e7cfaf0058bde1b36fd75
5e605c0https://github.com/nodejs/node/commit/5e605c0dd9c8b3012e5e7cfaf0058bde1b36fd75
#35500https://github.com/nodejs/node/pull/35500
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Oct 4, 2020https://github.com/nodejs/node/pull/35500#issuecomment-703288622
5e605c0https://github.com/nodejs/node/commit/5e605c0dd9c8b3012e5e7cfaf0058bde1b36fd75
Please reload this pagehttps://github.com/nodejs/node/pull/35500
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Oct 4, 2020https://github.com/nodejs/node/pull/35500#event-3837774740
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Oct 6, 2020 https://github.com/nodejs/node/pull/35500#ref-pullrequest-715898141
V14.13.1 proposal #35525 https://github.com/nodejs/node/pull/35525
danielleadamshttps://github.com/danielleadams
Oct 6, 2020 https://github.com/nodejs/node/pull/35500#ref-commit-5c879a9
https://github.com/guybedford
https://github.com/danielleadams
module: fix builtin reexport tracinghttps://github.com/nodejs/node/commit/5c879a97e6ca4f6f4d8ff4e659722ddc713cd36b
5c879a9https://github.com/nodejs/node/commit/5c879a97e6ca4f6f4d8ff4e659722ddc713cd36b
#35500https://github.com/nodejs/node/pull/35500
https://github.com/KilianKilmister
KilianKilmisterhttps://github.com/KilianKilmister
Oct 11, 2020 https://github.com/nodejs/node/pull/35500#ref-issue-598417180
ESM support: soliciting feedback TypeStrong/ts-node#1007 https://github.com/TypeStrong/ts-node/issues/1007
MylesBorinshttps://github.com/MylesBorins
Nov 3, 2020 https://github.com/nodejs/node/pull/35500#ref-commit-26a8bdc
https://github.com/guybedford
https://github.com/MylesBorins
module: fix builtin reexport tracinghttps://github.com/nodejs/node/commit/26a8bdc6c3a50dc86f4b558bc5f591ccf75e804a
26a8bdchttps://github.com/nodejs/node/commit/26a8bdc6c3a50dc86f4b558bc5f591ccf75e804a
#35500https://github.com/nodejs/node/pull/35500
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Nov 3, 2020 https://github.com/nodejs/node/pull/35500#ref-pullrequest-735694919
v12.20.0 proposal #35950 https://github.com/nodejs/node/pull/35950
MylesBorinshttps://github.com/MylesBorins
Nov 16, 2020 https://github.com/nodejs/node/pull/35500#ref-commit-76f7601
https://github.com/guybedford
https://github.com/MylesBorins
module: fix builtin reexport tracinghttps://github.com/nodejs/node/commit/76f76017bfe81022b9482cda4814cbeeb0ea3596
76f7601https://github.com/nodejs/node/commit/76f76017bfe81022b9482cda4814cbeeb0ea3596
#35500https://github.com/nodejs/node/pull/35500
joesepihttps://github.com/joesepi
Jan 8, 2021 https://github.com/nodejs/node/pull/35500#ref-commit-9e3f4b6
https://github.com/guybedford
https://github.com/joesepi
module: fix builtin reexport tracinghttps://github.com/joesepi/node/commit/9e3f4b611c61ab8221f1640dfe477d1d410a9ffb
9e3f4b6https://github.com/joesepi/node/commit/9e3f4b611c61ab8221f1640dfe477d1d410a9ffb
nodejs#35500https://github.com/nodejs/node/pull/35500
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35500
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/35500/files/8e3831e1daa2150d391fae7977aafdbe98ac8483
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/35500/files/8e3831e1daa2150d391fae7977aafdbe98ac8483
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/35500/files/8e3831e1daa2150d391fae7977aafdbe98ac8483
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Node 14.13 problematic (default?) import combinations https://github.com/nodejs/node/issues/35483
Please reload this pagehttps://github.com/nodejs/node/pull/35500
https://github.com/guybedford
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/GeoffreyBooth
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.