| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cce79b78-5f9a-6650-9f99-f94310e98e28 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A642:C9338:9380C9:C06CAB:696B1B64 |
| html-safe-nonce | 99378073e4449673cf6fb2e1b7ba0d113d358bf472c0ce2324347259588d579e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjQyOkM5MzM4OjkzODBDOTpDMDZDQUI6Njk2QjFCNjQiLCJ2aXNpdG9yX2lkIjoiNzU5NDU3NDIxNzgxODYxMDUzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 49d4b1ef5f9a0194168a23dd22ccc8807c9b9fd21f8447265bd547b304f0b58f |
| hovercard-subject-tag | pull_request:493847750 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35385/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/554e81e59e16c0cb53154fcd19e8b4c9556e11a39058073b9594de923ab421de/nodejs/node/pull/35385 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/554e81e59e16c0cb53154fcd19e8b4c9556e11a39058073b9594de923ab421de/nodejs/node/pull/35385 |
| og:image:alt | This includes the latest modules backports from 14 to 12, which should then ensure that #35249 can land cleanly as well while getting the latest support for the modules package.json fields for comp... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | guybedford |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35385#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35385 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35385 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35385 |
| Reload | https://github.com/nodejs/node/pull/35385 |
| Reload | https://github.com/nodejs/node/pull/35385 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35385#issue-comment-box |
| guybedford | https://github.com/guybedford |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| guybedford:12-modules-backports | https://github.com/guybedford/node/tree/12-modules-backports |
|
[12.x] modules backports
| https://github.com/nodejs/node/pull/35385#top |
| guybedford | https://github.com/guybedford |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| guybedford:12-modules-backports | https://github.com/guybedford/node/tree/12-modules-backports |
|
Conversation
5
| https://github.com/nodejs/node/pull/35385 |
|
Commits
13
| https://github.com/nodejs/node/pull/35385/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35385/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35385/files |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Sep 28, 2020 | https://github.com/nodejs/node/pull/35385#issue-709906207 |
| #35249 | https://github.com/nodejs/node/pull/35249 |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
| guybedford | https://github.com/guybedford |
| September 27, 2020 19:41 | https://github.com/nodejs/node/pull/35385#commits-pushed-75a2cf3 |
|
| https://github.com/guybedford |
| module: package "imports" field | https://github.com/nodejs/node/pull/35385/commits/75a2cf311240c7f24b52cf23fd0ae6e38fcc58d0 |
| 75a2cf3 | https://github.com/nodejs/node/pull/35385/commits/75a2cf311240c7f24b52cf23fd0ae6e38fcc58d0 |
| nodejs#34117 | https://github.com/nodejs/node/pull/34117 |
|
| https://github.com/dnlup |
|
| https://github.com/guybedford |
| module: self referential modules in repl or -r | https://github.com/nodejs/node/pull/35385/commits/f3a328c1b81d23148e1b58218dbc2bb911e44d30 |
| f3a328c | https://github.com/nodejs/node/pull/35385/commits/f3a328c1b81d23148e1b58218dbc2bb911e44d30 |
| nodejs#32261 | https://github.com/nodejs/node/pull/32261 |
| nodejs#31595 | https://github.com/nodejs/node/issues/31595 |
|
| https://github.com/guybedford |
| module: use cjsCache over esm injection | https://github.com/nodejs/node/pull/35385/commits/39a42b3fe5e26678d0ad8cd0f64dd88ceb2f3bcc |
| 39a42b3 | https://github.com/nodejs/node/pull/35385/commits/39a42b3fe5e26678d0ad8cd0f64dd88ceb2f3bcc |
| nodejs#34605 | https://github.com/nodejs/node/pull/34605 |
|
| https://github.com/guybedford |
| module: custom --conditions flag option | https://github.com/nodejs/node/pull/35385/commits/9485ad688387f530f67f77f04317d364257db70d |
| 9485ad6 | https://github.com/nodejs/node/pull/35385/commits/9485ad688387f530f67f77f04317d364257db70d |
| nodejs#34637 | https://github.com/nodejs/node/pull/34637 |
|
| https://github.com/guybedford |
| module: share CJS/ESM resolver fns, refactoring | https://github.com/nodejs/node/pull/35385/commits/7e20df26113b01421fac564ceb554613af85eb87 |
| 7e20df2 | https://github.com/nodejs/node/pull/35385/commits/7e20df26113b01421fac564ceb554613af85eb87 |
| nodejs#34744 | https://github.com/nodejs/node/pull/34744 |
|
| https://github.com/DerekNonGeneric |
|
| https://github.com/guybedford |
| module: fix check for package.json at volume root | https://github.com/nodejs/node/pull/35385/commits/d6af3ba83ec48f07728bdadac9d63bc0e6ebe046 |
| d6af3ba | https://github.com/nodejs/node/pull/35385/commits/d6af3ba83ec48f07728bdadac9d63bc0e6ebe046 |
| nodejs#33438 | https://github.com/nodejs/node/issues/33438 |
| nodejs#34595 | https://github.com/nodejs/node/pull/34595 |
|
| https://github.com/richardlau |
|
| https://github.com/guybedford |
| module: drop -u alias for --conditions | https://github.com/nodejs/node/pull/35385/commits/56393c126a7465b4c16df08f6d0f294af08a0129 |
| 56393c1 | https://github.com/nodejs/node/pull/35385/commits/56393c126a7465b4c16df08f6d0f294af08a0129 |
| nodejs#34637 | https://github.com/nodejs/node/pull/34637 |
| nodejs#34935 | https://github.com/nodejs/node/pull/34935 |
| mochajs/mocha#4417 | https://github.com/mochajs/mocha/issues/4417 |
| nodejs#34637 | https://github.com/nodejs/node/pull/34637 |
|
| https://github.com/lundibundi |
|
| https://github.com/guybedford |
| esm: improve error message of ERR_UNSUPPORTED_ESM_URL_SCHEME | https://github.com/nodejs/node/pull/35385/commits/8030eb5c2447d1d63652d81c6effeacc57a63e50 |
| 8030eb5 | https://github.com/nodejs/node/pull/35385/commits/8030eb5c2447d1d63652d81c6effeacc57a63e50 |
| nodejs#34765 | https://github.com/nodejs/node/issues/34765 |
| nodejs#34795 | https://github.com/nodejs/node/pull/34795 |
|
| https://github.com/Trott |
|
| https://github.com/guybedford |
| esm: shorten ERR_UNSUPPORTED_ESM_URL_SCHEME message | https://github.com/nodejs/node/pull/35385/commits/96325b1979b914d980079f0daffd84cd1ffcd7e5 |
| 96325b1 | https://github.com/nodejs/node/pull/35385/commits/96325b1979b914d980079f0daffd84cd1ffcd7e5 |
| nodejs#34836 | https://github.com/nodejs/node/pull/34836 |
|
| https://github.com/guybedford |
| esm: better package.json parser errors | https://github.com/nodejs/node/pull/35385/commits/b29b966d282419d623f87c759a8d083ffbbd6ec3 |
| b29b966 | https://github.com/nodejs/node/pull/35385/commits/b29b966d282419d623f87c759a8d083ffbbd6ec3 |
| nodejs#35117 | https://github.com/nodejs/node/pull/35117 |
|
| https://github.com/aduh95 |
|
| https://github.com/guybedford |
| module: use isURLInstance instead of instanceof | https://github.com/nodejs/node/pull/35385/commits/be78b835f6f5940616a2f3d93a54bc26a83cbbac |
| be78b83 | https://github.com/nodejs/node/pull/35385/commits/be78b835f6f5940616a2f3d93a54bc26a83cbbac |
| nodejs#34951 | https://github.com/nodejs/node/pull/34951 |
|
| https://github.com/ctavan |
|
| https://github.com/guybedford |
| module: fix crash on multiline named cjs imports | https://github.com/nodejs/node/pull/35385/commits/0772b5b53737669eaa459524e0eee818c0395a40 |
| 0772b5b | https://github.com/nodejs/node/pull/35385/commits/0772b5b53737669eaa459524e0eee818c0395a40 |
| nodejs#35259 | https://github.com/nodejs/node/issues/35259 |
| nodejs#35275 | https://github.com/nodejs/node/pull/35275 |
|
| https://github.com/guybedford |
| module: exports pattern support | https://github.com/nodejs/node/pull/35385/commits/ab60e951725011927936f18a17e1b00ceda9c266 |
| ab60e95 | https://github.com/nodejs/node/pull/35385/commits/ab60e951725011927936f18a17e1b00ceda9c266 |
| nodejs#34718 | https://github.com/nodejs/node/pull/34718 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 28, 2020 | https://github.com/nodejs/node/pull/35385#issuecomment-699752930 |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x |
| Sep 28, 2020 | https://github.com/nodejs/node/pull/35385#event-3812459383 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/35385#ref-pullrequest-673780552 |
|
module: custom --conditions flag option
#34637
| https://github.com/nodejs/node/pull/34637 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/52627bcd6a3488beef9c413a3911acbd89eb7559..2f67e99a0b63ebcbb231a6a049c72c64c45c894b |
| 52627bc | https://github.com/nodejs/node/commit/52627bcd6a3488beef9c413a3911acbd89eb7559 |
| 2f67e99 | https://github.com/nodejs/node/commit/2f67e99a0b63ebcbb231a6a049c72c64c45c894b |
|
Compare
| https://github.com/nodejs/node/compare/52627bcd6a3488beef9c413a3911acbd89eb7559..2f67e99a0b63ebcbb231a6a049c72c64c45c894b |
| September 28, 2020 09:00 | https://github.com/nodejs/node/pull/35385#event-3813422187 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 28, 2020 | https://github.com/nodejs/node/pull/35385#event-3813518214 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 28, 2020 | https://github.com/nodejs/node/pull/35385#event-3813522362 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 28, 2020 | https://github.com/nodejs/node/pull/35385#issuecomment-699889889 |
| https://ci.nodejs.org/job/node-test-pull-request/33274/ | https://ci.nodejs.org/job/node-test-pull-request/33274/ |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
| Sep 28, 2020 | https://github.com/nodejs/node/pull/35385#event-3813631739 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 28, 2020 | https://github.com/nodejs/node/pull/35385#issuecomment-700306376 |
| https://ci.nodejs.org/job/node-test-pull-request/33281/ | https://ci.nodejs.org/job/node-test-pull-request/33281/ |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
Sep 29, 2020
| https://github.com/nodejs/node/pull/35385#ref-pullrequest-710696536 |
|
[v12.x backport] CJS exports detection
#35405
| https://github.com/nodejs/node/pull/35405 |
| https://github.com/hybrist |
| hybrist | https://github.com/hybrist |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#pullrequestreview-500455934 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35385/files/ab60e951725011927936f18a17e1b00ceda9c266 |
| hybrist | https://github.com/hybrist |
| https://github.com/nodejs/node/pull/35385#pullrequestreview-500455934 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#pullrequestreview-500613554 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35385/files/ab60e951725011927936f18a17e1b00ceda9c266 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Oct 1, 2020 | https://github.com/nodejs/node/pull/35385#issuecomment-702321314 |
| b7be751...2f3ffc0 | https://github.com/nodejs/node/compare/b7be751447ab5aba65b38eb9c845325fd5b50e39...2f3ffc041c47fcbe9d6e6acedaaad27a0b7ccd9f |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Oct 1, 2020 | https://github.com/nodejs/node/pull/35385#event-3830907761 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-d065334 |
|
| https://github.com/guybedford |
|
| https://github.com/codebytere |
| module: package "imports" field | https://github.com/nodejs/node/commit/d065334d42e0206d8875fddc6631446f4ca05617 |
| d065334 | https://github.com/nodejs/node/commit/d065334d42e0206d8875fddc6631446f4ca05617 |
| #34117 | https://github.com/nodejs/node/pull/34117 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-00aa935 |
|
| https://github.com/dnlup |
|
| https://github.com/codebytere |
| module: self referential modules in repl or -r | https://github.com/nodejs/node/commit/00aa935f5c53571c2a63a98b80f0f0c5f507725f |
| 00aa935 | https://github.com/nodejs/node/commit/00aa935f5c53571c2a63a98b80f0f0c5f507725f |
| #32261 | https://github.com/nodejs/node/pull/32261 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| #31595 | https://github.com/nodejs/node/issues/31595 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-3ad146d |
|
| https://github.com/guybedford |
|
| https://github.com/codebytere |
| module: use cjsCache over esm injection | https://github.com/nodejs/node/commit/3ad146d474ebbc497f296791056e2cf91900e51b |
| 3ad146d | https://github.com/nodejs/node/commit/3ad146d474ebbc497f296791056e2cf91900e51b |
| #34605 | https://github.com/nodejs/node/pull/34605 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-d9857fd |
|
| https://github.com/guybedford |
|
| https://github.com/codebytere |
| module: custom --conditions flag option | https://github.com/nodejs/node/commit/d9857fdbc2ce69508e61e9d32b06ae3244d3f492 |
| d9857fd | https://github.com/nodejs/node/commit/d9857fdbc2ce69508e61e9d32b06ae3244d3f492 |
| #34637 | https://github.com/nodejs/node/pull/34637 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-cecc193 |
|
| https://github.com/guybedford |
|
| https://github.com/codebytere |
| module: share CJS/ESM resolver fns, refactoring | https://github.com/nodejs/node/commit/cecc193abcf64d7d7b1b2bb5bacf036982e59ac7 |
| cecc193 | https://github.com/nodejs/node/commit/cecc193abcf64d7d7b1b2bb5bacf036982e59ac7 |
| #34744 | https://github.com/nodejs/node/pull/34744 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-740c958 |
|
| https://github.com/codebytere |
| module: fix check for package.json at volume root | https://github.com/nodejs/node/commit/740c95819f0468345eebc44792c29c6e82b9820e |
| 740c958 | https://github.com/nodejs/node/commit/740c95819f0468345eebc44792c29c6e82b9820e |
| #33438 | https://github.com/nodejs/node/issues/33438 |
| #34595 | https://github.com/nodejs/node/pull/34595 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-fc93cc9 |
|
| https://github.com/richardlau |
|
| https://github.com/codebytere |
| module: drop -u alias for --conditions | https://github.com/nodejs/node/commit/fc93cc95d896b568e891418d7a1d702f0174e16d |
| fc93cc9 | https://github.com/nodejs/node/commit/fc93cc95d896b568e891418d7a1d702f0174e16d |
| #34637 | https://github.com/nodejs/node/pull/34637 |
| #34935 | https://github.com/nodejs/node/pull/34935 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| mochajs/mocha#4417 | https://github.com/mochajs/mocha/issues/4417 |
| #34637 | https://github.com/nodejs/node/pull/34637 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-551be2a |
|
| https://github.com/lundibundi |
|
| https://github.com/codebytere |
| esm: improve error message of ERR_UNSUPPORTED_ESM_URL_SCHEME | https://github.com/nodejs/node/commit/551be2aeb982483884f258adb5a7cf0521124a8c |
| 551be2a | https://github.com/nodejs/node/commit/551be2aeb982483884f258adb5a7cf0521124a8c |
| #34765 | https://github.com/nodejs/node/issues/34765 |
| #34795 | https://github.com/nodejs/node/pull/34795 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-9159649 |
|
| https://github.com/Trott |
|
| https://github.com/codebytere |
| esm: shorten ERR_UNSUPPORTED_ESM_URL_SCHEME message | https://github.com/nodejs/node/commit/91596493954110f2a4171d9fb82ab31cba1d71b0 |
| 9159649 | https://github.com/nodejs/node/commit/91596493954110f2a4171d9fb82ab31cba1d71b0 |
| #34836 | https://github.com/nodejs/node/pull/34836 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-bf7b796 |
|
| https://github.com/guybedford |
|
| https://github.com/codebytere |
| esm: better package.json parser errors | https://github.com/nodejs/node/commit/bf7b79649171d8225b0d22c5daf5015e845f6498 |
| bf7b796 | https://github.com/nodejs/node/commit/bf7b79649171d8225b0d22c5daf5015e845f6498 |
| #35117 | https://github.com/nodejs/node/pull/35117 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-89a58f6 |
|
| https://github.com/aduh95 |
|
| https://github.com/codebytere |
| module: use isURLInstance instead of instanceof | https://github.com/nodejs/node/commit/89a58f61d72eb70e582dc79f838530a60be7b971 |
| 89a58f6 | https://github.com/nodejs/node/commit/89a58f61d72eb70e582dc79f838530a60be7b971 |
| #34951 | https://github.com/nodejs/node/pull/34951 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-ed3278d |
|
| https://github.com/ctavan |
|
| https://github.com/codebytere |
| module: fix crash on multiline named cjs imports | https://github.com/nodejs/node/commit/ed3278d55dd682be5d933921633fa490b6098310 |
| ed3278d | https://github.com/nodejs/node/commit/ed3278d55dd682be5d933921633fa490b6098310 |
| #35259 | https://github.com/nodejs/node/issues/35259 |
| #35275 | https://github.com/nodejs/node/pull/35275 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| codebytere | https://github.com/codebytere |
|
Oct 1, 2020
| https://github.com/nodejs/node/pull/35385#ref-commit-2f3ffc0 |
|
| https://github.com/guybedford |
|
| https://github.com/codebytere |
| module: exports pattern support | https://github.com/nodejs/node/commit/2f3ffc041c47fcbe9d6e6acedaaad27a0b7ccd9f |
| 2f3ffc0 | https://github.com/nodejs/node/commit/2f3ffc041c47fcbe9d6e6acedaaad27a0b7ccd9f |
| #34718 | https://github.com/nodejs/node/pull/34718 |
| #35385 | https://github.com/nodejs/node/pull/35385 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
Oct 22, 2020
| https://github.com/nodejs/node/pull/35385#ref-pullrequest-726984884 |
|
[12.x backport] module: remove experimental modules warning
#35749
| https://github.com/nodejs/node/pull/35749 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35385 |
|
| https://github.com/hybrist |
|
hybrist
| https://github.com/hybrist |
|
| https://github.com/nodejs/node/pull/35385/files/ab60e951725011927936f18a17e1b00ceda9c266 |
|
| https://github.com/codebytere |
|
codebytere
| https://github.com/codebytere |
|
| https://github.com/nodejs/node/pull/35385/files/ab60e951725011927936f18a17e1b00ceda9c266 |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/35385 |
|
| https://github.com/guybedford |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/codebytere |
|
| https://github.com/hybrist |
|
| https://github.com/addaleax |
|
| https://github.com/dnlup |
|
| https://github.com/DerekNonGeneric |
|
| https://github.com/richardlau |
|
| https://github.com/lundibundi |
|
| https://github.com/Trott |
|
| https://github.com/aduh95 |
|
| https://github.com/ctavan |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |