René's URL Explorer Experiment


Title: tls: copy client CAs and cert store on CertCb by indutny · Pull Request #3537 · nodejs/node · GitHub

Open Graph Title: tls: copy client CAs and cert store on CertCb by indutny · Pull Request #3537 · nodejs/node

X Title: tls: copy client CAs and cert store on CertCb by indutny · Pull Request #3537 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Copy client CA certs and cert store when asynchronously selecting SecureContext during SNICallback. Fix: #2772 cc @nodejs/crypto

X Description: Copy client CA certs and cert store when asynchronously selecting SecureContext during SNICallback. Fix: #2772 cc @nodejs/crypto

Opengraph URL: https://github.com/nodejs/node/pull/3537

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:303920d8-8c3b-3007-11aa-7142f925a8fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA2C:3B3BAC:121D5AA:1A6A492:6A4E40C7
html-safe-nonce7d542ac70dd7338818463654786c42fd1d48b10bf83a5039858d3b5acd4626e5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTJDOjNCM0JBQzoxMjFENUFBOjFBNkE0OTI6NkE0RTQwQzciLCJ2aXNpdG9yX2lkIjoiODg0MjkzMTg4NDMyNzMyMTc5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac21e21cba40c0b123fccaee3e618bda2042366ce958665eb5a9a5a404dcc164f1
hovercard-subject-tagpull_request:48810252
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3537/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/28ba85baebe933c664dc8cbfb343ca595657f6897c33604eef51e031b94a4d71/nodejs/node/pull/3537
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/28ba85baebe933c664dc8cbfb343ca595657f6897c33604eef51e031b94a4d71/nodejs/node/pull/3537
og:image:altCopy client CA certs and cert store when asynchronously selecting SecureContext during SNICallback. Fix: #2772 cc @nodejs/crypto
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameindutny
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9fabff9b8b127e686a3ec86f91422e818056ca2c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3537#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3537
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3537
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3537
Reloadhttps://github.com/nodejs/node/pull/3537
Reloadhttps://github.com/nodejs/node/pull/3537
Please reload this pagehttps://github.com/nodejs/node/pull/3537
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3537
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
indutnyhttps://github.com/indutny
nodejs:masterhttps://github.com/nodejs/node/tree/master
indutny:fix/tls-ca-snihttps://github.com/indutny/io.js/tree/fix/tls-ca-sni
Conversationhttps://github.com/nodejs/node/pull/3537
Commits2 (2)https://github.com/nodejs/node/pull/3537/commits
Checkshttps://github.com/nodejs/node/pull/3537/checks
Files changedhttps://github.com/nodejs/node/pull/3537/files
tls: copy client CAs and cert store on CertCbhttps://github.com/nodejs/node/pull/3537#top
indutnyhttps://github.com/indutny
nodejs:masterhttps://github.com/nodejs/node/tree/master
indutny:fix/tls-ca-snihttps://github.com/indutny/io.js/tree/fix/tls-ca-sni
https://github.com/indutny
indutnyhttps://github.com/indutny
Oct 26, 2015https://github.com/nodejs/node/pull/3537#issue-113470730
#2772https://github.com/nodejs/node/issues/2772
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/mscdex
mscdexhttps://github.com/mscdex
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Oct 27, 2015https://github.com/nodejs/node/pull/3537#event-446315677
bnoordhuishttps://github.com/bnoordhuis
Oct 27, 2015 https://github.com/nodejs/node/pull/3537#discussion-diff-43110494
View reviewed changes https://github.com/nodejs/node/pull/3537/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
src/node_crypto.cchttps://github.com/nodejs/node/pull/3537/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
bnoordhuishttps://github.com/bnoordhuis
Oct 27, 2015https://github.com/nodejs/node/pull/3537#discussion_r43110494
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3537
indutnyhttps://github.com/indutny
Oct 27, 2015https://github.com/nodejs/node/pull/3537#discussion_r43159519
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 27, 2015https://github.com/nodejs/node/pull/3537#issuecomment-151464869
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
indutnyhttps://github.com/indutny
Oct 27, 2015https://github.com/nodejs/node/pull/3537#issuecomment-151586572
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
indutnyhttps://github.com/indutny
Oct 27, 2015https://github.com/nodejs/node/pull/3537#issuecomment-151586704
https://ci.nodejs.org/job/node-test-pull-request/631/https://ci.nodejs.org/job/node-test-pull-request/631/
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
indutnyhttps://github.com/indutny
Oct 27, 2015https://github.com/nodejs/node/pull/3537#issuecomment-151602756
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
tls: copy client CAs and cert store on CertCbhttps://github.com/nodejs/node/pull/3537/commits/7f60df57c96cd015fe286bfde313ca613959b383
7f60df5https://github.com/nodejs/node/pull/3537/commits/7f60df57c96cd015fe286bfde313ca613959b383
nodejs#2772https://github.com/nodejs/node/issues/2772
https://github.com/indutny
indutnyhttps://github.com/indutny
force-pushedhttps://github.com/nodejs/node/compare/387e4b9cf10c3662f832d9e6febd485b65ba463d..7f60df57c96cd015fe286bfde313ca613959b383
387e4b9https://github.com/nodejs/node/commit/387e4b9cf10c3662f832d9e6febd485b65ba463d
7f60df5https://github.com/nodejs/node/commit/7f60df57c96cd015fe286bfde313ca613959b383
Compare https://github.com/nodejs/node/compare/387e4b9cf10c3662f832d9e6febd485b65ba463d..7f60df57c96cd015fe286bfde313ca613959b383
October 27, 2015 18:46https://github.com/nodejs/node/pull/3537#event-447165333
https://github.com/indutny
indutnyhttps://github.com/indutny
Oct 27, 2015https://github.com/nodejs/node/pull/3537#issuecomment-151607005
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/3537
bnoordhuishttps://github.com/bnoordhuis
Nov 10, 2015 https://github.com/nodejs/node/pull/3537#discussion-diff-44471681
View reviewed changes https://github.com/nodejs/node/pull/3537/files/7f60df57c96cd015fe286bfde313ca613959b383#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
src/node_crypto.cchttps://github.com/nodejs/node/pull/3537/files#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
bnoordhuishttps://github.com/bnoordhuis
Nov 10, 2015https://github.com/nodejs/node/pull/3537#discussion_r44471681
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3537
indutnyhttps://github.com/indutny
Nov 12, 2015https://github.com/nodejs/node/pull/3537#discussion_r44724362
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
fixeshttps://github.com/nodejs/node/pull/3537/commits/919dd47b37e4f63989e2ba8c9a56304dff25c09c
919dd47https://github.com/nodejs/node/pull/3537/commits/919dd47b37e4f63989e2ba8c9a56304dff25c09c
https://github.com/indutny
indutnyhttps://github.com/indutny
Nov 12, 2015https://github.com/nodejs/node/pull/3537#issuecomment-156256914
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
indutnyhttps://github.com/indutny
Nov 12, 2015https://github.com/nodejs/node/pull/3537#issuecomment-156257780
https://ci.nodejs.org/job/node-test-pull-request/715/https://ci.nodejs.org/job/node-test-pull-request/715/
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 13, 2015https://github.com/nodejs/node/pull/3537#issuecomment-156450177
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
indutnyhttps://github.com/indutny
Nov 13, 2015https://github.com/nodejs/node/pull/3537#issuecomment-156499476
483a41chttps://github.com/nodejs/node/commit/483a41c0ad585b88e05e3d610f8cded0efcd0e49
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
indutnyhttps://github.com/indutny
Nov 13, 2015https://github.com/nodejs/node/pull/3537#event-463851497
https://github.com/indutny
indutnyhttps://github.com/indutny
November 13, 2015 17:48https://github.com/nodejs/node/pull/3537#event-463851514
indutnyhttps://github.com/indutny
Nov 13, 2015 https://github.com/nodejs/node/pull/3537#ref-commit-483a41c
https://github.com/indutny
tls: copy client CAs and cert store on CertCbhttps://github.com/nodejs/node/commit/483a41c0ad585b88e05e3d610f8cded0efcd0e49
483a41chttps://github.com/nodejs/node/commit/483a41c0ad585b88e05e3d610f8cded0efcd0e49
#2772https://github.com/nodejs/node/issues/2772
#3537https://github.com/nodejs/node/pull/3537
indutnyhttps://github.com/indutny
Nov 17, 2015 https://github.com/nodejs/node/pull/3537#ref-commit-05f0549
https://github.com/indutny
https://github.com/Fishrock123
tls: copy client CAs and cert store on CertCbhttps://github.com/nodejs/node/commit/05f0549b50c83753b43f02f1a02fc4a79ec7fd03
05f0549https://github.com/nodejs/node/commit/05f0549b50c83753b43f02f1a02fc4a79ec7fd03
#2772https://github.com/nodejs/node/issues/2772
#3537https://github.com/nodejs/node/pull/3537
https://github.com/rvagg
rvagghttps://github.com/rvagg
Dec 17, 2015 https://github.com/nodejs/node/pull/3537#ref-issue-122642707
Release 4.2.4 Planning #4321 https://github.com/nodejs/node/issues/4321
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 14, 2016 https://github.com/nodejs/node/pull/3537#ref-issue-126730245
Audit commits not found on v4.x-staging #4698 https://github.com/nodejs/node/issues/4698
https://github.com/rvagg
rvagghttps://github.com/rvagg
Jan 15, 2016https://github.com/nodejs/node/pull/3537#issuecomment-171879691
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
indutnyhttps://github.com/indutny
Jan 15, 2016https://github.com/nodejs/node/pull/3537#issuecomment-171881044
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
indutnyhttps://github.com/indutny
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Jan 15, 2016https://github.com/nodejs/node/pull/3537#event-515843253
https://github.com/indutny
indutnyhttps://github.com/indutny
Jan 15, 2016https://github.com/nodejs/node/pull/3537#issuecomment-171881116
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 15, 2016https://github.com/nodejs/node/pull/3537#issuecomment-171881161
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Jan 28, 2016https://github.com/nodejs/node/pull/3537#event-530288801
MylesBorinshttps://github.com/MylesBorins
Jan 28, 2016 https://github.com/nodejs/node/pull/3537#ref-commit-dac9e38
https://github.com/indutny
tls: copy client CAs and cert store on CertCbhttps://github.com/nodejs/node/commit/dac9e3811059ea72f16c448bf7cb927999eb64f4
dac9e38https://github.com/nodejs/node/commit/dac9e3811059ea72f16c448bf7cb927999eb64f4
#2772https://github.com/nodejs/node/issues/2772
#3537https://github.com/nodejs/node/pull/3537
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2016 https://github.com/nodejs/node/pull/3537#ref-commit-c841d57
https://github.com/indutny
tls: copy client CAs and cert store on CertCbhttps://github.com/nodejs/node/commit/c841d57f3f5a64d0471e113cad36218933160794
c841d57https://github.com/nodejs/node/commit/c841d57f3f5a64d0471e113cad36218933160794
#2772https://github.com/nodejs/node/issues/2772
#3537https://github.com/nodejs/node/pull/3537
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2016 https://github.com/nodejs/node/pull/3537#ref-commit-5cf132a
https://github.com/indutny
tls: copy client CAs and cert store on CertCbhttps://github.com/MylesBorins/node/commit/5cf132a1d64d68c080a4c299745ba3a03fc9b889
5cf132ahttps://github.com/MylesBorins/node/commit/5cf132a1d64d68c080a4c299745ba3a03fc9b889
nodejs#2772https://github.com/nodejs/node/issues/2772
nodejs#3537https://github.com/nodejs/node/pull/3537
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2016 https://github.com/nodejs/node/pull/3537#ref-pullrequest-133119871
V4.3.1 proposal #5200 https://github.com/nodejs/node/pull/5200
MylesBorinshttps://github.com/MylesBorins
Feb 15, 2016 https://github.com/nodejs/node/pull/3537#ref-commit-aefb20a
https://github.com/indutny
tls: copy client CAs and cert store on CertCbhttps://github.com/MylesBorins/node/commit/aefb20a94f1b18b9c30d5b691aae15be97b01988
aefb20ahttps://github.com/MylesBorins/node/commit/aefb20a94f1b18b9c30d5b691aae15be97b01988
nodejs#2772https://github.com/nodejs/node/issues/2772
nodejs#3537https://github.com/nodejs/node/pull/3537
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3537
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/3537
https://github.com/indutny
https://github.com/bnoordhuis
https://github.com/rvagg
https://github.com/jasnell
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.