| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6fd25adc-bf58-6507-fbb3-9763f7faec3b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CED4:113F62:3F4F39:581B34:696A72AB |
| html-safe-nonce | a198d2d29f12dccb5f5334bf5b6e57f97fef76480da66b98f6cd20d818dac235 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUQ0OjExM0Y2MjozRjRGMzk6NTgxQjM0OjY5NkE3MkFCIiwidmlzaXRvcl9pZCI6IjM3NDU5ODIwNDk4NDE4MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8f91ce57fe464405e3d17987329987f05c715b2c93a676c74a95a86a4ec1c256 |
| hovercard-subject-tag | pull_request:492811734 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35336/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4129cce4e79f7a35addb2a78e50a055e14563ffc37553e4c68e5bde900bedb65/nodejs/node/pull/35336 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4129cce4e79f7a35addb2a78e50a055e14563ffc37553e4c68e5bde900bedb65/nodejs/node/pull/35336 |
| og:image:alt | Mark napi_detach_arraybuffer and napi_is_detached_arraybuffer as
stable.
Signed-off-by: @gabrielschulhof
PR-URL: #35199
Reviewed-By: @cjihrig
Reviewed-By: @gengjiawen
Reviewed-By: @legendecas
Revie... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35336#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35336 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35336 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35336 |
| Reload | https://github.com/nodejs/node/pull/35336 |
| Reload | https://github.com/nodejs/node/pull/35336 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35336#issue-comment-box |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| gabrielschulhof:backport-n-api-7-to-v10.x | https://github.com/gabrielschulhof/node/tree/backport-n-api-7-to-v10.x |
|
[v10.x] n-api: create N-API version 7
| https://github.com/nodejs/node/pull/35336#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:v10.x-staging | https://github.com/nodejs/node/tree/v10.x-staging |
| gabrielschulhof:backport-n-api-7-to-v10.x | https://github.com/gabrielschulhof/node/tree/backport-n-api-7-to-v10.x |
|
Conversation
9
| https://github.com/nodejs/node/pull/35336 |
|
Commits
1
| https://github.com/nodejs/node/pull/35336/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35336/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35336/files |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#issue-708613223 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| #35199 | https://github.com/nodejs/node/pull/35199 |
| @cjihrig | https://github.com/cjihrig |
| @gengjiawen | https://github.com/gengjiawen |
| @legendecas | https://github.com/legendecas |
| @mhdawson | https://github.com/mhdawson |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| n-api: create N-API version 7 | https://github.com/nodejs/node/pull/35336/commits/2320140d5e85b82be3a8ea153d750a2903f4a488 |
| 2320140 | https://github.com/nodejs/node/pull/35336/commits/2320140d5e85b82be3a8ea153d750a2903f4a488 |
| nodejs#35199 | https://github.com/nodejs/node/pull/35199 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
v10.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av10.x |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#event-3805863735 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| legendecas | https://github.com/legendecas |
| lundibundi | https://github.com/lundibundi |
| richardlau | https://github.com/richardlau |
| September 25, 2020 03:32 | https://github.com/nodejs/node/pull/35336#event-3805863742 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#issuecomment-698700578 |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#event-3805863825 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Sep 25, 2020
| https://github.com/nodejs/node/pull/35336#ref-pullrequest-704793468 |
|
[v10.x] build: expose napi_build_version variable
#35266
| https://github.com/nodejs/node/pull/35266 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Sep 25, 2020
| https://github.com/nodejs/node/pull/35336#pullrequestreview-496095922 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
| legendecas | https://github.com/legendecas |
| https://github.com/nodejs/node/pull/35336#pullrequestreview-496095922 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Sep 25, 2020
| https://github.com/nodejs/node/pull/35336#pullrequestreview-496143663 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
| https://github.com/lundibundi |
| lundibundi | https://github.com/lundibundi |
|
Sep 25, 2020
| https://github.com/nodejs/node/pull/35336#pullrequestreview-496338535 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
| test/addons-napi/test_general/test.js | https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488#diff-5b77f83085d05604051ac870caedcaa6312d00a4a7914958e2856aefbea23f16 |
| lundibundi | https://github.com/lundibundi |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#discussion_r494926514 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Sep 25, 2020
| https://github.com/nodejs/node/pull/35336#pullrequestreview-496436161 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/35336#pullrequestreview-496436161 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#event-3807805162 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 25, 2020
| https://github.com/nodejs/node/pull/35336#pullrequestreview-496439822 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
| richardlau | https://github.com/richardlau |
| https://github.com/nodejs/node/pull/35336#pullrequestreview-496439822 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#event-3807825576 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#issuecomment-698944050 |
| https://ci.nodejs.org/job/node-test-pull-request/33240/ | https://ci.nodejs.org/job/node-test-pull-request/33240/ |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#issuecomment-698970896 |
| @richardlau | https://github.com/richardlau |
| #35345 | https://github.com/nodejs/node/pull/35345 |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 25, 2020 | https://github.com/nodejs/node/pull/35336#issuecomment-699162133 |
| https://ci.nodejs.org/job/node-test-pull-request/33244/ | https://ci.nodejs.org/job/node-test-pull-request/33244/ |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| richardlau | https://github.com/richardlau |
|
Oct 7, 2020
| https://github.com/nodejs/node/pull/35336#ref-commit-54c2bc2 |
|
| https://github.com/richardlau |
| n-api: create N-API version 7 | https://github.com/nodejs/node/commit/54c2bc2e621fd9cde22ea65bda7f652a63b40340 |
| 54c2bc2 | https://github.com/nodejs/node/commit/54c2bc2e621fd9cde22ea65bda7f652a63b40340 |
| #35199 | https://github.com/nodejs/node/pull/35199 |
| #35336 | https://github.com/nodejs/node/pull/35336 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 7, 2020 | https://github.com/nodejs/node/pull/35336#issuecomment-704880225 |
| 54c2bc2 | https://github.com/nodejs/node/commit/54c2bc2e621fd9cde22ea65bda7f652a63b40340 |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Oct 7, 2020 | https://github.com/nodejs/node/pull/35336#event-3850088879 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| January 28, 2021 00:14 | https://github.com/nodejs/node/pull/35336#event-4258555674 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| January 28, 2021 05:40 | https://github.com/nodejs/node/pull/35336#event-4259272758 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| February 3, 2021 07:17 | https://github.com/nodejs/node/pull/35336#event-4283581771 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35336 |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
|
| https://github.com/lundibundi |
|
lundibundi
| https://github.com/lundibundi |
|
| https://github.com/nodejs/node/pull/35336/files/2320140d5e85b82be3a8ea153d750a2903f4a488 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/35336 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mhdawson |
|
| https://github.com/richardlau |
|
| https://github.com/gengjiawen |
|
| https://github.com/legendecas |
|
| https://github.com/lundibundi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |